Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #31648 from dixitp012/rubocop_active_support_test | Ryuta Kamizono | 2018-01-08 | 1 | -2/+2 |
|\ | | | | | | | Fix rubocop space before comma | ||||
| * | Fix rubocop space before comma | Dixit Patel | 2018-01-08 | 1 | -1/+1 |
|/ | |||||
* | Merge pull request #31049 from gwincr11/cg-blank | Ryuta Kamizono | 2018-01-04 | 1 | -2/+2 |
|\ | | | | | Add support for multiple encodings in String.blank? | ||||
| * | Add support for multiple encodings in String.blank? | Cory Gwin @gwincr11 | 2017-11-17 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Motivation: - When strings are encoded with `.encode("UTF-16LE")` `.blank?` throws an `Encoding::CompatibilityError` exception. - We tested multiple implementation to see what the fastest implementation was, rescueing the execption seems to be the fastest option we could find. Related Issues: - #28953 Changes: - Add a rescue to catch the exception. - Added a `Concurrent::Map` to store a cache of encoded regex objects for requested encoding types. - Use the new `Concurrent::Map` cache to return the correct regex for the string being checked. | ||||
* | | Suppress `warning: BigDecimal.new is deprecated` | Yasuo Honda | 2017-12-15 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `BigDecimal.new` has been deprecated in BigDecimal 1.3.3 which will be a default for Ruby 2.5. Refer https://github.com/ruby/bigdecimal/commit/533737338db915b00dc7168c3602e4b462b23503 * This commit has been made as follows: ``` cd rails git grep -l BigDecimal.new | grep -v guides/source/5_0_release_notes.md | grep -v activesupport/test/xml_mini_test.rb | xargs sed -i -e "s/BigDecimal.new/BigDecimal/g" ``` - `activesupport/test/xml_mini_test.rb` Editmanually to remove `.new` and `::` - guides/source/5_0_release_notes.md This is a Rails 5.0 release notes. | ||||
* | | These strings should already be frozen where ruby accepts the magic-comment | Akira Matsuda | 2017-11-15 | 1 | -2/+2 |
|/ | |||||
* | [Active Support] `rubocop -a --only Layout/EmptyLineAfterMagicComment` | Koichi ITO | 2017-07-11 | 11 | -0/+11 |
| | |||||
* | Use frozen-string-literal in ActiveSupport | Kir Shatrov | 2017-07-09 | 11 | -0/+11 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 11 | -11/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 11 | -0/+11 |
| | |||||
* | Fix duplicable? for Ratiional and Complex on ruby master, since they are now ↵ | Vipul A M | 2017-03-23 | 1 | -1/+4 |
| | | | | duplicable | ||||
* | Add Time#blank? to blank_test | kenta-s | 2017-02-12 | 1 | -1/+1 |
| | |||||
* | Uninterned Symbol can be duped since ruby 2.4.1 | Akira Matsuda | 2017-01-26 | 1 | -1/+4 |
| | | | | | | https://github.com/ruby/ruby/commit/11e6bd5ac2a2eebfa589bd6db8c9c4daa337733e Leaving the 2.4.0 conditional for now, in order never to forget backporting r57407 to 2.4.1 | ||||
* | Give a message to `#test_duplicable` assertion | yui-knk | 2017-01-25 | 1 | -1/+1 |
| | | | | | Giving a message helps us to know what happened when we look at Travis CI. | ||||
* | Fix style guide violations | Rafael Mendonça França | 2017-01-05 | 1 | -1/+1 |
| | |||||
* | Fix Symbol#duplicable? for Ruby 2.4.0. | Kasper Timm Hansen | 2017-01-01 | 1 | -2/+2 |
| | | | | | | | | | | | | | Ruby 2.4.0 has trouble duplicating certain symbols created from strings via `to_sym`. It didn't happen with `'symbol'.to_sym.dup` for some reason, but works fine with the longer string sample. Once a newer Ruby version with a fix is released we'll get have a failing test case we can fix. Ref: #27532 | ||||
* | "Use assert_nil if expecting nil. This will fail in minitest 6." | Akira Matsuda | 2016-12-25 | 2 | -5/+5 |
| | |||||
* | Fix Complex and Rational are duplicable? | utilum | 2016-12-21 | 1 | -2/+2 |
| | | | | See [this test](https://gist.github.com/utilum/78918f1b64f8b61ee732cb266db7c43a). | ||||
* | change return value of `duplicable?` with Ruby 2.4+ | yuuji.yaginuma | 2016-12-13 | 1 | -2/+7 |
| | | | | | | | `NilClass`, `FalseClass`, `TrueClass`, `Symbol` and `Numeric` can dup with Ruby 2.4+. Ref: https://bugs.ruby-lang.org/issues/12979 | ||||
* | :nail_care: | Akira Matsuda | 2016-12-13 | 1 | -2/+1 |
| | |||||
* | nil, true, 1, etc. don't raise on #dup since Ruby 2.4 | Akira Matsuda | 2016-12-13 | 1 | -1/+1 |
| | | | | https://bugs.ruby-lang.org/issues/12979 | ||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 2 | -4/+4 |
| | |||||
* | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 2 | -5/+5 |
| | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 1 | -2/+0 |
| | |||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -2/+2 |
| | |||||
* | remove redundant curlies from hash arguments | Xavier Noria | 2016-08-06 | 1 | -5/+5 |
| | |||||
* | modernizes hash syntax in activesupport | Xavier Noria | 2016-08-06 | 2 | -9/+9 |
| | |||||
* | applies new string literal convention in activesupport/test | Xavier Noria | 2016-08-06 | 11 | -88/+88 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Revert "Adds `not_in?` onto Object" | David Heinemeier Hansson | 2016-07-29 | 1 | -53/+0 |
| | |||||
* | Adds `not_in?` onto Object | Jon McCartie | 2016-07-21 | 1 | -0/+53 |
| | |||||
* | Support for unified Integer class in Ruby 2.4+ | Jeremy Daer | 2016-05-18 | 1 | -1/+1 |
| | | | | | | | | Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005 * Forward compat with new unified Integer class in Ruby 2.4+. * Backward compat with separate Fixnum/Bignum in Ruby 2.2 & 2.3. * Drops needless Fixnum distinction in docs, preferring Integer. | ||||
* | Fix some typos in comments. | Joe Rafaniello | 2016-05-04 | 1 | -1/+1 |
| | | | | [ci skip] | ||||
* | :hocho: Typos | Akira Matsuda | 2015-09-21 | 1 | -1/+1 |
| | |||||
* | :scissors: empty line at the top of files | Akira Matsuda | 2015-09-21 | 1 | -1/+0 |
| | |||||
* | Expand coverage of JSON gem tests | Godfrey Chan | 2015-07-11 | 1 | -16/+30 |
| | |||||
* | Add tests to ensure we don't interfere with json gem's output | Godfrey Chan | 2015-07-11 | 1 | -0/+52 |
| | |||||
* | Small stylistic tweaks for `Delegator#try` patch | Godfrey Chan | 2015-05-19 | 1 | -15/+15 |
| | | | | | | * Rename `ActiveSupport::Try` => `ActiveSupport::Tryable` * Include the modules inline * `private` indentation | ||||
* | Patch `Delegator` to work with `#try` | Nate Smith | 2015-05-19 | 1 | -0/+64 |
| | | | | | | | | | | | | `Delegator` inherits from `BasicObject`, which means that it will not have `Object#try` defined. It will then delegate the call to the underlying object, which will not (necessarily) respond to the method defined in the enclosing `Delegator`. This patches `Delegator` with the `#try` method to work around the surprising behaviour. Fixes #5790 | ||||
* | Put the assertion arguments in the right order | Matthew Draper | 2015-05-05 | 1 | -1/+1 |
| | |||||
* | deep_dup method, remove old key from duplicated hash to avoid unnecessary pairs | Mehmet Emin İNAÇ | 2015-05-04 | 1 | -0/+6 |
| | |||||
* | Skip the failing tests on Rubinius for now | Robin Dupret | 2015-03-02 | 1 | -0/+3 |
| | |||||
* | Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵ | Vipul A M | 2015-02-03 | 1 | -1/+0 |
| | | | | onwards. | ||||
* | Remove hack to support BigDecimal in Ruby 1.9 | claudiob | 2015-01-04 | 1 | -10/+1 |
| | | | | | Now that Rails requires Ruby >= 2.0, there is no need to check whether `BigDecimal` exists or not. | ||||
* | Removed Object#itself as it's implemented in ruby 2.2 | Cristian Bica | 2014-12-29 | 1 | -9/+0 |
| | |||||
* | Pass symbol as an argument instead of a block | Erik Michaels-Ober | 2014-11-29 | 1 | -2/+2 |
| | |||||
* | Bring try! into parity with try. | Ari Pollak | 2014-10-22 | 1 | -4/+8 |
| | | | | Based on commit 5e51bdda. | ||||
* | add implementation of respond_to? for ActiveSupport::Duration | lsylvester | 2014-09-15 | 1 | -1/+1 |
| | |||||
* | Methods are not duplicable. | Peter Jaros | 2014-09-03 | 1 | -1/+1 |
| | |||||
* | Bring back the test cases for `presence` | Godfrey Chan | 2014-08-29 | 1 | -0/+5 |
| | | | | This was removed by mistake in 5e51bdd | ||||
* | We tenderized the wrong method! Object#try already had the yield option, ↵ | David Heinemeier Hansson | 2014-08-29 | 2 | -10/+4 |
| | | | | just needed some tenderloving instance_eval to fit the bill |