Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | :hocho: Typos | Akira Matsuda | 2015-09-21 | 1 | -1/+1 |
| | |||||
* | :scissors: empty line at the top of files | Akira Matsuda | 2015-09-21 | 1 | -1/+0 |
| | |||||
* | Expand coverage of JSON gem tests | Godfrey Chan | 2015-07-11 | 1 | -16/+30 |
| | |||||
* | Add tests to ensure we don't interfere with json gem's output | Godfrey Chan | 2015-07-11 | 1 | -0/+52 |
| | |||||
* | Small stylistic tweaks for `Delegator#try` patch | Godfrey Chan | 2015-05-19 | 1 | -15/+15 |
| | | | | | | * Rename `ActiveSupport::Try` => `ActiveSupport::Tryable` * Include the modules inline * `private` indentation | ||||
* | Patch `Delegator` to work with `#try` | Nate Smith | 2015-05-19 | 1 | -0/+64 |
| | | | | | | | | | | | | `Delegator` inherits from `BasicObject`, which means that it will not have `Object#try` defined. It will then delegate the call to the underlying object, which will not (necessarily) respond to the method defined in the enclosing `Delegator`. This patches `Delegator` with the `#try` method to work around the surprising behaviour. Fixes #5790 | ||||
* | Put the assertion arguments in the right order | Matthew Draper | 2015-05-05 | 1 | -1/+1 |
| | |||||
* | deep_dup method, remove old key from duplicated hash to avoid unnecessary pairs | Mehmet Emin İNAÇ | 2015-05-04 | 1 | -0/+6 |
| | |||||
* | Skip the failing tests on Rubinius for now | Robin Dupret | 2015-03-02 | 1 | -0/+3 |
| | |||||
* | Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵ | Vipul A M | 2015-02-03 | 1 | -1/+0 |
| | | | | onwards. | ||||
* | Remove hack to support BigDecimal in Ruby 1.9 | claudiob | 2015-01-04 | 1 | -10/+1 |
| | | | | | Now that Rails requires Ruby >= 2.0, there is no need to check whether `BigDecimal` exists or not. | ||||
* | Removed Object#itself as it's implemented in ruby 2.2 | Cristian Bica | 2014-12-29 | 1 | -9/+0 |
| | |||||
* | Pass symbol as an argument instead of a block | Erik Michaels-Ober | 2014-11-29 | 1 | -2/+2 |
| | |||||
* | Bring try! into parity with try. | Ari Pollak | 2014-10-22 | 1 | -4/+8 |
| | | | | Based on commit 5e51bdda. | ||||
* | add implementation of respond_to? for ActiveSupport::Duration | lsylvester | 2014-09-15 | 1 | -1/+1 |
| | |||||
* | Methods are not duplicable. | Peter Jaros | 2014-09-03 | 1 | -1/+1 |
| | |||||
* | Bring back the test cases for `presence` | Godfrey Chan | 2014-08-29 | 1 | -0/+5 |
| | | | | This was removed by mistake in 5e51bdd | ||||
* | We tenderized the wrong method! Object#try already had the yield option, ↵ | David Heinemeier Hansson | 2014-08-29 | 2 | -10/+4 |
| | | | | just needed some tenderloving instance_eval to fit the bill | ||||
* | Clarify the origin of this great addition to Rails :trollface: :trollface ↵ | David Heinemeier Hansson | 2014-08-29 | 1 | -1/+1 |
| | | | | :trollface: | ||||
* | Use instance_eval on @tenderlove's suggestion :trollface: | David Heinemeier Hansson | 2014-08-29 | 1 | -2/+2 |
| | |||||
* | Added yield to Object#presence | David Heinemeier Hansson | 2014-08-29 | 1 | -0/+5 |
| | |||||
* | Rename tests too | Rafael Mendonça França | 2014-08-01 | 1 | -2/+2 |
| | |||||
* | Rename Object#self to Object#itself to have parity with matz sanctioned ↵ | David Heinemeier Hansson | 2014-08-01 | 1 | -1/+1 |
| | | | | method name for Ruby 2.2 | ||||
* | Added Object#self which returns the object itself | David Heinemeier Hansson | 2014-08-01 | 1 | -0/+9 |
| | |||||
* | Add missing test case for Array#to_sentence, collect all test cases for ↵ | Akshay Vishnoi | 2014-07-29 | 1 | -2/+8 |
| | | | | Object#to_param at one place and avoid repitition | ||||
* | Added failing test case for #16131 | Godfrey Chan | 2014-07-29 | 1 | -0/+42 |
| | |||||
* | Merge pull request #15629 from akshay-vishnoi/test-to_param | Rafael Mendonça França | 2014-07-28 | 2 | -0/+22 |
|\ | | | | | Define Hash#to_query and set Hash#to_param as alias to it; with test cases | ||||
| * | Move to_param to to_query, also Improve tests | Akshay Vishnoi | 2014-06-20 | 2 | -0/+22 |
| | | |||||
* | | Move object test files under object | Akshay Vishnoi | 2014-07-29 | 3 | -0/+155 |
| | | |||||
* | | missing activesupport test coverage | Eugene Gilburg | 2014-07-19 | 1 | -0/+4 |
| | | |||||
* | | Move test for blank.rb under object | Akshay Vishnoi | 2014-06-11 | 1 | -0/+36 |
| | | |||||
* | | Add test cases for #in? and #presence_in | Akshay Vishnoi | 2014-06-11 | 1 | -0/+4 |
|/ | |||||
* | Merge pull request #14949 from bogdan/empty-hash-array-parameterization | Rafael Mendonça França | 2014-05-04 | 1 | -3/+5 |
|\ | | | | | [Fixes #14948] Hash#to_query: right serialization for empty hash and array | ||||
| * | [Fixes #14948] Hash#to_query: Changed a way how empty hash and empty array ↵ | Bogdan Gusiev | 2014-05-03 | 1 | -3/+5 |
| | | | | | | | | | | | | | | | | | | | | | | are serialized Empty Hash or Array should not present in serialization result {a: []}.to_query # => "" {a: {}}.to_query # => "" For more info see #14948. | ||||
* | | Remove deprecated file(`active_support/core_ext/object/to_json.rb`) and its ↵ | Kuldeep Aggarwal | 2014-05-04 | 1 | -9/+0 |
|/ | | | | test case. | ||||
* | Object#duplicable? | Akshay Vishnoi | 2014-04-16 | 1 | -16/+9 |
| | | | | | | 1. Improve tests 2. Remove unnecessary constant 3. Add docs for BigDecimal#duplicable? | ||||
* | Move tests for deep_dup and duplicable to object directory | Akshay Vishnoi | 2014-04-13 | 2 | -0/+91 |
| | |||||
* | Go with #presence_in instead of #present_in -- it doesnt sound quite as ↵ | David Heinemeier Hansson | 2014-02-24 | 1 | -3/+3 |
| | | | | good, but the closer relationship to #presence over #present is ultimately worth it | ||||
* | Use assert_nil instead as its clearer about what the return is expected to be | David Heinemeier Hansson | 2014-02-18 | 1 | -1/+1 |
| | |||||
* | Added Object#present_in to simplify value whitelisting | David Heinemeier Hansson | 2014-02-18 | 1 | -0/+5 |
| | |||||
* | Fix to_query with empty arrays too | Rafael Mendonça França | 2014-02-06 | 1 | -0/+2 |
| | |||||
* | Refatoring the method to avoid shot-circuit return | Rafael Mendonça França | 2014-02-05 | 1 | -0/+2 |
| | |||||
* | Test with a blank value | Rafael Mendonça França | 2014-02-05 | 1 | -2/+2 |
| | |||||
* | Move test to the right file | Rafael Mendonça França | 2014-02-05 | 2 | -11/+9 |
| | |||||
* | Fixed "Hash#to_param confused by empty hash values #13892" | Hincu Petru | 2014-02-05 | 1 | -0/+11 |
| | |||||
* | Moved all JSON core extensions into core_ext/object/json | Godfrey Chan | 2013-09-13 | 1 | -0/+9 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | TL;DR The primary driver is to remove autoload surprise. This is related to #12106. (The root cause for that ticket is that json/add defines Regexp#to_json among others, but here I'll reproduce the problem without json/add.) Before: >> require 'active_support/core_ext/to_json' => true >> //.as_json NoMethodError: undefined method `as_json' for //:Regexp from (irb):3 from /Users/godfrey/.rvm/rubies/ruby-2.0.0-p195/bin/irb:16:in `<main>' >> //.to_json => "\"(?-mix:)\"" >> //.as_json => "(?-mix:)" After: >> require 'active_support/core_ext/to_json' => true >> //.as_json => "(?-mix:)" This is because ActiveSupport::JSON is autoloaded the first time Object#to_json is called, which causes additional core extentions (previously defined in active_support/json/encoding.rb) to be loaded. When someone require 'active_support/core_ext', the expectation is that it would add certain methods to the core classes NOW. The previous behaviour causes additional methods to be loaded the first time you call `to_json`, which could cause nasty surprises and other unplesant side-effects. This change moves all core extensions in to core_ext/json. AS::JSON is still autoloaded on first #to_json call, but since it nolonger include the core extensions, it should address the aforementioned bug. *Requiring core_ext/object/to_json now causes a deprecation warnning* | ||||
* | Revert "Object#in? also accepts multiple parameters" | Brian Morearty | 2013-05-01 | 1 | -10/+0 |
| | | | | | | | | | | | | | | | | | | This reverts commit ebf69ab1636df74c76332c53bcd3d8494fb91b45. `in?` must not take multiple parameters because its behavior would be ambiguous: # Test if "B" is included in a list of names with `"B".in?(*names)`: names = ["BMorearty"] "B".in?(*names) # => true names = ["BMorearty","rubyduo"] "B".in?(*names) # => false Conflicts: activesupport/lib/active_support/core_ext/object/inclusion.rb activesupport/test/core_ext/object/inclusion_test.rb | ||||
* | remove unused parameter passed to assert_query_equal method | Vipul A M | 2013-03-17 | 1 | -1/+1 |
| | |||||
* | Remove .rb from require sentences | José Corcuera Z | 2012-09-21 | 1 | -1/+1 |
| | |||||
* | remove usages of AS::OrderedHash | Vishnu Atrai | 2012-03-03 | 1 | -2/+2 |
| |