Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #31648 from dixitp012/rubocop_active_support_test | Ryuta Kamizono | 2018-01-08 | 1 | -2/+2 |
|\ | | | | | | | Fix rubocop space before comma | ||||
| * | Fix rubocop space before comma | Dixit Patel | 2018-01-08 | 1 | -1/+1 |
|/ | |||||
* | Add support for multiple encodings in String.blank? | Cory Gwin @gwincr11 | 2017-11-17 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | Motivation: - When strings are encoded with `.encode("UTF-16LE")` `.blank?` throws an `Encoding::CompatibilityError` exception. - We tested multiple implementation to see what the fastest implementation was, rescueing the execption seems to be the fastest option we could find. Related Issues: - #28953 Changes: - Add a rescue to catch the exception. - Added a `Concurrent::Map` to store a cache of encoded regex objects for requested encoding types. - Use the new `Concurrent::Map` cache to return the correct regex for the string being checked. | ||||
* | [Active Support] `rubocop -a --only Layout/EmptyLineAfterMagicComment` | Koichi ITO | 2017-07-11 | 1 | -0/+1 |
| | |||||
* | Use frozen-string-literal in ActiveSupport | Kir Shatrov | 2017-07-09 | 1 | -0/+1 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | Add Time#blank? to blank_test | kenta-s | 2017-02-12 | 1 | -1/+1 |
| | |||||
* | "Use assert_nil if expecting nil. This will fail in minitest 6." | Akira Matsuda | 2016-12-25 | 1 | -1/+1 |
| | |||||
* | applies new string literal convention in activesupport/test | Xavier Noria | 2016-08-06 | 1 | -4/+4 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | :scissors: empty line at the top of files | Akira Matsuda | 2015-09-21 | 1 | -1/+0 |
| | |||||
* | Removed magic comments # encoding: utf-8 , since its default from ruby 2.0 ↵ | Vipul A M | 2015-02-03 | 1 | -1/+0 |
| | | | | onwards. | ||||
* | Bring back the test cases for `presence` | Godfrey Chan | 2014-08-29 | 1 | -0/+5 |
| | | | | This was removed by mistake in 5e51bdd | ||||
* | We tenderized the wrong method! Object#try already had the yield option, ↵ | David Heinemeier Hansson | 2014-08-29 | 1 | -10/+0 |
| | | | | just needed some tenderloving instance_eval to fit the bill | ||||
* | Clarify the origin of this great addition to Rails :trollface: :trollface ↵ | David Heinemeier Hansson | 2014-08-29 | 1 | -1/+1 |
| | | | | :trollface: | ||||
* | Use instance_eval on @tenderlove's suggestion :trollface: | David Heinemeier Hansson | 2014-08-29 | 1 | -2/+2 |
| | |||||
* | Added yield to Object#presence | David Heinemeier Hansson | 2014-08-29 | 1 | -0/+5 |
| | |||||
* | Move test for blank.rb under object | Akshay Vishnoi | 2014-06-11 | 1 | -0/+36 |