Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Adjust `Module.parent_name` to work when frozen; fixes #27637 | Corey Ward | 2017-01-17 | 1 | -30/+0 |
| | |||||
* | Constant look-up would no longer fall back to top-level constant since ruby 2.5 | Akira Matsuda | 2017-01-13 | 1 | -2/+2 |
| | | | | | See: https://github.com/ruby/ruby/commit/44a2576f798b07139adde2d279e48fdbe71a0148 https://github.com/ruby/ruby/commit/9df88e9cae57aa421230f14500e88f33f127414f | ||||
* | class Foo < Struct.new(:x) creates an extra unneeded anonymous class | Akira Matsuda | 2017-01-13 | 1 | -1/+1 |
| | | | | because Struct.new returns a Class, we just can give it a name and use it directly without inheriting from it | ||||
* | assert_equal takes expectation first | Akira Matsuda | 2016-12-26 | 1 | -9/+9 |
| | |||||
* | Remove deprecated method alias_method_chain | Andrew White | 2016-11-14 | 1 | -215/+0 |
| | |||||
* | Remove deprecated local_constants | Andrew White | 2016-11-13 | 1 | -10/+0 |
| | |||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 1 | -2/+2 |
| | |||||
* | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 1 | -3/+3 |
| | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
* | Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty lines | Ryuta Kamizono | 2016-08-07 | 1 | -1/+0 |
| | |||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -3/+3 |
| | |||||
* | modernizes hash syntax in activesupport | Xavier Noria | 2016-08-06 | 1 | -25/+25 |
| | |||||
* | applies new string literal convention in activesupport/test | Xavier Noria | 2016-08-06 | 1 | -35/+35 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Add test for `delegate_missing_to` where method doesn't exist | Jon Moss | 2016-05-26 | 1 | -0/+8 |
| | |||||
* | Add tests for keyword arg to: for Module#delegate | Yosuke Kabuto | 2016-05-25 | 1 | -0/+15 |
| | |||||
* | Don't delegate to private methods of the targer | Rafael Mendonça França | 2016-05-24 | 1 | -0/+14 |
| | | | | And make sure that it doesn't even try to call the method in the target. | ||||
* | Merge pull request #23930 from gsamokovarov/module-delegate-missing-to | Rafael Mendonça França | 2016-05-24 | 1 | -0/+22 |
|\ | | | | | | | Introduce Module#delegate_missing_to | ||||
| * | Introduce Module#delegate_missing_to | Genadi Samokovarov | 2016-02-27 | 1 | -0/+22 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When building decorators, a common pattern may emerge: class Partition def initialize(first_event) @events = [ first_event ] end def people if @events.first.detail.people.any? @events.collect { |e| Array(e.detail.people) }.flatten.uniq else @events.collect(&:creator).uniq end end private def respond_to_missing?(name, include_private = false) @events.respond_to?(name, include_private) end def method_missing(method, *args, &block) @events.send(method, *args, &block) end end With `Module#delegate_missing_to`, the above is condensed to: class Partition delegate_missing_to :@events def initialize(first_event) @events = [ first_event ] end def people if @events.first.detail.people.any? @events.collect { |e| Array(e.detail.people) }.flatten.uniq else @events.collect(&:creator).uniq end end end David suggested it in #23824. | ||||
* | | Remove duplicated `test_` prefix [ci skip] | Ryuta Kamizono | 2016-03-02 | 1 | -1/+1 |
| | | |||||
* | | Deprecate `Module.local_constants` | yui-knk | 2016-03-01 | 1 | -1/+7 |
|/ | | | | | After Ruby 1.9, we can easily get the constants that have been defined locally by `Module.constants(false)`. | ||||
* | Fixing issue when delegating to methods named "block", "args", or "arg" | Jake Bell | 2015-08-19 | 1 | -0/+15 |
| | |||||
* | Deprecate alias_method_chain in favour of Module#prepend | Kir Shatrov | 2015-03-22 | 1 | -95/+125 |
| | | | …as discussed #19413 | ||||
* | Revert 88d08f2ec9f89ba431cba8d0c06ac9ebc204bbbb | Rafael Mendonça França | 2015-02-11 | 1 | -1/+1 |
| | | | | | | | This caused a performance regression since we were decided to do the nil check in run time not in the load time. See https://github.com/rails/rails/pull/15187#issuecomment-71760058 | ||||
* | Delegation works with reserved words passed to `:to` | Agis- | 2014-09-19 | 1 | -0/+11 |
| | | | | Fixes #16956. | ||||
* | Fix confusing exception in ActiveSupport delegation | Vladimir Yarotsky | 2014-05-20 | 1 | -1/+1 |
| | |||||
* | Remove warning | Rafael Mendonça França | 2014-01-16 | 1 | -2/+2 |
| | |||||
* | define the delegate methods on one line. fixes #13724 | Aaron Patterson | 2014-01-16 | 1 | -0/+10 |
| | | | | sup haters | ||||
* | Unused classes in AS tests | Akira Matsuda | 2013-12-19 | 1 | -6/+0 |
| | |||||
* | Only raise DelegationError if it's is the source of the exception | Andrew White | 2013-07-11 | 1 | -0/+27 |
| | | | | | | | | | This fixes situations where nested NoMethodError exceptions are masked by delegations. This would cause confusion especially where there was a problem in the Rails booting process because of a delegation in the routes reloading code. Fixes #10559 | ||||
* | Fixed test broken by local_constant_names | Arun Agrawal | 2013-07-03 | 1 | -6/+0 |
| | | | depreciation removed | ||||
* | Move delegation error constant to inside Module | Carlos Antonio da Silva | 2013-06-26 | 1 | -1/+1 |
| | |||||
* | Add DelegationError class. Rasied by delegation to a nil object | Steve Faulkner | 2013-06-26 | 1 | -1/+1 |
| | |||||
* | Module#delegate checks nilness rather that falsehood if :allow_nil is true, ↵ | Xavier Noria | 2013-04-26 | 1 | -0/+31 |
| | | | | | | | | | | | | | | and avoids multiple evaluation of the target method Notes: 1) I hope nilness is a word. 2) See rationale for avoiding multiple evaluation in a comment in the patch, credit goes to @jeremy for pointing out this gotcha in the existing implementation. 3) Embeds a little joke dedicated to @pixeltrix (it could be worse! :D). References #10347. | ||||
* | Delegation method bug | Li Ellis Gallardo | 2013-04-25 | 1 | -0/+5 |
| | | | | | | Add documentation and test to delegation method that make sure we're aware that when a delegated object is not nil or false and doesn't respond to the method it will still raise a NoMethodError exception. | ||||
* | Nice and easy delegation to the class | Marc-Andre Lafortune | 2012-09-11 | 1 | -0/+11 |
| | |||||
* | JRuby return different Array for module contents. | Arun Agrawal | 2012-05-29 | 1 | -1/+1 |
| | | | | | Test was failing against JRuby. It loads like [Constant3 Constant1] | ||||
* | Optimize the performance of #delegate | Daniel Schierbeck | 2012-04-12 | 1 | -0/+19 |
| | | | | | | Remove the use of #__send__ in order to boost performance. This also means that you can no longer delegate to private methods on the target object. | ||||
* | deprecates Module#local_constant_names | Xavier Noria | 2012-01-12 | 1 | -0/+6 |
| | |||||
* | use AS::TestCase as the base class | Aaron Patterson | 2012-01-05 | 1 | -2/+2 |
| | |||||
* | We can't simply check the first line of the backtrace, | Arun Agrawal | 2011-09-04 | 1 | -4/+6 |
| | | | because JRuby reports the call to __send__ in the backtrace. | ||||
* | Revert all the stuff to do with disallowing non-public methods for ↵ | Jon Leighton | 2011-08-25 | 1 | -19/+1 |
| | | | | Module#delegate | ||||
* | Add a test for delegating a method ending in '=' as this is a special case. | Jon Leighton | 2011-08-15 | 1 | -0/+8 |
| | |||||
* | Split up the definitions in Module#delegate depending on :allow_nil, and ↵ | Jon Leighton | 2011-08-15 | 1 | -0/+12 |
| | | | | don't use exceptions for flow control in the :allow_nil => true case. | ||||
* | Fix the line number in the backtrace when Module#delegate raises | Jon Leighton | 2011-08-15 | 1 | -1/+13 |
| | |||||
* | Just do the method call directly in Module#delegate, if we can (we cannot ↵ | Jon Leighton | 2011-08-15 | 1 | -2/+20 |
| | | | | for method names ending in '='). Two reasons: 1) it's faster, see https://gist.github.com/1089783 and 2) more importantly, delegate should not allow you to accidentally call private or protected methods. | ||||
* | Remove unused line in test setup. | Ben Orenstein | 2011-02-17 | 1 | -1/+0 |
| | | | | | | [#6442 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Remove unused code. | Ben Orenstein | 2011-02-16 | 1 | -3/+0 |
| | | | | | | [#6437 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | delegate method should treat :prefix => false same as :prefix => nil | Neeraj Singh | 2010-09-01 | 1 | -0/+13 |
| | | | | | | [#5375 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Removes unused vars | Santiago Pastorino | 2010-07-24 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Final iteration of use better testing methods | Neeraj Singh | 2010-05-19 | 1 | -5/+5 |
| | | | | | | [#4652 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Singleton classes returns parent's methods with instance_methods(false) and ↵ | José Valim | 2010-03-19 | 1 | -0/+14 |
| | | | | this makes remove_method in Module#delegate fail. Add a test case and fix the bug. |