aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/test/core_ext/module
Commit message (Collapse)AuthorAgeFilesLines
* code gardening: removes redundant selfsXavier Noria2016-08-081-8/+8
| | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required.
* applies remaining conventions across the projectXavier Noria2016-08-061-2/+0
|
* normalizes indentation and whitespace across the projectXavier Noria2016-08-064-10/+10
|
* modernizes hash syntax in activesupportXavier Noria2016-08-061-3/+3
|
* applies new string literal convention in activesupport/testXavier Noria2016-08-069-48/+48
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Fix `thread_mattr_accessor` thread-local variable namingMichael Ryan2016-03-111-0/+6
| | | | | | | | | | | | | | | | | The current implentation of `thread_mattr_accessor` is setting differently-named thread variables when defining class and instance writer methods, so the method isn't working as documented: Account.user = "DHH" Account.user # => "DHH" Account.new.user # => nil a = Account.new a.user = "ABC" # => "ABC" a.class.user # => "DHH" At this point `:attr_Account_user` and `:attr_Class_user` thread-local variables have been created. Modify the reader and writer methods to use the class name instead of 'Class'.
* Use separate test class nameDavid Heinemeier Hansson2015-12-171-1/+1
|
* Add thread_m/cattr_accessor/reader/writer suite of methods for declaring ↵David Heinemeier Hansson2015-12-171-0/+109
| | | | class and module variables that live per-thread
* Don't leak Object constants in core_ext/module/qualified_constGenadi Samokovarov2015-12-161-60/+70
|
* Make `Module#redefine_method` to keep method visibilityyui-knk2015-10-261-1/+19
| | | | | | | Before this commit `Module#redefine_method` always changes visibility of redefined method to `public`. This commit changes behavior of Module#redefine_method` to keep method visibility.
* Add Module#remove_possible_singleton_methodAndrew White2015-10-211-3/+15
| | | | | This is primarily to fix method redefinition warnings in class_attribute but may be of use in other places where we define singleton methods.
* Regex fix for mattr_accessor validationAliaksandr Buhayeu2015-10-011-0/+14
| | | | | Change ^ and $ operators to \A and \z to prevent code injection after the line breaks
* Only invoke the default block for mattr_accessor once so that it does not ↵Lachlan Sylvester2015-08-071-0/+6
| | | | cause issues if it is not idempotent
* Introduce Concern#class_methods and Kernel#concernJeremy Kemper2014-02-231-14/+44
|
* Introduce Module#concerningJeremy Kemper2013-12-171-0/+35
| | | | | | A natural, low-ceremony way to separate responsibilities within a class. Imported from https://github.com/37signals/concerning#readme
* Unify cattr and mattr accessors declarationsGenadi Samokovarov2013-12-021-4/+22
|
* Fix some assert_raise calls containing messages in Active SupportCarlos Antonio da Silva2012-10-281-6/+13
|
* Fix ActiveSupport tests that depend on run orderFrancesco Rodriguez2012-08-231-11/+18
|
* validate attribute names in class and module attribute accessorsDmitry Plashchynski2012-03-301-0/+14
|
* use AS::TestCase as the base classAaron Patterson2012-01-053-3/+3
|
* Module#synchronize is deprecated with no replacement. Please use `monitor` ↵Aaron Patterson2011-11-291-89/+0
| | | | from ruby's standard library.
* added remove_method core_ext testsAnand2011-11-071-0/+29
|
* defines Module#qualified_const_(defined?|get|set) and String#deconstantizeXavier Noria2011-10-291-0/+94
| | | | | | | | | | This commit also implements a faster version of #demodulize I was unable to isolate with git add --patch. Not a big fan of the name #deconstantize. It complements #demodulize getting rid of the rightmost constant, hence the name, but it is unrelated to the well-known #constantize. So unsure. Could not come with anything better, please feel free to rename.
* Added instance_accessor: false to Module#mattr_accessorVijay Dev2011-06-141-0/+7
|
* Removed deprecated methods and related tests from ActiveSupportJosh Kalderimis2011-05-251-39/+0
|
* Deprecate attr_accessor_with_default.José Valim2011-05-161-4/+12
|
* Don't depend on rubygems loading thread (for Mutex)raggi2010-11-251-0/+1
|
* attr_accessor_with_default should raise an ArgumentError not a RuntimeErrorAaron Patterson2010-09-241-1/+1
|
* Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵Santiago Pastorino2010-08-145-17/+17
| | | | 's/[ \t]*$//' -i {} \;)
* Final iteration of use better testing methodsNeeraj Singh2010-05-192-7/+7
| | | | | | [#4652 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* fixing inconsistency with cattr_reader and matter_reader [#4172 state:resolved]Kabari Hendrick2010-03-271-0/+6
| | | Signed-off-by: wycats <wycats@gmail.com>
* moves Class#reachable? to Module#reachable?, bases implementation on ↵Xavier Noria2010-02-111-0/+41
| | | | anonymous? and constantize, and adds test coverage
* defines Module#anonymous?Xavier Noria2010-02-111-0/+14
|
* Move model naming into ActiveModelJoshua Peek2009-06-171-28/+0
|
* Add #element and #collection to ModelNameJeremy Kemper2009-06-081-0/+8
|
* Fix dependencies revealed by testing in isolationJeremy Kemper2009-04-224-3/+7
|
* Opt in to DependenciesJeremy Kemper2009-04-221-0/+1
|
* Explicit test dependenciesJeremy Kemper2009-03-281-1/+4
|
* Ruby 1.9 compat: rename deprecated assert_raises to assert_raise.Jeremy Kemper2009-03-081-2/+2
| | | | [#1617 state:resolved]
* Rework testing extensions to reflect the recent miniunit upheavalJeremy Kemper2008-11-071-4/+4
|
* Module#synchronize: Add testcase to ensure that singleton methods can be wrappedNick2008-08-291-3/+17
|
* Add method punctuation handling to #synchronizeNick2008-08-291-0/+14
|
* Adds Module#synchronize for easier method-level synchronization.Nick2008-08-291-0/+57
|
* Move Class::ModelName to Active Support module core_extJeremy Kemper2008-06-061-0/+19
|
* require abstract_unit directly since test is in load pathJeremy Kemper2008-01-054-5/+5
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8563 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Ruby 1.9 compat: shadowed vars, kcodeJeremy Kemper2007-12-151-2/+6
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8402 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Hax to workaround private send for Ruby 1.9. Consider moving to send! and ↵Jeremy Kemper2007-09-271-7/+7
| | | | | | aliasing to send for < 1.9. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7651 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Use instance_variable_defined? instead of instance_variables.include? to ↵Jeremy Kemper2007-09-272-11/+11
| | | | | | account for string/symbol differences between 1.8 and 1.9 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7650 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Let alias_attribute work with attributes with initial capital letters ↵Michael Koziarski2007-07-191-1/+24
| | | | | | (legacy columns etc). Closes #8596 [mpalmer] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Clean up junk test. Closes #7973 [Rob Sanheim]Jeremy Kemper2007-06-082-31/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de