Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Do nothing when the same block is included again. | Mark J. Titorenko | 2018-11-29 | 1 | -0/+8 |
| | | | | | | | | | If the same block is included multiple times, we no longer raise an exception or overwrite the included block instance variable. Fixes #14802. [Mark J. Titorenko + Vlad Bokov] | ||||
* | Use respond_to test helpers | Daniel Colson | 2018-01-25 | 1 | -1/+1 |
| | |||||
* | [Active Support] `rubocop -a --only Layout/EmptyLineAfterMagicComment` | Koichi ITO | 2017-07-11 | 1 | -0/+1 |
| | |||||
* | Use frozen-string-literal in ActiveSupport | Kir Shatrov | 2017-07-09 | 1 | -0/+1 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | use public Module#include instead of send :include | yuuji.yaginuma | 2016-11-27 | 1 | -1/+1 |
| | | | | Follow up to #18767 | ||||
* | improve error message when include assertions fail | Michael Grosser | 2016-09-16 | 1 | -2/+2 |
| | | | | | | assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong | ||||
* | code gardening: removes redundant selfs | Xavier Noria | 2016-08-08 | 1 | -1/+1 |
| | | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required. | ||||
* | applies new string literal convention in activesupport/test | Xavier Noria | 2016-08-06 | 1 | -2/+2 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Fix for #20489 - ActiveSupport::Concern#class_methods affects parent classes | Kristijan Novoselic | 2015-06-12 | 1 | -0/+25 |
| | |||||
* | Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846 | robertomiranda | 2015-01-31 | 1 | -5/+5 |
| | | | | ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769 | ||||
* | Introduce Concern#class_methods and Kernel#concern | Jeremy Kemper | 2014-02-23 | 1 | -2/+8 |
| | |||||
* | remove useless duplication in include test | Damien Mathieu | 2013-07-22 | 1 | -4/+0 |
| | |||||
* | remove duplication in test | Marat Kazbekov | 2013-07-18 | 1 | -6/+0 |
| | |||||
* | Raise when multiple included blocks are defined | Mike Dillon | 2013-05-16 | 1 | -0/+14 |
| | |||||
* | use AS::TestCase as the base class | Aaron Patterson | 2012-01-05 | 1 | -1/+1 |
| | |||||
* | Deprecate InstanceMethods namespace handling in ActiveSupport::Concern. | José Valim | 2011-11-21 | 1 | -5/+2 |
| | | | | This avoids the unnecessary "yo dawg, I heard you like include, so I put a module that includes your module when it is included" approach when building extensions. | ||||
* | AS::Concern redefines "include" to lazy include modules as dependencies | Joshua Peek | 2009-05-29 | 1 | -3/+3 |
| | |||||
* | AS::Concern includes InstanceMethods module if it exists | Joshua Peek | 2009-05-29 | 1 | -4/+13 |
| | |||||
* | Break up DependencyModule's dual function of providing a "depend_on" DSL and ↵ | Joshua Peek | 2009-05-28 | 1 | -0/+88 |
"included" block DSL into separate modules. But, unify both approaches under AS::Concern. |