Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Fix FileStore#cleanup to no longer rely on missing each_key method | Murray Steele | 2013-09-11 | 1 | -0/+12 | |
|/ | ||||||
* | [Fixes #11512] improves cache size calculation in ↵ | Simeon Simeonov | 2013-07-22 | 1 | -2/+26 | |
| | | | | | | | | | | | | | | | | | | | | | ActiveSupport::Cache::MemoryStore Previously, the cache size of `ActiveSupport::Cache::MemoryStore` was calculated as the sum of the size of its entries, ignoring the size of keys and any data structure overhead. This could lead to the calculated cache size sometimes being 10-100x smaller than the memory used, e.g., in the case of small values. The size of a key/entry pair is now calculated via `#cached_size`: def cached_size(key, entry) key.to_s.bytesize + entry.size + PER_ENTRY_OVERHEAD end The value of `PER_ENTRY_OVERHEAD` is 240 bytes based on an [empirical estimation](https://gist.github.com/ssimeonov/6047200) for 64-bit MRI on 1.9.3 and 2.0. Fixes GH#11512 https://github.com/rails/rails/issues/11512 | |||||
* | Explicitly test for true and false. | Jade Tucker | 2013-07-07 | 1 | -2/+2 | |
| | ||||||
* | Allow fetching multiple values from the cache at once | Daniel Schierbeck | 2013-05-06 | 1 | -0/+20 | |
| | | | | | Add a simple API for fetching a list of entries from the cache, where any missing entries are computed by a supplied block. | |||||
* | switch (and lazily convert) ivar names to 3.x | Sam Ruby | 2013-04-16 | 1 | -16/+15 | |
| | ||||||
* | Fixed typo | Anupam Choudhury | 2013-04-10 | 1 | -1/+1 | |
| | ||||||
* | Fix typo in DependenciesTestHelpers module name | Vipul A M | 2013-03-12 | 1 | -2/+2 | |
| | ||||||
* | Fix deletion of empty directories: | Charles Jones | 2013-02-25 | 1 | -0/+12 | |
| | | | | | | | | | | | | | | | 1. When comparing the directory to delete against the top level cache_path, use File.realpath to make sure we aren't comparing two unequal strings that point to the same path. This occurs, for example, when cache_path has a trailing slash, which it does in the default Rails configuration. Since the input to delete_empty_directories never has a trailing slash, the comparison will never be true and the top level cache directory (and above) may be deleted. However… 2. File.delete raises EPERM when trying to delete a directory, so no directories have ever been deleted. Changing the code to Dir.delete fixes that. | |||||
* | deprecate `assert_blank` and `assert_present`. | Yves Senn | 2013-01-05 | 1 | -3/+3 | |
| | | | | | They don't add any benefits over `assert object.blank?` and `assert object.present?` | |||||
* | Patched Marshal#load to work with constant autoloading ↵ | Uriel Katz | 2012-12-01 | 1 | -0/+42 | |
| | | | | (active_support/dependecies.rb) (issue #8167) | |||||
* | make the cache test more @tenderlove(ing) and not depend on internal ↵ | Noah Hendrix | 2012-10-23 | 1 | -2/+7 | |
| | | | | implentation | |||||
* | pass the key to the block in cache.fetch on misses | Noah Hendrix | 2012-10-23 | 1 | -2/+7 | |
| | ||||||
* | adding a test for b21f24d9807bd161af947cf0f0cc440c9adffb73 | Aaron Patterson | 2012-10-11 | 1 | -0/+14 | |
| | ||||||
* | warning fixed: (...) interpreted as grouped expression | Arun Agrawal | 2012-10-01 | 1 | -1/+1 | |
| | ||||||
* | fix broken cache tests | Brian Durand | 2012-09-30 | 1 | -1/+1 | |
| | ||||||
* | Fix other assertions that were backwards. | Steve Klabnik | 2012-09-30 | 1 | -5/+5 | |
| | | | | This time I used ack. | |||||
* | fix order of assertions. | Steve Klabnik | 2012-09-30 | 1 | -2/+2 | |
| | ||||||
* | Optimize ActiveSupport::Cache::Entry to reduce memory and processing overhead. | Brian Durand | 2012-09-30 | 1 | -38/+53 | |
| | ||||||
* | skip the memcache tests if the memcache server is not up | Aaron Patterson | 2012-08-22 | 1 | -38/+50 | |
| | ||||||
* | Add test to cover increment/decrement of non-existing key in MemCacheStore | Guillermo Iguaran | 2012-08-17 | 1 | -0/+2 | |
| | ||||||
* | Replace deprecated `memcache-client` gem with `dalli` in ↵ | Guillermo Iguaran | 2012-08-17 | 1 | -6/+6 | |
| | | | | | | ActiveSupport::Cache::MemCacheStore memcache-client was deprecated in favour of dalli in 2010. | |||||
* | Merge pull request #5125 from winston/log_exception_when_cache_read_fails | Michael Koziarski | 2012-05-21 | 1 | -0/+9 | |
|\ | | | | | #read_entry in ActiveSupport::Cache::FileStore should log details of the exception when an exception is thrown | |||||
| * | #read_entry in ActiveSupport::Cache::FileStore should log details of the ↵ | Winston | 2012-02-22 | 1 | -0/+9 | |
| | | | | | | | | exception when an exception is thrown. | |||||
* | | add unless_exist option to memory store | grosser | 2012-05-10 | 1 | -0/+7 | |
| | | ||||||
* | | Merge pull request #4452 from tapajos/e5425c8f68fbb720fcbf4b14e1f154ac27dbbbed | Aaron Patterson | 2012-05-03 | 1 | -0/+7 | |
|\ \ | | | | | | | Fix cache (FileStore) clear to keep .gitkeep. | |||||
| * | | Cache (FileStore) clear should keep .gitkeep | Marcos Tapajos | 2012-01-13 | 1 | -0/+7 | |
| | | | ||||||
* | | | warning removed: (...) interpreted as grouped expression | Arun Agrawal | 2012-03-31 | 1 | -1/+1 | |
| | | | ||||||
* | | | Merge pull request #4911 from Floppy/master | Aaron Patterson | 2012-03-30 | 1 | -0/+10 | |
|\ \ \ | | | | | | | | | Reduce FILENAME_MAX_SIZE in ActiveSupport::Cache::FileStore | |||||
| * | | | Change FILENAME_MAX_SIZE in FileStore to 228. | James Smith | 2012-02-06 | 1 | -0/+10 | |
| | |/ | |/| | | | | | | | In order that temp filenames generated from it will fit in 255 chars. See https://github.com/rails/rails/issues/4907 | |||||
* / | | Allow retrieve_cache_key to work on collections such as ActiveRecord::Relation. | Erich Menge | 2012-03-12 | 1 | -0/+4 | |
|/ / | ||||||
* / | Revert "Fix expanding cache key for single element arrays" | David Heinemeier Hansson | 2012-01-27 | 1 | -15/+7 | |
|/ | | | | | | This reverts commit abe915f23777efe10f17d611bf5718ca855a0704. This broke all existing keys and it's wrong anyway. The array is just there as a convenience option for building the string. It's intentional that [ "stuff"] and "stuff" generates the same key. | |||||
* | Moved all the logger methods to active support logger | Karunakar (Ruby) | 2012-01-06 | 1 | -2/+2 | |
| | | | | minor | |||||
* | remove checks for encodings availability | Sergey Nartimov | 2011-12-25 | 1 | -21/+19 | |
| | ||||||
* | Merge pull request #4007 from exviva/expand_cache_key_for_one_element_array | José Valim | 2011-12-16 | 1 | -7/+15 | |
|\ | | | | | Fix expanding cache key for single element arrays | |||||
| * | Fix expanding cache key for single element arrays | Olek Janiszewski | 2011-12-16 | 1 | -7/+15 | |
| | | | | | | | | | | | | | | | | | | In short: expand_cache_key(element) should not equal expand_cache_key([element]) This way a fragment cache key for an index page with only a single element in the collection is different than a fragment cache for a typical show page for that element. | |||||
* | | Add ActiveSupport::Cache::NullStore to expose caching interface without ↵ | Brian Durand | 2011-12-12 | 1 | -6/+64 | |
|/ | | | | actually caching for development and test environments. | |||||
* | Optimize cache expansion by skipping rails cache id in nested keys. | José Valim | 2011-11-23 | 1 | -4/+4 | |
| | ||||||
* | Fix #3737 AS::expand_cache_key generates wrong key in certain situations ↵ | Olek Janiszewski | 2011-11-23 | 1 | -2/+13 | |
| | | | | | | | (part 2) `nil` and `false` both expand to `""` (empty string), while `true` expands to `"true"`; `false` should expand to `"false"` | |||||
* | Fix #3737 AS::expand_cache_key generates wrong key in certain situations | Olek Janiszewski | 2011-11-23 | 1 | -2/+10 | |
| | | | | | `cache_key` method is never called when the argument is a 1-element array with something that responds to `cache_key` | |||||
* | tests predicates according to the boolean interpretation of their return ↵ | Xavier Noria | 2011-11-21 | 1 | -48/+48 | |
| | | | | | | value, not expecting specifically true or false Respecting Genuine assert_equal false Edition | |||||
* | Revert "tests predicates according to the boolean interpretation of their ↵ | Xavier Noria | 2011-11-21 | 1 | -49/+49 | |
| | | | | | | | | | return value, not expecting specifically true or false" Reason: there were some genuine tests for false when reading values, going to revise those ones. This reverts commit a539a5e3f3be68f027d3dfe43f88dc9f0642c743. | |||||
* | tests predicates according to the boolean interpretation of their return ↵ | Xavier Noria | 2011-11-21 | 1 | -49/+49 | |
| | | | | value, not expecting specifically true or false | |||||
* | cache entry: options[:compressed] is a regular flag, no need for !! | Xavier Noria | 2011-11-21 | 1 | -3/+3 | |
| | ||||||
* | Improved testing so that it tests the real functionality and not the private ↵ | Philippe Huibonhoa | 2011-10-02 | 1 | -4/+5 | |
| | | | | method. | |||||
* | Added fix so that file store does not raise an exception when cache dir does ↵ | Philippe Huibonhoa | 2011-09-29 | 1 | -0/+7 | |
| | | | | not exist yet. This can happen if a delete_matched is called before anything is saved in the cache. | |||||
* | Updated existing test that fails with this fix ↵ | Philippe Huibonhoa | 2011-09-21 | 1 | -1/+1 | |
| | | | | | (8d63678d1406c5518d437709af0fde717c0248d7). Before the fix the test was giving a false positive, because file_store.key_file_path would return an empty filename (i.e. test/tmp_cache/4D0/F4D rather than test/tmp_cache/4D0/F4D/xxxx…). Even though the fix referenced above divides the filename into directories to prevent it from being too long, it seems that 1000 characters will always raise an error, so reducing the key size to 900). | |||||
* | Fixed issue in file store where it could create a filename that was too long ↵ | Philippe Huibonhoa | 2011-09-21 | 1 | -0/+9 | |
| | | | | for the file system. (https://github.com/rails/rails/issues/3072) | |||||
* | Merge pull request #2393 from bdurand/fix_cache_read_multi | Santiago Pastorino | 2011-08-01 | 1 | -0/+8 | |
|\ | | | | | Fix ArgumentError in ActiveSupport::Cache::CacheStore.read_multi | |||||
| * | Pass options in ActiveSupport::Cache::CacheStore#read_multi through to the ↵ | Brian Durand | 2011-08-01 | 1 | -0/+8 | |
| | | | | | | | | delete_entry call. | |||||
* | | Change ActiveSupport::Cache behavior to always return duplicate objects ↵ | Brian Durand | 2011-07-29 | 1 | -7/+10 | |
|/ | | | | instead of frozen objects. |