aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/lib
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #11546 from swoop-inc/ss_memory_store_cache_sizePiotr Sarnacki2013-07-221-3/+14
|\ | | | | [Fixes #11512] improves cache size calculation in MemoryStore
| * [Fixes #11512] improves cache size calculation in ↵Simeon Simeonov2013-07-221-3/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveSupport::Cache::MemoryStore Previously, the cache size of `ActiveSupport::Cache::MemoryStore` was calculated as the sum of the size of its entries, ignoring the size of keys and any data structure overhead. This could lead to the calculated cache size sometimes being 10-100x smaller than the memory used, e.g., in the case of small values. The size of a key/entry pair is now calculated via `#cached_size`: def cached_size(key, entry) key.to_s.bytesize + entry.size + PER_ENTRY_OVERHEAD end The value of `PER_ENTRY_OVERHEAD` is 240 bytes based on an [empirical estimation](https://gist.github.com/ssimeonov/6047200) for 64-bit MRI on 1.9.3 and 2.0. Fixes GH#11512 https://github.com/rails/rails/issues/11512
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2013-07-214-17/+16
|\ \ | |/ |/|
| * Merge branch 'master' of github.com:rails/docrailsThiago Pinto2013-07-163-17/+11
| |\
| | * Array#to_formatted_s does not call each element's to_s anymoreAkira Matsuda2013-07-111-17/+2
| | | | | | | | | | | | Array#to_s calls each element's inspect since ruby 1.9
| | * Add documentation for FileStore#increment and #decrementMatt Stopa2013-07-101-0/+4
| | | | | | | | | | | | [ci skip]
| | * Add documentation for #clear on certain Store classesMatt Stopa2013-07-102-0/+2
| | | | | | | | | | | | [ci skip
| | * Update the filestore documentation for clearMatt Stopa2013-07-091-0/+3
| | | | | | | | | | | | [ci skip]
| * | Enhancing readability of options for delegate methodThiago Pinto2013-07-161-0/+5
| |/
* | Fix examples of number_to_percentageRafael Mendonça França2013-07-181-8/+8
| | | | | | | | [ci skip]
* | Add missing requireAkira Matsuda2013-07-111-0/+1
| |
* | Only raise DelegationError if it's is the source of the exceptionAndrew White2013-07-111-10/+11
| | | | | | | | | | | | | | | | | | This fixes situations where nested NoMethodError exceptions are masked by delegations. This would cause confusion especially where there was a problem in the Rails booting process because of a delegation in the routes reloading code. Fixes #10559
* | Add missing require so that DateTime has the right superclassAndrew White2013-07-101-0/+1
| | | | | | | | | | | | | | | | If the DateTime core extensions were loaded before the Date core extensions then you would get a superclass mismatch as DateTime hasn't been defined yet so it gets set to Object by the acts_like core extension. Fixes #11206
* | Better not mutate the given options HashAkira Matsuda2013-07-101-3/+3
| |
* | Simplify Array#in_groups_of codeAkira Matsuda2013-07-101-3/+1
| |
* | Speed up Array#splitAkira Matsuda2013-07-101-6/+20
| | | | | | | | | | | | | | Benchmark: user system total real old 0.510000 0.000000 0.510000 ( 0.506749) new 0.330000 0.000000 0.330000 ( 0.336187)
* | Speed up String#truncateAkira Matsuda2013-07-101-1/+1
| | | | | | | | | | | | | | Benchmark: user system total real old 1.550000 0.040000 1.590000 ( 1.585866) new 1.250000 0.040000 1.290000 ( 1.287693)
* | Speed up AS::Inflector.underscoreAkira Matsuda2013-07-101-2/+1
| | | | | | | | | | | | | | Benchmark: user system total real old 6.090000 0.120000 6.210000 ( 6.202039) new 5.930000 0.110000 6.040000 ( 6.042022)
* | Speedup AS::Inflector.camelizeAkira Matsuda2013-07-101-1/+3
| | | | | | | | | | | | | | Benchmark: user system total real old 5.960000 0.020000 5.980000 ( 5.981754) new 5.740000 0.030000 5.770000 ( 5.757201)
* | Speedup AS::Inflector.deconstantizeAkira Matsuda2013-07-101-1/+1
| | | | | | | | | | | | | | Benchmark: user system total real old 0.740000 0.000000 0.740000 ( 0.744358) new 0.550000 0.000000 0.550000 ( 0.553690)
* | Speedup String#toAkira Matsuda2013-07-101-1/+1
| | | | | | | | | | | | | | | | Benchmark: 1000000.times { str.to(30) } user system total real old 0.490000 0.110000 0.600000 ( 0.607374) new 0.390000 0.000000 0.390000 ( 0.387306)
* | Return local time for backwards compatibilityAndrew White2013-07-091-1/+1
| |
* | Retain UTC offset when using Time.at_with_coercionAndrew White2013-07-091-3/+8
| | | | | | | | | | | | | | | | | | | | The standard Ruby behavior for Time.at is to return the same type of time when passing an instance of Time as a single argument. Since the an ActiveSupport::TimeWithZone instance may be a different timezone than the system timezone and DateTime just understands offsets the best we can do is to return an instance of Time with the correct offset. Fixes #11350.
* | Fix microsecond precision of Time#at_with_coercionNeer Friedman2013-07-091-1/+1
| | | | | | | | | | | | | | | | When Time.at_with_coercion (wraps Time.at) is called with a single argument that "acts_like?(:time)" it is coerced to integer thus losing it's microsecond percision. This commits changes this to use `#to_f` to prevent the problem
* | cache.exists? should return true/falseJade Tucker2013-07-071-1/+1
| |
* | Make HashWithIndifferentAccess#select always return the hash.Marc Schütz2013-07-061-1/+1
|/ | | | | Hash#select! returns nil if the hash didn't change and thus behaves differently from select, so it's return value can't be used as result for the latter.
* Adding back deprecation require in all.rbRashmi Yadav2013-07-051-0/+1
|
* Revert "remove string based terminators for `ActiveSupport::Callbacks`."Yves Senn2013-07-051-0/+6
| | | | | | | | This reverts commit d108672dada7ba97d3b3b56f0c6001cea621061e. Conflicts: activesupport/CHANGELOG.md
* remove string based terminators for `ActiveSupport::Callbacks`.Yves Senn2013-07-051-6/+0
|
* Removed unsued deprecation requireRashmi Yadav2013-07-042-2/+0
|
* method transplanting between modules isn't supported on 1.9Aaron Patterson2013-07-031-0/+11
|
* Remove deprecated `String#encoding_aware?` Arun Agrawal2013-07-031-8/+0
| | | core extensions (`core_ext/string/encoding`).
* Remove deprecated `Module#local_constant_names` Arun Agrawal2013-07-031-16/+0
| | | in favor of `Module#local_constants`
* Remove deprecated `DateTime.local_offset`Arun Agrawal2013-07-031-7/+0
|
* Remove deprecated Logger core extensions (core_ext/logger.rb)Carlos Antonio da Silva2013-07-032-68/+0
|
* Remove deprecated `Time#time_with_datetime_fallback`, `Time#utc_time`Vipul A M2013-07-031-35/+0
| | | | and `Time#local_time` in favour of `Time#utc` and `Time#local`
* Remove deprecated Hash#diff with no replacement.Carlos Antonio da Silva2013-07-022-17/+0
| | | | | If you're using it to compare hashes for the purpose of testing, please use MiniTest's assert_equal instead.
* Merge pull request #10909 from dockyard/masterCarlos Antonio da Silva2013-07-021-6/+6
|\ | | | | Use symbols instead of strings in ActiveSupport::Concern
| * Use symbols instead of stringsBrian Cardarella2013-06-101-6/+6
| | | | | | | | | | | | | | | | | | | | ActiveSupport::Concern is used all over Rails This PR will only create 3 new objects as keys are never recreated and are not subject to garbage collection. The strings were being uniquely created and garbage collected. I don't have any performance numbers but this should be better than all of the GC.
* | Remove deprecated `Date#to_time_in_current_zone`Vipul A M2013-07-021-15/+0
| |
* | Remove deprecated `Proc#bind` with no replacement.Carlos Antonio da Silva2013-07-012-18/+0
| |
* | Remove deprecated Array#uniq_by and Array#uniq_by!Carlos Antonio da Silva2013-07-012-20/+0
| | | | | | | | Use native Array#uniq and Array#uniq! instead.
* | Remove deprecated AS::BasicObject, use AS::ProxyObject insteadCarlos Antonio da Silva2013-07-012-12/+0
| |
* | Add missing requireCarlos Antonio da Silva2013-07-011-0/+1
| | | | | | | | | | | | Commit cfa35c55bb38b27af305ad21408e181bc3cd739e removed the buffered_logger from AS, which required the logger file. Now we need to add the proper require here.
* | remove deprecated `BufferedLogger`.Yves Senn2013-07-012-22/+0
| |
* | remove deprecated `assert_present` and `assert_blank`.Yves Senn2013-07-011-30/+0
| |
* | Further clean-up of ActiveSupport::CallbacksGenadi Samokovarov2013-07-011-10/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In #11195 I noticed a trailing comma in the docs, but I decided to further clean it up. What I have done: * Clean up the trailing comma in the docs and some extra whitespace lines. * Used `Array#extract` options to factor the repetitive pattern of `args.last.is_a(Hash) ? ...` * Renamed the local var `config` to `options` in `define_callbacks`, as `options` seems to be the de facto name for the options objects. * Renamed the local var `l` to `line` in `define_callback` (maybe it meant `lambda` in the context) as single `l` may look like `1` in some fonts.
* | unified the param names across all callbacks manipulation methodsSteven Yang2013-07-011-10/+10
| | | | | | | | | | | | | | _ Rename the define_callbacks params to `names` - in order to match the naming conventions for `get_callbacks` and `set_callbacks` at https://github.com/rails/rails/blob/master/activesupport/lib/active_support/callbacks.rb#L736-743 - `define_callbacks` just register names(events), not define the real callback functions. - Rename the `reset_callbacks` params
* | updated AS:Callbacks doc for terminator option in define_callbacks methodSteven Yang2013-06-301-3/+4
| | | | | | | | The change is commited at ba552764344bc0a3c25b8576ec11f127ceaa16da
* | fix grammar, change 'an' to 'a' [ci skip]Prathamesh Sonpatki2013-06-271-3/+3
| |