aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/lib
Commit message (Collapse)AuthorAgeFilesLines
* Delegation method bugLi Ellis Gallardo2013-04-251-0/+14
| | | | | | Add documentation and test to delegation method that make sure we're aware that when a delegated object is not nil or false and doesn't respond to the method it will still raise a NoMethodError exception.
* refactor number helperVipul A M2013-04-251-2/+3
|
* Merge pull request #10318 from vipulnsward/refactor_obviousGuillermo Iguaran2013-04-231-4/+1
|\ | | | | refactor initialization of array
| * refactor initialization of arrayVipul A M2013-04-231-4/+1
| |
* | Adjust for daylight savings in String#to_timeAndrew White2013-04-231-8/+6
|/ | | | | | | | | | | | | | | The changes in b79adc4323 had a bug where if the time in the String was in standard time but the current time was in daylight savings then the calculated adjustment was off by an hour. This commit fixes this and adds extra tests for the following: * time in string is standard time, current time is standard time * time in string is standard time, current time is daylight savings * time in string is daylight savings, current time is standard time * time in string is daylight savings, current time is daylight savings Fixes #10306.
* remove redundant variableVipul A M2013-04-221-2/+0
|
* Created a registry based on the +PerThreadRegistry+ module forwangjohn2013-04-221-2/+20
| | | | subscriber queues. Helps limit the number of thread locals.
* Merge pull request #10096 from benofsky/fix_skipping_object_callback_filtersRafael Mendonça França2013-04-211-2/+23
|\ | | | | Fixes skipping object callback filters
| * Fixes skipping object callback filtersBen McRedmond2013-04-041-2/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows you to skip callbacks that are defined by objects, e.g. for `ActionController`: skip_after_filter MySpecialFilter Previously this didn't work due to a bug in how Rails compared callbacks in `Callback#matches?`. When a callback is compiled, if it's an object filter (i.e. not a method, proc, etc.), `Callback` now defines a method on `@klass` that is derived from the class name rather than `@callback_id`. So, when `skip_callback` tries to find the appropriate callback to remove, `Callback` can regenerate the method name for the filter object and return the correct value for `Callback#matches?`.
* | extract array to a constantVipul A M2013-04-221-1/+3
| |
* | symbolize_keys => symbolize_keys! on new hash;Vipul A M2013-04-191-1/+1
| | | | | | | | "There're" => There are for better readability
* | Merge pull request #10235 from joergleis/patch-1Michael Koziarski2013-04-181-5/+4
|\ \ | | | | | | Reorganize MessageEncryptor
| * | Reorganize MessageEncryptorjgls2013-04-191-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | 1) According to OpenSSL's documentation, cipher.random_iv must be called after cipher.encrypt and already sets the generated IV on the cipher. 2) OpenSSL::CipherError was moved to OpenSSL::Cipher::CipherError in Ruby 1.8.7. Since Rails 4 requires at least Ruby 1.9.3, support for the old location can be dropped.
* | | The increment and decrement commands in the local cache are exactly thewangjohn2013-04-171-18/+14
| | | | | | | | | | | | same, so their logic is being refactored.
* | | Refactored the storage of a temporary version of the local cache intowangjohn2013-04-171-8/+6
| | | | | | | | | | | | its own method.
* | | Add nodoc to LocalCacheRegistryRafael Mendonça França2013-04-171-1/+1
| | | | | | | | | [ci skip]
* | | Adding a local thread registry to store local caches.wangjohn2013-04-171-15/+32
| | |
* | | more descriptive NameError's messages for class attributesHrvoje Šimić2013-04-171-2/+2
| | |
* | | switch (and lazily convert) ivar names to 3.xSam Ruby2013-04-161-36/+36
| | |
* | | Copy-edits in the ActiveSupport::Subscriber documentation.Rafael Mendonça França2013-04-161-6/+5
| | | | | | | | | | | | | | | | | | Thank you @fxn :green_heart::yellow_heart::heart::purple_heart::blue_heart: [ci skip]
* | | Merge pull request #10218 from dasch/dasch/extract-subscriber-classRafael Mendonça França2013-04-162-43/+83
|\ \ \ | |/ / |/| | Extract a Subscriber base class from LogSubscriber
| * | Extract a base class from ActiveSupport::LogSubscriberDaniel Schierbeck2013-04-162-43/+83
| | | | | | | | | | | | | | | | | | Adds a ActiveSupport::Subscriber base class that LogSubscriber inherits from. By inheriting from Subscriber, other kinds of subscribers can take advantage of the event attachment system.
* | | The third argument of deprecation_warning is always optionalRafael Mendonça França2013-04-161-1/+1
| | | | | | | | | [ci skip]
* | | Fix documentation to the custom DeprecatorRafael Mendonça França2013-04-161-1/+1
| | | | | | | | | [ci skip]
* | | interpolate instead of string concatVipul A M2013-04-151-1/+1
|/ /
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-04-131-1/+1
|\ \
| * | Corrected paramter to parameterCarson McDonald2013-04-131-1/+1
| | |
* | | use define_singleton_method instead of class_evalFrancesco Rodriguez2013-04-131-4/+2
| | |
* | | Add :nodoc: mark to PerThreadRegistry#method_missing [ci skip]Francesco Rodriguez2013-04-131-1/+1
| | |
* | | hides the per thread registry instance, and caches singleton methodsXavier Noria2013-04-132-23/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Existing code was delegating to the instance with delegate macro calls, or invoking the instance method to reach the object and call its instance methods. But the point is to have a clean class-level interface where the thread local instance is hidden in the implementation. References #11c6973. References #10198.
* | | complete rewrite of the documentation of AS::PerThreadRegistryXavier Noria2013-04-131-21/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * It focuses on how to use it. * Removes some ambigueties in the original docs about whether the state is stored in the class. * Documents it provides class-level accessors via method_missing. * Documents that if the extended class has an initializer, it must accept no arguments.
* | | Add Chatham Islands Time (UTC+1245) support.Hiro Asari2013-04-121-1/+2
|/ / | | | | | | Also update the documentation on the number of supported time zones.
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-04-113-5/+14
|\ \ | | | | | | | | | | | | Conflicts: guides/source/action_mailer_basics.md
| * | fix Array#uniq_by! docs [ci skip]Francesco Rodriguez2013-04-041-2/+2
| | |
| * | add documentation to Benchmark#ms [ci skip]Francesco Rodriguez2013-04-041-0/+7
| | |
| * | fix broken format in Array#to_sentence [ci skip]Francesco Rodriguez2013-04-041-3/+5
| | |
* | | Revert "Merge pull request #10158 from steveklabnik/issue_10125"Rafael Mendonça França2013-04-101-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit fa3ef8e82ab2f96cf15ef9bc885b2468fad77621, reversing changes made to e0af93dd3a5eeee2e2a67b05f34afb66cc80c00b. Reason: Routes, Active Record and the rendering stack should not depend on the default locale
* | | Using public send instead of send for the PerThreadRegistry module.wangjohn2013-04-101-1/+1
| | | | | | | | | | | | Prevents you from accidentally calling a protected method.
* | | Merge pull request #10158 from steveklabnik/issue_10125Steve Klabnik2013-04-091-2/+2
|\ \ \ | | | | | | | | Fix inflector to respect default locale.
| * | | Fix inflector to respect default locale.Nick Cox2013-04-101-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The inflector was made aware of locales in 7db0b073fec6bc3e6f213b58c76e7f43fcc2ab97, but it defaulted to :en. That should actually be our default locale instead. Fixes #10125
* | | | Changed the ScopeRegistry and the InstrumentationRegistry to use thewangjohn2013-04-091-5/+4
| | | | | | | | | | | | | | | | PerThreadRegistry module.
* | | | Creating a module so that per thread registries can be easily created aswangjohn2013-04-091-0/+41
|/ / / | | | | | | | | | thread local variables.
* | | Creating an object to consolidate thread locals which hold thewangjohn2013-04-081-1/+27
| | | | | | | | | | | | instrumenters for the AS::Notifications module.
* | | Add option to Class#class_attribute for skipping the query methodAgis-2013-04-061-3/+5
| | |
* | | `fast_xs` support has been removed. Use 'String#encode(xml: :attr)`.Aaron Patterson2013-04-052-19/+0
| | |
* | | Revert "Merge pull request #10034 from ↵Rafael Mendonça França2013-04-041-13/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | benofsky/fix_skipping_object_callback_filters" This reverts commit c79c6980647eb76bfa52178711fb04ba7e9d403b, reversing changes made to ba4c27479add60b783a0e623c8a5d176c1dc9043. This broke all the tests. See https://travis-ci.org/rails/rails/builds/6061839
* | | Merge pull request #10034 from benofsky/fix_skipping_object_callback_filtersRafael Mendonça França2013-04-041-1/+13
|\ \ \ | | | | | | | | Fixes skipping object callback filters
| * | | Fixes skipping object callback filtersBen McRedmond2013-04-041-1/+13
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows you to skip callbacks that are defined by objects, e.g. for `ActionController`: skip_after_filter MySpecialFilter Previously this didn't work due to a bug in how Rails compared callbacks in `Callback#matches?`. When a callback is compiled, if it's an object filter (i.e. not a method, proc, etc.), `Callback` now defines a method on `@klass` that is derived from the class name rather than `@callback_id`. So, when `skip_callback` tries to find the appropriate callback to remove, `Callback` can regenerate the method name for the filter object and return the correct value for `Callback#matches?`.
* | | Merge pull request #10080 from vipulnsward/railties_warning_fix_v2Steve Klabnik2013-04-031-0/+1
|\ \ \ | | | | | | | | add require to suppress warning; remove variable
| * | | add require to suppress warning; remove variableVipul A M2013-04-041-0/+1
| | | |