aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/lib
Commit message (Collapse)AuthorAgeFilesLines
* Further clean-up of ActiveSupport::CallbacksGenadi Samokovarov2013-07-011-10/+9
| | | | | | | | | | | | | | | | | In #11195 I noticed a trailing comma in the docs, but I decided to further clean it up. What I have done: * Clean up the trailing comma in the docs and some extra whitespace lines. * Used `Array#extract` options to factor the repetitive pattern of `args.last.is_a(Hash) ? ...` * Renamed the local var `config` to `options` in `define_callbacks`, as `options` seems to be the de facto name for the options objects. * Renamed the local var `l` to `line` in `define_callback` (maybe it meant `lambda` in the context) as single `l` may look like `1` in some fonts.
* unified the param names across all callbacks manipulation methodsSteven Yang2013-07-011-10/+10
| | | | | | | _ Rename the define_callbacks params to `names` - in order to match the naming conventions for `get_callbacks` and `set_callbacks` at https://github.com/rails/rails/blob/master/activesupport/lib/active_support/callbacks.rb#L736-743 - `define_callbacks` just register names(events), not define the real callback functions. - Rename the `reset_callbacks` params
* updated AS:Callbacks doc for terminator option in define_callbacks methodSteven Yang2013-06-301-3/+4
| | | | The change is commited at ba552764344bc0a3c25b8576ec11f127ceaa16da
* fix grammar, change 'an' to 'a' [ci skip]Prathamesh Sonpatki2013-06-271-3/+3
|
* Move delegation error constant to inside ModuleCarlos Antonio da Silva2013-06-261-2/+4
|
* Merge pull request #10828 from southpolesteve/delegation_error_classYves Senn2013-06-261-1/+3
|\ | | | | Create DelegationError class
| * Add DelegationError class. Rasied by delegation to a nil objectSteve Faulkner2013-06-261-1/+3
| |
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-06-261-1/+0
|\ \ | | | | | | | | | | | | Conflicts: guides/source/layout.html.erb
| * | Remove a comment related to 920753fRobin Dupret2013-06-261-1/+0
| | | | | | | | | Since 920753f, double assignment isn't used anymore
* | | Merge pull request #10542 from waseem/remove_requireCarlos Antonio da Silva2013-06-251-1/+0
|\ \ \ | | | | | | | | Remove unnecessary require from active_support/inflector/methods.rb
| * | | Remove unnecessary require from active_support/inflector/methods.rbWaseem Ahmad2013-05-101-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | `active_support/inflections` already requires `active_support/inflector/inflections`. There's no need to require it in `active_support/inflector/methods`.
* | | | Merge pull request #10627 from vipulnsward/destructive_symbolizeCarlos Antonio da Silva2013-06-251-1/+1
|\ \ \ \ | | | | | | | | | | Change to destructive `deep_symbolize_keys` to avoid a new hash creation.
| * | | | change to destructive `deep_symbolize_keys` after ↵Vipul A M2013-05-151-1/+1
| | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails/commit/df24b8790f22384a068fece7042f04ffd2fcb33e which allows to do so. This helps to avoid extra hash object creation, by symbolizing inplace
* | | | | Fix BacktraceCleaner#noise for multiple silencers.Mark J. Titorenko2013-06-201-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous implementation of BacktraceSilencer#noise did not work correctly if more than one silencer was configured -- specifically, it would only return noise which was matched by all silencers. The new implementation is such that anything that has been matched by silencers is removed from the backtrace using Array#- (array difference), ie. we now return all elements within a backtrace that have been matched by any silencer (and are thus removed by #silence). Fixes #11030.
* | | | | add documentation for `ActiveSupport::Testing::SetupAndTeardown`.Yves Senn2013-06-191-2/+17
| | | | |
* | | | | better documentation for `AS::Testing::Declarative#test`. [ci skip]Yves Senn2013-06-191-3/+6
| | | | |
* | | | | we only support 1.9+, so just check for a nameAaron Patterson2013-06-171-1/+1
| | | | |
* | | | | be consistent about parameter types passed to new_constants_inAaron Patterson2013-06-171-1/+1
| | | | |
* | | | | Updated the doc for const_regexp [ci skip]Arun Agrawal2013-06-151-1/+3
| | | | |
* | | | | Merge pull request #10946 from arunagw/build_fix_for_object_const_get_nilXavier Noria2013-06-141-0/+3
|\ \ \ \ \ | | | | | | | | | | | | We need to check exception name to be nil
| * | | | | Changing const_regexp to check for constant name.Arun Agrawal2013-06-151-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | We need to return Regexp.escape(camel_cased_word) if the split is blank.
* | | | | | Merge pull request #10740 from mrsimo/hash-with-indifferent-access-selectRafael Mendonça França2013-06-141-0/+4
|\ \ \ \ \ \ | |/ / / / / |/| | | | | HashWithIndifferentAccess#select working as intended
| * | | | | HashWithIndifferentAccess#select working as intendedAlbert Llop2013-05-231-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this commit, #reject returned a HashWithIndifferentAccess, whereas #select returned a Hash. Now #select also returns a HashWithIndifferentAccess.
* | | | | | Merge pull request #10943 from killthekitten/10932_constantize_emptyXavier Noria2013-06-141-1/+6
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | Fix #10932. Treat "" and "::" as invalid on constantize
| * | | | | Fix #10932. Treat "" and "::" as invalid on constantizeNikolay Shebanov2013-06-141-1/+6
| | | | | |
* | | | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-06-143-8/+8
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md
| * | | | | | minor doc changes to `ActiveSupport::BacktraceCleaner`.Yves Senn2013-06-121-5/+5
| | | | | | |
| * | | | | | correction on cache.fetch race_condition_ttldickeyxxx2013-05-231-1/+1
| | | | | | |
| * | | | | | Documentation: Notifications queue does not run in a thread.David Butler2013-05-201-2/+2
| | | | | | |
* | | | | | | Keep sub-second resolution when wrapping a DateTime valueAndrew White2013-06-132-5/+11
| |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add `DateTime#usec` and `DateTime#nsec` so that `ActiveSupport::TimeWithZone` keeps sub-second resolution when wrapping a `DateTime` value. Fixes #10855
* | | | | | remove some evals from callback conditionalsAaron Patterson2013-06-111-0/+10
| | | | | |
* | | | | | Merge pull request #10897 from prathamesh-sonpatki/active-support-typosCarlos Antonio da Silva2013-06-101-3/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fixed typos in activesupport [ci skip]
| * | | | | | Fixed typos in activesupport [ci skip]Prathamesh Sonpatki2013-06-091-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - eval'ed to eval'd in accordance with https://github.com/rails/rails/pull/10889 - tried to improve statement about compiling Procs into methods using define_method
* | | | | | | Don't blindly call blame_file! on exceptions in ↵Andrew Kreiling2013-06-091-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveSupport::Dependencies::Loadable It is possible under some environments to receive an Exception that is not extended with Blamable (e.g. JRuby). ActiveSupport::Dependencies::Loadable#load_dependency blindly call blame_file! on the exception which throws it's own NoMethodError exception and hides the original Exception. This commit fixes #9521
* | | | | | Override Time.at to work with Time-like valuesAndrew White2013-06-081-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Time.at allows passing a single Time argument which is then converted to an integer. The conversion code since 1.9.3r429 explicitly checks for an instance of Time so we need to override it to allow DateTime and ActiveSupport::TimeWithZone values.
* | | | | | Fix some typosVipul A M2013-06-072-2/+2
| | | | | |
* | | | | | Merge pull request #10784 from senny/10526_prevent_key_transformationRafael Mendonça França2013-06-031-6/+12
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | Prevent side effects in `Hash#with_indifferent_access`.
| * | | | | Prevent side effects in `Hash#with_indifferent_access`.Yves Senn2013-05-291-6/+12
| | | | | |
* | | | | | The behavior we had in place in rc1 was actually to convert to DateTime and ↵David Heinemeier Hansson2013-06-031-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | use <=> from there. Restore that.
* | | | | | Allow Date to be compared with Time (like it was possible to compare Time ↵David Heinemeier Hansson2013-06-031-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | with Date)
* | | | | | Remove active_support/testing/pending.rb was deprecated.kennyj2013-06-012-16/+0
| | | | | |
* | | | | | Remove ActiveSupport::Benchmarkable#silence was deprecated.kennyj2013-06-011-10/+0
| | | | | |
* | | | | | Remove active_support/json/variable was deprecated.kennyj2013-06-012-19/+0
|/ / / / /
* | / / / compatability => compatibilityVipul A M2013-05-261-3/+3
| |/ / / |/| | |
* | | | Require only minitest.Rafael Mendonça França2013-05-221-1/+1
| | | | | | | | | | | | | | | | | | | | minitest/autorun required minitest/spec and we are avoiding to require it.
* | | | Merge pull request #10667 from rubys/minitest-autorunRafael Mendonça França2013-05-221-1/+1
|\ \ \ \ | | | | | | | | | | Eliminate minitest warnings
| * | | | Eliminate minitest warningsSam Ruby2013-05-171-1/+1
| | | | | | | | | | | | | | | | | | | | https://github.com/seattlerb/minitest/commit/9a57c520ceac76abfe6105866f8548a94eb357b6#L15R8
* | | | | Merge pull request #10659 from vipulnsward/normalize_param2Rafael Mendonça França2013-05-191-3/+3
|\ \ \ \ \ | |_|/ / / |/| | | | "normalize_callback_params" doesn't require name param
| * | | | "normalize_callback_params" doesn't require name paramVipul A M2013-05-171-3/+3
| |/ / /
* / / / Bug fix: Evented notification subscribers can handle published eventsCarl Lerche2013-05-171-0/+7
|/ / /