aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/lib
Commit message (Collapse)AuthorAgeFilesLines
* fixed spelling in the attribute_accessors docuTorsten Braun2016-03-231-1/+1
| | | mattr_writer to mattr_reader
* fixed spellin in the mattr_reader documentationTorsten Braun2016-03-231-1/+1
| | | renamed cattr_reader to mattr_reader
* Improve code readability in ActiveSupport::DependenciesAaron Ang2016-03-161-5/+6
|
* Add comments to ActiveSupport::Dependencies to help understandingAaron Ang2016-03-161-0/+2
| | | | | | | | In a previous patch, all log-related stuff was removed. However, some logs are still useful to understand the code. Therefore, in this patch, I put those log messages back as comments. [ci skip]
* no need to clear an unusued collectionXavier Noria2016-03-161-1/+1
| | | | | | | | | | If the code reaches that line new_constants is no longer needed. We only need here to iterate over it to discard stuff and done. Note that constant_watch_stack.new_constants returns a new reference each time it is invoked, so that #clear call was not cleaning state in some internal structure (which would have been a bit dirty as well at this level of coupling).
* removes unreachable codeXavier Noria2016-03-161-2/+0
| | | | | | | | | | | | This array literal cannot be reached. The previous begin either returns to the caller via the explicit return in the ensure block if all goes well, or else propagates whatever make the begin block abort execution. I have investigated the origin of this a bit. In the past the ensure block didn't have a return call, see for example c08547d. Later on the return was added in 4da4506, but the trailing literal was left there.
* Remove log-related stuff from ActiveSupport::DependenciesAaron Ang2016-03-151-44/+0
| | | | | In this patch, all log-related stuff in `ActiveSupport::Dependencies` is removed because the logging is no longer useful.
* Use the most highest priority exception handler when cause is setSean Griffin2016-03-111-0/+10
| | | | | | | | | | | | There was some subtle breakage caused by #18774, when we removed `#original_exception` in favor of `#cause`. However, `#cause` is automatically set by Ruby when raising an exception from a rescue block. With this change, we will use whichever handler has the highest priority (whichever call to `rescue_from` came last). In cases where the outer has lower precidence than the cause, but the outer is what should be handled, cause will need to be explicitly unset. Fixes #23925
* Merge pull request #24150 from exviva/unmarshal-infinite-retryXavier Noria2016-03-111-1/+4
|\ | | | | Prevent `Marshal.load` from looping infinitely
| * Prevent `Marshal.load` from looping infinitelyOlek Janiszewski2016-03-111-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | Fix a bug in `Marshal.load` that caused it to loop indefinitely when trying to autoload a constant that resolved to a different name. This could occur when marshalling an ActiveRecord 4.0 object (e.g. into memcached) and then trying to unmarshal it with Rails 4.2. The marshalled payload contains a reference to `ActiveRecord::ConnectionAdapters::Mysql2Adapter::Column`, which in Rails 4.2 resolves to `ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter::Column`.
* | Merge pull request #24143 from perceptec/fix-thread-mattr-accessor-refsMatthew Draper2016-03-121-2/+2
|\ \ | | | | | | Fix `thread_mattr_accessor` thread-local variable naming
| * | Fix `thread_mattr_accessor` thread-local variable namingMichael Ryan2016-03-111-2/+2
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current implentation of `thread_mattr_accessor` is setting differently-named thread variables when defining class and instance writer methods, so the method isn't working as documented: Account.user = "DHH" Account.user # => "DHH" Account.new.user # => nil a = Account.new a.user = "ABC" # => "ABC" a.class.user # => "DHH" At this point `:attr_Account_user` and `:attr_Class_user` thread-local variables have been created. Modify the reader and writer methods to use the class name instead of 'Class'.
* / use `ActiveSupport::Reloader.to_prepare` instead of deprecated ↵yuuji.yaginuma2016-03-111-1/+1
|/ | | | `ActionDispatch::Reloader.to_prepare` [ci skip]
* Add missing require to tryRafael Mendonça França2016-03-111-0/+2
|
* Remove unused try requireBart de Water2016-03-101-1/+0
|
* friendly error message if missing listenJerry Cheung2016-03-081-1/+7
|
* Prevent nested ExecutionWrapper calls even when using run! directlyMatthew Draper2016-03-042-9/+16
|
* Fix `ActiveSupport::Reloader.check!`Ryuta Kamizono2016-03-021-4/+3
| | | | | The test failure in `bug_report_templates/action_controller_master.rb` is due to `app.reloader.check` is `nil`.
* Merge pull request #23936 from yui-knk/local_constants_to_be_publicRafael Mendonça França2016-03-012-2/+6
|\ | | | | | | Deprecate `Module.local_constants`
| * Deprecate `Module.local_constants`yui-knk2016-03-012-2/+6
| | | | | | | | | | After Ruby 1.9, we can easily get the constants that have been defined locally by `Module.constants(false)`.
* | Publish AS::Executor and AS::Reloader APIsMatthew Draper2016-03-028-10/+214
|/ | | | | | These should allow external code to run blocks of user code to do "work", at a similar unit size to a web request, without needing to get intimate with ActionDipatch.
* Prep release for Rails 5 beta3eileencodes2016-02-241-1/+1
|
* :bomb: run the test @rafaelfranca :angry:Rafael Mendonça França2016-02-241-1/+1
|
* Make internal class as nodocRafael Mendonça França2016-02-241-2/+2
| | | | Also use the new hash syntax.
* Merge pull request #23616 from piotrj/issue_23609_logger_broadcast_silencingRafael Mendonça França2016-02-243-21/+42
|\ | | | | | | Fix logger silencing for broadcasted loggers
| * Fix logger silencing for broadcasted loggersPiotr Jakubowski2016-02-113-21/+42
| | | | | | | | | | | | | | | | | | | | | | Fix #23609 Commit 629efb6 introduced thread safety to logger silencing but it didn't take into account the fact that the logger can be extended with broadcasting to other logger. This commit introduces local_level to broadcasting Module which enables broadcasted loggers to be properly silenced.
* | Ignore callstacks from Ruby stdlib in deprecationRafael Mendonça França2016-02-241-4/+12
| | | | | | | | Fixes #22982.
* | Fix `assert_nothing_raised` deprecation warning formatRyuta Kamizono2016-02-241-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before: ``` DEPRECATION WARNING: Passing arguments to assert_nothing_raised is deprecated and will be removed in Rails 5.1. ``` After: ``` DEPRECATION WARNING: Passing arguments to assert_nothing_raised is deprecated and will be removed in Rails 5.1. ```
* | add deprecation warning to assert_nothing_raised and changelog entryTara Scherner de la Fuente2016-02-221-1/+5
| |
* | remove args from assert_nothing_raised in testsTara Scherner de la Fuente2016-02-221-1/+1
| |
* | Merge pull request #23785 from eval/correct-types-examplesVipul A M2016-02-222-108/+108
|\ \ | | | | | | Show correct return types for examples
| * | Show correct return types for examples [ci skip]Gert Goet2016-02-202-108/+108
| | |
* | | Merge pull request #23695 from kaspth/remove-automatic-collection-cachingKasper Timm Hansen2016-02-202-32/+17
|\ \ \ | | | | | | | | Make collection caching explicit.
| * | | Revert "Instrument read_multi".Kasper Timm Hansen2016-02-202-32/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reevaluating the log output generated from this instrumentation, we've found that it wasn't all that useful in practice. ``` Caches multi read: - views/david/2/4184ab71db6849621a4d8820fcd2c0ad - views/david/2/4184ab71db6849621a4d8820fcd2c0ad - views/david/3/4184ab71db6849621a4d8820fcd2c0ad - views/david/3/4184ab71db6849621a4d8820fcd2c0ad ``` If rendering many templates the output is inscrutable, and it's impossible to see how many cache misses there were. Revert ca6aba7f30 and implement a better way later.
* | | | Make benchmark('something', silence: true) actually workDavid Heinemeier Hansson2016-02-201-1/+1
| |/ / |/| |
* | | Dependencies clean upSruli Rapps2016-02-191-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cleans up four items I came across in ActiveSupport::Dependencies: - DependenciesTest# test_dependency_which_raises_exception_isnt_added_to_loaded_set: Fixes current implementation which will pass no matter what since the filepath is never added to "loaded" or "history" without being expanded first. - Remove DependenciesTest#test_unhook. Seems leftover from when alias_method_chain was used in Loadable and ModuleConstMissing. The test will always pass since Module never responds to those methods - WatchStack#new_constants documentation: update self to @stack. Looks like self was leftover from when WatchStack inherited from Hash - Remove ActiveSupport namespace from call to Dependencies.constant_watch_stack.watching? since the namespace is not needed, Dependencies is called two other times in the same method without it (even on the same line) and it brings the line to within 80 characters
* | | better docs for ActiveSupport::TestCase#assert_nothing_raisedTara Scherner de la Fuente2016-02-181-2/+5
|/ /
* | Missing documentation about hash algorithm option for MessageVerifier [ci skip]Mehmet Emin İNAÇ2016-02-181-0/+6
| |
* | Add `#on_weekday?` method to `Date`, `Time`, and `DateTime`.Vipul A M2016-02-151-0/+5
| |
* | Merge pull request #23596 from afn/issue-23058Aaron Patterson2016-02-101-1/+1
|\ \ | | | | | | Converting backtrace to strings before calling set_backtrace
| * | Converting backtrace to strings before calling set_backtraceTony Novak2016-02-101-1/+1
| | | | | | | | | | | | Fixes #23058
* | | rename to 'second_to_last' and 'third_to_last'Brian Christian2016-02-101-4/+4
| | |
* | | allow Array.penultimate and Array.antepenultiate access methodsBrian Christian2016-02-091-0/+14
|/ /
* | drop array allocations on `html_safe`Aaron Patterson2016-02-081-1/+1
| | | | | | | | | | | | | | | | For better or worse, anonymous `*` args will allocate arrays. Ideally, the interpreter would optimize away this allocation. However, given the number of times we call `html_safe` it seems worth the shedding idealism and going for performance. This line was the top allocation spot for a scaffold (and presumably worse on real applications).
* | Merge pull request #23532 from matthewd/live-interlockMatthew Draper2016-02-082-25/+57
|\ \ | | | | | | Hand off the interlock to the new thread in AC::Live
| * | Manual yield doesn't block new sharesMatthew Draper2016-02-081-5/+6
| | |
| * | Eagerly reacquire when start_sharing is nested inside yield_sharesMatthew Draper2016-02-081-11/+18
| | | | | | | | | | | | A full write-preferring wait can lead to deadlock.
| * | Hand off the interlock to the new thread in AC::LiveMatthew Draper2016-02-072-15/+39
| | | | | | | | | | | | | | | | | | Most importantly, the original request thread must yield its share lock while waiting for the live thread to commit -- otherwise a request's base and live threads can deadlock against each other.
* | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-02-071-2/+2
|\ \ \ | |/ / |/| |
| * | [ci skip] Fix one more typoPrathamesh Sonpatki2016-01-301-1/+1
| | | | | | | | | | | | - Followup of https://github.com/rails/docrails/commit/10bc49710b7205a6172c3e072b3c77114fefd952
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 02:20:01 +0000