| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |\ \ \ \
| | | | |
| | | | | |
Deprecate `LoadError::REGEXPS` constant
|
| | | | | |
| | | | |
| | | | |
| | | | | |
since 4ad1a52, `LoadError::REGEXPS` is no longer needed.
|
| |/ / / / |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
String#camelize was returning nil without any feedback when an
invalid option was passed as parameter. This update makes the method
to raises an ArgumentError when the option passed is invalid, similar
to what Ruby does for String#downcase (and others) in 2.4.1.
https://ruby-doc.org/core-2.4.1/String.html#method-i-downcase
|
| | |/ /
|/| | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Rails 5.1 introduce an `ActiveSupport::Duration::Scalar` class as
a wrapper around a numeric value as a way of ensuring a duration
was the outcome of an expression. However the implementation was
missing support for modulo operations. This commit adds support
for those operations and should result in a duration being
returned from expressions involving them.
Fixes #29603 and #29743.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
PR #29163 introduced a change in behavior when a duration was
the denominator in a calculation - this was incorrect as dividing
by a duration should always return a `Numeric`. The behavior of
previous versions of Rails has been restored.
Fixes #29592.
|
| |\ \ \
| | | |
| | | | |
Document metadata support for MessageEncryptor
|
| | | | |
| | | |
| | | |
| | | | |
[ci skip]
|
| |\ \ \ \
| | | | |
| | | | | |
Remove time stubs after each test
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Reverts 7abb6e0.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
[ Assain Jaleel & Kasper Timm Hansen ]
|
| | |/ / /
|/| | |
| | | |
| | | | |
[ Assain Jaleel & Kasper Timm Hansen ]
|
| | | | | |
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | | |
Fix HashWithIndifferentAccess#default when include?(nil)
|
| | |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The implementation of HashWithIndifferentAccess#default didn't
distinguish `default` from `default(nil)`, which caused an incorrect
result for `default` if `nil` was used as a key.
Define HashWithIndifferentAccess#dig so that hackery that behaves
differently from Hash#default can be removed from
HashWithIndifferentAccess#default.
|
| |\ \ \ \
| | | | |
| | | | | |
Add documentation for class_attribute default option
|
| | | | | | |
|
| |\ \ \ \ \ |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We have some indentation cops. But now there is a little inconsistent
params indentations. Enable `Layout/FirstParameterIndentation` cop to
prevent newly inconsistent indentation added and auto-correct to
existing violations.
|
| | | | | | | |
|
| | | |_|/ /
| |/| | | |
|
| | | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | | |
ActiveSupport::Cache::RedisStore
Broken in 8da30ad.
|
| | |/ / |
|
| | | |
| | |
| | |
| | | |
[ci skip]
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
By making the Rails minitest behave like a standard minitest plugin
we're much more likely to not break when people use other minitest
plugins. Like minitest-focus and pride.
To do this, we need to behave like minitest: require files up front
and then perform the plugin behavior via the at_exit hook.
This also saves us a fair bit of wrangling with test file loading.
Finally, since the environment and warnings options have to be applied
as early as possible, and since minitest loads plugins at_exit, they
have to be moved to the test command.
* Don't expect the root method.
It's likely this worked because we eagerly loaded the Rails minitest plugin
and that somehow defined a root method on `Rails`.
* Assign a backtrace to failed exceptions.
Otherwise Minitest pukes when attempting to filter the backtrace (which
Rails' backtrace cleaner then removes).
Means the exception message test has to be revised too.
This is likely caused by the rails minitest plugin now being loaded for
these tests and assigning a default backtrace cleaner.
|
| | | |
| | |
| | |
| | | |
Time.now` (#29681)
|
| | |\ \
| | | |
| | | | |
Update MessageEncryptor example to use dynamic key length
|
| | | | |
| | | |
| | | |
| | | | |
by OpenSSL
|
| | |\ \ \
| | | | |
| | | | | |
Use frozen-string-literal in ActiveSupport
|
| | | | | | |
|
| | |\ \ \ \
| | | | | |
| | | | | | |
Mention Time.zone.parse possibly throwing ArgumentError
|
| | | | | | | |
|
| | | |/ / /
| |/| | |
| | | | |
| | | | | |
if using prefix version.
|
| | |\ \ \ \ |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing
changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
|
| | | |\ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
Enforce frozen string in Rubocop
|
| | | | | | | | |
|
| | | |\ \ \ \ \
| | | |_|_|/ /
| | |/| | | |
| | | | | | | |
Make ActiveSupport frozen-string-literal friendly.
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The ActiveSupport test suite only passes currently if it uses the latest unreleased commits for dalli, and a patch for Builder:
https://github.com/tenderlove/builder/pull/6
Beyond that, all external dependencies (at least, to the extent they’re used by ActiveSupport) are happy, including Nokogiri as of 1.8.0.
|
| | |/ / / / / |
|
| | | |/ / /
| |/| | | |
|
| | |\ \ \ \
| | | | | |
| | | | | | |
Remove useless class checking for `ActiveSupport::Callbacks`s result_lambda
|
| | | |/ / / |
|
| | | | | | |
|
| | |/ / /
| | | |
| | | |
| | | | |
This deprecation warning message will be more useful if it indicates what the string was doing — being eval'd — and what the non-deprecated options for callback conditionals are.
|
| | |\ \ \
| | | | |
| | | | | |
Log subscriber - avoid rescuing certain exceptions
|
| | | | | | |
|
| | | | | | |
|
