aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/lib
Commit message (Collapse)AuthorAgeFilesLines
* Add missing support for modulo operations on durationsSayan Chakraborty2017-07-281-1/+47
| | | | | | | | | | | Rails 5.1 introduce an `ActiveSupport::Duration::Scalar` class as a wrapper around a numeric value as a way of ensuring a duration was the outcome of an expression. However the implementation was missing support for modulo operations. This commit adds support for those operations and should result in a duration being returned from expressions involving them. Fixes #29603 and #29743.
* Fix division where a duration is the denominatorAndrew White2017-07-271-5/+4
| | | | | | | | | PR #29163 introduced a change in behavior when a duration was the denominator in a calculation - this was incorrect as dividing by a duration should always return a `Numeric`. The behavior of previous versions of Rails has been restored. Fixes #29592.
* Merge pull request #29892 from assain/documenation_for_metadataKasper Timm Hansen2017-07-242-0/+72
|\ | | | | Document metadata support for MessageEncryptor
| * document metadata support added to message encryptor and message verifierAssain2017-07-242-0/+72
| | | | | | | | [ci skip]
* | Merge pull request #29860 from georgeclaghorn/travel-back-automaticallyRafael França2017-07-241-1/+8
|\ \ | | | | | | Remove time stubs after each test
| * | Remove time stubs after each testGeorge Claghorn2017-07-221-1/+8
| | | | | | | | | | | | Reverts 7abb6e0.
* | | Let Metadata instance handle purpose coercion.Kasper Timm Hansen2017-07-231-4/+4
| | | | | | | | | | | | [ Assain Jaleel & Kasper Timm Hansen ]
* | | Remove dependency on `from_now` extension.Kasper Timm Hansen2017-07-231-1/+1
| |/ |/| | | | | [ Assain Jaleel & Kasper Timm Hansen ]
* | add metadata support to message verifierAssain2017-07-191-6/+7
| |
* | Add expires_at, expires_in, and purpose meta_data to messages.Assain2017-07-192-5/+61
| |
* | Merge pull request #29757 from lugray/hash_with_indifferent_access_defaultSean Griffin2017-07-171-10/+30
|\ \ | | | | | | Fix HashWithIndifferentAccess#default when include?(nil)
| * | Fix HashWithIndifferentAccess#default when include?(nil)Lisa Ugray2017-07-171-10/+30
| |/ | | | | | | | | | | | | | | | | | | The implementation of HashWithIndifferentAccess#default didn't distinguish `default` from `default(nil)`, which caused an incorrect result for `default` if `nil` was used as a key. Define HashWithIndifferentAccess#dig so that hackery that behaves differently from Hash#default can be removed from HashWithIndifferentAccess#default.
* | Merge pull request #29758 from glaucocustodio/patch-1 [ci skip]Sean Griffin2017-07-171-0/+10
|\ \ | | | | | | Add documentation for class_attribute default option
| * | Add documentation for class_attribute optionsGlauco Custódio2017-07-171-0/+10
| | |
* | | Merge branch 'master' into make-reverse-merge-bang-order-consistentSean Griffin2017-07-17226-733/+1865
|\ \ \
| * | | Enable `Layout/FirstParameterIndentation` copRyuta Kamizono2017-07-171-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We have some indentation cops. But now there is a little inconsistent params indentations. Enable `Layout/FirstParameterIndentation` cop to prevent newly inconsistent indentation added and auto-correct to existing violations.
| * | | explain why require_relative is not used here [ci skip]Xavier Noria2017-07-161-0/+2
| | | |
| * | | Fix doc format for `ActiveSupport::Testing::TimeHelpers` [ci skip]yuuji.yaginuma2017-07-151-2/+2
| | | |
| * | | Fix configuring third-party cache stores such as ↵George Claghorn2017-07-121-1/+1
| | |/ | |/| | | | | | | | | | | | | ActiveSupport::Cache::RedisStore Broken in 8da30ad.
| * | [Active Support] `rubocop -a --only Layout/EmptyLineAfterMagicComment`Koichi ITO2017-07-11226-0/+226
| |/
| * :scissors:Ryuta Kamizono2017-07-111-1/+0
| | | | | | | | [ci skip]
| * * Don't eagerly require Rails' minitest plugin.Kasper Timm Hansen2017-07-101-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By making the Rails minitest behave like a standard minitest plugin we're much more likely to not break when people use other minitest plugins. Like minitest-focus and pride. To do this, we need to behave like minitest: require files up front and then perform the plugin behavior via the at_exit hook. This also saves us a fair bit of wrangling with test file loading. Finally, since the environment and warnings options have to be applied as early as possible, and since minitest loads plugins at_exit, they have to be moved to the test command. * Don't expect the root method. It's likely this worked because we eagerly loaded the Rails minitest plugin and that somehow defined a root method on `Rails`. * Assign a backtrace to failed exceptions. Otherwise Minitest pukes when attempting to filter the backtrace (which Rails' backtrace cleaner then removes). Means the exception message test has to be revised too. This is likely caused by the rails minitest plugin now being loaded for these tests and assigning a default backtrace cleaner.
| * Added time helper method `freeze_time` which is an alias for `travel_to ↵प्रथमेश Sonpatki2017-07-101-0/+21
| | | | | | | | Time.now` (#29681)
| * Merge pull request #29730 from bdewater/update-encryptor-docsKasper Timm Hansen2017-07-091-5/+6
| |\ | | | | | | Update MessageEncryptor example to use dynamic key length
| | * [ci skip] update MessageEncryptor example to use the key length as returned ↵Bart de Water2017-07-091-5/+6
| | | | | | | | | | | | by OpenSSL
| * | Merge pull request #29728 from kirs/frozen-activesupportMatthew Draper2017-07-09226-0/+226
| |\ \ | | | | | | | | Use frozen-string-literal in ActiveSupport
| | * | Use frozen-string-literal in ActiveSupportKir Shatrov2017-07-09226-0/+226
| | | |
| * | | Merge pull request #28668 from Dorian/mention-time-parse-argument-errorAaron Patterson2017-07-051-1/+3
| |\ \ \ | | | | | | | | | | Mention Time.zone.parse possibly throwing ArgumentError
| | * | | Mention and test for possible ArgumentError when parsing timesDorian Marié2017-04-081-1/+3
| | | | |
| * | | | Use `map` in `delegate` so that actual prefixed method names are returned, ↵Krzysztof Zych2017-07-051-1/+1
| | |/ / | |/| | | | | | | | | | if using prefix version.
| * | | Merge branch 'master' into require_relative_2017Xavier Noria2017-07-029-11/+11
| |\ \ \
| | * | | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-02226-226/+0
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
| | * | | Merge pull request #29540 from kirs/rubocop-frozen-stringMatthew Draper2017-07-02226-0/+226
| | |\ \ \ | | | | | | | | | | | | | | | | | | Enforce frozen string in Rubocop
| | | * | | Enforce frozen string in RubocopKir Shatrov2017-07-01226-0/+226
| | | | | |
| | * | | | Merge pull request #29506 from pat/frozen-string-literalsMatthew Draper2017-07-029-11/+11
| | |\ \ \ \ | | | |_|_|/ | | |/| | | | | | | | | Make ActiveSupport frozen-string-literal friendly.
| | | * | | Make ActiveSupport frozen string literal friendly.Pat Allan2017-06-209-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ActiveSupport test suite only passes currently if it uses the latest unreleased commits for dalli, and a patch for Builder: https://github.com/tenderlove/builder/pull/6 Beyond that, all external dependencies (at least, to the extent they’re used by ActiveSupport) are happy, including Nokogiri as of 1.8.0.
| * | | | | [Active Support] require => require_relativeAkira Matsuda2017-07-01129-383/+383
| |/ / / /
| * | / / Fix the next version of Rails from 5.3 to 6.0Koichi ITO2017-06-301-1/+1
| | |/ / | |/| |
| * | | Merge pull request #29595 from fatkodima/result_lambda_class_checkingRafael França2017-06-281-1/+1
| |\ \ \ | | | | | | | | | | Remove useless class checking for `ActiveSupport::Callbacks`s result_lambda
| | * | | Remove useless class checking for `ActiveSupport::Callbacks`s result_lambdafatkodima2017-06-271-1/+1
| | |/ /
| * | | Fix typo in callback deprecation messageyuuji.yaginuma2017-06-281-1/+1
| | | |
| * | | Add more explicit guidance on how to fix callback deprecationsSage Ross2017-06-231-2/+4
| |/ / | | | | | | | | | This deprecation warning message will be more useful if it indicates what the string was doing — being eval'd — and what the non-deprecated options for callback conditionals are.
| * | Merge pull request #29140 from notEthan/log_subscribed_avoid_rescuingRafael França2017-06-161-2/+4
| |\ \ | | | | | | | | Log subscriber - avoid rescuing certain exceptions
| | * | check that logger is defined in log subscriber rescue before loggingEthan2017-05-241-1/+3
| | | |
| | * | lob subscriber should only rescue StandardError, not ExceptionEthan2017-05-241-1/+1
| | | |
| * | | Fix `Message::Encryptor` default cipher [ci skip]yuuji.yaginuma2017-06-121-1/+1
| | | | | | | | | | | | | | | | Follow up of #29263
| * | | Merge pull request #29263 from assain/default_message_encryptor_to_gcmKasper Timm Hansen2017-06-112-4/+21
| |\ \ \ | | | | | | | | | | Default Message Encryptor Cipher to AES-256-GCM From AES-256-CBC
| | * | | set message_encryptor default cipher to aes-256-gcmAssain2017-06-122-4/+21
| | | | | | | | | | | | | | | | | | | | - Introduce a method to select default cipher, and maintain backward compatibility
| * | | | Cache: test coverage for cleanup behavior with local cache strategyEugene Kenny2017-06-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | No need to pass `#cleanup` options through to `LocalCache#clear`. Fixes #29081. References #25628.
| * | | | Revert #25628. Incomplete change + needs a deprecation cycle.Jeremy Daer2017-06-103-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://github.com/rails/rails/issues/29067#issuecomment-301342084 for rationale. This reverts commit b76f82d714e590c20370e72fa36fa574c4f17650. Fixes #29067. Fixes #29081.