Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add documentation to six AS::TimeWithZone methods | claudiob | 2014-12-04 | 1 | -2/+23 |
| | | | | [ci skip] | ||||
* | Copy-edit the MessageVerifier documentation [ci skip] | Rafael Mendonça França | 2014-12-04 | 1 | -7/+6 |
| | |||||
* | Add documentation to MessageVerifier | claudiob | 2014-12-03 | 1 | -4/+50 |
| | | | | | | | | [ci skip] Complements #17727 and closes ee73d9ff8. @lleger How do you feel about this? | ||||
* | Add some FIXME notes about documentation [ci skip] | Rafael Mendonça França | 2014-12-02 | 1 | -0/+4 |
| | |||||
* | Prefer object/nil over `true`/`false` | Rafael Mendonça França | 2014-12-02 | 1 | -6/+4 |
| | | | | | | | | | | | This is the project guideline and the reasons are: * That follows standard Ruby semantics. * Allows the implementation to avoid artificial code like !! or something ? true : false * You do not need to rely on the exact type of 3rd party code. For example, if your method returns str.end_with?('foo') you do not need to make sure end_with? returns a singleton. Your predicate just propagates predicate semantics up regardless of what end_with? returns. | ||||
* | Add `#verified` and `#valid_message?` to MessageVerifier | Logan Leger | 2014-12-01 | 1 | -6/+15 |
| | | | | | | | | | | | This commit adds a `#verified` method to `ActiveSupport::MessageVerifier` which will return either `false` when it encounters an error or the message. `#verify` continues to raise an `InvalidSignature` exception on error. This commit also adds a convenience boolean method on `MessageVerifier` as a way to check if a message is valid without performing the decoding. | ||||
* | Pass symbol as an argument instead of a block | Erik Michaels-Ober | 2014-11-29 | 9 | -12/+12 |
| | |||||
* | Merge pull request #17816 from byroot/prevent-numeric-to-s-to-allocate-an-array | Rafael Mendonça França | 2014-11-29 | 2 | -16/+25 |
|\ | | | | | Prevent Numeric#to_s from allocating an array | ||||
| * | Prevent Numeric#to_s from allocating an array | Jean Boussier | 2014-11-28 | 2 | -16/+25 |
| | | |||||
* | | fixed indent of end in jdom.rb | bigtone1284 | 2014-11-28 | 1 | -1/+1 |
| | | |||||
* | | Start Rails 5 development :tada: | Rafael Mendonça França | 2014-11-28 | 1 | -3/+3 |
|/ | | | | | | | We will support only Ruby >= 2.1. But right now we don't accept pull requests with syntax changes to drop support to Ruby 1.9. | ||||
* | Document `String#html_safe` [ci skip] | Sean Griffin | 2014-11-24 | 1 | -0/+5 |
| | | | | | | It should be part of the documented public API, since we have an entire section of the guides dedicated to it. Documented in a way that addresses the concerns which kept it undocumented in the past. | ||||
* | Update to Unicode 7.0.0 | Benjamin Fleischer | 2014-11-15 | 2 | -1/+1 |
| | | | | | | | | 7.0.0 was released on June 16, 2014 http://unicode-inc.blogspot.com.ar/2014/10/unicode-version-70-complete-text-of.html ruby bin/generate_tables | ||||
* | Abstract encoding strategy for ActiveSupport::MessageVerifier | Ryan Mohr | 2014-11-12 | 1 | -2/+10 |
| | |||||
* | Merge pull request #17047 from betesh/master | Rafael Mendonça França | 2014-11-11 | 1 | -0/+1 |
|\ | | | | | Time includes DateAndTime::Zones acts_like(:time) | ||||
| * | Time includes DateAndTime::Zones acts_like(:time) | betesh | 2014-11-09 | 1 | -0/+1 |
| | | |||||
* | | dependencies.rb: keep the decorated #load and #require private [closes #17553] | Xavier Noria | 2014-11-10 | 1 | -13/+18 |
| | | |||||
* | | added description for rails generators, and fixed sentence formation for ↵ | Rishi Jain | 2014-11-10 | 1 | -1/+1 |
|/ | | | | active_support/notifications [ci skip] | ||||
* | Merge pull request #17493 from petewest/duration-comparable | Aaron Patterson | 2014-11-07 | 1 | -0/+2 |
|\ | | | | | Delegate comparison operator to value | ||||
| * | Delegate comparison operator to value | Peter West | 2014-11-03 | 1 | -0/+2 |
| | | |||||
* | | added example of hash#except, and removed extra whitespaces [ci skip] | Rishi Jain | 2014-11-07 | 2 | -5/+11 |
| | | |||||
* | | added example of squish!, remove, test case for multiple occurrence of | Rishi Jain | 2014-11-06 | 1 | -0/+9 |
| | | | | | | | | | | | | | | | | pattern removal added example for string#remove and test case for remove of multiple occurence of pattern removed extra whitespaces | ||||
* | | Removed the unused require of proxy_object and test related to it | Prathamesh Sonpatki | 2014-11-05 | 1 | -1/+0 |
| | | | | | | | | | | - Reference : https://github.com/rails/rails/pull/17493#issuecomment-61739359 - Duration stopped inheriting from ProxyObject in https://github.com/rails/rails/pull/16574 | ||||
* | | fix typo [ci skip] | Vijay Dev | 2014-11-04 | 1 | -1/+1 |
| | | |||||
* | | fixed typo [ci skip] | Rishi Jain | 2014-11-04 | 1 | -1/+1 |
| | | |||||
* | | added example for hash slice method [ci skip] | Rishi Jain | 2014-11-04 | 1 | -2/+8 |
|/ | |||||
* | Merge pull request #17487 from pabloh/avoid_allocations | Rafael Mendonça França | 2014-11-03 | 1 | -1/+1 |
|\ | | | | | Avoid unnecessary allocations and method calls | ||||
| * | Avoid unnecessary allocations/calls | Pablo Herrero | 2014-11-02 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #17383 from rwz/string-remove | Rafael Mendonça França | 2014-11-03 | 1 | -6/+10 |
|\ \ | |/ |/| | | | | | | | | | Make `String#remove` and `String#remove!` accept multiple arguments Conflicts: activesupport/CHANGELOG.md | ||||
| * | Make `String#remove` and `String#remove!` accept multiple arguments | Pavel Pravosud | 2014-10-25 | 1 | -6/+10 |
| | | |||||
* | | Call gsub with a Regexp instead of a String for better performance | Pablo Herrero | 2014-11-01 | 1 | -1/+1 |
| | | |||||
* | | Prepare for 4.2.0.beta4 release | Godfrey Chan | 2014-10-30 | 1 | -1/+1 |
| | | |||||
* | | Do gsub with a regexp instead of a string | Pablo Herrero | 2014-10-29 | 3 | -3/+3 |
| | | |||||
* | | edit pass over all warnings | Xavier Noria | 2014-10-28 | 3 | -5/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch uniformizes warning messages. I used the most common style already present in the code base: * Capitalize the first word. * End the message with a full stop. * "Rails 5" instead of "Rails 5.0". * Backticks for method names and inline code. Also, converted a few long strings into the new heredoc convention. | ||||
* | | Fix doc markup for `NumberHelper` [ci skip] | Ryunosuke SATO | 2014-10-29 | 1 | -5/+5 |
| | | | | | | | | | | The character "*" is unnecessary in option candidates. This incorrect markup was injected in e8c9aeca . | ||||
* | | Optimize TimeWithZoneTest#strftime | Pablo Herrero | 2014-10-27 | 1 | -10/+6 |
| | | |||||
* | | Prefix internal method with _ | Rafael Mendonça França | 2014-10-25 | 1 | -2/+2 |
| | | | | | | | | This will avoid naming clash with user defined methods | ||||
* | | fixes circularity check in dependencies | Xavier Noria | 2014-10-25 | 1 | -1/+9 |
| | | | | | | | | | | | | | | | | | | | | The check for circular loading should depend on a stack of files being loaded at the moment, rather than the collection of loaded files. This showed up indirectly in #16468, where a misspelled helper would incorrectly result in a circularity error message. References #16468 | ||||
* | | instance_eval is evil | Akira Matsuda | 2014-10-25 | 1 | -1/+1 |
| | | |||||
* | | Avoid creating range objects (take II) | Akira Matsuda | 2014-10-25 | 1 | -1/+5 |
| | | |||||
* | | Revert a change made to the example in 1ac4525 | Godfrey Chan | 2014-10-24 | 1 | -1/+1 |
| | | | | | | | | | | | | | | @carlosantoniodasilva pointed out that when `@person` is nil then this would blow up when you ended up calling `#first`on `nil`. > "there’s no way to break a try chain when you enter it :D" [ci skip] | ||||
* | | Include return value in examples added in #17378 [ci skip] | Zachary Scott | 2014-10-24 | 1 | -2/+2 |
| | | |||||
* | | Improved try documentation [ci skip] | Eugene Gilburg | 2014-10-24 | 1 | -8/+25 |
|/ | | | | | | | | | | - better `if` example - Added chaining example to the try method description - Documented the `respond_to?` check to the try method description - Clearer wording to explain that argument error is raised on argument mismatch to responding method, rather than to non-responding method (which is handled without exception by `try`) - `.any?` is more precise than `! .blank?` - Don't need to use `try` on `children` as (for regular associations) they will always be a collection or array that responds to `first` - Fix typos/grammar | ||||
* | Merge pull request #17377 from aripollak/dry-try-bang | Godfrey Chan | 2014-10-23 | 1 | -10/+6 |
|\ | | | | | DRY up try/try! | ||||
| * | DRY up try/try! | Ari Pollak | 2014-10-23 | 1 | -10/+6 |
| | | |||||
* | | Merge pull request #17369 from rails/secure_compare | Guillermo Iguaran | 2014-10-23 | 2 | -12/+22 |
|\ \ | |/ |/| | Secure compare | ||||
| * | Use AS secure_compare in AS::MessageVerifier | Guillermo Iguaran | 2014-10-23 | 1 | -12/+2 |
| | | |||||
| * | Add AS::SecurityUtils.secure_compare for constant time string comparison | Guillermo Iguaran | 2014-10-23 | 1 | -0/+20 |
| | | |||||
* | | Reword documentation for `uncountable` [ci skip] | Melanie Gilman | 2014-10-23 | 1 | -1/+1 |
|/ | |||||
* | Bring try! into parity with try. | Ari Pollak | 2014-10-22 | 1 | -1/+1 |
| | | | | Based on commit 5e51bdda. |