aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | Handle max_time edge cases for epoch times and add testBlake Mesdag2016-04-121-3/+12
| | | | | | |
* | | | | | | Use Time#compare_without_coercion for super speedBlake Mesdag2016-04-121-1/+6
| | | | | | |
* | | | | | | Use a single memoized loop to find max mtime in ↵Blake Mesdag2016-04-121-1/+12
| |/ / / / / |/| | | | | | | | | | | | | | | | | ActiveSupport::FileUpdateChecker#max_mtime
* | | | | | Pass over all Rails 5 warnings, to make sure:Vipul A M2016-04-122-2/+1
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - we are ending sentences properly - fixing of space issues - fixed continuity issues in some sentences. Reverts https://github.com/rails/rails/commit/8fc97d198ef31c1d7a4b9b849b96fc08a667fb02 . This change reverts making sure we add '.' at end of deprecation sentences. This is to keep sentences within Rails itself consistent and with a '.' at the end.
* | | | | Fix behavior of JSON encoding for Exceptionnamusyaka2016-04-091-0/+6
| | | | |
* | | | | Merge pull request #24422 from matthewd/extinguish-executor-exceptionsMatthew Draper2016-04-072-4/+49
|\ \ \ \ \ | | | | | | | | | | | | Clean up after a failure in a run callback
| * | | | | Directly support stateful executor hooksMatthew Draper2016-04-052-4/+49
| | | | | | | | | | | | | | | | | | | | | | | | Also, make sure to call the +complete+ hooks if +run+ fails.
* | | | | | Avoid unused captureRyuta Kamizono2016-04-051-1/+1
| | | | | |
* | | | | | Merge pull request #24345 from ↵Rafael França2016-04-051-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | mtsmfm/fix-marshal-with-autoloading-for-nested-class Fix marshal with autoloading for nested class/module
| * | | | | | Fix marshal with autoloading for nested class/moduleFumiaki MATSUSHIMA2016-03-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #24150 break autoloading for nested class/module. There is test for nested class but it doesn't work correctly. Following code will autoload `ClassFolder::ClassFolderSubclass` before `Marshal.load`: `assert_kind_of ClassFolder::ClassFolderSubclass, Marshal.load(dumped)`
* | | | | | | Merge pull request #24401 from pan/number-to-phoneRafael Mendonça França2016-04-052-3/+19
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | `number_to_phone` formats number with regexp
| * | | | | | `number_to_phone` formats number with regexpPan GaoYong2016-04-022-3/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By default, this method formats US number. This commit extends its functionality to format number for other countries with a custom regular expression. number_to_phone(18812345678, pattern: /(\d{3})(\d{4})(\d{4})/) # => 188-1234-5678 The output phone number is divided into three groups, so the regexp should also match three groups of numbers.
* | | | | | | Match `String#to_time`'s behaviour to rubySiim Liiser2016-04-041-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously `String#to_time` returned the midnight of the current date in some cases where there was no relavant information in the string. Now the method returns `nil` instead in those cases. Fixes #22958.
* | | | | | | Call super instead of returning nil for DateTime#<=>Andrew White2016-04-031-5/+2
| |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The native DateTime#<=> implementation can be used to compare instances with numeric values being considered as astronomical julian day numbers so we should call that instead of returning nil. Fixes #24228.
* | | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-04-031-1/+1
|\ \ \ \ \ \
| * | | | | | s/responsibilty/responsibility/Vipul A M2016-03-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | s/symantically/semantically/ [ci skip]
* | | | | | | Remove not needed includingyui-knk2016-04-022-7/+0
| |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | Because `DateTime` inherits `Date` and `Date` includes `DateAndTime::Zones`, `DateTime` not need to include `DateAndTime::Zones` again.
* | | | | | Fix method String#upcase_firstbogdanvlviv2016-03-312-3/+7
| | | | | |
* | | | | | Replace _meth with _method to remove ambiguityScott Latham2016-03-301-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | Merge pull request #23895 from glaucocustodio/add_upcase_first_methodRafael Mendonça França2016-03-302-0/+14
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | Add upcase_first method
| * | | | | Add upcase_first methodGlauco Custódio2016-02-252-0/+14
| | |/ / / | |/| | |
* | | | | fixed spelling in the attribute_accessors docuTorsten Braun2016-03-231-1/+1
| | | | | | | | | | | | | | | mattr_writer to mattr_reader
* | | | | fixed spellin in the mattr_reader documentationTorsten Braun2016-03-231-1/+1
| | | | | | | | | | | | | | | renamed cattr_reader to mattr_reader
* | | | | Improve code readability in ActiveSupport::DependenciesAaron Ang2016-03-161-5/+6
| | | | |
* | | | | Add comments to ActiveSupport::Dependencies to help understandingAaron Ang2016-03-161-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In a previous patch, all log-related stuff was removed. However, some logs are still useful to understand the code. Therefore, in this patch, I put those log messages back as comments. [ci skip]
* | | | | no need to clear an unusued collectionXavier Noria2016-03-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the code reaches that line new_constants is no longer needed. We only need here to iterate over it to discard stuff and done. Note that constant_watch_stack.new_constants returns a new reference each time it is invoked, so that #clear call was not cleaning state in some internal structure (which would have been a bit dirty as well at this level of coupling).
* | | | | removes unreachable codeXavier Noria2016-03-161-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This array literal cannot be reached. The previous begin either returns to the caller via the explicit return in the ensure block if all goes well, or else propagates whatever make the begin block abort execution. I have investigated the origin of this a bit. In the past the ensure block didn't have a return call, see for example c08547d. Later on the return was added in 4da4506, but the trailing literal was left there.
* | | | | Remove log-related stuff from ActiveSupport::DependenciesAaron Ang2016-03-151-44/+0
| | | | | | | | | | | | | | | | | | | | | | | | | In this patch, all log-related stuff in `ActiveSupport::Dependencies` is removed because the logging is no longer useful.
* | | | | Use the most highest priority exception handler when cause is setSean Griffin2016-03-111-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was some subtle breakage caused by #18774, when we removed `#original_exception` in favor of `#cause`. However, `#cause` is automatically set by Ruby when raising an exception from a rescue block. With this change, we will use whichever handler has the highest priority (whichever call to `rescue_from` came last). In cases where the outer has lower precidence than the cause, but the outer is what should be handled, cause will need to be explicitly unset. Fixes #23925
* | | | | Merge pull request #24150 from exviva/unmarshal-infinite-retryXavier Noria2016-03-111-1/+4
|\ \ \ \ \ | | | | | | | | | | | | Prevent `Marshal.load` from looping infinitely
| * | | | | Prevent `Marshal.load` from looping infinitelyOlek Janiszewski2016-03-111-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix a bug in `Marshal.load` that caused it to loop indefinitely when trying to autoload a constant that resolved to a different name. This could occur when marshalling an ActiveRecord 4.0 object (e.g. into memcached) and then trying to unmarshal it with Rails 4.2. The marshalled payload contains a reference to `ActiveRecord::ConnectionAdapters::Mysql2Adapter::Column`, which in Rails 4.2 resolves to `ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter::Column`.
* | | | | | Merge pull request #24143 from perceptec/fix-thread-mattr-accessor-refsMatthew Draper2016-03-121-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix `thread_mattr_accessor` thread-local variable naming
| * | | | | | Fix `thread_mattr_accessor` thread-local variable namingMichael Ryan2016-03-111-2/+2
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current implentation of `thread_mattr_accessor` is setting differently-named thread variables when defining class and instance writer methods, so the method isn't working as documented: Account.user = "DHH" Account.user # => "DHH" Account.new.user # => nil a = Account.new a.user = "ABC" # => "ABC" a.class.user # => "DHH" At this point `:attr_Account_user` and `:attr_Class_user` thread-local variables have been created. Modify the reader and writer methods to use the class name instead of 'Class'.
* / / / / / use `ActiveSupport::Reloader.to_prepare` instead of deprecated ↵yuuji.yaginuma2016-03-111-1/+1
|/ / / / / | | | | | | | | | | | | | | | `ActionDispatch::Reloader.to_prepare` [ci skip]
* | | | | Add missing require to tryRafael Mendonça França2016-03-111-0/+2
| | | | |
* | | | | Remove unused try requireBart de Water2016-03-101-1/+0
| |_|_|/ |/| | |
* | | | friendly error message if missing listenJerry Cheung2016-03-081-1/+7
| |/ / |/| |
* | | Prevent nested ExecutionWrapper calls even when using run! directlyMatthew Draper2016-03-042-9/+16
| | |
* | | Fix `ActiveSupport::Reloader.check!`Ryuta Kamizono2016-03-021-4/+3
| | | | | | | | | | | | | | | The test failure in `bug_report_templates/action_controller_master.rb` is due to `app.reloader.check` is `nil`.
* | | Merge pull request #23936 from yui-knk/local_constants_to_be_publicRafael Mendonça França2016-03-012-2/+6
|\ \ \ | | | | | | | | | | | | Deprecate `Module.local_constants`
| * | | Deprecate `Module.local_constants`yui-knk2016-03-012-2/+6
| |/ / | | | | | | | | | | | | After Ruby 1.9, we can easily get the constants that have been defined locally by `Module.constants(false)`.
* / / Publish AS::Executor and AS::Reloader APIsMatthew Draper2016-03-028-10/+214
|/ / | | | | | | | | | | These should allow external code to run blocks of user code to do "work", at a similar unit size to a web request, without needing to get intimate with ActionDipatch.
* | Prep release for Rails 5 beta3eileencodes2016-02-241-1/+1
| |
* | :bomb: run the test @rafaelfranca :angry:Rafael Mendonça França2016-02-241-1/+1
| |
* | Make internal class as nodocRafael Mendonça França2016-02-241-2/+2
| | | | | | | | Also use the new hash syntax.
* | Merge pull request #23616 from piotrj/issue_23609_logger_broadcast_silencingRafael Mendonça França2016-02-243-21/+42
|\ \ | | | | | | | | | Fix logger silencing for broadcasted loggers
| * | Fix logger silencing for broadcasted loggersPiotr Jakubowski2016-02-113-21/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix #23609 Commit 629efb6 introduced thread safety to logger silencing but it didn't take into account the fact that the logger can be extended with broadcasting to other logger. This commit introduces local_level to broadcasting Module which enables broadcasted loggers to be properly silenced.
* | | Ignore callstacks from Ruby stdlib in deprecationRafael Mendonça França2016-02-241-4/+12
| | | | | | | | | | | | Fixes #22982.
* | | Fix `assert_nothing_raised` deprecation warning formatRyuta Kamizono2016-02-241-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before: ``` DEPRECATION WARNING: Passing arguments to assert_nothing_raised is deprecated and will be removed in Rails 5.1. ``` After: ``` DEPRECATION WARNING: Passing arguments to assert_nothing_raised is deprecated and will be removed in Rails 5.1. ```
* | | add deprecation warning to assert_nothing_raised and changelog entryTara Scherner de la Fuente2016-02-221-1/+5
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 02:46:38 +0000