Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Make caller attribute in deprecation methods optional | Alexey Gaziev | 2012-10-30 | 11 | -14/+17 |
| | |||||
* | Provide a call stack for deprecation warnings where needed. | Nikita Afanasenko | 2012-10-29 | 4 | -6/+12 |
| | | | | It's sometimes hard to quickly find where deprecated call was performed, especially in case of migrating between Rails versions. So this is an attempt to improve the call stack part of the warning message by providing caller explicitly. | ||||
* | atomicc.rb: Don't assume we may chown/chmod a file. | Daniele Sluijters | 2012-10-29 | 1 | -2/+7 |
| | | | | | | | | | | | | | | | | | | | | | | Previously this code just assumed it is capable of changing the file ownership, both user and group. This will fail in a lot of scenario's unless: * The process is run as a superuser (root); * The owning user and group are already set to the user and group we're trying to chown to; * The user chown'ing only changes the group to another group it is a member of. If either of those conditions are not met the filesystem will simply deny the operation throwing an error. It is also not always possible to do a chmod, there might be a SELinux policy or another limitation preventing the user to change the file mode. To this end the chmod call has also been added to the rescue block. I've also added a little comment above the chmod command that doing a chmod on a file which has an ACL set will cause the ACL to be recalculated / modified. | ||||
* | Replace flow-control exception with explicit test. | Patrick Mahoney | 2012-10-27 | 1 | -2/+2 |
| | | | | | | | | | | | It was noticed while profiling 'assets:precompile' in JRuby that exception creation was consuming a large portion of time, and some of that was due to File.atomic_write. Testing first with File.exists? eliminates the need for an exception which should be a perfomrance improvement on both JRuby and MRI. In this case, the stat() isn't even extra overhead, since it is always called. | ||||
* | Fix queueing tests that should be consuming the queue rather than draining it | Jeremy Kemper | 2012-10-26 | 1 | -1/+1 |
| | |||||
* | Job consumer logs to Rails.logger by default | Jeremy Kemper | 2012-10-26 | 1 | -2/+5 |
| | |||||
* | Job worker thread logs failed jobs too | Jeremy Kemper | 2012-10-26 | 1 | -1/+1 |
| | |||||
* | Job worker thread logs to stderr if no logger is provided | Jeremy Kemper | 2012-10-26 | 1 | -2/+1 |
| | |||||
* | Implement replace method so key? works correctly. | David Graham | 2012-10-26 | 1 | -0/+8 |
| | |||||
* | Remove ActiveRecord::Model consant from AS::TestCase | Carlos Antonio da Silva | 2012-10-26 | 1 | -1/+1 |
| | | | | Fixing the build. | ||||
* | pass the key to the block in cache.fetch on misses | Noah Hendrix | 2012-10-23 | 1 | -5/+5 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-10-21 | 5 | -8/+8 |
|\ | | | | | | | | | | | Conflicts: activesupport/lib/active_support/core_ext/hash/slice.rb guides/source/active_support_core_extensions.md | ||||
| * | Hash Syntax changes to 1.9 format | AvnerCohen | 2012-10-20 | 5 | -9/+9 |
| | | |||||
* | | Make DescendantsTracker thread safe and optimize the #descendants method. | thedarkone | 2012-10-18 | 1 | -19/+34 |
| | | |||||
* | | some ruby interpreters don't have ruby-prof so just skip the tests | Aaron Patterson | 2012-10-18 | 1 | -1/+1 |
| | | | | | | | | rather than exiting the process. | ||||
* | | Revert "remove unnecessary object/conversions file" | Xavier Noria | 2012-10-16 | 2 | -2/+9 |
| | | | | | | | | | | | | | | This file is used at least by Active Merchant, its existence is maybe not necessary but no big deal either. This reverts commit ae9b3d7cecd77b9ace38671b183e1a360bf632b6. | ||||
* | | Backpedal from class-oriented config.queue. Set an actual queue instance. | Jeremy Kemper | 2012-10-12 | 1 | -4/+0 |
| | | |||||
* | | Remove the queue container. Premature consolidation. Set up and maintain ↵ | Jeremy Kemper | 2012-10-12 | 1 | -26/+0 |
| | | | | | | | | queues in the classes that use them instead. | ||||
* | | Merge pull request #7007 from Mik-die/hash_extract | Rafael Mendonça França | 2012-10-12 | 1 | -3/+3 |
|\ \ | | | | | | | make Hash#extract! more symmetric with Hash#slice | ||||
| * | | make Hash#extract! more symmetric with Hash#slice | Mikhail Dieterle | 2012-10-08 | 1 | -3/+3 |
| | | | |||||
* | | | Padding expires_in by 5 minutes on dalli key write to facilitate ↵ | Mike Evans | 2012-10-11 | 1 | -0/+4 |
| |/ |/| | | | | | :race_condition_ttl working correctly. | ||||
* | | Ensure expires_in and created_at timestamps aren't nil when attempting to ↵ | Joshua Peek | 2012-10-10 | 1 | -1/+1 |
| | | | | | | | | upgrade cache | ||||
* | | let (array|hash)/conversions.rb load the extensions in ↵ | Xavier Noria | 2012-10-09 | 2 | -1/+5 |
| | | | | | | | | object/to_(param|query).rb | ||||
* | | keys.include? -> key? | Xavier Noria | 2012-10-09 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #7817 from NARKOZ/object-conversions | Xavier Noria | 2012-10-09 | 2 | -9/+2 |
|\ \ | |/ |/| | remove unnecessary object/conversions file | ||||
| * | remove unnecessary object/conversions file | Nihad Abbasov | 2012-10-02 | 2 | -9/+2 |
| | | |||||
* | | explains why these requires are in an unusual place | Xavier Noria | 2012-10-07 | 1 | -0/+8 |
| | | |||||
* | | Merge pull request #7650 from kennyj/fix_warning_20120915 | Xavier Noria | 2012-10-07 | 1 | -6/+7 |
|\ \ | | | | | | | Fix warning: circular require considered harmful. | ||||
| * | | Fix warning: circular require considered harmful. | kennyj | 2012-10-03 | 1 | -6/+7 |
| |/ | |||||
* | | rename private method to avoid overriding | Francesco Rodriguez | 2012-10-06 | 1 | -2/+2 |
| | | |||||
* | | use Rails backtrace in tests | Francesco Rodriguez | 2012-10-05 | 1 | -0/+1 |
| | | |||||
* | | Revert "Use flat_map { } instead of map {}.flatten" | Santiago Pastorino | 2012-10-05 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | This reverts commit abf8de85519141496a6773310964ec03f6106f3f. We should take a deeper look to those cases flat_map doesn't do deep flattening. irb(main):002:0> [[[1,3], [1,2]]].map{|i| i}.flatten => [1, 3, 1, 2] irb(main):003:0> [[[1,3], [1,2]]].flat_map{|i| i} => [[1, 3], [1, 2]] | ||||
* | | Use flat_map { } instead of map {}.flatten | Santiago Pastorino | 2012-10-05 | 1 | -2/+2 |
| | | |||||
* | | Merge pull request #6952 from NZKoz/key_generator | Michael Koziarski | 2012-10-02 | 2 | -0/+24 |
|\ \ | |/ |/| | Add ActiveSupport::KeyGenerator as a simple wrapper around PBKDF2 | ||||
| * | Add ActiveSupport::KeyGenerator as a simple wrapper around PBKDF2 | Michael Koziarski | 2012-10-01 | 2 | -0/+24 |
| | | | | | | | | | | | | This will be used to derive keys from the secret and a salt, in order to allow us to do things like encrypted cookie stores without using the secret for multiple purposes directly. | ||||
* | | fix broken cache tests | Brian Durand | 2012-09-30 | 1 | -2/+2 |
|/ | |||||
* | Optimize ActiveSupport::Cache::Entry to reduce memory and processing overhead. | Brian Durand | 2012-09-30 | 2 | -63/+86 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-09-28 | 2 | -2/+22 |
|\ | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/asset_tag_helper.rb | ||||
| * | Improve documentation for subscribe block | Grant Hutchins & Sabrina Staedt | 2012-09-27 | 1 | -1/+11 |
| | | |||||
| * | String.to_time documentation along examples. | Adam Stankiewicz | 2012-09-24 | 1 | -1/+11 |
| | | |||||
* | | ConstantLookup is not needed in every TestCase decendant | Andy Lindeman | 2012-09-26 | 1 | -1/+0 |
| | | |||||
* | | Tests tag the Rails log with the current test class and test case | Jeremy Kemper | 2012-09-26 | 2 | -0/+32 |
| | | |||||
* | | Allow wrapping a logger that hasn't set a formatter. Default to our ↵ | Jeremy Kemper | 2012-09-26 | 1 | -2/+4 |
| | | | | | | | | SimpleFormatter. Otherwise we try extending nil with the tagging API. | ||||
* | | Add logger.push_tags and .pop_tags to complement logger.tagged | Jeremy Kemper | 2012-09-26 | 1 | -14/+28 |
| | | |||||
* | | Add missing inflector dependency | Mike Moore | 2012-09-25 | 1 | -3/+2 |
| | | |||||
* | | Create ActiveSupport::Testing::ConstantLookup | Mike Moore | 2012-09-24 | 2 | -0/+55 |
| | | | | | | | | | | AS::TC::ConstantLookup walks the test's name to find the constant it is describing. This additional lookup logic is needed to better support minitest's spec DSL. | ||||
* | | Raise the same exception the code is handling | Santiago Pastorino | 2012-09-21 | 1 | -1/+1 |
|/ | |||||
* | Update examples in AS::Concern to use correct scope syntax. [ci skip] | José Corcuera | 2012-09-21 | 1 | -2/+2 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-09-21 | 79 | -873/+984 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: actionmailer/lib/action_mailer/base.rb activesupport/lib/active_support/configurable.rb activesupport/lib/active_support/core_ext/module/deprecation.rb guides/source/action_controller_overview.md guides/source/active_support_core_extensions.md guides/source/ajax_on_rails.textile guides/source/association_basics.textile guides/source/upgrading_ruby_on_rails.md While resolving conflicts, I have chosen to ignore changes done in docrails at some places - these will be most likely 1.9 hash syntax changes. | ||||
| * | Fix indentation and update documentation for Array#wrap for Ruby 1.9 | Jo Liss | 2012-09-20 | 1 | -9/+10 |
| | |