aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/lib
Commit message (Collapse)AuthorAgeFilesLines
* Fix to_query with empty arrays tooRafael Mendonça França2014-02-061-1/+6
|
* Refatoring the method to avoid shot-circuit returnRafael Mendonça França2014-02-051-4/+7
|
* Fixed "Hash#to_param confused by empty hash values #13892"Hincu Petru2014-02-051-0/+1
|
* fix interplay of humanize and html_escapeSean Walbran2014-02-051-1/+1
|
* Return sized enumerator from Enumerable#index_byMarc-Andre Lafortune2014-02-051-1/+1
|
* Return sized enumerator from Batches#find_eachMarc-Andre Lafortune2014-02-051-1/+1
|
* docs, be clear that `options` is a hash. Closes #11904. [ci skip].Yves Senn2014-02-031-1/+1
|
* Fix isolated testsRafael Mendonça França2014-02-011-0/+1
|
* Merge pull request #13911 from davidcelis/remove-bigdecimal-serializationRafael Mendonça França2014-02-012-15/+13
|\ | | | | | | | | | | | | Deprecate custom BigDecimal serialization Conflicts: activesupport/CHANGELOG.md
| * Remove BigDecimal#to_dDavid Celis2014-02-011-7/+0
| | | | | | | | | | | | This was backported for Ruby 1.8 support and is no longer needed. Signed-off-by: David Celis <me@davidcel.is>
| * Don't require BigDecimal serialization extensionDavid Celis2014-02-012-8/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails currently provides an extension to BigDecimal that redefines how it is serialized to YAML. However, as noted in #12467, this does not work as expected. When ActiveSupport is required, BigDecimal YAML serialization does not maintain the object type. It instead ends up serializing the number represented by the BigDecimal itself which, when loaded by YAML later, becomes a Float: ```ruby require 'yaml' require 'bigdecimal' yaml = BigDecimal('13.37').to_yaml YAML.load(yaml).class require 'active_support/all' yaml = BigDecimal('13.37').to_yaml YAML.load(yaml).class ``` @tenderlove posits that we should deprecate the custom BigDecimal serialization and let Ruby handle it. For the time being, users who require this serialization for backwards compatibility can manually `require 'active_support/core_ext/big_decimal/yaml_conversions'`. This will close #12467 and deprecate the custom BigDecimal#to_yaml. Signed-off-by: David Celis <me@davidcel.is>
* | Merge pull request #12769 from birkirb/masterRafael Mendonça França2014-02-011-2/+4
|\ \ | |/ |/| | | | | | | | | Boolean parser blows up on a Fixnum. Conflicts: activesupport/CHANGELOG.md
| * Fix breakage in XmlMiniBirkir A. Barkarson2013-12-231-2/+4
| | | | | | | | | | | | | | - Boolean parsing breaks on non strings (i.e. integer 1|0) - Symbol parsing breaks on non strings. - BigDecimal parsing breaks due to missing require. - Update changelog.
* | Maintain the current timezone in wrap_with_time_zoneAndrew White2014-01-311-7/+2
| | | | | | | | | | | | | | Extend the solution from the fix for #12163 to the general case where `Time` methods are wrapped with a time zone. Fixes #12596.
* | fix typo and indent. [ci skip]Yves Senn2014-01-301-1/+1
| |
* | Improve documentation [ci skip]Rafael Mendonça França2014-01-301-3/+4
| |
* | Remove automatic removal of Date/Time stubs after each test caseRafael Mendonça França2014-01-301-9/+2
| | | | | | | | | | | | This behavior is only work out-of-box with minitest and also add a downside to run after each test case, even if we don't used the travel or travel_to methods
* | Add `travel_back` to remove stubs from `travel` and `travel_to`Rafael Mendonça França2014-01-301-3/+14
| |
* | Use each_valueRafael Mendonça França2014-01-291-1/+1
| |
* | Store the singleton_class in a local variableRafael Mendonça França2014-01-291-3/+4
| |
* | Change the class and method visibilityRafael Mendonça França2014-01-291-9/+13
| |
* | Use instance method instead of before hookRafael Mendonça França2014-01-291-9/+8
| |
* | Alias the original method first to avoid warningsRafael Mendonça França2014-01-291-2/+7
| |
* | Implement a simple stub feature to use in the Time travel helpersRafael Mendonça França2014-01-291-4/+44
| |
* | Allow session serializer key in config.session_storeLukasz Sarnacki2014-01-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | MessageEncryptor has :serializer option, where any serializer object can be passed. This commit make it possible to set this serializer from configuration level. There are predefined serializers (:marshal_serializer, :json_serialzier) and custom serializer can be passed as String, Symbol (camelized and constantized in ActionDispatch::Session namepspace) or serializer object. Default :json_serializer was also added to generators to provide secure defalt.
* | Make ActiveSupport::TimeWithZone#xmlschema consistentAndrew White2014-01-261-2/+2
| | | | | | | | | | | | Both Time#xmlschema and DateTime#xmlschema can accept nil values for the fraction_digits parameter. This commit makes this so for TimeWithZone values as well.
* | Add support for JSON time_precision to Time and DateTimeAndrew White2014-01-263-6/+6
| |
* | Rename subsecond_fraction_digits option to time_precisionAndrew White2014-01-262-5/+5
| |
* | Customize subsecond digits when encoding DateWithTimeParker Selbert2014-01-262-2/+8
| | | | | | | | | | | | | | | | | | | | | | The subsecond fraction digits had been hardcoded to 3. This forced all timestamps to include the subsecond digits with no way to customize the value. While the subsecond format is part of the ISO8601 spec, it is not adhered to by all parsers (notably mobile clients). This adds the ability to customize the number of digits used, optionally setting them to 0 in order to eliminate the subsecond fraction entirely: ActiveSupport::JSON::Encoding.subsecond_fraction_digits = 0
* | Maintain current timezone when changing time during DST overlapAndrew White2014-01-262-3/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently if a time is changed during DST overlap in the autumn then the method `period_for_local` will return the DST period. However if the original time is not DST then this can be surprising and is not what is generally wanted. This commit changes that behavior to maintain the current period if it's in the list of periods returned by `periods_for_local`. It is possible to alter the behavior of `period_for_local` by specifying a second argument but since we may be change from another time that could be either DST or not then this would give inconsistent results. Fixes #12163.
* | Fix secrets.yml path in exception messageCarlos Antonio da Silva2014-01-201-9/+7
| | | | | | | | The file is config/secrets.yml, not config/initializers/secrets.yml.
* | Merge pull request #13765 from robertomiranda/secrets_tokenGuillermo Iguaran2014-01-191-4/+4
|\ \ | | | | | | Update Error Message when secrets.secret_key_base isn't given
| * | Update Error Message when secrets.secret_key_base isn't givenrobertomiranda2014-01-191-4/+4
| | |
* | | set encoding to binmode for pipeAnna Carey2014-01-171-0/+2
|/ /
* | Consistence in the block styleRafael Mendonça França2014-01-172-5/+5
| |
* | Remove warnings on Ruby 2.1Rafael Mendonça França2014-01-172-1/+9
| |
* | define the delegate methods on one line. fixes #13724Aaron Patterson2014-01-161-20/+22
| | | | | | | | sup haters
* | Revert "methods are defined right after the module_eval, so we don't need to do"Piotr Sarnacki2014-01-161-2/+2
| | | | | | | | | | | | | | | | | | This change breaks tests in activesupport/test/core_ext/module_test.rb: * test_delegation_exception_backtrace * test_delegation_exception_backtrace_with_allow_nil This reverts commit 0167765e3f84260522bc2f32d926c1f5dd44957c.
* | methods are defined right after the module_eval, so we don't need to doAaron Patterson2014-01-151-2/+2
| | | | | | | | any line number maths
* | Merge pull request #13709 from akshay-vishnoi/typoYves Senn2014-01-141-1/+1
|\ \ | | | | | | [ci skip] Grammar correction
| * | [ci skip] Grammar correctionAkshay Vishnoi2014-01-141-1/+1
| | |
* | | Merge pull request #13646 from jenseng/json_escapeGodfrey Chan2014-01-121-12/+12
|\ \ \ | | | | | | | | Clarify behavior of json_escape [ci skip]
| * | | Clarify behavior of json_escape, update examplesJon Jensen2014-01-091-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The behavior of json_escape was fixed in 2f1c5789, but the doc changes and example in that commit incorrectly indicated that the return value would be html-safe. Since quotation marks are preserved, the raw value is not safe to use in other contexts (specifically HTML attributes).
* | | | Merge pull request #13668 from prathamesh-sonpatki/issue-13667Andrew White2014-01-121-2/+1
|\ \ \ \ | | | | | | | | | | Fix iterating over DateTime by doing strict checking for Time objects
| * | | | Fix iterating over DateTime by doing strict checking for Time objectsPrathamesh Sonpatki2014-01-111-2/+1
| |/ / / | | | | | | | | | | | | - Fixes #13667
* / / / Check `respond_to` before delegation due to: ↵Aaron Patterson2014-01-092-1/+6
|/ / / | | | | | | | | | https://github.com/ruby/ruby/commit/d781caaf313b8649948c107bba277e5ad7307314
* | | Merge pull request #13632 from tinogomes/masterRafael Mendonça França2014-01-092-0/+21
|\ \ \ | | | | | | | | Adding Hash#compact and Hash#compact! methods
| * | | Adding Hash#compact and Hash#compact! methodstinogomes2014-01-092-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Adding Hash#compact and Hash#compact! methods * Using Ruby 1.9 syntax on documentation * Updating guides for `Hash#compact` and `Hash#compact!` methods * Updating CHANGELOG for ActiveSupport * Removing unecessary protected method and lambda for `Hash#compact` implementations * Performing `Hash#compact` implementation - https://gist.github.com/tinogomes/8332883 * fixing order position * Fixing typo
* | | | clear cache on body close so that cache remains during renderingAaron Patterson2014-01-081-2/+8
|/ / / | | | | | | | | | | | | | | | | | | | | | fixes #13547 The body may use the local cache during rendering. `call`ing the app doesn't mean that rendering is finished, so we need to wait until `close` is called on the body.
* | | Revert "Speedup String#to"Yves Senn2014-01-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2ef1fb2c455ca53a0c1e1768f50824926ce28bd3. As described in PR #13627 this commit broke functionality when passing a negative Fixnum to the `String#to` method: ```ruby assert_equal "hell", s.to(-2) ``` Before the revert, this failed with: ``` 1) Failure: StringAccessTest#test_#to_with_negative_Fixnum,_position_is_counted_from_the_end [test/core_ext/string_ext_test.rb:275]: Expected: "hell" Actual: nil ``` This revert is to keep the functionality on `master` working. If there is another way to get the performance benefit and keep the documented functionality we can add that. /cc @amatsuda @carlosantoniodasilva