aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/lib/active_support
Commit message (Collapse)AuthorAgeFilesLines
...
| * * Don't eagerly require Rails' minitest plugin.Kasper Timm Hansen2017-07-101-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By making the Rails minitest behave like a standard minitest plugin we're much more likely to not break when people use other minitest plugins. Like minitest-focus and pride. To do this, we need to behave like minitest: require files up front and then perform the plugin behavior via the at_exit hook. This also saves us a fair bit of wrangling with test file loading. Finally, since the environment and warnings options have to be applied as early as possible, and since minitest loads plugins at_exit, they have to be moved to the test command. * Don't expect the root method. It's likely this worked because we eagerly loaded the Rails minitest plugin and that somehow defined a root method on `Rails`. * Assign a backtrace to failed exceptions. Otherwise Minitest pukes when attempting to filter the backtrace (which Rails' backtrace cleaner then removes). Means the exception message test has to be revised too. This is likely caused by the rails minitest plugin now being loaded for these tests and assigning a default backtrace cleaner.
| * Added time helper method `freeze_time` which is an alias for `travel_to ↵प्रथमेश Sonpatki2017-07-101-0/+21
| | | | | | | | Time.now` (#29681)
| * Merge pull request #29730 from bdewater/update-encryptor-docsKasper Timm Hansen2017-07-091-5/+6
| |\ | | | | | | Update MessageEncryptor example to use dynamic key length
| | * [ci skip] update MessageEncryptor example to use the key length as returned ↵Bart de Water2017-07-091-5/+6
| | | | | | | | | | | | by OpenSSL
| * | Merge pull request #29728 from kirs/frozen-activesupportMatthew Draper2017-07-09225-0/+225
| |\ \ | | | | | | | | Use frozen-string-literal in ActiveSupport
| | * | Use frozen-string-literal in ActiveSupportKir Shatrov2017-07-09225-0/+225
| | | |
| * | | Merge pull request #28668 from Dorian/mention-time-parse-argument-errorAaron Patterson2017-07-051-1/+3
| |\ \ \ | | | | | | | | | | Mention Time.zone.parse possibly throwing ArgumentError
| | * | | Mention and test for possible ArgumentError when parsing timesDorian Marié2017-04-081-1/+3
| | | | |
| * | | | Use `map` in `delegate` so that actual prefixed method names are returned, ↵Krzysztof Zych2017-07-051-1/+1
| | |/ / | |/| | | | | | | | | | if using prefix version.
| * | | Merge branch 'master' into require_relative_2017Xavier Noria2017-07-029-11/+11
| |\ \ \
| | * | | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-02225-225/+0
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
| | * | | Merge pull request #29540 from kirs/rubocop-frozen-stringMatthew Draper2017-07-02225-0/+225
| | |\ \ \ | | | | | | | | | | | | | | | | | | Enforce frozen string in Rubocop
| | | * | | Enforce frozen string in RubocopKir Shatrov2017-07-01225-0/+225
| | | | | |
| | * | | | Merge pull request #29506 from pat/frozen-string-literalsMatthew Draper2017-07-029-11/+11
| | |\ \ \ \ | | | |_|_|/ | | |/| | | | | | | | | Make ActiveSupport frozen-string-literal friendly.
| | | * | | Make ActiveSupport frozen string literal friendly.Pat Allan2017-06-209-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ActiveSupport test suite only passes currently if it uses the latest unreleased commits for dalli, and a patch for Builder: https://github.com/tenderlove/builder/pull/6 Beyond that, all external dependencies (at least, to the extent they’re used by ActiveSupport) are happy, including Nokogiri as of 1.8.0.
| * | | | | [Active Support] require => require_relativeAkira Matsuda2017-07-01128-378/+378
| |/ / / /
| * | / / Fix the next version of Rails from 5.3 to 6.0Koichi ITO2017-06-301-1/+1
| | |/ / | |/| |
| * | | Merge pull request #29595 from fatkodima/result_lambda_class_checkingRafael França2017-06-281-1/+1
| |\ \ \ | | | | | | | | | | Remove useless class checking for `ActiveSupport::Callbacks`s result_lambda
| | * | | Remove useless class checking for `ActiveSupport::Callbacks`s result_lambdafatkodima2017-06-271-1/+1
| | |/ /
| * | | Fix typo in callback deprecation messageyuuji.yaginuma2017-06-281-1/+1
| | | |
| * | | Add more explicit guidance on how to fix callback deprecationsSage Ross2017-06-231-2/+4
| |/ / | | | | | | | | | This deprecation warning message will be more useful if it indicates what the string was doing — being eval'd — and what the non-deprecated options for callback conditionals are.
| * | Merge pull request #29140 from notEthan/log_subscribed_avoid_rescuingRafael França2017-06-161-2/+4
| |\ \ | | | | | | | | Log subscriber - avoid rescuing certain exceptions
| | * | check that logger is defined in log subscriber rescue before loggingEthan2017-05-241-1/+3
| | | |
| | * | lob subscriber should only rescue StandardError, not ExceptionEthan2017-05-241-1/+1
| | | |
| * | | Fix `Message::Encryptor` default cipher [ci skip]yuuji.yaginuma2017-06-121-1/+1
| | | | | | | | | | | | | | | | Follow up of #29263
| * | | Merge pull request #29263 from assain/default_message_encryptor_to_gcmKasper Timm Hansen2017-06-112-4/+21
| |\ \ \ | | | | | | | | | | Default Message Encryptor Cipher to AES-256-GCM From AES-256-CBC
| | * | | set message_encryptor default cipher to aes-256-gcmAssain2017-06-122-4/+21
| | | | | | | | | | | | | | | | | | | | - Introduce a method to select default cipher, and maintain backward compatibility
| * | | | Cache: test coverage for cleanup behavior with local cache strategyEugene Kenny2017-06-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | No need to pass `#cleanup` options through to `LocalCache#clear`. Fixes #29081. References #25628.
| * | | | Revert #25628. Incomplete change + needs a deprecation cycle.Jeremy Daer2017-06-103-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://github.com/rails/rails/issues/29067#issuecomment-301342084 for rationale. This reverts commit b76f82d714e590c20370e72fa36fa574c4f17650. Fixes #29067. Fixes #29081.
| * | | | Merge pull request #29386 from y-yagi/remove_unreachable_codeGuillermo Iguaran2017-06-071-8/+1
| |\ \ \ \ | | | | | | | | | | | | Remove unreachable code
| | * | | | Remove unreachable codeyuuji.yaginuma2017-06-081-8/+1
| | |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `Time.find_zone!` raise `ArgumentError` if invalid value is specified. https://github.com/rails/rails/blob/379a0b42daf0d8e14130db7fd886d05d8d88e3f2/activesupport/lib/active_support/core_ext/time/zones.rb#L97..L99 Therefore, the return value never becomes nil.
| * / / / Cache: write_multi (#29366)Jeremy Daer2017-06-061-6/+28
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails.cache.write_multi foo: 'bar', baz: 'qux' Plus faster `fetch_multi` with stores that implement `write_multi_entries`. Keys that aren't found may be written to the cache store in one shot instead of separate writes. The default implementation simply calls `write_entry` for each entry. Stores may override if they're capable of one-shot bulk writes, like Redis `MSET`.
| * | | Merge pull request #29294 from gsamokovarov/attributes-defaultKasper Timm Hansen2017-06-045-51/+33
| |\ \ \ | | | | | | | | | | Introduce mattr_accessor default option
| | * | | Use mattr_accessor default: option throughout the projectGenadi Samokovarov2017-06-034-27/+14
| | | | |
| | * | | Implement mattr_acessor :default optionGenadi Samokovarov2017-06-031-24/+19
| | | | |
| * | | | Don't create extra assignment, just returnVipul A M2017-06-041-3/+3
| |/ / /
| * | | Add next occur and previous occurred day of week API (#26600)Shota Iguchi2017-05-301-0/+16
| | | |
| * | | Add missing "not" in the doc for `assert_no_changes` [ci skip]Ryuta Kamizono2017-05-301-1/+1
| | | |
| * | | Add option for class_attribute default (#29270)David Heinemeier Hansson2017-05-294-11/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Allow a default value to be declared for class_attribute * Convert to using class_attribute default rather than explicit setter * Removed instance_accessor option by mistake * False is a valid default value * Documentation
| * | | Merge pull request #26628 from mjhoy/fix-number-to-human-25742Eileen M. Uchitelle2017-05-294-30/+73
| |\ \ \ | | | | | | | | | | round before calculating exponent in number_to_human_converter
| | * | | number_to_human_converter: round before calculating exponentMichael Hoy2017-03-161-4/+2
| | | | | | | | | | | | | | | | | | | | fixes #25664
| | * | | number_to_rounded_converter: extract rounding logicMichael Hoy2017-03-163-26/+71
| | | | |
| * | | | Merge pull request #29074 from ↵Kasper Timm Hansen2017-05-281-4/+0
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | kamipo/remove_returning_true_in_internal_callbacks Remove returning true in internal callbacks
| | * | | | Remove returning true in internal callbacksRyuta Kamizono2017-05-141-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `display_deprecation_warning_for_false_terminator` was removed since 3a25cdc.
| * | | | | Merge pull request #29097 from ↵Matthew Draper2017-05-281-6/+9
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | EilisHamilton/fix_uncountable_pluralization_locale Fix pluralization of uncountables when given a locale
| | * | | | | Fix pluralization of uncountables when given a localeEilis Hamilton2017-05-191-6/+9
| | | |_|/ / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously apply_inflections would only use the :en uncountables rather then the ones for the locale that was passed to pluralize or singularize. This changes apply_inflections to take a locale which it will use to find the uncountables.
| * | | | | Clear all current instances before a reload.Kasper Timm Hansen2017-05-282-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If users added an attribute or otherwise changed a CurrentAttributes subclass they'd see exceptions on the next page load. Because `ActiveSupport::CurrentAttributes.current_instances` would keep references to the old instances from the previous request. We can fix this by clearing out the `current_attributes` before we unload constants. Then any change to the model can be autoloaded again since its slot isn't taken by an old instance. We'll still have to call reset before we clear so external collaborators, like Time.zone, won't linger with their current value throughout other code.
| * | | | | Remove double Thread.current storage.Kasper Timm Hansen2017-05-281-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since we're generating a key through the class name we can combine the two Thread.current calls into a single hash version.
| * | | | | Use non-raising finder.Kasper Timm Hansen2017-05-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `find` raises when it can't find a record, so we'll never reach the else. Switch to `find_by` which returns nil when no record can be found.
| * | | | | [ci skip] Fix spelling that's a bit of an overreach.Kasper Timm Hansen2017-05-271-1/+1
| | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-19 12:21:30 +0000