| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
[ci skip] Fix #seconds_since_midnight documentation output it will al…
|
| |
| |
| |
| | |
return floating pointnumber
|
|\ \
| | |
| | | |
Fix Time.now format in documentation [ci skip]
|
| |/ |
|
|\ \
| | |
| | | |
Use #current instead of #now to prevent zone issues and use new ruby …
|
| |/
| |
| |
| | |
application's time zone
|
|\ \
| |/
|/| |
|
| | |
|
| | |
|
| |
| |
| |
| | |
[ci skip]
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
mtsmfm/xmlschema-should-display-more-than-6-digits
TimeWithZone#xmlschema should be able to display more than 6 digits
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
Change ^ and $ operators to \A and \z to prevent
code injection after the line breaks
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Move from `AS::Callbacks::CallbackChain.halt_and_display_warning_on_return_false`
to `AS::Callbacks.halt_and_display_warning_on_return_false` base on
[this
discussion](https://github.com/rails/rails/pull/21218#discussion_r39354580)
Fix the documentation broken by 0a120a818d413c64ff9867125f0b03788fc306f8
|
|/ /
| |
| |
| |
| | |
this should fix the error where isolation tests raise an exception and
we just get a marshal error
|
| | |
|
|\ \
| | |
| | | |
Update docs for `formatted_offset`
|
| | |
| | |
| | | |
Output of `formatted_offset` is depends on input so it’s not always in +HH:MM format. Possible outputs are “+5:30”, “+530” or provided alternate UTC string [ci skip]
|
|\ \ \
| | | |
| | | | |
Updated docs for transform_keys & transform_values
|
| | | | |
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We're calling this function on an empty hash as part of copying the
attribute set during dirty checking initialization. The new structure
caused a performance regression on loading records from the database.
This causes `User.all.to_a` to perform about 10% faster w/ 10k records.
Calculating -------------------------------------
User.all - master 9.000 i/100ms
User.all - sg-fix-ar-regression
8.000 i/100ms
-------------------------------------------------
User.all - master 81.236 (± 7.4%) i/s - 405.000
User.all - sg-fix-ar-regression
89.716 (± 7.8%) i/s - 448.000
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With this we can perform new assertions on the returned value without having
to cache it with an outer variable or wrapping all subsequent assertions inside
the `assert_difference` block.
Before:
```
post = nil
assert_difference -> { Post.count }, 1 do
Post.create
end
assert_predicate post, :persisted?
```
Now:
```
post = assert_difference -> { Post.count } do
Post.create
end
assert_predicate post, :persisted?
```
|
| | |
|
| |
| |
| |
| |
| |
| | |
Rails 4.2.3 AS::Callbacks will not halt chain if `false` is returned.
That is the behavior of specific callbacks like AR::Callbacks and
AM::Callbacks.
|
|\ \
| | |
| | | |
Added Examples in docs for internal behavior of Array#to_formatted_s [ci skip]
|
| | | |
|
| | |
| | |
| | | |
Here is correct output of `number_to_percentage(100, format: "%n %”)`
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The concept of a blank date or time doesn't make sense so we can short
circuit the calls for `blank?` on these classes to gain small speed boost.
Fixes #21657
|
| | | |
|
| | |
| | |
| | |
| | | |
Call to Object#try was removed with this pull request https://github.com/rails/rails/pull/21596
|
| | | |
|
|\ \ \
| | | |
| | | | |
Replaced `ThreadSafe::Map` with successor `Concurrent::Map`.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The thread_safe gem is being deprecated and all its code has been merged
into the concurrent-ruby gem. The new class, Concurrent::Map, is exactly
the same as its predecessor except for fixes to two bugs discovered
during the merge.
|
|\ \ \ \
| | | | |
| | | | | |
Correcting `NameError` error message in `mattr_reader` method. [ci skip]
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | | |
commit https://github.com/rails/rails/commit/7dfbd91b0780fbd6a1dd9bfbc176e10894871d2d, `NameError` includes attribute_name also in error message [ci skip]
|
| |/ /
|/| | |
|
|/ /
| |
| |
| | |
@rafaelfranca suggested in https://github.com/rails/rails/commit/f7c7bcd9c2a8b0e8c2840295d001d2d4dfd4cfae that code examples should display
the result after `# =>` and not after `#=>`.
|
|\ \
| |/
|/| |
Corrected `to_time` output in ActiveSupport Date Conversion docs [ci …
|
| |
| |
| |
| |
| | |
https://github.com/rails/rails/commit/48583f8bf74d1cefefea3cd6591bd546a9eaff6c, to_time returns times formatted as YYYY-MM-DD HH:MM:SS UTC [ci skip]
`to_time` method now returns in `YYYY-MM-DD HH:MM:SS UTC` format.
|
|\ \ |
|
| | |
| | |
| | |
| | | |
[ci skip]
|
| |/
|/| |
|
| |
| |
| | |
This was happened after this commit https://github.com/rails/rails/commit/2ebf47aea21ff8ac10681e53e78dd7a0e5c31c6e
|
|\ \
| | |
| | | |
Improve Docs of ActiveSupport::TimeZone [ci skip]
|
| | |
| | |
| | |
| | |
| | | |
`TimeZone` class is a part of `ActiveSupport` module. For Accessing `TimeZone` class, we need to call `ActiveSupport::TimeZone` instead of `TimeZone`.
individual `TimeZone` gives `NameError: uninitialized constant ‘TimeZone’ error
|
|\ \ \
| |/ /
|/| | |
Remove methods that are never invoked
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes #21122 - does not change any current behavior; simply reflects
the fact that two conditions of the if/else statement are never reached.
The reason is #17227 which adds a default terminator to AS::Callbacks.
Therefore, even callback chains that do not define a terminator now
have a terminator, and `chain_config.key?(:terminator)` is always true.
Of course, if no terminator was defined, then we want this new default
terminator not to do anything special. What the terminator actually does
(or should do) is discussed in #21218 but the simple fact that a default
terminator exists makes this current PR valid.
*Note* that the conditional/simple methods have not been removed in
AS::Conditionals::Filter::After because of `:skip_after_callbacks_if_terminated`
which lets a user decide **not** to skip after callbacks even if the chain was
terminated.
|