| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
In dev, ActiveSupport::FileUpdateChecker#max_mtime triggers many
time comparisons. Time#to_time is quite a bit slower than not doing it,
so we should avoid it if possible.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When Active Record calls `set_callback` inside `after_commit`,
[these lines of code](https://github.com/rails/rails/blob/master/activerecord/lib/active_record/transactions.rb#L276)
pass an **array** of methods as the `:if` condition:
```ruby
options[:if] = Array(options[:if])
options[:if] << "transaction_include_any_action?(#{fire_on})"
```
That made me realize that anyone could pass an **array** of `:if` and `:unless`
conditions to `set_callback`, since Active Support transforms these conditions
into an array anyways in [these lines of code](https://github.com/rails/rails/blob/master/activesupport/lib/active_support/callbacks.rb#L365):
```ruby
@if = Array(options[:if])
@unless = Array(options[:unless])
```
Long story short, this commit updates the documentation of the `set_callback`
method to explain that arrays are also accepted.
It also replaces +false+ and +true+ with false and true, since any _falsey_ or
_truthy_ value will work.
[ci skip]
|
| |
|
|
|
|
| |
This reverts commit 9420de59f5b7f5ceac77e28e6c326ec145f71f80.
Reason: Turns out we want to keep this method.
|
| | |
|
| |
|
|
|
| |
We are promoting too much a feature that will not be widler used.
So for now lets keep just the ArrayInquirer constructor.
|
| |\
| |
| |
| | |
Provide friendlier access to request variants
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Wrapping an array in an `ArrayInquirer` gives a friendlier way to check its
string-like contents. For example, `request.variant` returns an `ArrayInquirer`
object. To check a request's variants, you can call:
request.variant.phone?
request.variant.any?(:phone, :tablet)
...instead of:
request.variant.include?(:phone)
request.variant.any? { |v| v.in?([:phone, :tablet]) }
`Array#inquiry` is a shortcut for wrapping the receiving array in an
`ArrayInquirer`:
pets = [:cat, :dog]
pets.cat? # => true
pets.ferret? # => false
pets.any?(:cat, :ferret} # => true
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
Conflicts:
guides/source/4_0_release_notes.md
|
| | | | |
|
| | |/
|/|
| | |
For consistency purposes with the changes done in https://github.com/rails/rails/pull/12285
|
| | | |
|
| |\ \
| | |
| | | |
Small doc fix. [CI SKIP]
|
| | | | |
|
| |/ / |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| | |
…as discussed #19413
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| | |
Thanks @fbernier for suggestion! <3
At this moment we can use Module#prepend in all all cases
except of Range because of the bug [1] in MRI 2.2
[1] https://bugs.ruby-lang.org/issues/10847
|
| |\ \
| | |
| | | |
Skip the `:race_condition_ttl` branch if the option is 0 or nil.
|
| | | |
| | |
| | |
| | | |
an issue with the redis cache, where this code will sometimes throw an error out of SETEX when passing 0 as the `expires_at`.
|
| |/ / |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Reverting this as it's not the implementation that we would like it to be.
This is being used inside of ActiveSUpport::TimeZone[] and it's unaware
of the context in which to find the timezone period so the timezone found
changes depending on whether DST is in effect for the current period.
This means that `'2001-01-01'.in_time_zone(-9)` changes from winter/summer
even though it's the same date that we're trying to convert.
Since finding timezones by numeric offsets is a bit hit and miss we should
introduce a new API for finding them which supplies the date context in
which we want to search and we should probably also deprecate the finding
of timezones via the [] method, though this needs further discussion.
This reverts commit 2cc2fa3633edd96773023c6b09d07c7b9d9b841d.
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
Closes #19227.
|
| |\ \
| | |
| | | |
[ci skip] Update documentation for Time#seconds_since_midnight
|
| | | | |
|
| |/ /
| |
| |
| |
| |
| | |
`CallbackSequence#call` can only ever take one argument. Using `*args`
here produces unnecessary array allocations. Since it only ever takes
one argument we should use `arg` instead of `*args`.
|
| |\ \
| | |
| | | |
If TZInfo-data is not present in windows, let the user know.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
* Fix a few typos
* Wrap some lines around 80 chars
* Rephrase some statements
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
mraidel/activesupport_cache_fetch_multi_documentation_fix
fixes documentation for returned hash in cache.fetch_multi
|
| | | | | |
|
| | |/ /
|/| | |
|
| |/ /
| |
| |
| |
| |
| | |
When given a specific offset, use the first result found where the
total current offset (including any periodic deviations such as DST)
from UTC is equal.
|
| |\ \
| | |
| | | |
Improve the Rubinius build
|
| | | |
| | |
| | |
| | |
| | | |
At the moment, `rescue_from` doesn't work with strings on Rubinius
because of rubinius/rubinius#3272.
|
| |/ /
| |
| |
| | |
(relates to #19157)
|
| | |
| |
| |
| | |
[egilburg]
|
| |/ |
|
