aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/lib/active_support
Commit message (Collapse)AuthorAgeFilesLines
* Remove unused instance variableschneems2016-01-061-1/+0
|
* [close #22917] Don't output to `STDOUT` twiceschneems2016-01-061-1/+11
| | | | | | | | | | | | | | When `rails console` or `rails server` are used along with a logger set to output to `STDOUT` then the contents will show up twice. This happens because the logger is extended with `ActiveSupportLogger.broadcast` with a destination of STDOUT even if it is already outputting to `STDOUT`. Previously PR #22592 attempted to fix this issue, but it ended up causing NoMethodErrors. A better approach than relying on adding a method and flow control is to inspect the log destination directly. For this `ActiveSupport::Logger.logger_outputs_to?` was introduced ```ruby logger = Logger.new(STDOUT) ActiveSupport::Logger.logger_outputs_to?(logger, STDOUT) # => true ``` To accomplish this we must look inside of an instance variable of standard lib's Logger `@logdev`. There is a related Ruby proposal to expose this method in a standard way: https://bugs.ruby-lang.org/issues/11955
* Revert "Add Logger option to disable message broadcasts"schneems2016-01-052-13/+4
| | | | This reverts related commits due to #22917.
* Merge pull request #22856 from ↵Rafael França2016-01-011-0/+1
|\ | | | | | | | | rthbound/adds-exception-object-to-instrumenter-payload Adds exception object to instrumenter's payload
| * Adds exception object to instrumenter's payloadRyan T. Hosford2015-12-311-0/+1
| | | | | | | | | | | | | | - Adds new key/value pair to payload when an exception is raised e.g. `:exception_object=> #<RuntimeError: FAIL>` - Updates relevant test - Adds CHANGELOG entry
* | Merge pull request #12877 from aroben/extended-graphemesRafael França2015-12-311-13/+38
|\ \ | |/ |/| Support extended grapheme clusters and UAX 29
| * Support extended grapheme clusters and UAX 29Adam Roben2013-11-131-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | http://www.unicode.org/reports/tr29/tr29-21.html is the version of UAX 29 that corresponds to Unicode 6.2.0. Unicode.unpack_graphemes now implements all the rules listed there, including the ones for extended grapheme clusters. I added a new optional test, test/multibyte_grapheme_break_conformance.rb, that is heavily based on test/multibyte_normalization_conformance.rb, which runs the Unicode test suite.
| * Refactor Unicode.unpack_graphemes slightlyAdam Roben2013-11-131-13/+23
| | | | | | | | This will make it easier to add the rest of the rules listed in UAX 29.
* | Fix - to_s(:db) on Numeric rangeAkshay Vishnoi2015-12-291-1/+5
| |
* | Merge pull request #22822 from maclover7/fix-22805Richard Schneeman2015-12-281-0/+1
|\ \ | | | | | | Add a missing require to ActiveSupport::NumericWithFormat
| * | Add a missing require to ActiveSupport::NumericWithFormatJon Moss2015-12-281-0/+1
| | |
* | | Removed extra "the" in the documentation of `broadcast_message` [ci skip]Prathamesh Sonpatki2015-12-281-1/+1
| | |
* | | Merge pull request #22771 from nwjsmith/document-broadcast-messagesEileen M. Uchitelle2015-12-271-1/+9
|\ \ \ | | | | | | | | Document `Logger#broadcast_messages` option
| * | | Document `Logger#broadcast_messages` optionNate Smith2015-12-231-1/+9
| |/ /
* | | Merge pull request #22759 from akshay-vishnoi/human-size-helperEileen M. Uchitelle2015-12-274-1/+7
|\ \ \ | | | | | | | | Add support for Petabyte and Exabyte in number to human size
| * | | Add support for Petabyte and Exabyte in number to human sizeAkshay Vishnoi2015-12-224-1/+7
| |/ /
* | | fix typo on commentsPaulo Ancheta2015-12-231-1/+1
| | |
* | | Merge pull request #20507 from rabbitt/bugfix/logger-threadsafetyRafael França2015-12-232-2/+36
|\ \ \ | | | | | | | | Fixes LoggerSilence#silence threadsafety
| * | | Fixes LoggerSilence#silence threadsafetyCarl P. Corliss2015-12-232-2/+36
| |/ / | | | | | | | | | | | | | | | | | | - uses instance defined level if no custom local log level defined - Keeps track of local log level per [ thread + object-instance ] - prevents memory leakage by removing local level hash key/value on #silence method exit - avoids the use of Thread local variables
* / / Add caveat to number_to_currency docs [ci skip]Derek Prior2015-12-231-0/+8
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | I've worked on a few applications that have gone through the internationalization process and had issues because they were using `number_to_currency`. The minute a user is allowed to change their locale, they can change the price displayed on a page from 10 US dollars to 10 Mexican Pesos, which is far from the same amount of money. Unlike other helpers that rely on i18n, `number_to_currency` does not produce equivalent results when the locale is changed. As I've explained this to a few groups of developers now, I thought it might make for a good caveat in the docs.
* | Use CGI.escapeHTML for html escapeTakashi Kokubun2015-12-211-4/+2
| |
* | Merge pull request #22581 from hirocaster/fix-expect-sample-codeYves Senn2015-12-211-4/+5
|\ \ | | | | | | | | | | | | | | | [ci skip] Change output timming of sample code
| * | Change output timming of sample codehirocaster2015-12-141-2/+2
| | | | | | | | | | | | - Expect returns "new value 1" but, retuns nil, because output at thread is not finished. Move val_1 output to finished thread.
* | | Fix documentation for mattr_accessor methodsJan Habermann2015-12-201-6/+6
| | |
* | | Add a commend about deprecation of ActiveSupport::OrderedHashRafael Mendonça França2015-12-201-1/+1
| | | | | | | | | | | | | | | | | | | | | It is in the code to provides backward compatibility for people that have this class serialized as YAML in some storage. Closes #22681
* | | Deprecation warning now targets at 5.1Akira Matsuda2015-12-191-1/+1
| | | | | | | | | | | | | | | Also, added a test case to make sure that the default deprecation horizon is always bigger than the current Rails version.
* | | Merge pull request #22479 from RobinClowers/fix-cache-notification-orderKasper Timm Hansen2015-12-191-8/+8
|\ \ \ | | | | | | | | Fix cache fetch miss notification order
| * | | Fix cache fetch miss notification orderRobin Clowers2015-12-021-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/rails/rails/issues/22477. When I improved the caching instrumentation in edd33c08d98723ae9bb89cf7f019277117ed6414, I inadvertently changed the order of AS notifications when there is a cache miss.
* | | | Change `alpha` to `beta1` to prep for release of Rails 5eileencodes2015-12-181-1/+1
| | | | | | | | | | | | | | | | :tada: :beers:
* | | | [ci skip] Revert most of ff851017Kasper Timm Hansen2015-12-181-2/+2
| | | | | | | | | | | | We went back to `Thread.current[]` in 33e11e59.
* | | | Revert "Use Thread.current.thread_variable_set/get insetad of the direct ↵David Heinemeier Hansson2015-12-181-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | accessors" This reverts commit 301f43820562c6a70dffe30f4227ff0751f47d4f per @matthewd on https://github.com/rails/rails/pull/22630/files#r47997074
* | | | [ci skip] Add `Thread.current` to match internalsKasper Timm Hansen2015-12-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We call the thread variable accessors on `Thread.current`, which matches Ruby's documentation: http://ruby-doc.org/core-2.2.0/Thread.html#method-i-thread_variable_get Fix these to stay `current` ( ͡° ͜ʖ ͡°)
* | | | Clarify thread_mattr_accessor subclass behavior documentationNate Berkopec2015-12-171-8/+9
| | | | | | | | | | | | | | | | [ci skip]
* | | | Copy-edit the Per Thread attribute accessor documentationRafael Mendonça França2015-12-171-3/+3
| | | | | | | | | | | | | | | | [ci skip]
* | | | Use Thread.current.thread_variable_set/get insetad of the direct accessorsDavid Heinemeier Hansson2015-12-171-4/+4
| | | |
* | | | Fix typo in thread_mattr_accessor doco [ci skip]Nate Berkopec2015-12-171-1/+1
| | | |
* | | | Add thread_m/cattr_accessor/reader/writer suite of methods for declaring ↵David Heinemeier Hansson2015-12-173-0/+144
| | | | | | | | | | | | | | | | class and module variables that live per-thread
* | | | Merge pull request #22592 from nwjsmith/disable-logger-message-broadcastsEileen M. Uchitelle2015-12-162-5/+8
|\ \ \ \ | | | | | | | | | | Add Logger option to disable message broadcasts
| * | | | Add Logger option to disable message broadcastsNate Smith2015-12-162-5/+8
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When setting the Rails logger to log to STDOUT, it would broadcast the log twice in development. This adds a setting that will prevent messages from being broadcast to multiple logs, while still allowing calls to `#close`, `#level=`, `#progname=`, and `#formatter=` to be broadcasted. Fixes #14769, #11415
* | | | Merge pull request #22556 from imanel/range_prependKasper Timm Hansen2015-12-161-10/+7
|\ \ \ \ | | | | | | | | | | Use Module.prepend instead of alias_method for Range#to_s
| * | | | Use Module.prepend instead of alias_method for Range#to_sBernard Potocki2015-12-161-10/+7
| | | | |
* | | | | Don't leak Object constants in core_ext/module/qualified_constGenadi Samokovarov2015-12-161-12/+30
| | | | |
* | | | | Merge pull request #22605 from tonyta/delete-dead-commentsRafael França2015-12-161-1/+0
|\ \ \ \ \ | | | | | | | | | | | | Delete dead code comments
| * | | | | delete code commented out (and replaced) in e93d0a5Tony Ta2015-12-151-1/+0
| | |/ / / | |/| | |
* | | | | Merge pull request #22598 from yui-knk/deprecate_string_callbackRafael França2015-12-161-1/+8
|\ \ \ \ \ | |/ / / / |/| | | | Deprecate passing string to define callback.
| * | | | Deprecate passing string to define callback.yui-knk2015-12-161-1/+8
| |/ / /
* / / / lazy load listen in coreXavier Noria2015-12-131-1/+4
|/ / / | | | | | | | | | See the rationale in the comment present in this patch.
* | | Correct the time comparison for remember_me tokenJeffrey Warren2015-12-101-1/+1
| | | | | | | | | | | | | | | Corrects the time comparison to be `Time.now < time` which allows the user to be set only when the current time is less than the 2 week window given in the example.
* | | renames AS::FileEventedUpdateChecker to AS::EventedFileUpdateCheckerXavier Noria2015-12-091-1/+1
| | | | | | | | | | | | Better English.
* | | Merge pull request #22428 from thedarkone/subs-notifEileen M. Uchitelle2015-12-062-4/+9
|\ \ \ | | | | | | | | Subscribing to notifications while inside the said instrumented section
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 09:33:42 +0000