Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | fixing arity2 test | Aaron Patterson | 2013-05-14 | 1 | -3/+8 | |
| | | | ||||||
* | | | Merge pull request #10266 from vipulnsward/fix_HIA_to_hash | Rafael Mendonça França | 2013-05-14 | 1 | -3/+7 | |
|\ \ \ | | | | | | | | | fix HashWithIndifferentAccess#to_hash behaviour | |||||
| * | | | fix HashWithIndifferentAccess#to_hash behaviour | Vipul A M | 2013-04-19 | 1 | -3/+7 | |
| | | | | ||||||
* | | | | Merge branch 'polymorphic' | Aaron Patterson | 2013-05-14 | 1 | -227/+361 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * polymorphic: (41 commits) fix shadowed variable warnings polymorphic around callbacks polymorphic after filter rename terminal to halting, try to keep naming consistent push the before filter lambdas to factory methods polymorphic before callbacks use a singleton end node Revert "we never pass blocks, so remove this" if there is nothing to compile, then do not bother compiling Arrays are no longer supported we never pass blocks, so remove this raise an argument error if the filter arity is greater than 1 pass the actual filter, not a string do not keep a reference to the chain in the callback objects fix deprecation test push merge code to the callback itself dup the callback and set the chain remove klass because it is not used rename instance variables push duplicates? logic to the instance ... | |||||
| * | | | | fix shadowed variable warnings | Aaron Patterson | 2013-05-14 | 1 | -5/+5 | |
| | | | | | ||||||
| * | | | | polymorphic around callbacks | Aaron Patterson | 2013-05-14 | 1 | -15/+79 | |
| | | | | | ||||||
| * | | | | polymorphic after filter | Aaron Patterson | 2013-05-14 | 1 | -25/+70 | |
| | | | | | ||||||
| * | | | | rename terminal to halting, try to keep naming consistent | Aaron Patterson | 2013-05-14 | 1 | -4/+4 | |
| | | | | | ||||||
| * | | | | push the before filter lambdas to factory methods | Aaron Patterson | 2013-05-14 | 1 | -40/+58 | |
| | | | | | ||||||
| * | | | | polymorphic before callbacks | Aaron Patterson | 2013-05-14 | 1 | -16/+54 | |
| | | | | | ||||||
| * | | | | use a singleton end node | Aaron Patterson | 2013-05-13 | 1 | -5/+10 | |
| | | | | | ||||||
| * | | | | Revert "we never pass blocks, so remove this" | Aaron Patterson | 2013-05-13 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | This reverts commit 9caf0cf9c8c7b42737ae78c470a5dd2f583ada75. | |||||
| * | | | | if there is nothing to compile, then do not bother compiling | Aaron Patterson | 2013-05-13 | 1 | -3/+8 | |
| | | | | | ||||||
| * | | | | Arrays are no longer supported | Aaron Patterson | 2013-05-13 | 1 | -4/+0 | |
| | | | | | ||||||
| * | | | | we never pass blocks, so remove this | Aaron Patterson | 2013-05-13 | 1 | -1/+1 | |
| | | | | | ||||||
| * | | | | raise an argument error if the filter arity is greater than 1 | Aaron Patterson | 2013-05-13 | 1 | -12/+6 | |
| | | | | | ||||||
| * | | | | Merge branch 'master' into normalizecb | Aaron Patterson | 2013-05-13 | 1 | -20/+34 | |
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: extract getting an setting callbacks to methods call extracted method from callback manipulation methods extract callback param munging no reason to make these defaulted, we always pass values in Conflicts: activesupport/lib/active_support/callbacks.rb | |||||
| * | | | | | pass the actual filter, not a string | Aaron Patterson | 2013-05-13 | 1 | -1/+1 | |
| | | | | | | ||||||
| * | | | | | Merge branch 'master' into normalizecb | Aaron Patterson | 2013-05-13 | 7 | -25/+28 | |
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (61 commits) add tests for reset_calbacks Fixing build broken by this change Extract variable out of loop Updated comment to Rails 4 Fixes NoMethodError: `alias_method_chain` when requiring just active_support/core_ext better error message when app name is not passed in `rails new` Code cleanup for ActionDispatch::Flash#call Fix typo: require -> requires Add CHANGELOG entry for #10576 Merge pull request #10556 from Empact/deprecate-schema-statements-distinct Some editorial changes on the documentation. respond_to -> respond to in a message from AM::Lint specify that dom_(id|class) are deprecated in controllers, views are fine copy edits [ci skip] Fix class and method name typos Replace multi_json with json ruby -> Ruby Adding documentation to the automatic inverse_of finder. Improve CHANGELOG entry [ci kip] Call assume_migrated_upto_version on connection ... Conflicts: activesupport/lib/active_support/callbacks.rb | |||||
| * | | | | | | do not keep a reference to the chain in the callback objects | Aaron Patterson | 2013-05-10 | 1 | -12/+10 | |
| | | | | | | | ||||||
| * | | | | | | fix deprecation test | Aaron Patterson | 2013-05-10 | 1 | -0/+2 | |
| | | | | | | | ||||||
| * | | | | | | push merge code to the callback itself | Aaron Patterson | 2013-05-10 | 1 | -18/+10 | |
| | | | | | | | ||||||
| * | | | | | | dup the callback and set the chain | Aaron Patterson | 2013-05-10 | 1 | -8/+8 | |
| | | | | | | | ||||||
| * | | | | | | remove klass because it is not used | Aaron Patterson | 2013-05-10 | 1 | -9/+7 | |
| | | | | | | | ||||||
| * | | | | | | rename instance variables | Aaron Patterson | 2013-05-10 | 1 | -12/+14 | |
| | | | | | | | ||||||
| * | | | | | | push duplicates? logic to the instance | Aaron Patterson | 2013-05-10 | 1 | -16/+7 | |
| | | | | | | | ||||||
| * | | | | | | callback chain is in charge of the cache, so remove method based cache | Aaron Patterson | 2013-05-10 | 1 | -21/+0 | |
| | | | | | | | ||||||
| * | | | | | | __define_callbacks method is not necessary anymore | Aaron Patterson | 2013-05-10 | 1 | -8/+1 | |
| | | | | | | | ||||||
| * | | | | | | just run compiled callbacks since they are cached | Aaron Patterson | 2013-05-10 | 1 | -14/+4 | |
| | | | | | | | ||||||
| * | | | | | | cache compiled callbacks | Aaron Patterson | 2013-05-10 | 1 | -7/+27 | |
| | | | | | | | ||||||
| * | | | | | | use delegation over inheritance so we can figure when to cache / bust cache | Aaron Patterson | 2013-05-10 | 1 | -5/+22 | |
| | | | | | | | ||||||
| * | | | | | | fixing activemodel tests | Aaron Patterson | 2013-05-10 | 1 | -1/+2 | |
| | | | | | | | ||||||
| * | | | | | | use an environment object to hold state about the filter calls | Aaron Patterson | 2013-05-10 | 1 | -21/+41 | |
| | | | | | | | ||||||
| * | | | | | | object based callbacks cannot be duplicated | Aaron Patterson | 2013-05-10 | 1 | -7/+4 | |
| | | | | | | | ||||||
| * | | | | | | pass the run block as a normal variable to the rest of the callbacks | Aaron Patterson | 2013-05-10 | 1 | -12/+12 | |
| | | | | | | | ||||||
| * | | | | | | fixing more variable names | Aaron Patterson | 2013-05-10 | 1 | -10/+10 | |
| | | | | | | | ||||||
| * | | | | | | fix variable name | Aaron Patterson | 2013-05-10 | 1 | -6/+6 | |
| | | | | | | | ||||||
| * | | | | | | reduce the number of lambas | Aaron Patterson | 2013-05-10 | 1 | -5/+2 | |
| | | | | | | | ||||||
| * | | | | | | callback sequence is no longer used | Aaron Patterson | 2013-05-10 | 1 | -6/+0 | |
| | | | | | | | ||||||
| * | | | | | | no need for variable assignments, just pass the values in | Aaron Patterson | 2013-05-10 | 1 | -6/+2 | |
| | | | | | | | ||||||
| * | | | | | | make_lambda is never called with an Array | Aaron Patterson | 2013-05-10 | 1 | -2/+0 | |
| | | | | | | | ||||||
| * | | | | | | callbacks are wrapped with lambdas | Aaron Patterson | 2013-05-10 | 1 | -106/+76 | |
| | | | | | | | ||||||
| * | | | | | | remove dead code | Aaron Patterson | 2013-05-10 | 1 | -10/+0 | |
| | | | | | | | ||||||
| * | | | | | | fix method names | Aaron Patterson | 2013-05-10 | 1 | -40/+44 | |
| | | | | | | | ||||||
| * | | | | | | using lambas for the callback bodies | Aaron Patterson | 2013-05-10 | 1 | -32/+12 | |
| | | | | | | | ||||||
| * | | | | | | wrap all options in lambas | Aaron Patterson | 2013-05-10 | 1 | -7/+13 | |
| | | | | | | | ||||||
| * | | | | | | conditions in callbacks return consistent lambdas | Aaron Patterson | 2013-05-10 | 1 | -9/+43 | |
| | |_|_|_|/ | |/| | | | | ||||||
* | | | | | | Merge pull request #10600 from aditya-kapoor/code_refactor | Rafael Mendonça França | 2013-05-14 | 1 | -11/+9 | |
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | Removed Class Eval and used define_method instead for the SafeBuffer | |||||
| * | | | | | Added a blank space and removed to_sym | aditya-kapoor | 2013-05-14 | 1 | -4/+5 | |
| | | | | | | ||||||
| * | | | | | Removed Class Eval and used define_method instead for the SafeBuffer | aditya-kapoor | 2013-05-14 | 1 | -12/+9 | |
| | |/ / / | |/| | | |