| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
I could not find any reason why each method got its own prepended
module here, and all tests appear to pass with my change.
|
|\
| |
| |
| | |
Fix cache fetch instrumentation
|
| |
| |
| |
| |
| | |
Before this change, you couldn't tell if a read was a hit or not when
you called fetch.
|
| |
| |
| |
| |
| |
| |
| |
| | |
With the previous implementation, the block passed to
define_singleton_method, which will live forever as the method body,
captures the parameters (args and block) in its enclosure.
For the current_scope registry, that can include an AR::Relation.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Saw this while doing a review of a patch:
* Normalize case and punctuation across comments.
* ascii -> ASCII
* Since I was on it, some blank lines that visually
add some clarity IMO.
|
|\ \
| | |
| | | |
[ci skip] Fix #seconds_since_midnight documentation output it will al…
|
| | |
| | |
| | |
| | | |
return floating pointnumber
|
|\ \ \
| | | |
| | | | |
Fix Time.now format in documentation [ci skip]
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
Use #current instead of #now to prevent zone issues and use new ruby …
|
| |/ /
| | |
| | |
| | | |
application's time zone
|
|\ \ \
| |/ /
|/| | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
[ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
mtsmfm/xmlschema-should-display-more-than-6-digits
TimeWithZone#xmlschema should be able to display more than 6 digits
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Change ^ and $ operators to \A and \z to prevent
code injection after the line breaks
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Move from `AS::Callbacks::CallbackChain.halt_and_display_warning_on_return_false`
to `AS::Callbacks.halt_and_display_warning_on_return_false` base on
[this
discussion](https://github.com/rails/rails/pull/21218#discussion_r39354580)
Fix the documentation broken by 0a120a818d413c64ff9867125f0b03788fc306f8
|
|/ / /
| | |
| | |
| | |
| | | |
this should fix the error where isolation tests raise an exception and
we just get a marshal error
|
| | | |
|
|\ \ \
| | | |
| | | | |
Update docs for `formatted_offset`
|
| | | |
| | | |
| | | | |
Output of `formatted_offset` is depends on input so it’s not always in +HH:MM format. Possible outputs are “+5:30”, “+530” or provided alternate UTC string [ci skip]
|
|\ \ \ \
| | | | |
| | | | | |
Updated docs for transform_keys & transform_values
|
| | | | | |
|
| | | | | |
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We're calling this function on an empty hash as part of copying the
attribute set during dirty checking initialization. The new structure
caused a performance regression on loading records from the database.
This causes `User.all.to_a` to perform about 10% faster w/ 10k records.
Calculating -------------------------------------
User.all - master 9.000 i/100ms
User.all - sg-fix-ar-regression
8.000 i/100ms
-------------------------------------------------
User.all - master 81.236 (± 7.4%) i/s - 405.000
User.all - sg-fix-ar-regression
89.716 (± 7.8%) i/s - 448.000
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
With this we can perform new assertions on the returned value without having
to cache it with an outer variable or wrapping all subsequent assertions inside
the `assert_difference` block.
Before:
```
post = nil
assert_difference -> { Post.count }, 1 do
Post.create
end
assert_predicate post, :persisted?
```
Now:
```
post = assert_difference -> { Post.count } do
Post.create
end
assert_predicate post, :persisted?
```
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
Rails 4.2.3 AS::Callbacks will not halt chain if `false` is returned.
That is the behavior of specific callbacks like AR::Callbacks and
AM::Callbacks.
|
|\ \ \
| | | |
| | | | |
Added Examples in docs for internal behavior of Array#to_formatted_s [ci skip]
|
| | | | |
|
| | | |
| | | |
| | | | |
Here is correct output of `number_to_percentage(100, format: "%n %”)`
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The concept of a blank date or time doesn't make sense so we can short
circuit the calls for `blank?` on these classes to gain small speed boost.
Fixes #21657
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Call to Object#try was removed with this pull request https://github.com/rails/rails/pull/21596
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Replaced `ThreadSafe::Map` with successor `Concurrent::Map`.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The thread_safe gem is being deprecated and all its code has been merged
into the concurrent-ruby gem. The new class, Concurrent::Map, is exactly
the same as its predecessor except for fixes to two bugs discovered
during the merge.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Correcting `NameError` error message in `mattr_reader` method. [ci skip]
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | | |
commit https://github.com/rails/rails/commit/7dfbd91b0780fbd6a1dd9bfbc176e10894871d2d, `NameError` includes attribute_name also in error message [ci skip]
|
| |/ / /
|/| | | |
|
|/ / /
| | |
| | |
| | | |
@rafaelfranca suggested in https://github.com/rails/rails/commit/f7c7bcd9c2a8b0e8c2840295d001d2d4dfd4cfae that code examples should display
the result after `# =>` and not after `#=>`.
|
|\ \ \
| |/ /
|/| | |
Corrected `to_time` output in ActiveSupport Date Conversion docs [ci …
|
| | |
| | |
| | |
| | |
| | | |
https://github.com/rails/rails/commit/48583f8bf74d1cefefea3cd6591bd546a9eaff6c, to_time returns times formatted as YYYY-MM-DD HH:MM:SS UTC [ci skip]
`to_time` method now returns in `YYYY-MM-DD HH:MM:SS UTC` format.
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
| |/ /
|/| | |
|