Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Remove NilClass whiners feature. | José Valim | 2011-12-08 | 1 | -40/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removing this feature causes boost in performance when using Ruby 1.9. Ruby 1.9 started to do implicit conversions using `to_ary` and `to_str` in some STDLIB methods (like Array#join). To do such implicit conversions, Ruby 1.9 always dispatches the method and rescues the NoMethodError exception in case one is raised. Therefore, since the whiners feature defined NilClass#method_missing, such implicit conversions for nil became much, much slower. In fact, just defining NilClass#method_missing (even without the whiners feature) already causes a massive slow down. Here is a snippet that shows such slow down: require "benchmark" Benchmark.realtime { 1_000.times { [nil,nil,nil].join } } class NilClass def method_missing(*args) raise NoMethodError end end Benchmark.realtime { 1_000.times { [nil,nil,nil].join } } | |||||
* | | Fix inflection regexes for mouse, mice | Mark Rushakoff | 2011-12-07 | 1 | -3/+3 | |
| | | ||||||
* | | Just track "require" if we have something in the watching stack. | José Valim | 2011-12-06 | 1 | -1/+5 | |
| | | | | | | | | | | | | | | | | A patch has been provided earlier and we have asked for feedback: https://gist.github.com/1437939 Except one case, all other cases showed improvements in boot time. | |||||
* | | make method signatures match the superclass signature | Aaron Patterson | 2011-12-05 | 1 | -2/+2 | |
| | | ||||||
* | | return value is never tested, so stop calling `presence` | Aaron Patterson | 2011-12-05 | 1 | -1/+1 | |
|/ | ||||||
* | Restore performance of ERB::Util.html_escape | Jon Jensen | 2011-12-03 | 1 | -1/+1 | |
| | | | | | | | Revert html_escape to do a single gsub again, but add the "n" flag (no language, i.e. not multi-byte) to protect against XSS via invalid utf8 Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Added Enumerable#pluck to wrap the common pattern of collect(&:method) *DHH* | David Heinemeier Hansson | 2011-12-02 | 1 | -0/+7 | |
| | ||||||
* | switch WatchStack to use composition, tighten up API | Aaron Patterson | 2011-11-30 | 1 | -6/+13 | |
| | ||||||
* | Revert "Implement ArraySerializer and move old serialization API to a new ↵ | José Valim | 2011-11-30 | 1 | -1/+1 | |
| | | | | | | | | | | | | | namespace." This reverts commit 8896b4fdc8a543157cdf4dfc378607ebf6c10ab0. Conflicts: activemodel/lib/active_model.rb activemodel/lib/active_model/serializable.rb activemodel/lib/active_model/serializer.rb activemodel/test/cases/serializer_test.rb | |||||
* | Revert "avoid hundreds of thousands of calls to (Symbol|String)#to_s" | Aaron Patterson | 2011-11-30 | 1 | -2/+2 | |
| | | | | | Test coverage isn't comprehensive enough to catch what this breaks. :( This reverts commit 45dad592e47944704ab6951351b2fa29d4a2385f. | |||||
* | avoid hundreds of thousands of calls to (Symbol|String)#to_s | Aaron Patterson | 2011-11-30 | 1 | -2/+2 | |
| | ||||||
* | Log 'Filter chain halted as CALLBACKNAME rendered or redirected' every time ↵ | José Valim | 2011-11-30 | 1 | -4/+14 | |
| | | | | a before callback halts. | |||||
* | Module#synchronize is deprecated with no replacement. Please use `monitor` ↵ | Aaron Patterson | 2011-11-29 | 1 | -0/+2 | |
| | | | | from ruby's standard library. | |||||
* | Fix typo in AS::TaggedLogging | Claudio Poli | 2011-11-29 | 1 | -1/+1 | |
| | ||||||
* | Revert "Used any? instead of length call" | Xavier Noria | 2011-11-28 | 2 | -2/+2 | |
| | | | | | | | | | Reason: This is slower, and any? is not equivalent in the general case. See discussion in https://github.com/rails/rails/pull/3779 This reverts commit 20cbf8eddc3844126d20f1218f068889d17b0dcf. | |||||
* | Used any? instead of length call | Rahul P. Chaudhari | 2011-11-28 | 2 | -2/+2 | |
| | ||||||
* | Merge pull request #3767 from tadast/object_in | Yehuda Katz | 2011-11-26 | 1 | -7/+17 | |
|\ | | | | | Object#in? also accepts multiple parameters | |||||
| * | Object#in? also accepts multiple parameters | Tadas Tamošauskas | 2011-11-26 | 1 | -7/+17 | |
| | | ||||||
* | | Adds Time#sunday method | Vijay Dev | 2011-11-26 | 1 | -0/+6 | |
| | | ||||||
* | | Convert aliases monday and sunday to methods | Vijay Dev | 2011-11-26 | 2 | -3/+18 | |
| | | | | | | | | | | | | | | | | A recent change to beginning_of_week and end_of_week added an argument that can be used to specify the week's starting day as a symbol. Now these methods were aliased as monday and sunday respectively which as a consequence of the argument addition, made calls like obj.monday(:sunday) possible. This commit makes them methods on their own. | |||||
* | | minor doc changes | Vijay Dev | 2011-11-26 | 1 | -3/+3 | |
| | | ||||||
* | | some tweaks to PR#3547. [Closes #3547] | Xavier Noria | 2011-11-25 | 1 | -7/+12 | |
| | | ||||||
* | | API docstrings updated with default value info | gregolsen | 2011-11-25 | 2 | -6/+6 | |
| | | ||||||
* | | beginning_of_week extended in both Time and Date so that to return week ↵ | gregolsen | 2011-11-25 | 2 | -16/+32 | |
| | | | | | | | | start based on start day that is monday by default | |||||
* | | Rely solely on active_model_serializer and remove the fancy constant lookup. | José Valim | 2011-11-23 | 1 | -0/+1 | |
| | | ||||||
* | | Implement ArraySerializer and move old serialization API to a new namespace. | José Valim | 2011-11-23 | 1 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | The following constants were renamed: ActiveModel::Serialization => ActiveModel::Serializable ActiveModel::Serializers::JSON => ActiveModel::Serializable::JSON ActiveModel::Serializers::Xml => ActiveModel::Serializable::XML The main motivation for such a change is that `ActiveModel::Serializers::JSON` was not actually a serializer, but a module that when included allows the target to be serializable to JSON. With such changes, we were able to clean up the namespace to add true serializers as the ArraySerializer. | |||||
* | | Add safe_constantize to ActiveSupport::Dependencies. | José Valim | 2011-11-23 | 1 | -13/+20 | |
| | | ||||||
* | | Merge branch 'master' into serializers | José Valim | 2011-11-23 | 20 | -207/+511 | |
|\ \ | ||||||
| * | | Optimize cache expansion by skipping rails cache id in nested keys. | José Valim | 2011-11-23 | 1 | -54/+60 | |
| | | | ||||||
| * | | Fix #3737 AS::expand_cache_key generates wrong key in certain situations ↵ | Olek Janiszewski | 2011-11-23 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | (part 2) `nil` and `false` both expand to `""` (empty string), while `true` expands to `"true"`; `false` should expand to `"false"` | |||||
| * | | Fix #3737 AS::expand_cache_key generates wrong key in certain situations | Olek Janiszewski | 2011-11-23 | 1 | -10/+4 | |
| | | | | | | | | | | | | | | | `cache_key` method is never called when the argument is a 1-element array with something that responds to `cache_key` | |||||
| * | | Merge pull request #3725 from marcandre/twz_eql | Yehuda Katz | 2011-11-22 | 2 | -2/+15 | |
| |\ \ | | | | | | | | | Fix inconsistencies with Time{WithZone}#{hash,eql?} | |||||
| | * | | Fix inconsistencies with Time{WithZone}#{hash,eql?} | Marc-Andre Lafortune | 2011-11-22 | 2 | -2/+15 | |
| | | | | ||||||
| * | | | remove nodoc on OrderedHash | Vijay Dev | 2011-11-22 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | Deprecate InstanceMethods namespace handling in ActiveSupport::Concern. | José Valim | 2011-11-21 | 1 | -10/+5 | |
| | | | | | | | | | | | | | | | | This avoids the unnecessary "yo dawg, I heard you like include, so I put a module that includes your module when it is included" approach when building extensions. | |||||
| * | | | Revert "tests predicates according to the boolean interpretation of their ↵ | Xavier Noria | 2011-11-21 | 1 | -2/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | return value, not expecting specifically true or false" Reason: there were some genuine tests for false when reading values, going to revise those ones. This reverts commit a539a5e3f3be68f027d3dfe43f88dc9f0642c743. | |||||
| * | | | tests predicates according to the boolean interpretation of their return ↵ | Xavier Noria | 2011-11-21 | 1 | -6/+2 | |
| | | | | | | | | | | | | | | | | value, not expecting specifically true or false | |||||
| * | | | cache entry: options[:compressed] is a regular flag, no need for !! | Xavier Noria | 2011-11-21 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | adds a comment to clarify an edge case | Xavier Noria | 2011-11-21 | 1 | -0/+3 | |
| | | | | ||||||
| * | | | a couple of spurious spaces I saw in passing | Xavier Noria | 2011-11-21 | 1 | -2/+2 | |
| | |/ | |/| | ||||||
| * | | Merge pull request #3668 from gregolsen/api_docstring_fix | Santiago Pastorino | 2011-11-19 | 2 | -4/+4 | |
| |\ \ | | | | | | | | | updating API docstring so that user can infer default value | |||||
| | * | | updating API docstring so that user can infer default value | gregolsen | 2011-11-17 | 2 | -4/+4 | |
| | | | | ||||||
| * | | | Fixed typo: expect -> expected | Philip Arndt | 2011-11-18 | 1 | -1/+1 | |
| |/ / | ||||||
| * | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-11-13 | 3 | -5/+5 | |
| |\ \ | ||||||
| | * | | Fix "in memory" where it should be "in-memory". | Cheah Chu Yeow | 2011-11-13 | 3 | -4/+4 | |
| | | | | ||||||
| | * | | Revert "Fix "in memory" where it should be "in-memory"." | Vijay Dev | 2011-11-11 | 3 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e34e4d43301618307f94123d3710f094297f91f3. Reason: code changes are not allowed in docrails. | |||||
| | * | | Update Memcached website to its new one at http://memcached.org/. | Cheah Chu Yeow | 2011-11-11 | 1 | -1/+1 | |
| | | | | ||||||
| | * | | Fix "in memory" where it should be "in-memory". | Cheah Chu Yeow | 2011-11-11 | 3 | -4/+4 | |
| | | | | ||||||
| * | | | AS::Callbacks::Callback#_compile_option refactored | Bogdan Gusiev | 2011-11-11 | 1 | -14/+12 | |
| | | | | ||||||
| * | | | AS::Callbacks.__run_keyed_callback: remove unused cache | Bogdan Gusiev | 2011-11-10 | 1 | -10/+6 | |
| | | | |