| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
ActiveSupport::Cache::RedisStore
Broken in 8da30ad.
|
| |
|
|
|
|
| |
[ci skip]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By making the Rails minitest behave like a standard minitest plugin
we're much more likely to not break when people use other minitest
plugins. Like minitest-focus and pride.
To do this, we need to behave like minitest: require files up front
and then perform the plugin behavior via the at_exit hook.
This also saves us a fair bit of wrangling with test file loading.
Finally, since the environment and warnings options have to be applied
as early as possible, and since minitest loads plugins at_exit, they
have to be moved to the test command.
* Don't expect the root method.
It's likely this worked because we eagerly loaded the Rails minitest plugin
and that somehow defined a root method on `Rails`.
* Assign a backtrace to failed exceptions.
Otherwise Minitest pukes when attempting to filter the backtrace (which
Rails' backtrace cleaner then removes).
Means the exception message test has to be revised too.
This is likely caused by the rails minitest plugin now being loaded for
these tests and assigning a default backtrace cleaner.
|
|
|
|
| |
Time.now` (#29681)
|
|\
| |
| | |
Update MessageEncryptor example to use dynamic key length
|
| |
| |
| |
| | |
by OpenSSL
|
|\ \
| | |
| | | |
Use frozen-string-literal in ActiveSupport
|
| | | |
|
|\ \ \
| | | |
| | | | |
Mention Time.zone.parse possibly throwing ArgumentError
|
| | | | |
|
| |/ /
|/| |
| | |
| | | |
if using prefix version.
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing
changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
|
| |\ \ \
| | | | |
| | | | |
| | | | | |
Enforce frozen string in Rubocop
|
| | | | | |
|
| |\ \ \ \
| | |_|_|/
| |/| | |
| | | | | |
Make ActiveSupport frozen-string-literal friendly.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The ActiveSupport test suite only passes currently if it uses the latest unreleased commits for dalli, and a patch for Builder:
https://github.com/tenderlove/builder/pull/6
Beyond that, all external dependencies (at least, to the extent they’re used by ActiveSupport) are happy, including Nokogiri as of 1.8.0.
|
|/ / / / |
|
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | | |
Remove useless class checking for `ActiveSupport::Callbacks`s result_lambda
|
| |/ / |
|
| | | |
|
|/ /
| |
| |
| | |
This deprecation warning message will be more useful if it indicates what the string was doing — being eval'd — and what the non-deprecated options for callback conditionals are.
|
|\ \
| | |
| | | |
Log subscriber - avoid rescuing certain exceptions
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
Follow up of #29263
|
|\ \ \
| | | |
| | | | |
Default Message Encryptor Cipher to AES-256-GCM From AES-256-CBC
|
| | | |
| | | |
| | | |
| | | | |
- Introduce a method to select default cipher, and maintain backward compatibility
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
No need to pass `#cleanup` options through to `LocalCache#clear`.
Fixes #29081. References #25628.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
See https://github.com/rails/rails/issues/29067#issuecomment-301342084
for rationale.
This reverts commit b76f82d714e590c20370e72fa36fa574c4f17650.
Fixes #29067. Fixes #29081.
|
|\ \ \ \
| | | | |
| | | | | |
Remove unreachable code
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`Time.find_zone!` raise `ArgumentError` if invalid value is specified.
https://github.com/rails/rails/blob/379a0b42daf0d8e14130db7fd886d05d8d88e3f2/activesupport/lib/active_support/core_ext/time/zones.rb#L97..L99
Therefore, the return value never becomes nil.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Rails.cache.write_multi foo: 'bar', baz: 'qux'
Plus faster `fetch_multi` with stores that implement `write_multi_entries`.
Keys that aren't found may be written to the cache store in one shot
instead of separate writes.
The default implementation simply calls `write_entry` for each entry.
Stores may override if they're capable of one-shot bulk writes, like
Redis `MSET`.
|
|\ \ \
| | | |
| | | | |
Introduce mattr_accessor default option
|
| | | | |
|
| | | | |
|
|/ / / |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Allow a default value to be declared for class_attribute
* Convert to using class_attribute default rather than explicit setter
* Removed instance_accessor option by mistake
* False is a valid default value
* Documentation
|
|\ \ \
| | | |
| | | | |
round before calculating exponent in number_to_human_converter
|
| | | |
| | | |
| | | |
| | | | |
fixes #25664
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
kamipo/remove_returning_true_in_internal_callbacks
Remove returning true in internal callbacks
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`display_deprecation_warning_for_false_terminator` was removed since
3a25cdc.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
EilisHamilton/fix_uncountable_pluralization_locale
Fix pluralization of uncountables when given a locale
|
| | |_|/ /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Previously apply_inflections would only use the :en uncountables
rather then the ones for the locale that was passed to pluralize or
singularize.
This changes apply_inflections to take a locale which it will use to
find the uncountables.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If users added an attribute or otherwise changed a CurrentAttributes subclass
they'd see exceptions on the next page load.
Because `ActiveSupport::CurrentAttributes.current_instances` would keep
references to the old instances from the previous request.
We can fix this by clearing out the `current_attributes` before we unload
constants. Then any change to the model can be autoloaded again since its
slot isn't taken by an old instance.
We'll still have to call reset before we clear so external collaborators,
like Time.zone, won't linger with their current value throughout other code.
|