Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | [Active Support] require_relative => require | Akira Matsuda | 2017-10-21 | 6 | -7/+7 |
| | | | | This basically reverts 8da30ad6be34339124ba4cb4e36aea260dda12bc | ||||
* | Fix `can't modify frozen String` error in `XmlMini_JDOM` | yuuji.yaginuma | 2017-09-01 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | Without this, `XmlMini_JDOM` raises an error as follwing: ``` RuntimeError: can't modify frozen String org/jruby/RubyString.java:2264:in `concat' activesupport/lib/active_support/xml_mini/jdom.rb:177:in `block in empty_content?' org/jruby/RubyRange.java:485:in `each' activesupport/lib/active_support/xml_mini/jdom.rb:174:in `empty_content?' activesupport/lib/active_support/xml_mini/jdom.rb:86:in `collapse' activesupport/lib/active_support/xml_mini/jdom.rb:66:in `merge_element!' activesupport/lib/active_support/xml_mini/jdom.rb:84:in `block in collapse' org/jruby/RubyRange.java:485:in `each' activesupport/lib/active_support/xml_mini/jdom.rb:82:in `collapse' activesupport/lib/active_support/xml_mini/jdom.rb:66:in `merge_element!' activesupport/lib/active_support/xml_mini/jdom.rb:51:in `parse' activesupport/lib/active_support/xml_mini.rb:101:in `parse' ``` We already have tests about `XmlMini_JDOM`. But it is not running in CI. https://github.com/rails/rails/blob/master/activesupport/test/xml_mini/jdom_engine_test.rb | ||||
* | Fix broken link for Java xml [ci skip] | Yoshiyuki Hirano | 2017-08-24 | 1 | -1/+1 |
| | |||||
* | [Active Support] `rubocop -a --only Layout/EmptyLineAfterMagicComment` | Koichi ITO | 2017-07-11 | 6 | -0/+6 |
| | |||||
* | Use frozen-string-literal in ActiveSupport | Kir Shatrov | 2017-07-09 | 6 | -0/+6 |
| | |||||
* | Merge branch 'master' into require_relative_2017 | Xavier Noria | 2017-07-02 | 5 | -6/+6 |
|\ | |||||
| * | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 6 | -6/+0 |
| | | | | | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
| * | Merge pull request #29540 from kirs/rubocop-frozen-string | Matthew Draper | 2017-07-02 | 6 | -0/+6 |
| |\ | | | | | | | | | | Enforce frozen string in Rubocop | ||||
| | * | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 6 | -0/+6 |
| | | | |||||
| * | | Make ActiveSupport frozen string literal friendly. | Pat Allan | 2017-06-20 | 5 | -6/+6 |
| |/ | | | | | | | | | | | | | The ActiveSupport test suite only passes currently if it uses the latest unreleased commits for dalli, and a patch for Builder: https://github.com/tenderlove/builder/pull/6 Beyond that, all external dependencies (at least, to the extent they’re used by ActiveSupport) are happy, including Nokogiri as of 1.8.0. | ||||
* / | [Active Support] require => require_relative | Akira Matsuda | 2017-07-01 | 6 | -7/+7 |
|/ | |||||
* | Fixes Hash.from_xml with frozen strings for all backends | Josh Nussbaum | 2017-04-20 | 4 | -13/+4 |
| | |||||
* | Avoid documenting private or external classes | Robin Dupret | 2017-02-07 | 1 | -0/+2 |
| | | | | | | | | | | | | | | | | There are a lot of monkey patches inside the code base but there's no need to document external constants so let's remove them from the documentation Also, since there are monkey patches for some test cases classes, there were sometimes both documented and sneaked under the wrong section in the sidebar. Finally, for future references, the `active_support/vendor` folder has been originally ignored in https://git.io/vDqfA but no longer exists. [ci skip] | ||||
* | `self.` is not needed when calling its own instance method | Akira Matsuda | 2017-01-05 | 2 | -2/+2 |
| | | | | Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby | ||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 4 | -4/+4 |
| | |||||
* | Fix broken comments indentation caused by rubocop auto-correct [ci skip] | Ryuta Kamizono | 2016-09-14 | 1 | -40/+40 |
| | | | | | | All indentation was normalized by rubocop auto-correct at 80e66cc4d90bf8c15d1a5f6e3152e90147f00772. But comments was still kept absolute position. This commit aligns comments with method definitions for consistency. | ||||
* | Add three new rubocop rules | Rafael Mendonça França | 2016-08-16 | 2 | -2/+2 |
| | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository. | ||||
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 4 | -15/+12 |
| | |||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -67/+67 |
| | |||||
* | applies new string literal convention in activesupport/lib | Xavier Noria | 2016-08-06 | 6 | -45/+45 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | systematic revision of =~ usage in AS | Xavier Noria | 2016-07-22 | 1 | -1/+1 |
| | | | | | Where appropriate prefer the more concise Regexp#match?, String#include?, String#start_with?, and String#end_with? | ||||
* | Fix Hash#from_xml with frozen strings (#24718) | Marek Kirejczyk | 2016-05-21 | 1 | -3/+1 |
| | | | | | | | | | * Hash#from_xml works with frozen strings Fixes #24647 * Fix rexml engine test [Marek Kirejczyk + Rafael Mendonça França] | ||||
* | enforce a depth limit on XML documents | Aaron Patterson | 2015-06-16 | 2 | -10/+12 |
| | | | | | | | XML documents that are too deep can cause an stack overflow, which in turn will cause a potential DoS attack. CVE-2015-3227 | ||||
* | Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846 | robertomiranda | 2015-01-31 | 2 | -4/+4 |
| | | | | ref: https://github.com/rails/rails/pull/18763#issuecomment-72349769 | ||||
* | fixed indent of end in jdom.rb | bigtone1284 | 2014-11-28 | 1 | -1/+1 |
| | |||||
* | change merge to merge! in AS on new hashes | Vipul A M | 2013-04-02 | 2 | -2/+2 |
| | |||||
* | JDOM XXE Protection [CVE-2013-1856] | Ben Murphy | 2013-03-15 | 1 | -0/+6 |
| | |||||
* | update AS/values and AS/xml_mini docs [ci skip] | Francesco Rodriguez | 2012-09-14 | 3 | -3/+3 |
| | |||||
* | Clean up module docs [ci skip] | Vijay Dev | 2012-03-07 | 6 | -8/+2 |
| | | | | Removed some useless docstrings and no-doc'ed some. | ||||
* | Replaced all 'for' loops with Enumerable#each | Nathan Broadbent | 2012-01-30 | 1 | -4/+4 |
| | |||||
* | Revert "Used any? instead of length call" | Xavier Noria | 2011-11-28 | 2 | -2/+2 |
| | | | | | | | | | Reason: This is slower, and any? is not equivalent in the general case. See discussion in https://github.com/rails/rails/pull/3779 This reverts commit 20cbf8eddc3844126d20f1218f068889d17b0dcf. | ||||
* | Used any? instead of length call | Rahul P. Chaudhari | 2011-11-28 | 2 | -2/+2 |
| | |||||
* | Adding __content__ into XmlMini_JDOM | Arun Agrawal | 2011-05-27 | 1 | -1/+8 |
| | |||||
* | Using java_import instead of import. Need to do this with rake 0.9.0 #jruby | Arun Agrawal | 2011-05-24 | 1 | -6/+6 |
| | |||||
* | fixed a missing require that causes trouble when using AS in a non-rails env. | Nick Sutterer | 2011-01-18 | 5 | -1/+6 |
| | |||||
* | using a merge with a Hash[] rather than a loop to add SAX parsed attributes | Aaron Patterson | 2010-11-16 | 1 | -2/+1 |
| | |||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -1/+1 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | AS gem doesn't depend on nokogiri so shows a nicer error if users haven't ↵ | Santiago Pastorino | 2010-07-30 | 2 | -3/+13 |
| | | | | installed | ||||
* | Change returning with tap | Santiago Pastorino | 2010-07-25 | 1 | -1/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | edit pass: the names of Rails components have a space, ie, "Active Record", ↵ | Xavier Noria | 2010-06-14 | 1 | -1/+1 |
| | | | | not "ActiveRecord" | ||||
* | Provide a better error if the parsed REXML document has no root [#3803 ↵ | wycats | 2010-03-28 | 1 | -1/+7 |
| | | | | state:resolved] | ||||
* | adds missing requires for Object#blank? and Object#present? | Xavier Noria | 2010-03-28 | 2 | -0/+2 |
| | |||||
* | nokogiri.rb needs active_support/core_ext/object/blank | Xavier Noria | 2010-01-01 | 1 | -0/+1 |
| | |||||
* | libxml.rb needs active_support/core_ext/object/blank | Xavier Noria | 2010-01-01 | 1 | -0/+1 |
| | |||||
* | jdom.rb needs active_support/core_ext/object/blank | Xavier Noria | 2010-01-01 | 1 | -0/+2 |
| | |||||
* | make sure returning is available for the libxml extension | Xavier Noria | 2010-01-01 | 1 | -0/+1 |
| | |||||
* | Fixed some bugs and fixed some tests in new SAX-based XmlMini backends. | Willem van Bergen | 2010-01-01 | 2 | -8/+8 |
| | | | | | | [#3636 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Added SAX-based parser for XmlMini, using LibXML | Willem van Bergen | 2010-01-01 | 1 | -0/+84 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Added SAX-based parser for XmlMini, using Nokogiri. | Willem van Bergen | 2010-01-01 | 1 | -0/+82 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Code cleanup, bugfixes and speed improvements for the Nokogiri and LibXML ↵ | Willem van Bergen | 2010-01-01 | 2 | -110/+48 |
| | | | | | | | | XmlMini backends [#3641 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> |