| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Add method_call_assertions and use them instead of Mocha | utilum | 2018-08-13 | 1 | -0/+29 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Six Mocha calls prove quite resistant to Minitestification. For example, if we replace ``` ActiveRecord::Associations::HasManyAssociation .any_instance .expects(:reader) .never ``` with `assert_not_called`, Minitest wisely raises ``` NameError: undefined method `reader' for class `ActiveRecord::Associations::HasManyAssociation' ``` as `:reader` comes from a deeply embedded abstract class, `ActiveRecord::Associations::CollectionAssociation`. This patch tackles this difficulty by adding `ActiveSupport::Testing::MethodCallAsserts#assert_called_on_instance_of` which injects a stubbed method into `klass`, and verifies the number of times it is called, similar to `assert_called`. It also adds a convenience method, `assert_not_called_on_instance_of`, mirroring `assert_not_called`. It uses the new method_call_assertions to replace the remaining Mocha calls in `ActiveRecord` tests. [utilum + bogdanvlviv + kspath] | ||||
| * | [Active Support] `rubocop -a --only Layout/EmptyLineAfterMagicComment` | Koichi ITO | 2017-07-11 | 1 | -0/+1 |
| | | |||||
| * | Use frozen-string-literal in ActiveSupport | Kir Shatrov | 2017-07-09 | 1 | -0/+1 |
| | | |||||
| * | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
| * | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | | |||||
| * | applies new string literal convention in activesupport/lib | Xavier Noria | 2016-08-06 | 1 | -1/+1 |
| | | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
| * | Cleaned up generators tests using internal assertion helper | Ronak Jangir | 2015-08-20 | 1 | -2/+4 |
| | | |||||
| * | Replacing lambda with proc getting argument error because of it. | Ronak Jangir | 2015-08-17 | 1 | -1/+1 |
| | | |||||
| * | Added helper methods to stub any instance | Ronak Jangir | 2015-08-13 | 1 | -1/+5 |
| | | |||||
| * | Add multiple expected calls to assert_called_with. | Kasper Timm Hansen | 2015-07-10 | 1 | -1/+6 |
| | | |||||
| * | Add method call assertions for internal use. | Kasper Timm Hansen | 2015-07-08 | 1 | -0/+30 |
| Add `assert_called` and `assert_not_called` to boil down the boilerplate we need to write to assert methods are called certain number of times. | |||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |