Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Missing require "active_support/number_helper/number_converter" | Akira Matsuda | 2018-10-20 | 1 | -0/+2 |
| | |||||
* | [Active Support] `rubocop -a --only Layout/EmptyLineAfterMagicComment` | Koichi ITO | 2017-07-11 | 1 | -0/+1 |
| | |||||
* | Use frozen-string-literal in ActiveSupport | Kir Shatrov | 2017-07-09 | 1 | -0/+1 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Merge pull request #29540 from kirs/rubocop-frozen-string | Matthew Draper | 2017-07-02 | 1 | -0/+1 |
|\ | | | | | | | Enforce frozen string in Rubocop | ||||
| * | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | | |||||
* | | Make ActiveSupport frozen string literal friendly. | Pat Allan | 2017-06-20 | 1 | -1/+1 |
|/ | | | | | | | The ActiveSupport test suite only passes currently if it uses the latest unreleased commits for dalli, and a patch for Builder: https://github.com/tenderlove/builder/pull/6 Beyond that, all external dependencies (at least, to the extent they’re used by ActiveSupport) are happy, including Nokogiri as of 1.8.0. | ||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 1 | -1/+1 |
| | |||||
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 1 | -1/+0 |
| | |||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -1/+0 |
| | |||||
* | `number_to_phone` formats number with regexp | Pan GaoYong | 2016-04-02 | 1 | -2/+11 |
| | | | | | | | | | | | | By default, this method formats US number. This commit extends its functionality to format number for other countries with a custom regular expression. number_to_phone(18812345678, pattern: /(\d{3})(\d{4})(\d{4})/) # => 188-1234-5678 The output phone number is divided into three groups, so the regexp should also match three groups of numbers. | ||||
* | Nodoc missing number helper classes in AS [ci skip] | Carlos Antonio da Silva | 2013-12-11 | 1 | -1/+1 |
| | | | | These classes are not meant to be public. | ||||
* | Change delimiter check order: first check if it is present | Carlos Antonio da Silva | 2013-12-03 | 1 | -3/+3 |
| | | | | | | | This reads a lot better, and we won't need to try start_with? for blank delimiters. Also rename method name to read better. | ||||
* | Make both conversion methods work similarly | Carlos Antonio da Silva | 2013-12-03 | 1 | -1/+2 |
| | | | | | The conversion without area code already changed the passed number in place, so change the other method to do the same. | ||||
* | Remove useless empty string | Carlos Antonio da Silva | 2013-12-03 | 1 | -2/+1 |
| | |||||
* | No need for #tap | Carlos Antonio da Silva | 2013-12-03 | 1 | -4/+3 |
| | |||||
* | Stop using local variables everywhere, make use of the reader | Carlos Antonio da Silva | 2013-12-03 | 1 | -1/+1 |
| | |||||
* | :sicssors: | Rafael Mendonça França | 2013-12-02 | 1 | -1/+0 |
| | |||||
* | Make load of NumberHelper thread safe | Rafael Mendonça França | 2013-12-02 | 1 | -0/+51 |