Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Enable `Layout/EmptyLinesAroundAccessModifier` cop | Ryuta Kamizono | 2019-06-13 | 1 | -1/+0 |
| | | | | | | | | | | | We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost. | ||||
* | Fix examples in ActiveSupport::LogSubscriber docs | Gannon McGibbon | 2019-01-01 | 1 | -3/+3 |
| | | | | [ci skip] | ||||
* | Add examples describing error handling in ActiveSupport::Notifications and ↵ | Mariusz Hausenplas | 2018-12-14 | 1 | -7/+30 |
| | | | | ActiveSupport::LogSubscriber documentation files | ||||
* | [Active Support] require_relative => require | Akira Matsuda | 2017-10-21 | 1 | -3/+3 |
| | | | | This basically reverts 8da30ad6be34339124ba4cb4e36aea260dda12bc | ||||
* | [Active Support] `rubocop -a --only Layout/EmptyLineAfterMagicComment` | Koichi ITO | 2017-07-11 | 1 | -0/+1 |
| | |||||
* | Use frozen-string-literal in ActiveSupport | Kir Shatrov | 2017-07-09 | 1 | -0/+1 |
| | |||||
* | [Active Support] require => require_relative | Akira Matsuda | 2017-07-01 | 1 | -3/+3 |
| | |||||
* | Merge pull request #29140 from notEthan/log_subscribed_avoid_rescuing | Rafael França | 2017-06-16 | 1 | -2/+4 |
|\ | | | | | Log subscriber - avoid rescuing certain exceptions | ||||
| * | check that logger is defined in log subscriber rescue before logging | Ethan | 2017-05-24 | 1 | -1/+3 |
| | | |||||
| * | lob subscriber should only rescue StandardError, not Exception | Ethan | 2017-05-24 | 1 | -1/+1 |
| | | |||||
* | | Use mattr_accessor default: option throughout the project | Genadi Samokovarov | 2017-06-03 | 1 | -2/+1 |
|/ | |||||
* | Privatize unneededly protected methods in Active Support | Akira Matsuda | 2016-12-24 | 1 | -2/+2 |
| | |||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 1 | -1/+1 |
| | |||||
* | applies new string literal convention in activesupport/lib | Xavier Noria | 2016-08-06 | 1 | -3/+3 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Improve sql logging coloration in `ActiveRecord::LogSubscriber`. | Peter Boling | 2015-07-17 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | - Improves coloring for statements like: # Become WHITE SELECT * FROM ( SELECT * FROM mytable FOR UPDATE ) ss WHERE col1 = 5; LOCK TABLE table_name IN ACCESS EXCLUSIVE MODE; # Becomes RED ROLLBACK - Reinstates the coloration of the `payload[:name]`. Instead of simple alternating colors, adds meaning: - `MAGENTA` for `"SQL"` or `blank?` payload names - `CYAN` for Model Load/Exists - Introduces specs for sql coloration. - Introduces specs for payload name coloration. GH#20885 | ||||
* | Extract a base class from ActiveSupport::LogSubscriber | Daniel Schierbeck | 2013-04-16 | 1 | -43/+7 |
| | | | | | | Adds a ActiveSupport::Subscriber base class that LogSubscriber inherits from. By inheriting from Subscriber, other kinds of subscribers can take advantage of the event attachment system. | ||||
* | Fix some railties test warnings | Vipul A M | 2013-04-03 | 1 | -3/+2 |
| | |||||
* | adding missing requires | Aaron Patterson | 2013-01-09 | 1 | -1/+3 |
| | |||||
* | update AS docs [ci skip] | Francesco Rodriguez | 2012-09-17 | 1 | -11/+13 |
| | |||||
* | logger is a singleton, just flush the singleton | Aaron Patterson | 2012-06-20 | 1 | -11/+1 |
| | |||||
* | use thread local queues. | Aaron Patterson | 2012-06-20 | 1 | -4/+10 |
| | | | | | Log listener is a singleton shared across threads, so make sure the event queues are local to each thread. | ||||
* | Correct the AP test。 | タコ焼き仮面 | 2012-06-19 | 1 | -0/+1 |
| | |||||
* | make logger a singleton on the class | Aaron Patterson | 2012-06-19 | 1 | -3/+7 |
| | |||||
* | listeners are per thread, so remove nested hash | Aaron Patterson | 2012-06-19 | 1 | -6/+4 |
| | |||||
* | make events not use date and time to determine parent_of. fixes #5932 | タコ焼き仮面 | 2012-06-18 | 1 | -6/+27 |
| | |||||
* | Avoid unnecessary catching of Exception instead of StandardError. | Dylan Smith | 2012-06-17 | 1 | -1/+1 |
| | |||||
* | Symbol responds_to :upcase & :downcase in Ruby >= 1.9 | Akira Matsuda | 2012-06-06 | 1 | -1/+1 |
| | |||||
* | stop `to_s`ing method names | Akira Matsuda | 2012-06-06 | 1 | -1/+1 |
| | | | | Module#methods are Symbols in Ruby >= 1.9 | ||||
* | Remove deprecation from AS::Deprecation behavior, some minor cleanups | Carlos Antonio da Silva | 2012-03-16 | 1 | -4/+4 |
| | | | | | | | | | * Refactor log subscriber, use select! to avoid a new object * Remove deprecation messages related to AS::Deprecation behavior This was added about 2 years ago for Rails 3: https://github.com/rails/rails/commit/d4c7d3fd94e5a885a6366eaeb3b908bb58ffd4db * Remove some not used requires * Refactor delegate to avoid string conversions and if statements inside each block | ||||
* | defined the actual logger signature | Aaron Patterson | 2012-01-20 | 1 | -2/+2 |
| | |||||
* | added the backtrace so errors can be found | Aaron Patterson | 2012-01-20 | 1 | -1/+1 |
| | |||||
* | grammar changes to log subscriber docs | Matt Jankowski | 2011-06-22 | 1 | -4/+4 |
| | |||||
* | simplifying buffered logger for easier and slightly more performant codes. ↵ | Aaron Patterson | 2011-04-26 | 1 | -1/+1 |
| | | | | pumpkin | ||||
* | more style changes | suchasurge | 2011-03-06 | 1 | -1/+1 |
| | |||||
* | Makes use of class << self instead of def self. | Santiago Pastorino | 2010-08-15 | 1 | -32/+31 |
| | |||||
* | Whitespace and example identation | Josep M. Bach | 2010-08-15 | 1 | -2/+2 |
| | |||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -1/+1 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | fixing typo | Neeraj Singh | 2010-07-23 | 1 | -1/+1 |
| | |||||
* | avoid proc activation every time a log message is made | Aaron Patterson | 2010-07-18 | 1 | -9/+14 |
| | |||||
* | Remove previously defined class method logger to supress warnings in Active ↵ | rohit | 2010-06-26 | 1 | -0/+4 |
| | | | | | | Support test suites. [#4618 state:open] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing ↵ | José Valim | 2010-06-24 | 1 | -0/+114 |
frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved] |