rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
*	[Active Support] require => require_relative	Akira Matsuda	2017-07-01	2	-3/+3
\|
*	🙈 :nodoc: `AS::Duration::ISO8601Serializer`	Godfrey Chan	2017-02-23	1	-1/+1
\| \| \|	This class should not be used directly, the public API is `AS::Duration#iso8601`.
*	Less method invocation	Akira Matsuda	2016-11-05	1	-1/+1
\|
*	Add more rubocop rules about whitespaces	Rafael Mendonça França	2016-10-29	1	-1/+1
\|
*	Fix broken comments indentation caused by rubocop auto-correct [ci skip]	Ryuta Kamizono	2016-09-14	1	-2/+2
\| \| \| \| \| \|	All indentation was normalized by rubocop auto-correct at 80e66cc4d90bf8c15d1a5f6e3152e90147f00772. But comments was still kept absolute position. This commit aligns comments with method definitions for consistency.
*	applies remaining conventions across the project	Xavier Noria	2016-08-06	1	-30/+30
\|
*	normalizes indentation and whitespace across the project	Xavier Noria	2016-08-06	1	-28/+28
\|
*	applies new string literal convention in activesupport/lib	Xavier Noria	2016-08-06	2	-17/+17
\| \| \| \| \|	The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
*	systematic revision of =~ usage in AS	Xavier Noria	2016-07-22	1	-1/+2
\| \| \| \| \|	Where appropriate prefer the more concise Regexp#match?, String#include?, String#start_with?, and String#end_with?
*	AS::Duration should serialize empty values correctly. (#25656)	Paul Sadauskas	2016-07-11	1	-1/+3
\| \| \| \| \| \| \| \| \| \| \| \| \|	The current implementation serializes zero-length durations incorrectly (it serializes as `"-P"`), and cannot un-serialize itself: ``` [1] pry(main)> ActiveSupport::Duration.parse(0.minutes.iso8601) ActiveSupport::Duration::ISO8601Parser::ParsingError: Invalid ISO 8601 duration: "-P" is empty duration from /Users/rando/.gem/ruby/2.3.1/gems/activesupport-5.0.0/lib/active_support/duration/iso8601_parser.rb:96:in `raise_parsing_error' ``` Postgres empty intervals are serialized as `"PT0S"`, which is also parseable by the Duration deserializer, so I've modified the `ISO8601Serializer` to do the same. Additionally, the `#normalize` function returned a negative sign if `parts` was blank (all zero). Even though this fix does not rely on the sign, I've gone ahead and corrected that, too, in case a future refactoring of `#serialize` uses it.
*	`ActiveSupport::Duration` supports ISO8601 formatting and parsing.	Arnau Siches, Andrey Novikov	2016-04-18	2	-0/+173
	```ruby ActiveSupport::Duration.parse('P3Y6M4DT12H30M5S') (3.years + 3.days).iso8601 ``` Inspired by Arnau Siches' [ISO8601 gem](https://github.com/arnau/ISO8601/) and rewritten by Andrey Novikov with suggestions from Andrew White. Test data from the ISO8601 gem redistributed under MIT license. (Will be used to support the PostgreSQL interval data type.)