| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Make `String#remove` and `String#remove!` accept multiple arguments
Conflicts:
activesupport/CHANGELOG.md
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This patch uniformizes warning messages. I used the most common style
already present in the code base:
* Capitalize the first word.
* End the message with a full stop.
* "Rails 5" instead of "Rails 5.0".
* Backticks for method names and inline code.
Also, converted a few long strings into the new heredoc convention.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
@carlosantoniodasilva pointed out that when `@person` is nil then this would blow up when you ended up calling `#first`on `nil`.
> "there’s no way to break a try chain when you enter it :D"
[ci skip]
|
| | |
|
|/
|
|
|
|
|
|
|
|
| |
- better `if` example
- Added chaining example to the try method description
- Documented the `respond_to?` check to the try method description
- Clearer wording to explain that argument error is raised on argument mismatch to responding method, rather than to non-responding method (which is handled without exception by `try`)
- `.any?` is more precise than `! .blank?`
- Don't need to use `try` on `children` as (for regular associations) they will always be a collection or array that responds to `first`
- Fix typos/grammar
|
| |
|
|
|
|
| |
Based on commit 5e51bdda.
|
|
|
|
| |
options and original options have same keys
|
|
|
| |
atomic_write rescue also Errno::EACCES on changing file permission. It could be raised with some type of filesystem
|
| |
|
|
|
|
| |
Fixes #16956.
|
|
|
|
|
|
|
| |
1. spacing issues
2. spelling correction
3. grammar correction
4. Add missing docs
|
|
|
|
|
| |
Ruby 2.2 knows this, and no longer matches it with [[:space:]], so it's
not a good candidate for testing String#squish.
|
|
|
|
| |
Closes #16392.
|
|
|
|
|
|
|
|
|
|
| |
https://github.com/rails/rails/commit/98b46bf5e201307cae56ee14bf41363a539779c5
did not properly handled out-of-range `:usec`s.
Passing a `:usec` that's out of range now throws an `ArgumentError` as it
should.
Fixes #16759.
|
| |
|
|
|
|
| |
just needed some tenderloving instance_eval to fit the bill
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Also moved comment for removal above `unless()` to not confuse RDoc with
the documentation for this method.
|
|
|
|
| |
Fixes #16406
|
| |
|
| |
|
|
|
|
|
|
|
| |
Ruby 2.2 will include Kernel#itself so we don't need to define again.
See
https://github.com/ruby/ruby/commit/0a0160d6b659f6131a525fe1579e7c463d4c197e
|
|
|
|
| |
method name for Ruby 2.2
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This is more consistent than the current behaviour of raising a
`ZeroDivisionError: divided by 0` error when 0 is given, which can be
non-obvious especially if `in_groups_of` is part of a longer chain of
methods.
The negative case was ok - "ArgumentError: invalid slice size" - but
this error is clearer still.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
`Time#as_json`, `Date#as_json` and `DateTime#as_json` incorrectly depends on a
delegation that is set up in `active_support/json/encoding`. We cannot simply
require that file in `core_ext/object/json` because it would cause a circular
dependency problem (see #12203 for background). We should instead rely on AS's
autoload to load that file for us on-demand.
To trigger autoload correctly, we need to reference the `AS::JSON::Encoding`
constant instead of using the delegated version.
Fixes #16131.
|
|\
| |
| | |
Define Hash#to_query and set Hash#to_param as alias to it; with test cases
|
| | |
|
|\ \
| | |
| | |
| | | |
Word truncation
|
|/ / |
|
| |
| |
| |
| |
| | |
These methods are not random so they should not belings to SecureRandom
module.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
(This is a manual merge of #9102)
|
| |
| |
| |
| |
| |
| |
| | |
Previously this method always returns `.0` in the fractional part. This commit
changes it to preserve the fractional seconds instead.
Fixes #15994.
|
| |
| |
| |
| |
| | |
Didn't get a chance to convert existing code, I'll skim through the code
base to make use of this later this afternoon.
|
| |
| |
| |
| |
| |
| |
| | |
These methods shouldn't be added to `SecureRandom`, as they are neither secure nor random. The more appropriate place for this seems to be `Digest`, so we should move them there. (Pull request welcomed!)
Marking this `:nodoc:` for now, so we don't accidentally ship it as public API.
See https://github.com/rails/rails/pull/15306/files#r13055862 for details.
|
| | |
|