aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/lib/active_support/core_ext
Commit message (Collapse)AuthorAgeFilesLines
* Return sized enumerator from Enumerable#index_byMarc-Andre Lafortune2014-02-051-1/+1
|
* Return sized enumerator from Batches#find_eachMarc-Andre Lafortune2014-02-051-1/+1
|
* Fix isolated testsRafael Mendonça França2014-02-011-0/+1
|
* Remove BigDecimal#to_dDavid Celis2014-02-011-7/+0
| | | | | | This was backported for Ruby 1.8 support and is no longer needed. Signed-off-by: David Celis <me@davidcel.is>
* Don't require BigDecimal serialization extensionDavid Celis2014-02-012-8/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails currently provides an extension to BigDecimal that redefines how it is serialized to YAML. However, as noted in #12467, this does not work as expected. When ActiveSupport is required, BigDecimal YAML serialization does not maintain the object type. It instead ends up serializing the number represented by the BigDecimal itself which, when loaded by YAML later, becomes a Float: ```ruby require 'yaml' require 'bigdecimal' yaml = BigDecimal('13.37').to_yaml YAML.load(yaml).class require 'active_support/all' yaml = BigDecimal('13.37').to_yaml YAML.load(yaml).class ``` @tenderlove posits that we should deprecate the custom BigDecimal serialization and let Ruby handle it. For the time being, users who require this serialization for backwards compatibility can manually `require 'active_support/core_ext/big_decimal/yaml_conversions'`. This will close #12467 and deprecate the custom BigDecimal#to_yaml. Signed-off-by: David Celis <me@davidcel.is>
* fix typo and indent. [ci skip]Yves Senn2014-01-301-1/+1
|
* Add support for JSON time_precision to Time and DateTimeAndrew White2014-01-261-4/+4
|
* define the delegate methods on one line. fixes #13724Aaron Patterson2014-01-161-20/+22
| | | | sup haters
* Revert "methods are defined right after the module_eval, so we don't need to do"Piotr Sarnacki2014-01-161-2/+2
| | | | | | | | | This change breaks tests in activesupport/test/core_ext/module_test.rb: * test_delegation_exception_backtrace * test_delegation_exception_backtrace_with_allow_nil This reverts commit 0167765e3f84260522bc2f32d926c1f5dd44957c.
* methods are defined right after the module_eval, so we don't need to doAaron Patterson2014-01-151-2/+2
| | | | any line number maths
* Merge pull request #13709 from akshay-vishnoi/typoYves Senn2014-01-141-1/+1
|\ | | | | [ci skip] Grammar correction
| * [ci skip] Grammar correctionAkshay Vishnoi2014-01-141-1/+1
| |
* | Merge pull request #13646 from jenseng/json_escapeGodfrey Chan2014-01-121-12/+12
|\ \ | | | | | | Clarify behavior of json_escape [ci skip]
| * | Clarify behavior of json_escape, update examplesJon Jensen2014-01-091-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | The behavior of json_escape was fixed in 2f1c5789, but the doc changes and example in that commit incorrectly indicated that the return value would be html-safe. Since quotation marks are preserved, the raw value is not safe to use in other contexts (specifically HTML attributes).
* | | Merge pull request #13668 from prathamesh-sonpatki/issue-13667Andrew White2014-01-121-2/+1
|\ \ \ | | | | | | | | Fix iterating over DateTime by doing strict checking for Time objects
| * | | Fix iterating over DateTime by doing strict checking for Time objectsPrathamesh Sonpatki2014-01-111-2/+1
| |/ / | | | | | | | | | - Fixes #13667
* / / Check `respond_to` before delegation due to: ↵Aaron Patterson2014-01-091-1/+5
|/ / | | | | | | https://github.com/ruby/ruby/commit/d781caaf313b8649948c107bba277e5ad7307314
* | Adding Hash#compact and Hash#compact! methodstinogomes2014-01-092-0/+21
| | | | | | | | | | | | | | | | | | | | | | * Adding Hash#compact and Hash#compact! methods * Using Ruby 1.9 syntax on documentation * Updating guides for `Hash#compact` and `Hash#compact!` methods * Updating CHANGELOG for ActiveSupport * Removing unecessary protected method and lambda for `Hash#compact` implementations * Performing `Hash#compact` implementation - https://gist.github.com/tinogomes/8332883 * fixing order position * Fixing typo
* | Revert "Speedup String#to"Yves Senn2014-01-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2ef1fb2c455ca53a0c1e1768f50824926ce28bd3. As described in PR #13627 this commit broke functionality when passing a negative Fixnum to the `String#to` method: ```ruby assert_equal "hell", s.to(-2) ``` Before the revert, this failed with: ``` 1) Failure: StringAccessTest#test_#to_with_negative_Fixnum,_position_is_counted_from_the_end [test/core_ext/string_ext_test.rb:275]: Expected: "hell" Actual: nil ``` This revert is to keep the functionality on `master` working. If there is another way to get the performance benefit and keep the documented functionality we can add that. /cc @amatsuda @carlosantoniodasilva
* | Merge pull request #10634 from teleological/time_advance_gregorianAndrew White2014-01-051-4/+6
|\ \ | | | | | | Maintain proleptic gregorian in Time#advance
| * | Maintain proleptic gregorian in Time#advanceRiley Lynch2013-05-151-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Time#advance uses Time#to_date and Date#advance to calculate a new date. The Date object returned by Time#to_date is constructed with the assumption that the Time object represents a proleptic gregorian date, but it is configured to observe the default julian calendar reform date (2299161j) for purposes of calculating month, date and year: Time.new(1582, 10, 4).to_date.to_s # => "1582-09-24" Time.new(1582, 10, 4).to_date.gregorian.to_s # => "1582-10-04" This patch ensures that when the intermediate Date object is advanced to yield a new Date object, that the Time object for return is contructed with a proleptic gregorian month, date and year.
* | | Avoid raising a NameError on FreeBSD using DateRobin Dupret2014-01-011-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Date object has a xmlschema method starting with Ruby 1.9 so we were assuming that we could safely remove this method and redefine it later but the call to remove_method throws a NameError on FreeBSD so we should rely on remove_possible_method instead. This call is actually needed to avoid warnings when running the test suite. Fixes #11723
* | | blank? and present? commit to return singletons [Xavier Noria & Pavel Pravosud]Xavier Noria2013-12-281-18/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The contract of blank? and present? was in principle to return Object, as we generally do, the test suite and description was consistent with that, but some examples had comments like "# => true". This cannot be unclear, we either fix the examples, or update the contract. Since users may be already assuming singletons due to the examples and the fact that they were returned before 30ba7ee, the safest option seems to be to revise the contract and the implementation of String#blank? The motivation for 30ba7ee was to improve the performance of the predicate, the refactor based on === is on par regarding speed. With this commit we start documenting return types using YARD conventions. We plan to document return types gradually.
* | | Extracted blank matcher regexp to constantPaul Nikitochkin2013-12-281-1/+3
| | |
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-12-202-7/+7
|\ \ \
| * | | fixed typo mistake time_formats.rb -> date_formats.rb [ci skip]Kuldeep Aggarwal2013-12-101-1/+1
| | | |
| * | | Typos. return -> returns. [ci skip]Lauro Caetano2013-12-032-7/+7
| | | |
* | | | Prevent creation of instance methods when `instance_reader = false`, Grammar ↵Akshay Vishnoi2013-12-191-8/+9
| | | | | | | | | | | | | | | | checks, Conditional statements combined
* | | | Merge pull request #13400 from nishant-cyro/docsGuillermo Iguaran2013-12-181-1/+1
|\ \ \ \ | | | | | | | | | | fix typos and grammar mistake [ci skip]
| * | | | fix typos and grammar mistake [ci skip]nishant-cyro2013-12-191-1/+1
| | | | |
* | | | | concern doesn't include the module automaticallyRafael Mendonça França2013-12-171-1/+0
| | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | Introduce Module#concerningJeremy Kemper2013-12-172-0/+137
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A natural, low-ceremony way to separate responsibilities within a class. Imported from https://github.com/37signals/concerning#readme
* | | | | Merge pull request #13321 from mezis/fix-safebuffer-interpolation-masterJeremy Kemper2013-12-161-7/+12
|\ \ \ \ \ | |_|_|_|/ |/| | | | Fixes interpolation on SafeBuffer
| * | | | Fixes interpolation on SafeBufferJulien Letessier2013-12-141-7/+12
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Interpolation was untested and did not work with hash arguments. Adds - support for interpolation with hash argument - tests for the above - tests for safe/unsafe interpolation
* / / / Spelling and Grammar check [ci skip]Akshay Vishnoi2013-12-161-2/+2
|/ / /
* | | doc: date/conversions.rb should talk about date format not time format.Yves Senn2013-12-101-2/+2
| | | | | | | | | | | | | | | | | | Closes #13245. [ci skip]
* | | Fix issue with Kernel#silence_stream leaking file descriptorsMario Visic2013-12-061-0/+1
| | | | | | | | | | | | | | | | | | | | | Calling Kernel#silence_stream creates a new file descriptor which isn't closed after it is used. As a result calling silence_stream multiple times leads to a build up of loose file descriptors and can cause issues in environments where garbage collection isn't run often.
* | | Review json_escape docs [ci skip]Carlos Antonio da Silva2013-12-041-22/+22
| | |
* | | Also move html_esacpe regex to a constant (see 9d25af60)Godfrey Chan2013-12-041-1/+2
| | |
* | | Added \u2028 \u2029 to json_escapeGodfrey Chan2013-12-041-5/+7
| | |
* | | Use lower case letters in unicodes sequences to match the new encoder's outputGodfrey Chan2013-12-041-1/+1
| | |
* | | Fixed a long-standing bug in `json_escape` that strips quotation marksGodfrey Chan2013-12-041-12/+49
| | |
* | | Added Date#all_week/month/quarter/year for generating date rangesDimko2013-12-032-21/+21
| | |
* | | Tidy up previous commit, fix message assertion and improve testsCarlos Antonio da Silva2013-12-031-1/+3
| | |
* | | Modify the Hash#assert_valid_keys error message so that it shows the valid ↵Nerian2013-12-031-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | keys. Also, show the wrong value as it was entered. { :failore => "stuff", :funny => "business" }.assert_valid_keys([ :failure, :funny ]) => ArgumentError: Unknown key: failore { 'failore' => "stuff", :funny => "business" }.assert_valid_keys([ :failure, :funny ]) => ArgumentError: Unknown key: failore { 'failore' => "stuff", :funny => "business" }.assert_valid_keys([ :failure, :funny ]) => ArgumentError: Unknown key: "failore". Valid keys are: :failure, :funny { :failore => "stuff", :funny => "business" }.assert_valid_keys([ :failure, :funny ]) => ArgumentError: Unknown key: :failore. Valid keys are: :failure, :funny Conflicts: activerecord/CHANGELOG.md Closes #11624.
* | | Avoid generating more strings while iterating to create methodsCarlos Antonio da Silva2013-12-021-1/+1
| | | | | | | | | | | | | | | Use the already existing strings instead of creating a new one each time just to test if it responds to the methods.
* | | Unify cattr and mattr accessors declarationsGenadi Samokovarov2013-12-023-195/+165
| | |
* | | Merge pull request #13111 from akshay-vishnoi/typoCarlos Antonio da Silva2013-11-301-2/+2
|\ \ \ | | | | | | | | Typo fixes [ci skip]
| * | | Typo fixes [ci skip]Akshay Vishnoi2013-11-301-2/+2
| | | |
* | | | Improve Module#delegate documentation to tell that delegate don't work with ↵Lauro Caetano2013-11-291-0/+2
|/ / / | | | | | | | | | private or protected methods. [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-16 03:03:51 +0000