| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | e4e1b62 broke `to_param` handling: | Edouard CHIN | 2018-07-12 | 1 | -2/+5 |
| | | | | | | | | | | | | | | | | | | | | - There was an issue inside controller tests where order params were not respected, the reason was because we were calling `Hash#to_query` which sorts the results lexicographically. 1e4e1b62 fixed that issue by not using `to_query` but instead a utility function provided by rack. - However with the fix came another issue where it's now no longer possible to do this ``` post :foo, params: { user: User.first } # Prior to the patch the controller will receive { "user" => "1" } # Whereas now you get { "user": "#<User: ...>" } ``` The fix in this PR is to modify `Hash#to_query` to sort only when it doesn't contain an array structure that looks something like "bar[]" Ref https://github.com/rails/rails/pull/33341#issuecomment-404039396 | ||||
| * | [Active Support] `rubocop -a --only Layout/EmptyLineAfterMagicComment` | Koichi ITO | 2017-07-11 | 1 | -0/+1 |
| | | |||||
| * | Use frozen-string-literal in ActiveSupport | Kir Shatrov | 2017-07-09 | 1 | -0/+1 |
| | | |||||
| * | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
| * | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | | |||||
| * | applies new string literal convention in activesupport/lib | Xavier Noria | 2016-08-06 | 1 | -4/+4 |
| | | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
| * | Pass symbol as an argument instead of a block | Erik Michaels-Ober | 2014-11-29 | 1 | -1/+1 |
| | | |||||
| * | Move to_param to to_query, also Improve tests | Akshay Vishnoi | 2014-06-20 | 1 | -6/+58 |
| | | |||||
| * | Do not check defined?(CGI) on every call #to_query | printercu | 2014-05-13 | 1 | -1/+1 |
| | | |||||
| * | Fix to_query with empty arrays too | Rafael Mendonça França | 2014-02-06 | 1 | -1/+6 |
| | | |||||
| * | Fix Hash#to_query edge case with html_safe string on 1.8 ruby | brainopia | 2011-09-16 | 1 | -1/+1 |
| | | |||||
| * | Revert "Quick fix for not escaping []s (not ideal)" | Santiago Pastorino | 2010-11-18 | 1 | -2/+2 |
| | | | | | | | | | | According to http://www.ietf.org/rfc/rfc2616.txt and http://tools.ietf.org/rfc/rfc3986.txt [ and ] are reserved characters and should be escaped using "%" HEX HEX This reverts commit 856d2fd874d72dd9f83204affff4edfef3308361 and 1ee9b40b18a0bed5bb10a0785f7e2730bac983f6.. | ||||
| * | Quick fix for not escaping []s (not ideal) | Joshua Peek | 2009-12-02 | 1 | -1/+1 |
| | | |||||
| * | Failing tests for to_param/to_query not escaping "[]" | Joshua Peek | 2009-12-02 | 1 | -1/+1 |
| | | |||||
| * | Consolidate Object#to_param and #to_query core extensions | Jeremy Kemper | 2009-11-02 | 1 | -0/+27 |
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |