| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Revert 88d08f2ec9f89ba431cba8d0c06ac9ebc204bbbb | Rafael Mendonça França | 2015-02-11 | 1 | -12/+24 |
| | | | | | | | | This caused a performance regression since we were decided to do the nil check in run time not in the load time. See https://github.com/rails/rails/pull/15187#issuecomment-71760058 | ||||
| * | English fix [ci skip] | George Millo | 2014-12-12 | 1 | -1/+1 |
| | | |||||
| * | Delegation works with reserved words passed to `:to` | Agis- | 2014-09-19 | 1 | -1/+9 |
| | | | | | Fixes #16956. | ||||
| * | Fix confusing exception in ActiveSupport delegation | Vladimir Yarotsky | 2014-05-20 | 1 | -25/+13 |
| | | |||||
| * | define the delegate methods on one line. fixes #13724 | Aaron Patterson | 2014-01-16 | 1 | -20/+22 |
| | | | | | sup haters | ||||
| * | Revert "methods are defined right after the module_eval, so we don't need to do" | Piotr Sarnacki | 2014-01-16 | 1 | -2/+2 |
| | | | | | | | | | | This change breaks tests in activesupport/test/core_ext/module_test.rb: * test_delegation_exception_backtrace * test_delegation_exception_backtrace_with_allow_nil This reverts commit 0167765e3f84260522bc2f32d926c1f5dd44957c. | ||||
| * | methods are defined right after the module_eval, so we don't need to do | Aaron Patterson | 2014-01-15 | 1 | -2/+2 |
| | | | | | any line number maths | ||||
| * | Improve Module#delegate documentation to tell that delegate don't work with ↵ | Lauro Caetano | 2013-11-29 | 1 | -0/+2 |
| | | | | | private or protected methods. [ci skip] | ||||
| * | Rely on NoMethodError#name when deciding to raise DelegationError. | Federico Ravasio | 2013-08-12 | 1 | -2/+1 |
| | | | | | | | | | | | Different Ruby implementations present backtraces differently, as it should be an information consumed by humans. A better implementation should use data from the error, in this case returned by NoMethodError#name. Fixes issues with Rubinius, which presents backtraces differently from MRI. | ||||
| * | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2013-07-21 | 1 | -0/+5 |
| |\ | |||||
| | * | Enhancing readability of options for delegate method | Thiago Pinto | 2013-07-16 | 1 | -0/+5 |
| | | | |||||
| * | | Only raise DelegationError if it's is the source of the exception | Andrew White | 2013-07-11 | 1 | -10/+11 |
| |/ | | | | | | | | | This fixes situations where nested NoMethodError exceptions are masked by delegations. This would cause confusion especially where there was a problem in the Rails booting process because of a delegation in the routes reloading code. Fixes #10559 | ||||
| * | Move delegation error constant to inside Module | Carlos Antonio da Silva | 2013-06-26 | 1 | -2/+4 |
| | | |||||
| * | Merge pull request #10828 from southpolesteve/delegation_error_class | Yves Senn | 2013-06-26 | 1 | -1/+3 |
| |\ | | | | | Create DelegationError class | ||||
| | * | Add DelegationError class. Rasied by delegation to a nil object | Steve Faulkner | 2013-06-26 | 1 | -1/+3 |
| | | | |||||
| * | | Fix some typos | Vipul A M | 2013-06-07 | 1 | -1/+1 |
| |/ | |||||
| * | Use new hash syntax in module delegation docs [ci skip] | Carlos Antonio da Silva | 2013-04-28 | 1 | -1/+1 |
| | | |||||
| * | Module#delegate checks nilness rather that falsehood if :allow_nil is true, ↵ | Xavier Noria | 2013-04-26 | 1 | -30/+42 |
| | | | | | | | | | | | | | | | and avoids multiple evaluation of the target method Notes: 1) I hope nilness is a word. 2) See rationale for avoiding multiple evaluation in a comment in the patch, credit goes to @jeremy for pointing out this gotcha in the existing implementation. 3) Embeds a little joke dedicated to @pixeltrix (it could be worse! :D). References #10347. | ||||
| * | Delegation method bug | Li Ellis Gallardo | 2013-04-25 | 1 | -0/+14 |
| | | | | | | | Add documentation and test to delegation method that make sure we're aware that when a delegated object is not nil or false and doesn't respond to the method it will still raise a NoMethodError exception. | ||||
| * | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-09-21 | 1 | -1/+0 |
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: actionmailer/lib/action_mailer/base.rb activesupport/lib/active_support/configurable.rb activesupport/lib/active_support/core_ext/module/deprecation.rb guides/source/action_controller_overview.md guides/source/active_support_core_extensions.md guides/source/ajax_on_rails.textile guides/source/association_basics.textile guides/source/upgrading_ruby_on_rails.md While resolving conflicts, I have chosen to ignore changes done in docrails at some places - these will be most likely 1.9 hash syntax changes. | ||||
| | * | update some AS code examples to 1.9 hash syntax [ci skip] | Francesco Rodriguez | 2012-09-12 | 1 | -10/+9 |
| | | | |||||
| * | | Update delegate docs with new hash syntax [ci skip] | Carlos Antonio da Silva | 2012-09-20 | 1 | -10/+10 |
| | | | |||||
| * | | Add changelog entry and docs about class delegation using the symbol :class | Carlos Antonio da Silva | 2012-09-20 | 1 | -0/+12 |
| | | | | | | | | | See #7613. [ci skip] | ||||
| * | | Nice and easy delegation to the class | Marc-Andre Lafortune | 2012-09-11 | 1 | -0/+3 |
| |/ | |||||
| * | no need to to_s here. Both String and Symbol can be interpolated into String | Akira Matsuda | 2012-06-06 | 1 | -3/+0 |
| | | |||||
| * | String quotes and trailing spaces | Alexey Gaziev | 2012-04-29 | 1 | -8/+8 |
| | | |||||
| * | AS core_ext refactoring pt.2 | Alexey Gaziev | 2012-04-29 | 1 | -1/+1 |
| | | |||||
| * | Remove Module#delegate! | Daniel Schierbeck | 2012-04-12 | 1 | -52/+0 |
| | | |||||
| * | Add back the old `deprecate` method as `deprecate!` | Daniel Schierbeck | 2012-04-12 | 1 | -0/+52 |
| | | |||||
| * | Change API docs regarding delegation to non-public methods | Daniel Schierbeck | 2012-04-12 | 1 | -1/+1 |
| | | |||||
| * | Optimize the performance of #delegate | Daniel Schierbeck | 2012-04-12 | 1 | -9/+13 |
| | | | | | | | Remove the use of #__send__ in order to boost performance. This also means that you can no longer delegate to private methods on the target object. | ||||
| * | Remove deprecation from AS::Deprecation behavior, some minor cleanups | Carlos Antonio da Silva | 2012-03-16 | 1 | -7/+9 |
| | | | | | | | | | | * Refactor log subscriber, use select! to avoid a new object * Remove deprecation messages related to AS::Deprecation behavior This was added about 2 years ago for Rails 3: https://github.com/rails/rails/commit/d4c7d3fd94e5a885a6366eaeb3b908bb58ffd4db * Remove some not used requires * Refactor delegate to avoid string conversions and if statements inside each block | ||||
| * | Fix indentation in code example of Delegation | Tomasz Zurkowski | 2012-01-20 | 1 | -19/+19 |
| | | |||||
| * | Revert all the stuff to do with disallowing non-public methods for ↵ | Jon Leighton | 2011-08-25 | 1 | -6/+2 |
| | | | | | Module#delegate | ||||
| * | prefer ends_with? over slicing | Xavier Noria | 2011-08-16 | 1 | -1/+2 |
| | | |||||
| * | Add a test for delegating a method ending in '=' as this is a special case. | Jon Leighton | 2011-08-15 | 1 | -0/+1 |
| | | |||||
| * | Need to include public_send | Arun Agrawal | 2011-08-15 | 1 | -0/+1 |
| | | |||||
| * | Split up the definitions in Module#delegate depending on :allow_nil, and ↵ | Jon Leighton | 2011-08-15 | 1 | -17/+22 |
| | | | | | don't use exceptions for flow control in the :allow_nil => true case. | ||||
| * | Fix the line number in the backtrace when Module#delegate raises | Jon Leighton | 2011-08-15 | 1 | -1/+1 |
| | | |||||
| * | Just do the method call directly in Module#delegate, if we can (we cannot ↵ | Jon Leighton | 2011-08-15 | 1 | -1/+4 |
| | | | | | for method names ending in '='). Two reasons: 1) it's faster, see https://gist.github.com/1089783 and 2) more importantly, delegate should not allow you to accidentally call private or protected methods. | ||||
| * | Refactored to more closely resemble idiom applied for on_nil | Evan Light | 2011-08-05 | 1 | -5/+11 |
| | | |||||
| * | Remove unnecessary require (happened after fcbde454f6) | Dmitriy Kiriyenko | 2011-08-01 | 1 | -2/+0 |
| | | |||||
| * | Don't do remove_possible_method when delegate is used. Two reasons: 1) ↵ | Jon Leighton | 2011-07-18 | 1 | -4/+0 |
| | | | | | warnings should be shown, and fixed at the source and 2) the code is slow. Fixes #1937. | ||||
| * | Simplify boolean logic into ternary. | Ben Orenstein | 2011-06-08 | 1 | -1/+1 |
| | | |||||
| * | delegate method should treat :prefix => false same as :prefix => nil | Neeraj Singh | 2010-09-01 | 1 | -1/+1 |
| | | | | | | | [#5375 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | fisting stack trace [#4349 state:resolved] | Aaron Patterson | 2010-04-08 | 1 | -1/+1 |
| | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
| * | Merge branch 'master' into docrails | wycats | 2010-03-26 | 1 | -1/+7 |
| |\ | |||||
| | * | Singleton classes returns parent's methods with instance_methods(false) and ↵ | José Valim | 2010-03-19 | 1 | -1/+3 |
| | | | | | | | | | this makes remove_method in Module#delegate fail. Add a test case and fix the bug. | ||||
| | * | Eliminate warnings for AM on 1.8 | wycats | 2010-03-16 | 1 | -1/+5 |
| | | | |||||
| * | | reformats an example in the rdoc of delegate | Xavier Noria | 2010-02-06 | 1 | -2/+7 |
| | | | |||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |