Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Replace comments' non-breaking spaces with spaces | claudiob | 2012-12-04 | 1 | -2/+2 |
| | | | | | | | | | | Sometimes, on Mac OS X, programmers accidentally press Option+Space rather than just Space and don’t see the difference. The problem is that Option+Space writes a non-breaking space (0XA0) rather than a normal space (0x20). This commit removes all the non-breaking spaces inadvertently introduced in the comments of the code. | ||||
* | Make caller attribute in deprecation methods optional | Alexey Gaziev | 2012-10-30 | 1 | -2/+2 |
| | |||||
* | Provide a call stack for deprecation warnings where needed. | Nikita Afanasenko | 2012-10-29 | 1 | -2/+5 |
| | | | | It's sometimes hard to quickly find where deprecated call was performed, especially in case of migrating between Rails versions. So this is an attempt to improve the call stack part of the warning message by providing caller explicitly. | ||||
* | update AS docs [ci skip] | Francesco Rodriguez | 2012-09-17 | 1 | -75/+80 |
| | |||||
* | AS::Callbacks: deprecate monkey patch of object callbacks | Bogdan Gusiev | 2012-09-07 | 1 | -0/+1 |
| | |||||
* | Fixed around callback with lambda example | Aaron Renner | 2012-09-06 | 1 | -1/+1 |
| | | | This is a follow up to issue #7535 | ||||
* | removes usage of Object#in? from the code base (the method remains defined ↵ | Xavier Noria | 2012-08-06 | 1 | -2/+1 |
| | | | | | | | | | | | | | | | | | | | by Active Support) Selecting which key extensions to include in active_support/rails made apparent the systematic usage of Object#in? in the code base. After some discussion in https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d we decided to remove it and use plain Ruby, which seems enough for this particular idiom. In this commit the refactor has been made case by case. Sometimes include? is the natural alternative, others a simple || is the way you actually spell the condition in your head, others a case statement seems more appropriate. I have chosen the one I liked the most in each case. | ||||
* | fix typo in documentation | Anatoly Makarevich | 2012-07-26 | 1 | -1/+1 |
| | |||||
* | AS::Callbacks: deprecate monkey patch code | Bogdan Gusiev | 2012-06-26 | 1 | -1/+2 |
| | | | | | Deprecate usage of filter object with #before and #after methods as around callback | ||||
* | Revert some ActiveSupport::Callbacks changes. | Rafael Mendonça França | 2012-06-01 | 1 | -3/+16 |
| | | | | | | | | | | | | | | | | | This reverts commits 911a0859ac065aa8e8834ac985353d659c7c7b65 and 30b31f51af6f7094c4a27b086755fc66c368d6fa. Reason: these changes make the Active Model tests fail randomly. Some examples: http://travis-ci.org/#!/rails/rails/jobs/1498992 http://travis-ci.org/#!/rails/rails/jobs/1496948 http://travis-ci.org/#!/rails/rails/jobs/1489985 This script was used to reproduce these breaks: https://gist.github.com/f6828a03ee4d40bffbc3 200 times, 0 failures | ||||
* | AS::Callbacks: fix run_callbacks for objects with negative id | Bogdan Gusiev | 2012-05-18 | 1 | -1/+1 |
| | |||||
* | Merge pull request #6351 from bogdan/callbacks | José Valim | 2012-05-17 | 1 | -16/+3 |
|\ | | | | | AS::Callbacks remove useless code, improve performance | ||||
| * | AS::Callbacks remove useless code, improve performance | Bogdan Gusiev | 2012-05-16 | 1 | -16/+3 |
| | | |||||
* | | AS::Callbacks: simplify logical statement | Bogdan Gusiev | 2012-05-17 | 1 | -2/+2 |
|/ | |||||
* | removing unnecessary 'examples' noise from activesupport | Francesco Rodriguez | 2012-05-13 | 1 | -2/+0 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-12 | 1 | -8/+0 |
|\ | | | | | | | | | Conflicts: activesupport/lib/active_support/callbacks.rb | ||||
| * | deleting empty lines in docs parts | Francesco Rodriguez | 2012-05-10 | 1 | -8/+0 |
| | | |||||
* | | AS::Callbacks#run_callbacks remove key argument | Francesco Rodriguez | 2012-05-10 | 1 | -2/+1 |
|/ | |||||
* | AS::Callbacks optimized to reduce call backtrace | Bogdan Gusiev | 2012-04-27 | 1 | -7/+7 |
| | |||||
* | fix doc for ActiveSupport::Callbacks::Callback#define_conditional_callback | Jan Xie | 2012-04-08 | 1 | -1/+1 |
| | |||||
* | AS::Callbacks: deprecate rescuable option | Bogdan Gusiev | 2012-02-22 | 1 | -26/+1 |
| | |||||
* | sync __run_callbacks with ruby-trunk | Sokolov Yura | 2012-02-14 | 1 | -1/+1 |
| | | | | | | https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/34580 In this revision behavior of respond_to? had changed: now to ask about protected method one should pass second argument `true` | ||||
* | AS::Callbacks: remove unused code | Bogdan Gusiev | 2012-02-05 | 1 | -17/+13 |
| | |||||
* | AS::Callbacks: rip out per_key option. | Bogdan Gusiev | 2012-02-04 | 1 | -34/+13 |
| | |||||
* | Merge pull request #4866 from bogdan/terminate_after_callbacks | José Valim | 2012-02-04 | 1 | -1/+6 |
|\ | | | | | AS::Callbacks#define_callbacks: add :terminate_after_callbacks option | ||||
| * | AS::Callbacks: :skip_after_callbacks_if_terminated option | Bogdan Gusiev | 2012-02-03 | 1 | -1/+6 |
| | | |||||
* | | AC::Callbacks: remove usage of :per_key option from filters | Bogdan Gusiev | 2012-02-03 | 1 | -2/+2 |
|/ | |||||
* | Fix GH #4344. A defined callback in extended module is called too. | kennyj | 2012-01-24 | 1 | -1/+1 |
| | |||||
* | Remove unused argument. | kennyj | 2012-01-22 | 1 | -3/+3 |
| | |||||
* | AS::Callbacks: Refactor :per_key option | Bogdan Gusiev | 2012-01-17 | 1 | -35/+7 |
| | |||||
* | AS::Callbacks: remove unused runner | Bogdan Gusiev | 2012-01-12 | 1 | -16/+3 |
| | |||||
* | Remove Array.wrap calls in ActiveSupport | Rafael Mendonça França | 2012-01-06 | 1 | -8/+7 |
| | |||||
* | Merge pull request #3637 from bogdan/compile_options | José Valim | 2012-01-05 | 1 | -58/+62 |
|\ | | | | | AS::Callbacks::Callback refactor | ||||
| * | AS::Callbacks::Callback refactor | Bogdan Gusiev | 2011-11-15 | 1 | -58/+62 |
| | | | | | | | | | | | | In order to make Callbacks code always operate on valid peaces of code Concatenated Callback#start and Callback#end method into #apply method. | ||||
* | | Revert "AS::Callbacks: remove __define_runner" | José Valim | 2012-01-04 | 1 | -3/+16 |
| | | | | | | | | | | | | Runners are used internally. This reverts commit 40c8aa706adbb60ff9d289016fb9020d48969fea. | ||||
* | | AS::Callbacks: remove __define_runner | Bogdan Gusiev | 2011-12-30 | 1 | -16/+3 |
| | | |||||
* | | Refactor AS::Callbacks | Bogdan Gusiev | 2011-12-28 | 1 | -6/+8 |
| | | | | | | | | | | Extracted `__reset_runner` from `__define_runner` And call it in proper places | ||||
* | | AS::Callbacks: improved __define_runner performance | Bogdan Gusiev | 2011-12-25 | 1 | -3/+2 |
| | | |||||
* | | AS::Callbacks: improve __define_runner perfomance | Bogdan Gusiev | 2011-12-25 | 1 | -10/+11 |
| | | |||||
* | | Log 'Filter chain halted as CALLBACKNAME rendered or redirected' every time ↵ | José Valim | 2011-11-30 | 1 | -4/+14 |
|/ | | | | a before callback halts. | ||||
* | AS::Callbacks::Callback#_compile_option refactored | Bogdan Gusiev | 2011-11-11 | 1 | -14/+12 |
| | |||||
* | AS::Callbacks.__run_keyed_callback: remove unused cache | Bogdan Gusiev | 2011-11-10 | 1 | -10/+6 |
| | |||||
* | self.class.name -> self.name (we are already inside a class). | José Valim | 2011-11-10 | 1 | -1/+1 |
| | |||||
* | AS::Callbacks#_define_runner refactored | Bogdan Gusiev | 2011-11-10 | 1 | -23/+22 |
| | | | | | Incapsulate the logic of keyed callback method definition and execution in the separated method. | ||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 1 | -1/+1 |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 1 | -1/+1 |
| | | | | suggestion! | ||||
* | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 1 | -1/+2 |
| | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | ||||
* | Prevent callbacks in child classes from being executed more than once. | Rolf Timmermans | 2011-03-13 | 1 | -1/+1 |
| | |||||
* | adds a couple of missing AS dependencies | Rolf Timmermans | 2011-03-12 | 1 | -0/+1 |
| | |||||
* | Allow access to a callback event's return result from around callbacks | Aaron Pfeifer | 2011-03-08 | 1 | -2/+8 |
| |