aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/lib/active_support/callbacks.rb
Commit message (Collapse)AuthorAgeFilesLines
* Fix typo in set_callback docs. [ci skip]Gilad Zohari2013-09-061-1/+1
|
* Revert "remove string based terminators for `ActiveSupport::Callbacks`."Yves Senn2013-07-051-0/+6
| | | | | | | | This reverts commit d108672dada7ba97d3b3b56f0c6001cea621061e. Conflicts: activesupport/CHANGELOG.md
* remove string based terminators for `ActiveSupport::Callbacks`.Yves Senn2013-07-051-6/+0
|
* Further clean-up of ActiveSupport::CallbacksGenadi Samokovarov2013-07-011-10/+9
| | | | | | | | | | | | | | | | | In #11195 I noticed a trailing comma in the docs, but I decided to further clean it up. What I have done: * Clean up the trailing comma in the docs and some extra whitespace lines. * Used `Array#extract` options to factor the repetitive pattern of `args.last.is_a(Hash) ? ...` * Renamed the local var `config` to `options` in `define_callbacks`, as `options` seems to be the de facto name for the options objects. * Renamed the local var `l` to `line` in `define_callback` (maybe it meant `lambda` in the context) as single `l` may look like `1` in some fonts.
* unified the param names across all callbacks manipulation methodsSteven Yang2013-07-011-10/+10
| | | | | | | _ Rename the define_callbacks params to `names` - in order to match the naming conventions for `get_callbacks` and `set_callbacks` at https://github.com/rails/rails/blob/master/activesupport/lib/active_support/callbacks.rb#L736-743 - `define_callbacks` just register names(events), not define the real callback functions. - Rename the `reset_callbacks` params
* updated AS:Callbacks doc for terminator option in define_callbacks methodSteven Yang2013-06-301-3/+4
| | | | The change is commited at ba552764344bc0a3c25b8576ec11f127ceaa16da
* remove some evals from callback conditionalsAaron Patterson2013-06-111-0/+10
|
* Fixed typos in activesupport [ci skip]Prathamesh Sonpatki2013-06-091-3/+3
| | | | | - eval'ed to eval'd in accordance with https://github.com/rails/rails/pull/10889 - tried to improve statement about compiling Procs into methods using define_method
* "normalize_callback_params" doesn't require name paramVipul A M2013-05-171-3/+3
|
* Revert "just call the class method since we know the callbacks are stored at ↵Aaron Patterson2013-05-161-2/+1
| | | | | | the" This reverts commit 55975c71ec9c2c18b67020484959ff5c69d4d3fb.
* just call the class method since we know the callbacks are stored at theAaron Patterson2013-05-151-1/+2
| | | | class level
* remove dead codeAaron Patterson2013-05-151-23/+4
|
* remove deprecation noticesAaron Patterson2013-05-151-10/+0
|
* stop keeping a reference to the options hashAaron Patterson2013-05-151-12/+7
|
* conditions are guaranteed to be arrays by initializeAaron Patterson2013-05-151-2/+2
|
* simplify the condions lambda generationAaron Patterson2013-05-151-12/+2
|
* use unless instead of if!Aaron Patterson2013-05-151-3/+3
|
* only dup the options once, the Callback object does not mutate themAaron Patterson2013-05-141-2/+2
|
* make the compile method thread safeAaron Patterson2013-05-141-5/+7
|
* use inject rather than multiple assignmentsAaron Patterson2013-05-141-4/+2
|
* deprecating string based terminatorsAaron Patterson2013-05-141-4/+11
|
* halting lambda must be instance execedAaron Patterson2013-05-141-2/+2
|
* fixing arity2 testAaron Patterson2013-05-141-3/+8
|
* fix shadowed variable warningsAaron Patterson2013-05-141-5/+5
|
* polymorphic around callbacksAaron Patterson2013-05-141-15/+79
|
* polymorphic after filterAaron Patterson2013-05-141-25/+70
|
* rename terminal to halting, try to keep naming consistentAaron Patterson2013-05-141-4/+4
|
* push the before filter lambdas to factory methodsAaron Patterson2013-05-141-40/+58
|
* polymorphic before callbacksAaron Patterson2013-05-141-16/+54
|
* use a singleton end nodeAaron Patterson2013-05-131-5/+10
|
* Revert "we never pass blocks, so remove this"Aaron Patterson2013-05-131-1/+1
| | | | This reverts commit 9caf0cf9c8c7b42737ae78c470a5dd2f583ada75.
* if there is nothing to compile, then do not bother compilingAaron Patterson2013-05-131-3/+8
|
* Arrays are no longer supportedAaron Patterson2013-05-131-4/+0
|
* we never pass blocks, so remove thisAaron Patterson2013-05-131-1/+1
|
* raise an argument error if the filter arity is greater than 1Aaron Patterson2013-05-131-12/+6
|
* Merge branch 'master' into normalizecbAaron Patterson2013-05-131-20/+34
|\ | | | | | | | | | | | | | | | | | | | | * master: extract getting an setting callbacks to methods call extracted method from callback manipulation methods extract callback param munging no reason to make these defaulted, we always pass values in Conflicts: activesupport/lib/active_support/callbacks.rb
| * extract getting an setting callbacks to methodsAaron Patterson2013-05-131-15/+22
| |
| * call extracted method from callback manipulation methodsAaron Patterson2013-05-131-6/+8
| |
| * extract callback param mungingAaron Patterson2013-05-131-3/+8
| |
| * no reason to make these defaulted, we always pass values inAaron Patterson2013-05-131-1/+1
| |
| * Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-05-121-1/+1
| |\ | | | | | | | | | | | | Conflicts: activesupport/lib/active_support/callbacks.rb
| | * replace apostrophe with backquote for matching [ci skip]Anton Kalyaev2013-05-031-2/+2
| | |
* | | pass the actual filter, not a stringAaron Patterson2013-05-131-1/+1
| | |
* | | do not keep a reference to the chain in the callback objectsAaron Patterson2013-05-101-12/+10
| | |
* | | fix deprecation testAaron Patterson2013-05-101-0/+2
| | |
* | | push merge code to the callback itselfAaron Patterson2013-05-101-18/+10
| | |
* | | dup the callback and set the chainAaron Patterson2013-05-101-8/+8
| | |
* | | remove klass because it is not usedAaron Patterson2013-05-101-9/+7
| | |
* | | rename instance variablesAaron Patterson2013-05-101-12/+14
| | |
* | | push duplicates? logic to the instanceAaron Patterson2013-05-101-16/+7
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 12:36:54 +0000