Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | remove deprecation warning | eileencodes | 2014-05-13 | 1 | -6/+0 |
| | | | | | This deprecation was released in 4.1.0 and can be removed for 4.2.0, deprecation message / handling is no longer necessary. | ||||
* | flip conditional to use if/else instead of unless/else | eileencodes | 2014-05-12 | 1 | -3/+3 |
| | | | | Use if/else instead of unless/else so conditional reads better. | ||||
* | Merge pull request #11411 from dscataglini/master | Aaron Patterson | 2014-04-09 | 1 | -6/+12 |
|\ | | | | | Active support callback's before/after/around filters are not correctly making their singleton methods private | ||||
| * | private method doesn't work for singleton methods defined this way | Diego Scataglini | 2013-07-12 | 1 | -6/+12 |
| | | |||||
* | | Fix few typos in the documentation [ci skip] | Robin Dupret | 2013-12-21 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #13287 from aayushkhandelwal11/typo_rectified | Yves Senn | 2013-12-11 | 1 | -3/+3 |
|\ \ | | | | | | | typos rectified lifecycle => life cycle | ||||
| * | | typos rectified lifecycle => life cycle | Aayush khandelwal | 2013-12-12 | 1 | -3/+3 |
| | | | |||||
* | | | typos rectified [ci skip] | Aayush khandelwal | 2013-12-12 | 1 | -1/+1 |
|/ / | |||||
* / | Fix typo in set_callback docs. [ci skip] | Gilad Zohari | 2013-09-06 | 1 | -1/+1 |
|/ | |||||
* | Revert "remove string based terminators for `ActiveSupport::Callbacks`." | Yves Senn | 2013-07-05 | 1 | -0/+6 |
| | | | | | | | | This reverts commit d108672dada7ba97d3b3b56f0c6001cea621061e. Conflicts: activesupport/CHANGELOG.md | ||||
* | remove string based terminators for `ActiveSupport::Callbacks`. | Yves Senn | 2013-07-05 | 1 | -6/+0 |
| | |||||
* | Further clean-up of ActiveSupport::Callbacks | Genadi Samokovarov | 2013-07-01 | 1 | -10/+9 |
| | | | | | | | | | | | | | | | | | In #11195 I noticed a trailing comma in the docs, but I decided to further clean it up. What I have done: * Clean up the trailing comma in the docs and some extra whitespace lines. * Used `Array#extract` options to factor the repetitive pattern of `args.last.is_a(Hash) ? ...` * Renamed the local var `config` to `options` in `define_callbacks`, as `options` seems to be the de facto name for the options objects. * Renamed the local var `l` to `line` in `define_callback` (maybe it meant `lambda` in the context) as single `l` may look like `1` in some fonts. | ||||
* | unified the param names across all callbacks manipulation methods | Steven Yang | 2013-07-01 | 1 | -10/+10 |
| | | | | | | | _ Rename the define_callbacks params to `names` - in order to match the naming conventions for `get_callbacks` and `set_callbacks` at https://github.com/rails/rails/blob/master/activesupport/lib/active_support/callbacks.rb#L736-743 - `define_callbacks` just register names(events), not define the real callback functions. - Rename the `reset_callbacks` params | ||||
* | updated AS:Callbacks doc for terminator option in define_callbacks method | Steven Yang | 2013-06-30 | 1 | -3/+4 |
| | | | | The change is commited at ba552764344bc0a3c25b8576ec11f127ceaa16da | ||||
* | remove some evals from callback conditionals | Aaron Patterson | 2013-06-11 | 1 | -0/+10 |
| | |||||
* | Fixed typos in activesupport [ci skip] | Prathamesh Sonpatki | 2013-06-09 | 1 | -3/+3 |
| | | | | | - eval'ed to eval'd in accordance with https://github.com/rails/rails/pull/10889 - tried to improve statement about compiling Procs into methods using define_method | ||||
* | "normalize_callback_params" doesn't require name param | Vipul A M | 2013-05-17 | 1 | -3/+3 |
| | |||||
* | Revert "just call the class method since we know the callbacks are stored at ↵ | Aaron Patterson | 2013-05-16 | 1 | -2/+1 |
| | | | | | | the" This reverts commit 55975c71ec9c2c18b67020484959ff5c69d4d3fb. | ||||
* | just call the class method since we know the callbacks are stored at the | Aaron Patterson | 2013-05-15 | 1 | -1/+2 |
| | | | | class level | ||||
* | remove dead code | Aaron Patterson | 2013-05-15 | 1 | -23/+4 |
| | |||||
* | remove deprecation notices | Aaron Patterson | 2013-05-15 | 1 | -10/+0 |
| | |||||
* | stop keeping a reference to the options hash | Aaron Patterson | 2013-05-15 | 1 | -12/+7 |
| | |||||
* | conditions are guaranteed to be arrays by initialize | Aaron Patterson | 2013-05-15 | 1 | -2/+2 |
| | |||||
* | simplify the condions lambda generation | Aaron Patterson | 2013-05-15 | 1 | -12/+2 |
| | |||||
* | use unless instead of if! | Aaron Patterson | 2013-05-15 | 1 | -3/+3 |
| | |||||
* | only dup the options once, the Callback object does not mutate them | Aaron Patterson | 2013-05-14 | 1 | -2/+2 |
| | |||||
* | make the compile method thread safe | Aaron Patterson | 2013-05-14 | 1 | -5/+7 |
| | |||||
* | use inject rather than multiple assignments | Aaron Patterson | 2013-05-14 | 1 | -4/+2 |
| | |||||
* | deprecating string based terminators | Aaron Patterson | 2013-05-14 | 1 | -4/+11 |
| | |||||
* | halting lambda must be instance execed | Aaron Patterson | 2013-05-14 | 1 | -2/+2 |
| | |||||
* | fixing arity2 test | Aaron Patterson | 2013-05-14 | 1 | -3/+8 |
| | |||||
* | fix shadowed variable warnings | Aaron Patterson | 2013-05-14 | 1 | -5/+5 |
| | |||||
* | polymorphic around callbacks | Aaron Patterson | 2013-05-14 | 1 | -15/+79 |
| | |||||
* | polymorphic after filter | Aaron Patterson | 2013-05-14 | 1 | -25/+70 |
| | |||||
* | rename terminal to halting, try to keep naming consistent | Aaron Patterson | 2013-05-14 | 1 | -4/+4 |
| | |||||
* | push the before filter lambdas to factory methods | Aaron Patterson | 2013-05-14 | 1 | -40/+58 |
| | |||||
* | polymorphic before callbacks | Aaron Patterson | 2013-05-14 | 1 | -16/+54 |
| | |||||
* | use a singleton end node | Aaron Patterson | 2013-05-13 | 1 | -5/+10 |
| | |||||
* | Revert "we never pass blocks, so remove this" | Aaron Patterson | 2013-05-13 | 1 | -1/+1 |
| | | | | This reverts commit 9caf0cf9c8c7b42737ae78c470a5dd2f583ada75. | ||||
* | if there is nothing to compile, then do not bother compiling | Aaron Patterson | 2013-05-13 | 1 | -3/+8 |
| | |||||
* | Arrays are no longer supported | Aaron Patterson | 2013-05-13 | 1 | -4/+0 |
| | |||||
* | we never pass blocks, so remove this | Aaron Patterson | 2013-05-13 | 1 | -1/+1 |
| | |||||
* | raise an argument error if the filter arity is greater than 1 | Aaron Patterson | 2013-05-13 | 1 | -12/+6 |
| | |||||
* | Merge branch 'master' into normalizecb | Aaron Patterson | 2013-05-13 | 1 | -20/+34 |
|\ | | | | | | | | | | | | | | | | | | | | | * master: extract getting an setting callbacks to methods call extracted method from callback manipulation methods extract callback param munging no reason to make these defaulted, we always pass values in Conflicts: activesupport/lib/active_support/callbacks.rb | ||||
| * | extract getting an setting callbacks to methods | Aaron Patterson | 2013-05-13 | 1 | -15/+22 |
| | | |||||
| * | call extracted method from callback manipulation methods | Aaron Patterson | 2013-05-13 | 1 | -6/+8 |
| | | |||||
| * | extract callback param munging | Aaron Patterson | 2013-05-13 | 1 | -3/+8 |
| | | |||||
| * | no reason to make these defaulted, we always pass values in | Aaron Patterson | 2013-05-13 | 1 | -1/+1 |
| | | |||||
| * | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-05-12 | 1 | -1/+1 |
| |\ | | | | | | | | | | | | | Conflicts: activesupport/lib/active_support/callbacks.rb | ||||
| | * | replace apostrophe with backquote for matching [ci skip] | Anton Kalyaev | 2013-05-03 | 1 | -2/+2 |
| | | |