Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix FileStore#cleanup to no longer rely on missing each_key method | Murray Steele | 2013-09-11 | 1 | -1/+2 |
| | |||||
* | Remove gist link from the code | Rafael Mendonça França | 2013-08-27 | 1 | -1/+0 |
| | | | | | | | It is not good to include links in the code. These links can be in the future outdated and nobody will upgrade they. [ci skip] | ||||
* | Merge pull request #11546 from swoop-inc/ss_memory_store_cache_size | Piotr Sarnacki | 2013-07-22 | 1 | -3/+14 |
|\ | | | | | [Fixes #11512] improves cache size calculation in MemoryStore | ||||
| * | [Fixes #11512] improves cache size calculation in ↵ | Simeon Simeonov | 2013-07-22 | 1 | -3/+14 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveSupport::Cache::MemoryStore Previously, the cache size of `ActiveSupport::Cache::MemoryStore` was calculated as the sum of the size of its entries, ignoring the size of keys and any data structure overhead. This could lead to the calculated cache size sometimes being 10-100x smaller than the memory used, e.g., in the case of small values. The size of a key/entry pair is now calculated via `#cached_size`: def cached_size(key, entry) key.to_s.bytesize + entry.size + PER_ENTRY_OVERHEAD end The value of `PER_ENTRY_OVERHEAD` is 240 bytes based on an [empirical estimation](https://gist.github.com/ssimeonov/6047200) for 64-bit MRI on 1.9.3 and 2.0. Fixes GH#11512 https://github.com/rails/rails/issues/11512 | ||||
* | | Add documentation for FileStore#increment and #decrement | Matt Stopa | 2013-07-10 | 1 | -0/+4 |
| | | | | | | | | [ci skip] | ||||
* | | Add documentation for #clear on certain Store classes | Matt Stopa | 2013-07-10 | 2 | -0/+2 |
| | | | | | | | | [ci skip | ||||
* | | Update the filestore documentation for clear | Matt Stopa | 2013-07-09 | 1 | -0/+3 |
|/ | | | | [ci skip] | ||||
* | The increment and decrement commands in the local cache are exactly the | wangjohn | 2013-04-17 | 1 | -18/+14 |
| | | | | same, so their logic is being refactored. | ||||
* | Refactored the storage of a temporary version of the local cache into | wangjohn | 2013-04-17 | 1 | -8/+6 |
| | | | | its own method. | ||||
* | Add nodoc to LocalCacheRegistry | Rafael Mendonça França | 2013-04-17 | 1 | -1/+1 |
| | | | [ci skip] | ||||
* | Adding a local thread registry to store local caches. | wangjohn | 2013-04-17 | 1 | -15/+32 |
| | |||||
* | Fix deletion of empty directories: | Charles Jones | 2013-02-25 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | 1. When comparing the directory to delete against the top level cache_path, use File.realpath to make sure we aren't comparing two unequal strings that point to the same path. This occurs, for example, when cache_path has a trailing slash, which it does in the default Rails configuration. Since the input to delete_empty_directories never has a trailing slash, the comparison will never be true and the top level cache directory (and above) may be deleted. However… 2. File.delete raises EPERM when trying to delete a directory, so no directories have ever been deleted. Changing the code to Dir.delete fixes that. | ||||
* | Missing require extract_options | Akira Matsuda | 2013-01-31 | 1 | -0/+1 |
| | |||||
* | Use already defined Encoding constants rather than creating one-trip Strings | Akira Matsuda | 2013-01-28 | 1 | -1/+1 |
| | |||||
* | Patched Marshal#load to work with constant autoloading ↵ | Uriel Katz | 2012-12-01 | 2 | -0/+2 |
| | | | | (active_support/dependecies.rb) (issue #8167) | ||||
* | Padding expires_in by 5 minutes on dalli key write to facilitate ↵ | Mike Evans | 2012-10-11 | 1 | -0/+4 |
| | | | | :race_condition_ttl working correctly. | ||||
* | Optimize ActiveSupport::Cache::Entry to reduce memory and processing overhead. | Brian Durand | 2012-09-30 | 1 | -0/+1 |
| | |||||
* | Replace deprecated `memcache-client` gem with `dalli` in ↵ | Guillermo Iguaran | 2012-08-17 | 1 | -32/+21 |
| | | | | | | ActiveSupport::Cache::MemCacheStore memcache-client was deprecated in favour of dalli in 2010. | ||||
* | removes usage of Object#in? from the code base (the method remains defined ↵ | Xavier Noria | 2012-08-06 | 1 | -4/+3 |
| | | | | | | | | | | | | | | | | | | | by Active Support) Selecting which key extensions to include in active_support/rails made apparent the systematic usage of Object#in? in the code base. After some discussion in https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d we decided to remove it and use plain Ruby, which seems enough for this particular idiom. In this commit the refactor has been made case by case. Sometimes include? is the natural alternative, others a simple || is the way you actually spell the condition in your head, others a case statement seems more appropriate. I have chosen the one I liked the most in each case. | ||||
* | Merge pull request #5125 from winston/log_exception_when_cache_read_fails | Michael Koziarski | 2012-05-21 | 1 | -1/+2 |
|\ | | | | | #read_entry in ActiveSupport::Cache::FileStore should log details of the exception when an exception is thrown | ||||
| * | #read_entry in ActiveSupport::Cache::FileStore should log details of the ↵ | Winston | 2012-02-22 | 1 | -1/+2 |
| | | | | | | | | exception when an exception is thrown. | ||||
* | | Remove wrong rack/utils dependency from AS | Santiago Pastorino | 2012-05-12 | 1 | -3/+3 |
| | | | | | | | | Closes #6274 | ||||
* | | add unless_exist option to memory store | grosser | 2012-05-10 | 1 | -0/+1 |
| | | |||||
* | | Merge pull request #4452 from tapajos/e5425c8f68fbb720fcbf4b14e1f154ac27dbbbed | Aaron Patterson | 2012-05-03 | 1 | -1/+1 |
|\ \ | | | | | | | Fix cache (FileStore) clear to keep .gitkeep. | ||||
| * | | Cache (FileStore) clear should keep .gitkeep | Marcos Tapajos | 2012-01-13 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #4911 from Floppy/master | Aaron Patterson | 2012-03-30 | 1 | -1/+1 |
|\ \ \ | |_|/ |/| | | Reduce FILENAME_MAX_SIZE in ActiveSupport::Cache::FileStore | ||||
| * | | Change FILENAME_MAX_SIZE in FileStore to 228. | James Smith | 2012-02-06 | 1 | -1/+1 |
| |/ | | | | | | | In order that temp filenames generated from it will fit in 255 chars. See https://github.com/rails/rails/issues/4907 | ||||
* | | Bug: cache_path.size doesn't return length of filename but size of file if ↵ | Issei Naruta | 2012-02-21 | 1 | -1/+1 |
| | | | | | | | | cache_path is Pathname. | ||||
* | | remove unnecessary require core_ext/string/encoding | Sergey Nartimov | 2012-02-14 | 1 | -1/+0 |
|/ | |||||
* | deprecate String#encoding_aware? and remove its usage | Sergey Nartimov | 2011-12-24 | 1 | -1/+1 |
| | |||||
* | Add ActiveSupport::Cache::NullStore to expose caching interface without ↵ | Brian Durand | 2011-12-12 | 1 | -0/+44 |
| | | | | actually caching for development and test environments. | ||||
* | Fix "in memory" where it should be "in-memory". | Cheah Chu Yeow | 2011-11-13 | 3 | -4/+4 |
| | |||||
* | Revert "Fix "in memory" where it should be "in-memory"." | Vijay Dev | 2011-11-11 | 3 | -4/+4 |
| | | | | | | This reverts commit e34e4d43301618307f94123d3710f094297f91f3. Reason: code changes are not allowed in docrails. | ||||
* | Update Memcached website to its new one at http://memcached.org/. | Cheah Chu Yeow | 2011-11-11 | 1 | -1/+1 |
| | |||||
* | Fix "in memory" where it should be "in-memory". | Cheah Chu Yeow | 2011-11-11 | 3 | -4/+4 |
| | |||||
* | Refactor ActiveSupport::Cache::FileStore. used method and deleted duplicate ↵ | kennyj | 2011-10-30 | 1 | -3/+4 |
| | | | | code. | ||||
* | Added fix so that file store does not raise an exception when cache dir does ↵ | Philippe Huibonhoa | 2011-09-29 | 1 | -0/+1 |
| | | | | not exist yet. This can happen if a delete_matched is called before anything is saved in the cache. | ||||
* | No need to create a range object | Santiago Pastorino | 2011-09-22 | 1 | -3/+3 |
| | |||||
* | Fixed issue in file store where it could create a filename that was too long ↵ | Philippe Huibonhoa | 2011-09-21 | 1 | -9/+8 |
| | | | | for the file system. (https://github.com/rails/rails/issues/3072) | ||||
* | Fix ActiveSupport::Cache::FileStore#file_path_key does not work if ↵ | Gonzalo Rodriguez | 2011-07-23 | 1 | -1/+1 |
| | | | | | | initialized with Pathname Port from 3-1-stable | ||||
* | MemcacheStore: deserialize the entry reading from local_cache when using raw | Dingding Ye | 2011-06-10 | 1 | -0/+8 |
| | |||||
* | Make MemCacheStore work with Ruby 1.9 and -Ku | Andrew White | 2011-05-31 | 1 | -1/+1 |
| | |||||
* | Removed deprecated methods and related tests from ActiveSupport | Josh Kalderimis | 2011-05-25 | 3 | -37/+1 |
| | |||||
* | Tidy up previous commit. | José Valim | 2011-04-28 | 1 | -3/+8 |
| | |||||
* | Merged pull request #219 from panthomakos/memcache. | José Valim | 2011-04-28 | 1 | -1/+4 |
|\ | | | | | Character encoding issues with MemCacheStore in 1.9.2 | ||||
| * | Fixed special character encoding issue with MemCacheStore in Ruby 1.9.2. | Pan Thomakos | 2011-03-11 | 1 | -1/+4 |
| | | |||||
* | | File should be open in read/write mode. When doing lock on a file. | Arun Agrawal | 2011-04-18 | 1 | -1/+1 |
| | | |||||
* | | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 1 | -2/+2 |
| | | | | | | | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 1 | -2/+2 |
| | | | | | | | | suggestion! | ||||
* | | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 1 | -2/+3 |
|/ | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. |