Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix deletion of empty directories: | Charles Jones | 2013-02-25 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | 1. When comparing the directory to delete against the top level cache_path, use File.realpath to make sure we aren't comparing two unequal strings that point to the same path. This occurs, for example, when cache_path has a trailing slash, which it does in the default Rails configuration. Since the input to delete_empty_directories never has a trailing slash, the comparison will never be true and the top level cache directory (and above) may be deleted. However… 2. File.delete raises EPERM when trying to delete a directory, so no directories have ever been deleted. Changing the code to Dir.delete fixes that. | ||||
* | Missing require extract_options | Akira Matsuda | 2013-01-31 | 1 | -0/+1 |
| | |||||
* | Use already defined Encoding constants rather than creating one-trip Strings | Akira Matsuda | 2013-01-28 | 1 | -1/+1 |
| | |||||
* | Patched Marshal#load to work with constant autoloading ↵ | Uriel Katz | 2012-12-01 | 2 | -0/+2 |
| | | | | (active_support/dependecies.rb) (issue #8167) | ||||
* | Padding expires_in by 5 minutes on dalli key write to facilitate ↵ | Mike Evans | 2012-10-11 | 1 | -0/+4 |
| | | | | :race_condition_ttl working correctly. | ||||
* | Optimize ActiveSupport::Cache::Entry to reduce memory and processing overhead. | Brian Durand | 2012-09-30 | 1 | -0/+1 |
| | |||||
* | Replace deprecated `memcache-client` gem with `dalli` in ↵ | Guillermo Iguaran | 2012-08-17 | 1 | -32/+21 |
| | | | | | | ActiveSupport::Cache::MemCacheStore memcache-client was deprecated in favour of dalli in 2010. | ||||
* | removes usage of Object#in? from the code base (the method remains defined ↵ | Xavier Noria | 2012-08-06 | 1 | -4/+3 |
| | | | | | | | | | | | | | | | | | | | by Active Support) Selecting which key extensions to include in active_support/rails made apparent the systematic usage of Object#in? in the code base. After some discussion in https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d we decided to remove it and use plain Ruby, which seems enough for this particular idiom. In this commit the refactor has been made case by case. Sometimes include? is the natural alternative, others a simple || is the way you actually spell the condition in your head, others a case statement seems more appropriate. I have chosen the one I liked the most in each case. | ||||
* | Merge pull request #5125 from winston/log_exception_when_cache_read_fails | Michael Koziarski | 2012-05-21 | 1 | -1/+2 |
|\ | | | | | #read_entry in ActiveSupport::Cache::FileStore should log details of the exception when an exception is thrown | ||||
| * | #read_entry in ActiveSupport::Cache::FileStore should log details of the ↵ | Winston | 2012-02-22 | 1 | -1/+2 |
| | | | | | | | | exception when an exception is thrown. | ||||
* | | Remove wrong rack/utils dependency from AS | Santiago Pastorino | 2012-05-12 | 1 | -3/+3 |
| | | | | | | | | Closes #6274 | ||||
* | | add unless_exist option to memory store | grosser | 2012-05-10 | 1 | -0/+1 |
| | | |||||
* | | Merge pull request #4452 from tapajos/e5425c8f68fbb720fcbf4b14e1f154ac27dbbbed | Aaron Patterson | 2012-05-03 | 1 | -1/+1 |
|\ \ | | | | | | | Fix cache (FileStore) clear to keep .gitkeep. | ||||
| * | | Cache (FileStore) clear should keep .gitkeep | Marcos Tapajos | 2012-01-13 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #4911 from Floppy/master | Aaron Patterson | 2012-03-30 | 1 | -1/+1 |
|\ \ \ | |_|/ |/| | | Reduce FILENAME_MAX_SIZE in ActiveSupport::Cache::FileStore | ||||
| * | | Change FILENAME_MAX_SIZE in FileStore to 228. | James Smith | 2012-02-06 | 1 | -1/+1 |
| |/ | | | | | | | In order that temp filenames generated from it will fit in 255 chars. See https://github.com/rails/rails/issues/4907 | ||||
* | | Bug: cache_path.size doesn't return length of filename but size of file if ↵ | Issei Naruta | 2012-02-21 | 1 | -1/+1 |
| | | | | | | | | cache_path is Pathname. | ||||
* | | remove unnecessary require core_ext/string/encoding | Sergey Nartimov | 2012-02-14 | 1 | -1/+0 |
|/ | |||||
* | deprecate String#encoding_aware? and remove its usage | Sergey Nartimov | 2011-12-24 | 1 | -1/+1 |
| | |||||
* | Add ActiveSupport::Cache::NullStore to expose caching interface without ↵ | Brian Durand | 2011-12-12 | 1 | -0/+44 |
| | | | | actually caching for development and test environments. | ||||
* | Fix "in memory" where it should be "in-memory". | Cheah Chu Yeow | 2011-11-13 | 3 | -4/+4 |
| | |||||
* | Revert "Fix "in memory" where it should be "in-memory"." | Vijay Dev | 2011-11-11 | 3 | -4/+4 |
| | | | | | | This reverts commit e34e4d43301618307f94123d3710f094297f91f3. Reason: code changes are not allowed in docrails. | ||||
* | Update Memcached website to its new one at http://memcached.org/. | Cheah Chu Yeow | 2011-11-11 | 1 | -1/+1 |
| | |||||
* | Fix "in memory" where it should be "in-memory". | Cheah Chu Yeow | 2011-11-11 | 3 | -4/+4 |
| | |||||
* | Refactor ActiveSupport::Cache::FileStore. used method and deleted duplicate ↵ | kennyj | 2011-10-30 | 1 | -3/+4 |
| | | | | code. | ||||
* | Added fix so that file store does not raise an exception when cache dir does ↵ | Philippe Huibonhoa | 2011-09-29 | 1 | -0/+1 |
| | | | | not exist yet. This can happen if a delete_matched is called before anything is saved in the cache. | ||||
* | No need to create a range object | Santiago Pastorino | 2011-09-22 | 1 | -3/+3 |
| | |||||
* | Fixed issue in file store where it could create a filename that was too long ↵ | Philippe Huibonhoa | 2011-09-21 | 1 | -9/+8 |
| | | | | for the file system. (https://github.com/rails/rails/issues/3072) | ||||
* | Fix ActiveSupport::Cache::FileStore#file_path_key does not work if ↵ | Gonzalo Rodriguez | 2011-07-23 | 1 | -1/+1 |
| | | | | | | initialized with Pathname Port from 3-1-stable | ||||
* | MemcacheStore: deserialize the entry reading from local_cache when using raw | Dingding Ye | 2011-06-10 | 1 | -0/+8 |
| | |||||
* | Make MemCacheStore work with Ruby 1.9 and -Ku | Andrew White | 2011-05-31 | 1 | -1/+1 |
| | |||||
* | Removed deprecated methods and related tests from ActiveSupport | Josh Kalderimis | 2011-05-25 | 3 | -37/+1 |
| | |||||
* | Tidy up previous commit. | José Valim | 2011-04-28 | 1 | -3/+8 |
| | |||||
* | Merged pull request #219 from panthomakos/memcache. | José Valim | 2011-04-28 | 1 | -1/+4 |
|\ | | | | | Character encoding issues with MemCacheStore in 1.9.2 | ||||
| * | Fixed special character encoding issue with MemCacheStore in Ruby 1.9.2. | Pan Thomakos | 2011-03-11 | 1 | -1/+4 |
| | | |||||
* | | File should be open in read/write mode. When doing lock on a file. | Arun Agrawal | 2011-04-18 | 1 | -1/+1 |
| | | |||||
* | | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 1 | -2/+2 |
| | | | | | | | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 1 | -2/+2 |
| | | | | | | | | suggestion! | ||||
* | | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 1 | -2/+3 |
|/ | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | ||||
* | remove to_s implementation so that inspect is helpful | Aaron Patterson | 2011-03-02 | 1 | -1/+0 |
| | |||||
* | * LocalCache strategy is now a real middleware class, not an anonymous class | Aaron Patterson | 2011-03-02 | 1 | -23/+29 |
| | | | | posing for pictures. | ||||
* | Fix FileStore cache incorrectly regenerating its key from a pathname when a ↵ | Denis Odorcic | 2010-11-07 | 1 | -4/+3 |
| | | | | | | | | regexp is used in expire_fragment [#5850 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Fix misleading advice to add 'memcache' to Gemfile | Wincent Colaiuta | 2010-10-10 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | [#5539 state:committed] Commit 57144388f removed the hard-coded dependency on the memcache-client gem, and added this warning advising people to install it if needed. The problem is, however, that if people follow the advice literally and install the 'memcache' gem, they will wind up with a completely different thing, which is not API compatible with the memcache-client gem and which Rails can't work with. So, be explicit and tell users to install the 'memcache-client' gem. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | remove another lolinject | Aaron Patterson | 2010-10-01 | 1 | -1/+1 |
| | |||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -1/+1 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | making comments meaningful by correcting, adding and pruning | Neeraj Singh | 2010-07-26 | 3 | -14/+13 |
| | |||||
* | String#[] doesn't return the byte representation on 1.9.2, we should use ↵ | Santiago Pastorino | 2010-06-27 | 1 | -1/+1 |
| | | | | | | getbyte that was already added as a Ruby < 1.9 core_ext Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | preventing memcached initialization errors with default servers list [#4921 ↵ | David Calavera | 2010-06-22 | 1 | -1/+1 |
| | | | | | | | | state:resolved] As of this writing the JRuby client does not support a default port. Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | Fix a bunch of minor spelling mistakes | Evgeniy Dolzhenko | 2010-06-15 | 1 | -1/+1 |
|\ | |||||
| * | Fix a bunch of minor spelling mistakes | Evgeniy Dolzhenko | 2010-06-11 | 1 | -1/+1 |
| | |