aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/lib/active_support/cache.rb
Commit message (Collapse)AuthorAgeFilesLines
* modernizes hash syntax in activesupportXavier Noria2016-08-061-3/+3
|
* applies new string literal convention in activesupport/libXavier Noria2016-08-061-18/+18
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Change doc for race_condition_ttl option of ↵Dimitris Zorbas2016-06-061-2/+2
| | | | | | | | | ActiveSupport::Cache::Store#fetch [ci skip] The related option of this method, `expires_in` is documented as expecting an `ActiveSupport::Duration` value. To minimize any sort of ambiguity between duration options, this change also documents `race_condition_ttl` accepting `ActiveSupport::Duration`.
* Merge pull request #24577 from mechanicles/fix-fetch-cache-missJeremy Daer2016-04-181-2/+11
|\ | | | | | | Fix forced cache miss for fetch when called without a block.
| * Fix forced cache miss for fetch.Santosh Wadghule2016-04-181-2/+10
| | | | | | | | | | | | - Raised an argument error if no block is passed to #fetch with 'force: true' option is set. - Added tests for the same.
* | Merge pull request #24587 from mechanicles/doc-consistencyXavier Noria2016-04-181-19/+19
|\ \ | |/ |/| Document consistency [ci skip]
| * Document consistency [ci skip]Santosh Wadghule2016-04-171-19/+19
| |
* | Stop passing unused payloads to instrumentation block in cacheVipul A M2016-04-171-2/+2
|/
* Revert "Instrument read_multi".Kasper Timm Hansen2016-02-201-23/+10
| | | | | | | | | | | | | | | | | | Reevaluating the log output generated from this instrumentation, we've found that it wasn't all that useful in practice. ``` Caches multi read: - views/david/2/4184ab71db6849621a4d8820fcd2c0ad - views/david/2/4184ab71db6849621a4d8820fcd2c0ad - views/david/3/4184ab71db6849621a4d8820fcd2c0ad - views/david/3/4184ab71db6849621a4d8820fcd2c0ad ``` If rendering many templates the output is inscrutable, and it's impossible to see how many cache misses there were. Revert ca6aba7f30 and implement a better way later.
* Merge pull request #22581 from hirocaster/fix-expect-sample-codeYves Senn2015-12-211-4/+5
|\ | | | | | | | | | | [ci skip] Change output timming of sample code
| * Change output timming of sample codehirocaster2015-12-141-2/+2
| | | | | | | | - Expect returns "new value 1" but, retuns nil, because output at thread is not finished. Move val_1 output to finished thread.
* | Fix cache fetch miss notification orderRobin Clowers2015-12-021-8/+8
|/ | | | | | | | Fixes https://github.com/rails/rails/issues/22477. When I improved the caching instrumentation in edd33c08d98723ae9bb89cf7f019277117ed6414, I inadvertently changed the order of AS notifications when there is a cache miss.
* add deprecations for a smooth transition after #22215Michael Grosser2015-11-191-1/+9
|
* keep deprecated namespaced_key in case any subclass uses itMichael Grosser2015-11-101-0/+1
|
* send normalized keys to the cache backends so they do not need to manage ↵Michael Grosser2015-11-101-8/+8
| | | | this themselves
* Merge pull request #11872 from AvnerCohen/log_namespaceSean Griffin2015-10-301-1/+1
|\ | | | | When testing cache issues, it is useful to log the actual key, including namespace
| * When logging Cache key, in debug mode, also log namespace, to create the ↵Avner Cohen2015-06-231-1/+1
| | | | | | | | full key that actually used by the underline cache implementation
* | Fix Cache#fetch instrumentationRobin Clowers2015-09-141-13/+11
| | | | | | | | | | Before this change, you couldn't tell if a read was a hit or not when you called fetch.
* | Correct cache store superclass in commentJonah Burke2015-08-191-1/+1
|/
* Skip the `:race_condition_ttl` branch if the option is 0 or nil. This fixes ↵Matt Wilde2015-03-111-2/+2
| | | | an issue with the redis cache, where this code will sometimes throw an error out of SETEX when passing 0 as the `expires_at`.
* Doc fix [ci skip]Sushruth Sivaramakrishnan2015-03-051-1/+1
|
* fixes documentation for returned hash in cache.fetch_multiMichael Raidel2015-03-041-2/+5
|
* Instrument read_multi.Kasper Timm Hansen2015-02-211-13/+27
| | | | | | | | | | Adds `read_multi` instrumentation formatted as: Caches multi read: - views/david/2/4184ab71db6849621a4d8820fcd2c0ad - views/david/2/4184ab71db6849621a4d8820fcd2c0ad - views/david/3/4184ab71db6849621a4d8820fcd2c0ad - views/david/3/4184ab71db6849621a4d8820fcd2c0ad
* Remove deprecated ActiveSupport::Cache::Store.instrumentRafael Mendonça França2015-01-041-13/+0
|
* Remove conversion code for old Rails cache entryRafael Mendonça França2015-01-011-24/+0
| | | | | | | | | This code was there just to convert entries generated in Rails 4.0.0.beta1 applications to a supported format. It is almost unlikely that any existent application have this cache entry format in their caches at the point that Rails 5 will be released so we don't need this code anymore.
* Check by @v before converting the entry on expired?Rafael Mendonça França2015-01-011-1/+1
| | | | | | | We should convert when @v is defined not @value. The test was calling value first that already converts the entry so we are not catching this bug.
* Docs: grammar fix for fetch. [ci skip]Mike Coutermarsh2014-08-081-1/+1
|
* Merge pull request #15943 from wagenet/cache-instrumentationRafael Mendonça França2014-06-271-11/+10
|\ | | | | | | Always instrument ActiveSupport::Cache
| * Always instrument ActiveSupport::CachePeter Wagenet2014-06-271-11/+10
|/ | | | | | | | The current approach is broken because it uses a thread local value which means on multi-threaded environments it has to be turned on per thread. Secondly, ActiveSupport::Notifications does not instrument items when there are not subscribers so this flag is unnecessary.
* Return a hash rather than array from fetch_multiParker Selbert2014-02-261-6/+5
| | | | | | | The current implementation of `fetch_multi` returns an array and has no means to easily backtrack which names yielded which results. By changing the return value to a Hash we retain the name information. Hash#values can be used on the response if only the values are needed.
* docs, be clear that `options` is a hash. Closes #11904. [ci skip].Yves Senn2014-02-031-1/+1
|
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-12-201-1/+1
|\
| * Typos. return -> returns. [ci skip]Lauro Caetano2013-12-031-1/+1
| |
* | Remove deprecated cattr_* requiresGenadi Samokovarov2013-12-031-1/+1
|/
* Change syntax format for example returned valuesPrem Sichanugrist2013-11-111-1/+1
| | | | | | | | | According to our guideline, we leave 1 space between `#` and `=>`, so we want `# =>` instead of `#=>`. Thanks to @fxn for the suggestion. [ci skip]
* AestheticsDavid Heinemeier Hansson2013-11-031-22/+30
|
* Fix small typo in docsJonathan Baudanza2013-09-251-1/+1
|
* cache.exists? should return true/falseJade Tucker2013-07-071-1/+1
|
* correction on cache.fetch race_condition_ttldickeyxxx2013-05-231-1/+1
|
* Allow fetching multiple values from the cache at onceDaniel Schierbeck2013-05-061-0/+28
| | | | | Add a simple API for fetching a list of entries from the cache, where any missing entries are computed by a supplied block.
* Making the retrieval of the cache store class a method, also wrotewangjohn2013-04-281-10/+23
| | | | comments for the expand_cache_key method.
* switch (and lazily convert) ivar names to 3.xSam Ruby2013-04-161-36/+36
|
* remove unused payloads in blocks in caching instrumentationVipul A M2013-03-191-3/+3
|
* Remove warning: shadowing outer local variableCarlos Antonio da Silva2013-01-191-1/+1
|
* Refactor ActiveSupport::Cache::Store#fetch.Joey Butler2013-01-191-25/+41
|
* remove meaningless AS::FrozenObjectErrorAkira Matsuda2013-01-021-1/+0
|
* Replace comments' non-breaking spaces with spacesclaudiob2012-12-041-1/+1
| | | | | | | | | | Sometimes, on Mac OS X, programmers accidentally press Option+Space rather than just Space and don’t see the difference. The problem is that Option+Space writes a non-breaking space (0XA0) rather than a normal space (0x20). This commit removes all the non-breaking spaces inadvertently introduced in the comments of the code.
* pass the key to the block in cache.fetch on missesNoah Hendrix2012-10-231-5/+5
|
* Ensure expires_in and created_at timestamps aren't nil when attempting to ↵Joshua Peek2012-10-101-1/+1
| | | | upgrade cache
* fix broken cache testsBrian Durand2012-09-301-2/+2
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 04:13:33 +0000