Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix Cache#fetch instrumentation | Robin Clowers | 2015-09-14 | 1 | -13/+11 |
| | | | | | Before this change, you couldn't tell if a read was a hit or not when you called fetch. | ||||
* | Correct cache store superclass in comment | Jonah Burke | 2015-08-19 | 1 | -1/+1 |
| | |||||
* | Skip the `:race_condition_ttl` branch if the option is 0 or nil. This fixes ↵ | Matt Wilde | 2015-03-11 | 1 | -2/+2 |
| | | | | an issue with the redis cache, where this code will sometimes throw an error out of SETEX when passing 0 as the `expires_at`. | ||||
* | Doc fix [ci skip] | Sushruth Sivaramakrishnan | 2015-03-05 | 1 | -1/+1 |
| | |||||
* | fixes documentation for returned hash in cache.fetch_multi | Michael Raidel | 2015-03-04 | 1 | -2/+5 |
| | |||||
* | Instrument read_multi. | Kasper Timm Hansen | 2015-02-21 | 1 | -13/+27 |
| | | | | | | | | | | Adds `read_multi` instrumentation formatted as: Caches multi read: - views/david/2/4184ab71db6849621a4d8820fcd2c0ad - views/david/2/4184ab71db6849621a4d8820fcd2c0ad - views/david/3/4184ab71db6849621a4d8820fcd2c0ad - views/david/3/4184ab71db6849621a4d8820fcd2c0ad | ||||
* | Remove deprecated ActiveSupport::Cache::Store.instrument | Rafael Mendonça França | 2015-01-04 | 1 | -13/+0 |
| | |||||
* | Remove conversion code for old Rails cache entry | Rafael Mendonça França | 2015-01-01 | 1 | -24/+0 |
| | | | | | | | | | This code was there just to convert entries generated in Rails 4.0.0.beta1 applications to a supported format. It is almost unlikely that any existent application have this cache entry format in their caches at the point that Rails 5 will be released so we don't need this code anymore. | ||||
* | Check by @v before converting the entry on expired? | Rafael Mendonça França | 2015-01-01 | 1 | -1/+1 |
| | | | | | | | We should convert when @v is defined not @value. The test was calling value first that already converts the entry so we are not catching this bug. | ||||
* | Docs: grammar fix for fetch. [ci skip] | Mike Coutermarsh | 2014-08-08 | 1 | -1/+1 |
| | |||||
* | Merge pull request #15943 from wagenet/cache-instrumentation | Rafael Mendonça França | 2014-06-27 | 1 | -11/+10 |
|\ | | | | | | | Always instrument ActiveSupport::Cache | ||||
| * | Always instrument ActiveSupport::Cache | Peter Wagenet | 2014-06-27 | 1 | -11/+10 |
|/ | | | | | | | | The current approach is broken because it uses a thread local value which means on multi-threaded environments it has to be turned on per thread. Secondly, ActiveSupport::Notifications does not instrument items when there are not subscribers so this flag is unnecessary. | ||||
* | Return a hash rather than array from fetch_multi | Parker Selbert | 2014-02-26 | 1 | -6/+5 |
| | | | | | | | The current implementation of `fetch_multi` returns an array and has no means to easily backtrack which names yielded which results. By changing the return value to a Hash we retain the name information. Hash#values can be used on the response if only the values are needed. | ||||
* | docs, be clear that `options` is a hash. Closes #11904. [ci skip]. | Yves Senn | 2014-02-03 | 1 | -1/+1 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-12-20 | 1 | -1/+1 |
|\ | |||||
| * | Typos. return -> returns. [ci skip] | Lauro Caetano | 2013-12-03 | 1 | -1/+1 |
| | | |||||
* | | Remove deprecated cattr_* requires | Genadi Samokovarov | 2013-12-03 | 1 | -1/+1 |
|/ | |||||
* | Change syntax format for example returned values | Prem Sichanugrist | 2013-11-11 | 1 | -1/+1 |
| | | | | | | | | | According to our guideline, we leave 1 space between `#` and `=>`, so we want `# =>` instead of `#=>`. Thanks to @fxn for the suggestion. [ci skip] | ||||
* | Aesthetics | David Heinemeier Hansson | 2013-11-03 | 1 | -22/+30 |
| | |||||
* | Fix small typo in docs | Jonathan Baudanza | 2013-09-25 | 1 | -1/+1 |
| | |||||
* | cache.exists? should return true/false | Jade Tucker | 2013-07-07 | 1 | -1/+1 |
| | |||||
* | correction on cache.fetch race_condition_ttl | dickeyxxx | 2013-05-23 | 1 | -1/+1 |
| | |||||
* | Allow fetching multiple values from the cache at once | Daniel Schierbeck | 2013-05-06 | 1 | -0/+28 |
| | | | | | Add a simple API for fetching a list of entries from the cache, where any missing entries are computed by a supplied block. | ||||
* | Making the retrieval of the cache store class a method, also wrote | wangjohn | 2013-04-28 | 1 | -10/+23 |
| | | | | comments for the expand_cache_key method. | ||||
* | switch (and lazily convert) ivar names to 3.x | Sam Ruby | 2013-04-16 | 1 | -36/+36 |
| | |||||
* | remove unused payloads in blocks in caching instrumentation | Vipul A M | 2013-03-19 | 1 | -3/+3 |
| | |||||
* | Remove warning: shadowing outer local variable | Carlos Antonio da Silva | 2013-01-19 | 1 | -1/+1 |
| | |||||
* | Refactor ActiveSupport::Cache::Store#fetch. | Joey Butler | 2013-01-19 | 1 | -25/+41 |
| | |||||
* | remove meaningless AS::FrozenObjectError | Akira Matsuda | 2013-01-02 | 1 | -1/+0 |
| | |||||
* | Replace comments' non-breaking spaces with spaces | claudiob | 2012-12-04 | 1 | -1/+1 |
| | | | | | | | | | | Sometimes, on Mac OS X, programmers accidentally press Option+Space rather than just Space and don’t see the difference. The problem is that Option+Space writes a non-breaking space (0XA0) rather than a normal space (0x20). This commit removes all the non-breaking spaces inadvertently introduced in the comments of the code. | ||||
* | pass the key to the block in cache.fetch on misses | Noah Hendrix | 2012-10-23 | 1 | -5/+5 |
| | |||||
* | Ensure expires_in and created_at timestamps aren't nil when attempting to ↵ | Joshua Peek | 2012-10-10 | 1 | -1/+1 |
| | | | | upgrade cache | ||||
* | fix broken cache tests | Brian Durand | 2012-09-30 | 1 | -2/+2 |
| | |||||
* | Optimize ActiveSupport::Cache::Entry to reduce memory and processing overhead. | Brian Durand | 2012-09-30 | 1 | -63/+85 |
| | |||||
* | update AS docs [ci skip] | Francesco Rodriguez | 2012-09-17 | 1 | -71/+79 |
| | |||||
* | Fix ActiveSupport Cache decrement method description | Alexey Vakhov | 2012-05-25 | 1 | -1/+1 |
| | |||||
* | Merge pull request #4496 from makeable/master | Aaron Patterson | 2012-05-03 | 1 | -1/+1 |
|\ | | | | | Active Support Cache - race_condition_ttl should be an integer | ||||
| * | race_condition_ttl should be an integer | Matt Williams | 2012-01-17 | 1 | -1/+1 |
| | | |||||
* | | Allow retrieve_cache_key to work on collections such as ActiveRecord::Relation. | Erich Menge | 2012-03-12 | 1 | -0/+1 |
| | | |||||
* | | suggested changes. | Nupur Jain | 2012-02-21 | 1 | -5/+1 |
| | | |||||
* | | Inline the prefix assignment so it doesnt look so daft | David Heinemeier Hansson | 2012-01-27 | 1 | -2/+1 |
| | | |||||
* | | Revert "Fix expanding cache key for single element arrays" | David Heinemeier Hansson | 2012-01-27 | 1 | -1/+1 |
|/ | | | | | | This reverts commit abe915f23777efe10f17d611bf5718ca855a0704. This broke all existing keys and it's wrong anyway. The array is just there as a convenience option for building the string. It's intentional that [ "stuff"] and "stuff" generates the same key. | ||||
* | Merge pull request #4007 from exviva/expand_cache_key_for_one_element_array | José Valim | 2011-12-16 | 1 | -1/+1 |
|\ | | | | | Fix expanding cache key for single element arrays | ||||
| * | Fix expanding cache key for single element arrays | Olek Janiszewski | 2011-12-16 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | In short: expand_cache_key(element) should not equal expand_cache_key([element]) This way a fragment cache key for an index page with only a single element in the collection is different than a fragment cache for a typical show page for that element. | ||||
* | | Add ActiveSupport::Cache::NullStore to expose caching interface without ↵ | Brian Durand | 2011-12-12 | 1 | -0/+1 |
|/ | | | | actually caching for development and test environments. | ||||
* | Optimize cache expansion by skipping rails cache id in nested keys. | José Valim | 2011-11-23 | 1 | -54/+60 |
| | |||||
* | Fix #3737 AS::expand_cache_key generates wrong key in certain situations ↵ | Olek Janiszewski | 2011-11-23 | 1 | -1/+1 |
| | | | | | | | (part 2) `nil` and `false` both expand to `""` (empty string), while `true` expands to `"true"`; `false` should expand to `"false"` | ||||
* | Fix #3737 AS::expand_cache_key generates wrong key in certain situations | Olek Janiszewski | 2011-11-23 | 1 | -10/+4 |
| | | | | | `cache_key` method is never called when the argument is a 1-element array with something that responds to `cache_key` | ||||
* | Revert "tests predicates according to the boolean interpretation of their ↵ | Xavier Noria | 2011-11-21 | 1 | -2/+6 |
| | | | | | | | | | return value, not expecting specifically true or false" Reason: there were some genuine tests for false when reading values, going to revise those ones. This reverts commit a539a5e3f3be68f027d3dfe43f88dc9f0642c743. | ||||
* | tests predicates according to the boolean interpretation of their return ↵ | Xavier Noria | 2011-11-21 | 1 | -6/+2 |
| | | | | value, not expecting specifically true or false |