aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/CHANGELOG.md
Commit message (Collapse)AuthorAgeFilesLines
* Changelog improvements [ci skip]Carlos Antonio da Silva2013-01-021-2/+2
|
* missing changelog entry for #8682Akira Matsuda2013-01-021-0/+4
|
* Introduce assert_not to replace 'assert !foo'Jeremy Kemper2012-12-281-0/+2
|
* Merge pull request #7376 from ↵Rafael Mendonça França2012-12-211-0/+9
|\ | | | | | | | | | | | | | | | | dmitriy-kiriyenko/fix-double-callback-in-same-statement Prevent callback from being set twice. Conflicts: activesupport/CHANGELOG.md
| * Prevent callback from being set twice.Dmitriy Kiriyenko2012-12-201-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When you add one callack in two separate `set_callback` calls - it is only called once. When you do it in one `set_callback` call - it is called twice. This violates the principle of least astonishment for me. Duplicating callback is usually an error. There is a correct and obvious way to do anything without this "feature". If you want to do before_save :clear_balance, :calculate_tax, :clear_balance or whatever, you should better do before_save :carefully_calculate_tax def carefully_calculate_tax clear_balance calculate_tax clear_balance end And this even opens gates for some advanced refactorings, unlike the first approach. My assumptions are: - Principle of least astonishment is violated, when callbacks are either prevented from duplication, or not. - Duplicating callbacks is usually an error. When it is intentional - it's a smell of a bad design and can be approached without abusing this "feature". My suggestion is: do not allow duplicating callbacks in one callback call, like it is not allowed in separate callbacks call.
* | Revert "Make sure that ActiveSupport::Logger includes the Logger extensions ↵David Heinemeier Hansson2012-12-211-1/+1
| | | | | | | | | | | | from core_ext/logger" (some confusion over deprecation) This reverts commit d00f568a83a5159ed93618b1081bd17858536d1c.
* | Make sure that ActiveSupport::Logger includes the Logger extensions from ↵David Heinemeier Hansson2012-12-211-1/+1
| | | | | | | | core_ext/logger
* | Add ActiveSupport::Logger#silence that works the same as the old ↵David Heinemeier Hansson2012-12-211-0/+4
| | | | | | | | Logger#silence extension
* | Fix Action Mailer changelog indenation to match other changelogsCarlos Antonio da Silva2012-12-191-3/+4
| | | | | | | | Also some minor improvements to other changelogs. [ci skip]
* | Remove unicode character encoding from ActiveSupport::JSON.encodeBrett Carter2012-12-141-0/+6
| | | | | | | | | | | | | | | | | | | | The encoding scheme (e.g. ☠ -> "\u2620") was broken for characters not in the Basic Multilingual Plane. It is possible to escape them for json using the weird encoding scheme of a twelve-character sequence representing the UTF-16 surrogate pair (e.g. '𠜎' -> "\u270e\u263a") but this wasn't properly handled in the escaping code. Since raw UTF-8 is allowed in json, it was decided to simply pass through the raw bytes rather than attempt to escape them.
* | Convert changelogs to 1.9 hash style and fix some formatting [ci skip]Carlos Antonio da Silva2012-12-141-3/+3
|/
* Deprecate obsolete Time to DateTime fallback methodsAndrew White2012-12-111-0/+7
| | | | | | | The Time.time_with_datetime_fallback, Time.utc_time and Time.local_time methods were added to handle the limitations of Ruby's native Time implementation. Those limitations no longer apply so we are deprecating them in 4.0 and they will be removed in 4.1.
* Deprecate Date#to_time_in_current_zoneAndrew White2012-12-111-0/+2
| | | | | | | | | | | | | The to_time_in_current_zone method doesn't match the naming of the methods for converting to ActiveSupport::TimeWithZone on Time and DateTime. Since DateTime inherits from Date that has led to confusion with some users using the to_time_in_current_zone method with DateTime instances and having the time part dropped and the UTC offset lost. This commit fixes this by deprecating the old method and adding a new in_time_zone method which matches the naming for DateTime and Time. This should prevent accidently dropping times and UTC offsets when converting DateTime instances to ActiveSupport::TimeWithZone.
* Add String#in_time_zone methodAndrew White2012-12-111-0/+2
| | | | | | This commit adds a convenience method for converting a string to an ActiveSupport::TimeWithZone instance using the configured Time.zone or another passed as an argument.
* Rename ActiveSupport::BasicObject to ActiveSupport::ProxyObjectFrancesco Rodriguez2012-12-071-0/+6
| | | | | AS::BasicObject is used for proxy classes. Let's give it a less concerning name. Also, it avoids the confusion with Ruby's Basic Object.
* Patched Marshal#load to work with constant autoloading ↵Uriel Katz2012-12-011-0/+5
| | | | (active_support/dependecies.rb) (issue #8167)
* Make `Time.zone.parse` to work with JavaScript date stringsAndrew White2012-12-011-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Chrome, Safari and Firefox serialize Date objects to strings such as 'Mon May 28 2012 00:00:00 GMT-0700 (PDT)'. When these strings are parsed the zone is interpreted as 'GMT-0700' which doesn't exist in the TzInfo list of timezones. By taking advantage of the improved date/time handling in 1.9.3 we can use `Date._parse` and the `:offset` value which is parsed correctly. Three tests were amended to make them pass: 1. test_parse_with_old_date This needed changing to a different value because the original value was before EST was adopted so was being changed to a LMT (Local Mean Time) value after the change. It didn't before because `DateTime` just has offsets from UTC not timezones. 2. test_parse_should_not_black_out_system_timezone_dst_jump Changed the implementation of this test as the stubs were dependent on internal implementation details of the test. Confirmed that the modified test still failed when the implementation of `parse` was restored to pre-#5571. 3. test_parse_should_black_out_app_timezone_dst_jump Ditto. Closes #5770.
* Add #seconds_until_end_of_day to DateTime and TimeOlek Janiszewski2012-11-291-1/+10
|
* Simplify String#mb_chars and stop proxying #classSteve Klabnik2012-11-281-0/+2
| | | | | | | | This behavior mattered under Ruby 1.8, but that doesn't matter now that we don't support it. In addition, we don't want to proxy the #class method. A test was added to prevent against regressions.
* Properly deprecate #pending from AS::TestCaseCarlos Antonio da Silva2012-11-181-0/+2
| | | | Check https://github.com/rails/rails/pull/4575#issuecomment-5765575.
* Revert "Merge pull request #4575 from carlosantoniodasilva/remove-test-pending"Carlos Antonio da Silva2012-11-181-2/+0
| | | | | | | | | This reverts commit 1620df78dff527b4fa3f7b204fa05d1b630aae17, reversing changes made to 2d000328dfc0d4b297fb4bdcebc9af6c2fb559dc. Conflicts: activesupport/CHANGELOG.md activesupport/lib/active_support/test_case.rb
* Merge pull request #8219 from nikitug/threadsafe_xmlmini_with_backendRafael Mendonça França2012-11-151-0/+13
|\ | | | | | | | | | | | | Make XmlMini.with_backend usable with threads Conflicts: activesupport/CHANGELOG.md
| * Make XmlMini.with_backend usable with threadsNikita Afanasenko2012-11-151-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | `XmlMini.with_backend` now may be safely used with threads: Thread.new do XmlMini.with_backend("REXML") { rexml_power } end Thread.new do XmlMini.with_backend("LibXML") { libxml_power } end Each thread will use it's own backend.
* | let remove_constant still delete Kernel#autoload constants [rounds #8213]Xavier Noria2012-11-151-1/+1
|/ | | | | The method #remove_const does not load the file, so we can still remove the constant.
* dependencies no longer trigger Kernel#autoload in remove_const [fixes #8213]Xavier Noria2012-11-151-0/+2
|
* Use new mocha version and add changelog entry for #8180Carlos Antonio da Silva2012-11-131-0/+2
|
* `#as_json` isolates options when encoding a hash. Closes #8182Yves Senn2012-11-121-0/+5
| | | | | | Setting options in a custom `#as_json` method had side effects. Modifications of the `options` hash leaked outside and influenced the conversion of other objects contained in the hash.
* Deprecate Hash#diff.Steve Klabnik2012-11-091-0/+3
| | | | | | It's no longer used in Rails any more. See https://github.com/rails/rails/pull/8142\#issuecomment-10227297 for more
* Merge pull request #7763 from route/full-captureCarlos Antonio da Silva2012-11-081-0/+1
|\ | | | | Kernel#capture replaced by version which can catch output from subprocesses
| * Kernel#capture replaced by version which can catch output from subprocessesDmitry Vorotilin2012-11-011-0/+1
| |
* | Use `tag!` instead of `method_missing` in `to_xml` conversions.Nikita Afanasenko2012-11-041-0/+4
| | | | | | | | Since version `3.0.x` `Builder` caches method passed to `method_missing` each time. This commit replaces `method_missing` call with `tag!` call to prevent method redefinition on each `to_xml` call with the same builder.
* | Fixed timezone mapping of Solomon Islands.Steve Klabnik2012-11-011-0/+2
|/ | | | | | | | Fixes #8095. For reference, here is the discussion about the mapping being incorrect: http://rubyforge.org/pipermail/tzinfo-users/2012-November/000114.html
* Make caller attribute in deprecation methods optionalAlexey Gaziev2012-10-301-0/+5
|
* atomicc.rb: Don't assume we may chown/chmod a file.Daniele Sluijters2012-10-291-0/+2
| | | | | | | | | | | | | | | | | | | | | | Previously this code just assumed it is capable of changing the file ownership, both user and group. This will fail in a lot of scenario's unless: * The process is run as a superuser (root); * The owning user and group are already set to the user and group we're trying to chown to; * The user chown'ing only changes the group to another group it is a member of. If either of those conditions are not met the filesystem will simply deny the operation throwing an error. It is also not always possible to do a chmod, there might be a SELinux policy or another limitation preventing the user to change the file mode. To this end the chmod call has also been added to the rescue block. I've also added a little comment above the chmod command that doing a chmod on a file which has an ACL set will cause the ACL to be recalculated / modified.
* Implement replace method so key? works correctly.David Graham2012-10-261-0/+2
|
* add more testcases and doc about Hash#extract!Mikhail Dieterle2012-10-081-2/+2
|
* make Hash#extract! more symmetric with Hash#sliceMikhail Dieterle2012-10-081-0/+11
|
* Merge pull request #7708 from bdurand/optimize_log_subscribersRafael Mendonça França2012-10-011-0/+2
|\ | | | | Optimize log subscribers to check if the log level is sufficient
| * Optimize log subscribers to check if the log level is sufficient before ↵Brian Durand2012-09-301-0/+2
| | | | | | | | performing an operations.
* | New CHANGELOG entries always in the topRafael Mendonça França2012-10-011-2/+2
| |
* | Optimize ActiveSupport::Cache::Entry to reduce memory and processing overhead.Brian Durand2012-09-301-0/+2
| |
* | Tests tag the Rails log with the current test class and test caseJeremy Kemper2012-09-261-0/+7
| |
* | Add logger.push_tags and .pop_tags to complement logger.taggedJeremy Kemper2012-09-261-0/+14
| |
* | Add changelog entry and docs about class delegation using the symbol :classCarlos Antonio da Silva2012-09-201-5/+24
|/ | | | See #7613. [ci skip]
* Date.beginning_of_week thread local and beginning_of_week application config ↵gregolsen2012-09-181-0/+2
| | | | option added (default is Monday)
* set up config_accessor with a default value by blockLarry Lv2012-09-171-0/+13
| | | | | | | | | | | | | | | | | | * ActiveSupport::Configurable should allow config_accessor to take default value by block, just like cattr_accessor. class User include ActiveSupport::Configurable config_accessor :hair_colors do [:brown, :black, :blonde, :red] end end User.hair_colors # => [:brown, :black, :blonde, :red] * remove trailing whitespaces in configurable.rb and its test file. * Update ActiveSupport CHANGELOG.
* Deprecate ActiveSupport::Benchmarkable#silence.Steve Klabnik2012-09-151-0/+4
| | | | | | | Due to its lack of thread safety, we're deprecating this, and it will be removed in Rails 4.1. Fixes #4060.
* Allow passing block to deep_merge and deep_merge!Pranas Kiziela2012-09-131-0/+3
| | | | | Hash#merge accepts block that you can use to customize how hash values are merged. This change makes merge and deep_merge compatible.
* Copy-edit deprecation relared documentation [ci skip]Rafael Mendonça França2012-09-131-16/+15
|
* Change ActiveSupport::Deprecation to class.Piotr Niełacny2012-09-131-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | ActiveSupport::Deprecation is now a class rather than a module. You can get instance of ActiveSupport::Deprecation calling #instance method. ActiveSupport::Deprecation.instance But when you need to get new object od ActiveSupport::Deprecation you need to just call #new. @instance = ActiveSupport::Deprecation.new Since you can create a new object, you can change the version and the name of the library where the deprecator concerned. ActiveSupport::Deprecation.new('2.0', 'MyGem') If you need use another deprecator instance you can select it in the options of deprecate method. deprecate :method, :deprecator => deprecator_instance Documentation has been updated.