Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Provide a sensible default host | George Claghorn | 2018-01-16 | 6 | -8/+6 |
| | |||||
* | Extract content types from blob data | George Claghorn | 2018-01-15 | 16 | -32/+132 |
| | |||||
* | Instrument image transformation | George Claghorn | 2018-01-10 | 1 | -7/+9 |
| | |||||
* | Instrument preview image drawing | George Claghorn | 2018-01-10 | 1 | -3/+5 |
| | |||||
* | Update error names in docs [ci skip] | George Claghorn | 2018-01-10 | 1 | -3/+3 |
| | |||||
* | Add missing `# frozen_string_literal: true` | Ryuta Kamizono | 2018-01-11 | 3 | -0/+6 |
| | |||||
* | Correct comment [ci skip] | George Claghorn | 2018-01-10 | 1 | -1/+1 |
| | |||||
* | Extract Analyzable and Representable concerns | George Claghorn | 2018-01-10 | 8 | -150/+158 |
| | |||||
* | Change Active Storage destroy callbacks | kami-zh | 2018-01-09 | 2 | -2/+8 |
| | | | | | There is concern that only blob are deleted depending on the `before_destroy` definition order which throws abort. | ||||
* | Rebuild activestorage.js | Javan Makhmali | 2018-01-08 | 1 | -1/+1 |
| | | | | To pick up 21417e02e906f6b64f013aafefdc0cb8ea8b5e74 | ||||
* | Work around Firefox's refusal to dispatch events on disabled elements. Fixes ↵ | Javan Makhmali | 2018-01-08 | 1 | -1/+10 |
| | | | | | | #31393 Brought to you by a 12 year old Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=329509 | ||||
* | Fix attaching blobs to optimistically-locked records | George Claghorn | 2018-01-08 | 1 | -2/+2 |
| | | | | | | Explicitly declare inverse associations so ActiveStorage::Attachment touches the original record instance. Closes #31542. | ||||
* | Allow overriding filename in `Blob#service_url` | Rosa Gutierrez | 2018-01-08 | 2 | -4/+15 |
| | | | | | | | This is useful when we have several representations for the same underlying file, each one with a different name, and we need to provide a custom download URL based on that name and not that of the underlying file. | ||||
* | Document automatic width-height swapping [ci skip] | George Claghorn | 2018-01-07 | 1 | -0/+2 |
| | |||||
* | Remove redundant sentences [ci skip] | George Claghorn | 2018-01-07 | 2 | -4/+2 |
| | |||||
* | Tweak engine for readability | George Claghorn | 2018-01-07 | 1 | -11/+13 |
| | |||||
* | Force content disposition to attachment for specific content types | Rosa Gutierrez | 2018-01-05 | 5 | -2/+36 |
| | | | | | | | | | | | | | | In this way we avoid HTML, XML, SVG and other files that can be rendered by the browser to be served inline by default. Depending on the origin from where these files are served, this might lead to XSS vulnerabilities, and in the best case, to more realistic phishing attacks and open redirects. We force it rather than falling back to it when other disposition is not provided. Otherwise it would be possible for someone to force inline just by passing `disposition=inline` in the URL. The list of content types to be served as attachments is configurable. | ||||
* | Configure previewer/analyzer command paths centrally | George Claghorn | 2018-01-03 | 5 | -23/+15 |
| | |||||
* | Exclude ActiveStorage::SetBlob from API docs [ci skip] | George Claghorn | 2018-01-02 | 1 | -1/+1 |
| | |||||
* | Restore support for the -layers transformation | George Claghorn | 2018-01-02 | 3 | -14/+22 |
| | |||||
* | Merge pull request #31606 from yhirano55/bump_license_years_for_2018 | Arun Agrawal | 2017-12-31 | 2 | -2/+2 |
|\ | | | | | Bump license years for 2018 | ||||
| * | Bump license years for 2018 | Yoshiyuki Hirano | 2017-12-31 | 2 | -2/+2 |
| | | |||||
* | | Expose ActiveStorage::Analyzer#logger in API docs [ci skip] | George Claghorn | 2017-12-31 | 1 | -1/+1 |
| | | | | | | | | Clarify that it's public API and may be used in third-party analyzers. | ||||
* | | Expose ActiveStorage::Previewer#logger in API docs [ci skip] | George Claghorn | 2017-12-31 | 1 | -2/+2 |
| | | | | | | | | Clarify that it's public API intended for use by third-party previewers. It shouldn't be removed without deprecation even though it isn't used by the built-in previewers. | ||||
* | | Suppress noise from drawing command invocations | George Claghorn | 2017-12-31 | 1 | -1/+1 |
| | | |||||
* | | Append extension to tempfile name | George Claghorn | 2017-12-31 | 3 | -2/+23 |
|/ | | | | | | Fixes analyzing an SVG image without an XML declaration. ImageMagick occasionally looks to the extension when it can't discern the type of an image file from its contents. References #31356. | ||||
* | prevent shadowing outer variables | Dorian Marié | 2017-12-25 | 1 | -4/+4 |
| | |||||
* | Active Storage: Fix direct uploads in IE 11 | Javan Makhmali | 2017-12-23 | 2 | -4/+18 |
| | | | | | Fixes #31531 Closes #31540 | ||||
* | Merge pull request #31538 from ↵ | Eileen M. Uchitelle | 2017-12-22 | 1 | -2/+2 |
|\ | | | | | | | | | yhirano55/add_cloud_service_links_to_readme_in_active_storage Add cloud service's links to README of Active Storage [ci skip] | ||||
| * | Add cloud service's links to README of Active Storage [ci skip] | Yoshiyuki Hirano | 2017-12-22 | 1 | -2/+2 |
| | | |||||
* | | Add support for combined MiniMagick transformations | Robert Glaser | 2017-12-22 | 2 | -6/+30 |
| | | |||||
* | | Merge pull request #31537 from yhirano55/pass_options_to_rails_blob_url | Rafael França | 2017-12-21 | 1 | -1/+1 |
|\ \ | | | | | | | Pass options to rails_blob_url | ||||
| * | | Pass options to rails_blob_url | Yoshiyuki Hirano | 2017-12-22 | 1 | -1/+1 |
| |/ | |||||
* / | [ci skip] Remove needless from doc for ActiveStorage::Variant | Yoshiyuki Hirano | 2017-12-22 | 1 | -1/+1 |
|/ | |||||
* | Delete MiniMagick tempfile when transformation fails | George Claghorn | 2017-12-18 | 1 | -1/+7 |
| | |||||
* | Ensure MiniMagick tempfiles are properly unlinked after image transformation | George Claghorn | 2017-12-18 | 1 | -9/+18 |
| | |||||
* | Convert non-web image (e.g. PSD) variants to PNG | George Claghorn | 2017-12-18 | 3 | -12/+53 |
| | |||||
* | Update ActiveStorage::Blob#transformation docs [ci skip] | George Claghorn | 2017-12-16 | 1 | -3/+3 |
| | |||||
* | Handle invalid signed blob IDs gracefully | George Claghorn | 2017-12-15 | 7 | -18/+51 |
| | |||||
* | Restrict variants to variable image blobs | George Claghorn | 2017-12-15 | 4 | -4/+27 |
| | |||||
* | Merge branch 'master' into activestorage-guide | Jeffrey Guenther | 2017-12-14 | 9 | -20/+25 |
|\ | |||||
| * | Merge pull request #31434 from olivierlacan/boot-feedback | Sean Griffin | 2017-12-14 | 1 | -0/+4 |
| |\ | | | | | | | Provide instant feedback when booting Rails | ||||
| | * | Provide instant feedback when booting Rails | Olivier Lacan | 2017-12-13 | 1 | -0/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've noticed during pair/mob programming sessions with peers that despite the speed boosts provided by Bootsnap and Spring, there is a noticeable latency between firing a bin/rails server command and any feedback being provided to the console. Depending on the size of the application this lack of feedback can make it seem like something is wrong when Rails is simply busy initializing. This change may seem gratuitous but by just printing one line to STDOUT we're giving a clear signal to the Rails user that their command has been received and that Rails is indeed booting. It almost imperciptibly makes Rails feel more responsive. Sure the code doesn't look very fancy but there's no other appropriate place I could think of putting it than boot.rb. Compare these two GIFs of booting without and with this change: Before: ![Without Boot Feedback](https://user-images.githubusercontent.com/65950/33964140-721041fc-e025-11e7-9b25-9d839ce92977.gif) After: ![With Boot Feedback](https://user-images.githubusercontent.com/65950/33964151-79e12f86-e025-11e7-93e9-7a75c70d408f.gif) | ||||
| * | | Enable `Layout/LeadingCommentSpace` to not allow cosmetic changes in the future | Ryuta Kamizono | 2017-12-14 | 1 | -4/+0 |
| |/ | | | | | | | Follow up of #31432. | ||||
| * | Expose Active Storage routes | Mehmet Emin INAC | 2017-12-13 | 1 | -6/+6 |
| | | |||||
| * | Exclude ActiveStorage::Filename{#parameters,::Parameters} from API docs [ci ↵ | George Claghorn | 2017-12-13 | 2 | -2/+2 |
| | | | | | | | | skip] | ||||
| * | Merge pull request #31391 from ↵ | Eileen M. Uchitelle | 2017-12-13 | 1 | -1/+5 |
| |\ | | | | | | | | | | | | | 5t111111/fix-active_storage-installation-failure-in-engine Fix active_storage installation failure when in engine | ||||
| | * | Invoke app-prefixed active storage task when in engine | Hirofumi Wakasugi | 2017-12-13 | 1 | -1/+5 |
| | | | |||||
| * | | Fix optimizing GIF variants using mogrify's -layers option | George Claghorn | 2017-12-11 | 1 | -5/+7 |
| | | | |||||
| * | | Revert "Invoke mogrify once when transforming an image" | George Claghorn | 2017-12-11 | 1 | -8/+6 |
| | | | | | | | | | | | | This reverts commit a80f81af055f02bf4625c90470aa90441cf6fc24. |