aboutsummaryrefslogtreecommitdiffstats
path: root/activestorage
Commit message (Collapse)AuthorAgeFilesLines
* Remove errant debugger callGeorge Claghorn2018-05-301-1/+0
|
* Include blob ID in tempfile name for debugging convenienceGeorge Claghorn2018-05-303-10/+20
|
* Fix referenceGeorge Claghorn2018-05-281-1/+1
|
* Verify integrity after chunked downloadGeorge Claghorn2018-05-285-3/+24
|
* Hide Active Storage migration installation task (#33007)utilum2018-05-281-0/+3
| | | Resolves #33006
* Merge pull request #32968 from utilum/shadowing_outer_variableGeorge Claghorn2018-05-231-8/+6
|\ | | | | Avoid 2.6 warning: shadowing outer local variable - list
| * Avoid 2.6 warning: shadowing outer local variable - listutilum2018-05-231-8/+6
| |
* | Enable warnings in all test tasksutilum2018-05-231-6/+6
|/ | | | Also normalize AJ task use t, like all other Rails test tasks.
* Change video preview format from PNG to JPGJavan Makhmali2018-05-233-7/+7
|
* Merge pull request #32144 from kazu9su/masterGeorge Claghorn2018-05-221-0/+4
|\ | | | | Add ActiveStorage::Service::DiskService#url_for_direct_upload test
| * Add ActiveStorage::Service::DiskService#url_for_direct_upload testtommy2018-03-011-0/+4
| |
* | Disable variant options when false or nil presentJacob Smith2018-05-213-12/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In response to https://github.com/rails/rails/issues/32917 In the current implementation, ActiveStorage passes all options to the underlying processor, including when a key has a value of false. For example, passing: ``` avatar.variant(resize: "100x100", monochrome: false, flip: "-90") ``` will return a monochrome image (or an error, pending on ImageMagick configuration) because it passes `-monochrome false` to the command (but the command line does not allow disabling flags this way, as usually a user would omit the flag entirely to disable that feature). This fix only passes those keys forward to the underlying processor if the value responds to `present?`. In practice, this means that `false` or `nil` will be filtered out before going to the processor. One possible use case would be for a user to be able to apply different filters to an avatar. The code might look something like: ``` variant_options = { monochrome: params[:monochrome], resize: params[:resize] } avatar.variant(*variant_options) ``` Obviously some sanitization may be beneficial in a real-world scenario, but this type of configuration object could be used in many other places as well. - Add removing falsy values from varaints to changelog - The entirety of #image_processing_transformation inject block was wrapped in `list.tap` to guard against the default `nil` being returned if no conditional was called. - add test for explicitly true variant options
* | Permit opening a blob in a custom tempdirGeorge Claghorn2018-05-175-9/+26
| |
* | Generate getter and setter methods in mixinJosh Susser2018-05-173-2/+62
| | | | | | | | | | | | | | | | | | | | | | Generated attachment getter and setter methods are created within the model's `GeneratedAssociationMethods` module to allow overriding and composition using `super`. Includes tests for new functionality. Co-authored-by: Josh Susser <josh@hasmanythrough.com> Co-authored-by: Jamon Douglas <terrildouglas@gmail.com>
* | Fix formatting of author credit [ci skip]Ryuta Kamizono2018-05-171-1/+1
| |
* | Active storage: Image variant options not correctlucfranken2018-05-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ### Steps to reproduce Using Rails 5.2.0 When following this example: http://api.rubyonrails.org/classes/ActiveStorage/Variant.html `avatar.variant(resize: "100x100", monochrome: true, flip: "-90")` ### Expected behavior Image should be rendered as flipped. ### Actual behavior I get an error: > failed with error: gm mogrify: Unrecognized option (-90). ### Fix: According to: https://github.com/minimagick/minimagick the option should be called rotate: `avatar.variant(resize: "100x100", monochrome: true, rotate: "-90")` So **flip** changed to **rotate**. ### System configuration **Rails version**: 5.2.0 **Ruby version**: ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin17]
* | Remove unused `require "active_support/core_ext/string/filters"`Ryuta Kamizono2018-05-171-2/+0
| |
* | Add ActiveStorage::Previewer#tempdirGeorge Claghorn2018-05-161-1/+5
| |
* | Add missing block parametersGeorge Claghorn2018-05-162-2/+2
| |
* | Add ActiveStorage::Blob#openGeorge Claghorn2018-05-168-12/+81
| | | | | | | | [David Robertson & George Claghorn]
* | Add option to ActiveStorage::Blob to set extract_content_type_from_ioRyan Davidson2018-05-084-9/+37
| | | | | | | | | | | | | | This adds a boolean argument called identify to ActiveStorage::Blob methods #create_after_upload, #build_after_upload and #upload. It allows a user to bypass the automatic content_type inference from the io.
* | Assert correct response bodyGeorge Claghorn2018-05-031-4/+6
| |
* | Stream blobs from diskGeorge Claghorn2018-05-021-2/+13
| |
* | Support streaming downloads from Google Cloud StorageGeorge Claghorn2018-05-013-24/+43
| |
* | Avoid duplicating downloads from Google Cloud Storage in memoryGeorge Claghorn2018-04-291-2/+2
| | | | | | | | References #32703.
* | Stream blobs from disk in 5 MB chunksGeorge Claghorn2018-04-292-4/+4
| | | | | | | | Match other services, which all use a 5 MB chunk size.
* | Merge pull request #31956 from fatkodima/has_attached-presence-validationEileen M. Uchitelle2018-04-272-0/+34
|\ \ | | | | | | has_(one/many)_attached presence validation
| * | has_(one/many)_attached presence validationfatkodima2018-02-112-0/+34
| | |
* | | Move #extract_metadata_from to ActiveStorage's TestHelperRicardo Díaz2018-04-253-10/+4
| | | | | | | | | | | | | | | | | | ImageAnalyzerTest and VideoAnalyzerTest are defining the same helper, since both use `#create_file_blob` that is defined in TestHelper, it makes sense to move `#extract_metadata_from` to that side.
* | | Simplify URL generation for partial downloads from GCSGeorge Claghorn2018-04-251-1/+2
| | |
* | | Unminify activestorage.jsJavan Makhmali2018-04-256-1386/+1093
| | |
* | | Flush tempfile after populating itGeorge Claghorn2018-04-231-0/+1
| | | | | | | | | | | | Ensure that other processes like ImageMagick and FFmpeg see the complete contents of the file.
* | | Merge pull request #32471 from janko-m/use-image_processing-gemGeorge Claghorn2018-04-2310-74/+171
|\ \ \ | | | | | | | | Use ImageProcessing gem for ActiveStorage variants
| * | | Don't swallow LoadError raised for missing libvipsJanko Marohnić2018-04-231-3/+7
| | | |
| * | | Add CHANGELOG entryJanko Marohnić2018-04-231-0/+19
| | | |
| * | | Recommend using :resize_to_fit after allJanko Marohnić2018-04-235-13/+13
| | | |
| * | | Remove warning that image will be loaded into memoryJanko Marohnić2018-04-231-4/+4
| | | | | | | | | | | | | | | | | | | | This is not true anymore, the image will be downloaded into a temporary file in a streaming fashion.
| * | | Show ImageProcessing macros in a dedicated exampleJanko Marohnić2018-04-232-16/+25
| | | |
| * | | Ensure result file is deleted on uploading errorsJanko Marohnić2018-04-221-4/+10
| | | |
| * | | Rename ActiveStorage.processor to .variant_processorJanko Marohnić2018-04-225-15/+15
| | | |
| * | | Use ImageProcessing gem for ActiveStorage variantsJanko Marohnić2018-04-187-66/+125
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ImageProcessing gem is a wrapper around MiniMagick and ruby-vips, and implements an interface for common image resizing and processing. This is the canonical image processing gem recommended in [Shrine], and that's where it developed from. The initial implementation was extracted from Refile, which also implements on-the-fly transformations. Some features that ImageProcessing gem adds on top of MiniMagick: * resizing macros - #resize_to_limit - #resize_to_fit - #resize_to_fill - #resize_and_pad * automatic orientation * automatic thumbnail sharpening * avoids the complex and inefficient MiniMagick::Image class * will use "magick" instead of "convert" on ImageMagick 7 However, the biggest feature of the ImageProcessing gem is that it has an alternative implementation that uses libvips. Libvips is an alternative to ImageMagick that can process images very rapidly (we've seen up 10x faster than ImageMagick). What's great is that the ImageProcessing gem provides the same interface for both implementations. The macros are named the same, and the libvips implementation does auto orientation and thumbnail sharpening as well; only the operations/options specific to ImageMagick/libvips differ. The integration provided by this PR should work for both implementations. The plan is to introduce the ImageProcessing backend in Rails 6.0 as the default backend and deprecate the MiniMagick backend, then in Rails 6.1 remove the MiniMagick backend.
* | | | Halve memory allocation in S3Service#downloadJanko Marohnić2018-04-231-1/+1
|/ / / | | | | | | | | | | | | | | | | | | | | | Aws::S3::Object#get returns a response with object content wrapped in an in-memory StringIO object. StringIO#read will return a copy of the content, which is not necessary because we can return the content directly using StringIO#string. This halves memory allocation of S3Service#download, because we remove unnecessary content duplication.
* | | Always exclude JSON root from direct_uploads#create responseJavan Makhmali2018-04-102-1/+24
| | | | | | | | | | | | | | | | | | The JavaScript component expects a bare response. Fixes #32365
* | | Merge pull request #32494 from dixpac/as_fix_outdated_documentation_for_variantsRyuta Kamizono2018-04-082-4/+4
|\ \ \ | | | | | | | | Fix leftover references to VariantsController in AS documentation [ci skip]
| * | | Fix leftover references to VariantsController [ci skip]dixpac2018-04-082-4/+4
| | | | | | | | | | | | | | | | | | | | VariantsController has been merged to RepresentationsController, this PR fixes outdated references to VariantsController in ActiveStorage documentation.
* | | | Enable verbose option in ActiveStorageYoshiyuki Hirano2018-04-081-0/+1
|/ / /
* | | Use a current model to provide the host for service urlsAndrew White2018-04-066-6/+26
| | | | | | | | | | | | | | | | | | | | | Trying to pass the current request down to the service so that it can create full urls instead of paths makes the API messy so use a model based on ActiveSupport::CurrentAttributes to provide the current host to services that need it (primarily the disk service).
* | | Protect all active storage controllers agains CSRFRafael Mendonça França2018-04-065-5/+11
| | | | | | | | | | | | | | | Before it was possible to for example use the direct upload controller without using the site.
* | | fixes a bug in IE11 that broke direct uploadskylekeesling2018-04-062-2/+2
| | |
* | | Flip the order of the after_create callbacksDwight Watson2018-03-273-4/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Addresses rails/rails#32247 Add test that checks identify and analyze work in correct order Break out direct upload test helper Review changes for direct-upload test helper
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 11:29:17 +0000