aboutsummaryrefslogtreecommitdiffstats
path: root/activestorage
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Set ActiveStorage::Blob.service when ActiveStorage::Blob is loadedGeorge Claghorn2017-08-081-16/+15
| | | | | | | | | | | | | | | Fixes that ActiveStorage::Blob.service is unset when ActiveStorage::Blob is reloaded.
* | | Merge pull request #30135 from ffmike/azure-storage-fix-content-typeRafael Mendonça França2017-08-082-3/+11
|\ \ \ | |/ / |/| | | | | Support content_type in AzureStorageService#url
| * | Support content_type in AzureStorageService#urlMike Gunderloy2017-08-082-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | Add in the content_type option, which is defined as part of the generic ActiveStorage::Service class. Without this option, attempts to generate a URL for an attached file fail with "ArgumentError (unknown keyword: content_type)"
* | | ActiveStorage:Add migrations per rails engine conventions (#30111)Dino Maric2017-08-083-12/+4
|/ / | | | | | | | | | | * Add migrations per rails engine conventions * Fix failing tests
* / Extend image_tag to accept ActiveStorage Attachments and Variants (#30084)Anton Khamets2017-08-072-1/+41
|/ | | | | | | | | | | | | | | | | | * Extend image_tag to accept ActiveStorage's Attachments and Variants * Flip resolve_image_source around * Add tests for the new use-cases of image_tag * Remove the higher-level test * Update image_tag documentation * Add error states into the test suite * Re-raise polymorhic_url's NoMethodError as ArgumentError * delegate_missing_to will raise DelegationError instead of NoMethodError
* Active Storage to 5.2.0.alpha inside `activestorage/package.json`bogdanvlviv2017-08-061-1/+1
| | | | Follow #30083
* Pass over Active Storage readme [ci skip] (#30086)Vipul A M2017-08-061-2/+2
|
* Merge branch 'master' into ast-moduleDavid Heinemeier Hansson2017-08-0512-24/+30
|\
| * Merge pull request #30068 from kamipo/user_start_with_than_regexpDavid Heinemeier Hansson2017-08-051-4/+4
| |\ | | | | | | Use `content_type.start_with?("...")` than `content_type =~ /^.../`
| | * Use `content_type.start_with?("...")` than `content_type =~ /^.../`Ryuta Kamizono2017-08-051-4/+4
| | | | | | | | | | | | | | | `start_with?` is a little faster than regexp for prefix matching by a fixed string.
| * | Merge pull request #30081 from y-yagi/fix_ruby_warningsDavid Heinemeier Hansson2017-08-056-11/+17
| |\ \ | | | | | | | | Fix ruby warnings
| | * | Fix ruby warningsyuuji.yaginuma2017-08-056-11/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes following warnings: ``` test/models/variant_test.rb:11: warning: ambiguous first argument; put parentheses or a space even after `/' operator lib/active_storage/attached/macros.rb:63: warning: instance variable @active_storage_attached_highlights not initialized lib/active_storage/attached/macros.rb:25: warning: instance variable @active_storage_attached_avatar not initialized ```
| * | | Merge pull request #30080 from georgeclaghorn/active-storage-secret-key-baseDavid Heinemeier Hansson2017-08-051-1/+1
| |\ \ \ | | | | | | | | | | Active Storage: check for `app.secrets.secret_key_base`, not `app.config.secret_key_base`
| | * | | Check for `app.secrets.secret_key_base`, not `app.config.secret_key_base`George Claghorn2017-08-051-1/+1
| | |/ / | | | | | | | | | | | | By default, apps only have the former set.
| * | | Merge pull request #30083 from ↵David Heinemeier Hansson2017-08-051-2/+2
| |\ \ \ | | | | | | | | | | | | | | | | | | | | koic/change_gem_version_of_active_storage_to_5_2_0 Change gem version of Active Storage to 5.2.0.alpha
| | * | | Change gem version of Active Storage to 5.2.0.alphaKoichi ITO2017-08-051-2/+2
| | |/ /
| * / / Remove unecesarry exception variabledixpac2017-08-051-1/+1
| |/ /
| * / Fix repository URL [ci skip]yuuji.yaginuma2017-08-052-4/+4
| |/ | | | | | | changed `rails/activestorage` to `rails/rails`.
* / `module ActiveStorage`, not `ActiveStorage::Class`claudiob2017-08-0412-660/+685
|/ | | | | | | | | | | | | | | | | | The reasons for this commit are: - uniformity with the other Rails libraries - (possibly) behave better with respect to autoloading - fix the index in the generated documentation Before this commit, run `rake rdoc` generates this left sidebar (ActiveStorage entries are indexed twice, both inside and outside the module): <img width="308" alt="before" src="https://user-images.githubusercontent.com/10076/28939523-7c087dec-7846-11e7-9289-38ed4a2930cd.png"> After this commit, run `rake rdoc` generates this left sidebar: (ActiveStorage entries are only indexed inside the module): <img width="303" alt="after" src="https://user-images.githubusercontent.com/10076/28939524-7c090be0-7846-11e7-8ee5-29dfecae548e.png">
* Rename Azure to AzureStorage (#30057)Dino Maric2017-08-046-8/+8
|
* Fix tests for AWS buckets that include a . (#30059)Claudio B2017-08-042-3/+7
| | | | | | | | | If an AWS bucket name includes a `.` (e.g. `bucket.name`), then the canonical URL for an object will start with "https://s3.amazonaws.com/bucket.name/" and not with "https://bucket.name.s3.amazonaws.com/". The URL tests have now been separated into two separate asserts, to ensure that both the "s3.amazonaws.com" and the "bucket.name" components are included, but not specifically in that order.
* Do not change the entire codebase style only because of active_storageRafael Mendonça França2017-08-031-4/+2
| | | | | | We are already removing the braces around hash parameters in the last argument in other places so we should not change the entire codebase because of two places.
* Fix all rubocop violationsRafael Mendonça França2017-08-031-2/+4
|
* Merge pull request #30061 from claudiob/ast-rubocopRafael França2017-08-035-5/+5
|\ | | | | Make Rubocop happy about ActiveStorage
| * Make Rubocop happier about ActiveStorageclaudiob2017-08-035-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | Running `rubocop activestorage` before this commit resulted in 20 offenses. This commit only fixes: - Trailing whitespace detected - Space inside } missing - Put one space between the method name and the first argument. The other offenses are left since they are intentional according to @georgeclaghorn (https://github.com/rails/rails/pull/30061#issuecomment-319999190)
* | We need to require the top file before individual oneRafael Mendonça França2017-08-031-0/+1
| |
* | Do not eager load ActiveRecord::BaseRafael Mendonça França2017-08-034-12/+0
| | | | | | | | Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them.
* | There is no reason to single line methods hereRafael Mendonça França2017-08-031-4/+12
|/ | | | | I know those methods are unlikely to change but having one line method is hard to read and also hard to modify.
* Can't initialize a message verifier without a key baseDavid Heinemeier Hansson2017-08-031-1/+3
|
* Tweak requiresMike Gunderloy2017-08-021-1/+1
| | | Omit azure-core (it's required by azure-storage), remove require:false to match other points.
* Use release azure-core gemMike Gunderloy2017-08-021-1/+1
|
* Update README.mdMike Gunderloy2017-08-021-1/+1
|
* Add Azure gems to READMEMike Gunderloy2017-08-021-1/+2
|
* Fix `Style/StringLiterals` violations for Active StorageRyuta Kamizono2017-08-0315-25/+25
| | | | | | | | | | | | ``` % be rubocop -a --only Style/StringLiterals activestorage Inspecting 74 files ........................................CCCCCCCCCC.C........CC.......C.C.. (snip) 74 files inspected, 31 offenses detected, 31 offenses corrected ```
* Add Azure to the available services listRolandas Barysas2017-08-021-0/+1
|
* Add Azure to readme Bryan Lim2017-08-021-3/+1
| | | previously https://github.com/rails/activestorage/pull/86
* Skip if credentials aren't providedDavid Heinemeier Hansson2017-08-012-2/+2
|
* Fix dummy app for inclusion in RailsDavid Heinemeier Hansson2017-08-011-2/+1
|
* Remove circular dependencyDavid Heinemeier Hansson2017-08-011-2/+0
|
* Follow same format as action_cableDavid Heinemeier Hansson2017-08-011-1/+3
|
* Cut down on installation adviceDavid Heinemeier Hansson2017-08-011-8/+4
|
* Drop README terms no longer relevantDavid Heinemeier Hansson2017-08-011-12/+0
|
* Rely on top-level filesDavid Heinemeier Hansson2017-08-012-150/+0
|
* Merge pull request #30030 from claudiob/only-diskGuillermo Iguaran2017-08-011-1/+3
|\ | | | | Let ActiveStorage tests pass only for Disk
| * Let ActiveStorage tests pass only for Diskclaudiob2017-08-011-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you have a "service/configurations.yml" file, but every single line is commented out, then an error occurs when running tests: ``` git:active-storage-import~/code/rails/activestorage$ rake ~/code/rails/activestorage/test/test_helper.rb:17:in `<top (required)>': undefined method `deep_symbolize_keys' for false:FalseClass (NoMethodError) from ~/code/rails/activestorage/test/controllers/direct_uploads_controller_test.rb:1:in `require' ``` The reason is that `YAML.load(..an empty file content..)` simply returns `false`, and not `{}`. This PR fixes this behavior so tests can also run when no remote service is available.
* | Don't depend on HTTPartyclaudiob2017-08-013-15/+18
|/ | | | | | | "httparty" is only added in #30020 to write two tests to make PUT requests against S3 and GCS. The same requests can be made with net/http, removing a dependency from the Gemfile.
* Setup travis to be able to run CI tests against S3David Heinemeier Hansson2017-07-314-33/+31
|
* Move the direct_upload: true convenience option from the activestorage ↵David Heinemeier Hansson2017-07-311-18/+0
| | | | helper into actionview
* Move to new storage.yml locationDavid Heinemeier Hansson2017-07-311-0/+0
|
* Directory and config installation now done by app_generatorDavid Heinemeier Hansson2017-07-311-7/+0
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 20:42:15 +0000