aboutsummaryrefslogtreecommitdiffstats
path: root/activestorage
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Merge pull request #30201 from ↵Rafael França2017-08-111-12/+8
|\ \ \ | | | | | | | | | | | | | | | | kamipo/eval_active_storage_attached_name_only_once Evaluate `@active_storage_attached_#{name}` only once
| * | | Evaluate `@active_storage_attached_#{name}` only onceRyuta Kamizono2017-08-121-12/+8
| | | | | | | | | | | | | | | | | | | | Currently `"@active_storage_attached_#{name}"` in `define_method` is evaluated every call. It is better to evaluate it only once.
* | | | Merge pull request #30202 from kamipo/add_null_false_to_active_storage_tablesRafael França2017-08-111-10/+10
|\ \ \ \ | | | | | | | | | | Add `null: false` to Active Storage tables
| * | | | Add `null: false` to Active Storage tablesRyuta Kamizono2017-08-121-10/+10
| |/ / / | | | | | | | | | | | | These columns aren't intended nullable.
* / / / Enable browser caching for blobs and variants (#30196)Anton Khamets2017-08-113-0/+17
|/ / /
* | | Microsoft Azure --> Microsoft Azure Storage [ci skip]Ryuta Kamizono2017-08-121-1/+1
| | |
* | | Fix formatting of Active Storage docs [ci skip]Koichi ITO2017-08-117-33/+33
| | | | | | | | | | | | Follow up of #30188.
* | | Fix formatting of Active Storage docs [ci skip]yuuji.yaginuma2017-08-119-36/+36
| |/ |/| | | | | | | * Use `+` instead of backquote. * Remove escape from class to be link
* | Run Active Storage tests in CI (#30144)George Claghorn2017-08-104-20/+18
| |
* | Isolate ActiveStorage namespaces (#30095)Dino Maric2017-08-102-1/+3
| | | | | | | | | | | | | | * Isolate ActiveStorage namespaces * Rename migrations task [Rafael Mendonça França + Dino Maric]
* | Fix a typoqsona2017-08-101-1/+1
|/
* Merge pull request #30112 from dixpac/filter_minitest_backtraceRafael França2017-08-081-0/+4
|\ | | | | ActiveStorage:Filter out Minitest backtrace.
| * Filter out Minitest backtrace.dixpac2017-08-071-0/+4
| | | | | | | | | | Filter out Minitest backtrace while allowing backtrace from other libraries to be shown.
* | Merge pull request #30118 from georgeclaghorn/active-storage-load-hooksRafael França2017-08-081-16/+15
|\ \ | | | | | | Set ActiveStorage::Blob.service when ActiveStorage::Blob is loaded
| * | Set ActiveStorage::Blob.service when ActiveStorage::Blob is loadedGeorge Claghorn2017-08-081-16/+15
| | | | | | | | | | | | | | | Fixes that ActiveStorage::Blob.service is unset when ActiveStorage::Blob is reloaded.
* | | Merge pull request #30135 from ffmike/azure-storage-fix-content-typeRafael Mendonça França2017-08-082-3/+11
|\ \ \ | |/ / |/| | | | | Support content_type in AzureStorageService#url
| * | Support content_type in AzureStorageService#urlMike Gunderloy2017-08-082-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | Add in the content_type option, which is defined as part of the generic ActiveStorage::Service class. Without this option, attempts to generate a URL for an attached file fail with "ArgumentError (unknown keyword: content_type)"
* | | ActiveStorage:Add migrations per rails engine conventions (#30111)Dino Maric2017-08-083-12/+4
|/ / | | | | | | | | | | * Add migrations per rails engine conventions * Fix failing tests
* / Extend image_tag to accept ActiveStorage Attachments and Variants (#30084)Anton Khamets2017-08-072-1/+41
|/ | | | | | | | | | | | | | | | | | * Extend image_tag to accept ActiveStorage's Attachments and Variants * Flip resolve_image_source around * Add tests for the new use-cases of image_tag * Remove the higher-level test * Update image_tag documentation * Add error states into the test suite * Re-raise polymorhic_url's NoMethodError as ArgumentError * delegate_missing_to will raise DelegationError instead of NoMethodError
* Active Storage to 5.2.0.alpha inside `activestorage/package.json`bogdanvlviv2017-08-061-1/+1
| | | | Follow #30083
* Pass over Active Storage readme [ci skip] (#30086)Vipul A M2017-08-061-2/+2
|
* Merge branch 'master' into ast-moduleDavid Heinemeier Hansson2017-08-0512-24/+30
|\
| * Merge pull request #30068 from kamipo/user_start_with_than_regexpDavid Heinemeier Hansson2017-08-051-4/+4
| |\ | | | | | | Use `content_type.start_with?("...")` than `content_type =~ /^.../`
| | * Use `content_type.start_with?("...")` than `content_type =~ /^.../`Ryuta Kamizono2017-08-051-4/+4
| | | | | | | | | | | | | | | `start_with?` is a little faster than regexp for prefix matching by a fixed string.
| * | Merge pull request #30081 from y-yagi/fix_ruby_warningsDavid Heinemeier Hansson2017-08-056-11/+17
| |\ \ | | | | | | | | Fix ruby warnings
| | * | Fix ruby warningsyuuji.yaginuma2017-08-056-11/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes following warnings: ``` test/models/variant_test.rb:11: warning: ambiguous first argument; put parentheses or a space even after `/' operator lib/active_storage/attached/macros.rb:63: warning: instance variable @active_storage_attached_highlights not initialized lib/active_storage/attached/macros.rb:25: warning: instance variable @active_storage_attached_avatar not initialized ```
| * | | Merge pull request #30080 from georgeclaghorn/active-storage-secret-key-baseDavid Heinemeier Hansson2017-08-051-1/+1
| |\ \ \ | | | | | | | | | | Active Storage: check for `app.secrets.secret_key_base`, not `app.config.secret_key_base`
| | * | | Check for `app.secrets.secret_key_base`, not `app.config.secret_key_base`George Claghorn2017-08-051-1/+1
| | |/ / | | | | | | | | | | | | By default, apps only have the former set.
| * | | Merge pull request #30083 from ↵David Heinemeier Hansson2017-08-051-2/+2
| |\ \ \ | | | | | | | | | | | | | | | | | | | | koic/change_gem_version_of_active_storage_to_5_2_0 Change gem version of Active Storage to 5.2.0.alpha
| | * | | Change gem version of Active Storage to 5.2.0.alphaKoichi ITO2017-08-051-2/+2
| | |/ /
| * / / Remove unecesarry exception variabledixpac2017-08-051-1/+1
| |/ /
| * / Fix repository URL [ci skip]yuuji.yaginuma2017-08-052-4/+4
| |/ | | | | | | changed `rails/activestorage` to `rails/rails`.
* / `module ActiveStorage`, not `ActiveStorage::Class`claudiob2017-08-0412-660/+685
|/ | | | | | | | | | | | | | | | | | The reasons for this commit are: - uniformity with the other Rails libraries - (possibly) behave better with respect to autoloading - fix the index in the generated documentation Before this commit, run `rake rdoc` generates this left sidebar (ActiveStorage entries are indexed twice, both inside and outside the module): <img width="308" alt="before" src="https://user-images.githubusercontent.com/10076/28939523-7c087dec-7846-11e7-9289-38ed4a2930cd.png"> After this commit, run `rake rdoc` generates this left sidebar: (ActiveStorage entries are only indexed inside the module): <img width="303" alt="after" src="https://user-images.githubusercontent.com/10076/28939524-7c090be0-7846-11e7-8ee5-29dfecae548e.png">
* Rename Azure to AzureStorage (#30057)Dino Maric2017-08-046-8/+8
|
* Fix tests for AWS buckets that include a . (#30059)Claudio B2017-08-042-3/+7
| | | | | | | | | If an AWS bucket name includes a `.` (e.g. `bucket.name`), then the canonical URL for an object will start with "https://s3.amazonaws.com/bucket.name/" and not with "https://bucket.name.s3.amazonaws.com/". The URL tests have now been separated into two separate asserts, to ensure that both the "s3.amazonaws.com" and the "bucket.name" components are included, but not specifically in that order.
* Do not change the entire codebase style only because of active_storageRafael Mendonça França2017-08-031-4/+2
| | | | | | We are already removing the braces around hash parameters in the last argument in other places so we should not change the entire codebase because of two places.
* Fix all rubocop violationsRafael Mendonça França2017-08-031-2/+4
|
* Merge pull request #30061 from claudiob/ast-rubocopRafael França2017-08-035-5/+5
|\ | | | | Make Rubocop happy about ActiveStorage
| * Make Rubocop happier about ActiveStorageclaudiob2017-08-035-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | Running `rubocop activestorage` before this commit resulted in 20 offenses. This commit only fixes: - Trailing whitespace detected - Space inside } missing - Put one space between the method name and the first argument. The other offenses are left since they are intentional according to @georgeclaghorn (https://github.com/rails/rails/pull/30061#issuecomment-319999190)
* | We need to require the top file before individual oneRafael Mendonça França2017-08-031-0/+1
| |
* | Do not eager load ActiveRecord::BaseRafael Mendonça França2017-08-034-12/+0
| | | | | | | | Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them.
* | There is no reason to single line methods hereRafael Mendonça França2017-08-031-4/+12
|/ | | | | I know those methods are unlikely to change but having one line method is hard to read and also hard to modify.
* Can't initialize a message verifier without a key baseDavid Heinemeier Hansson2017-08-031-1/+3
|
* Tweak requiresMike Gunderloy2017-08-021-1/+1
| | | Omit azure-core (it's required by azure-storage), remove require:false to match other points.
* Use release azure-core gemMike Gunderloy2017-08-021-1/+1
|
* Update README.mdMike Gunderloy2017-08-021-1/+1
|
* Add Azure gems to READMEMike Gunderloy2017-08-021-1/+2
|
* Fix `Style/StringLiterals` violations for Active StorageRyuta Kamizono2017-08-0315-25/+25
| | | | | | | | | | | | ``` % be rubocop -a --only Style/StringLiterals activestorage Inspecting 74 files ........................................CCCCCCCCCC.C........CC.......C.C.. (snip) 74 files inspected, 31 offenses detected, 31 offenses corrected ```
* Add Azure to the available services listRolandas Barysas2017-08-021-0/+1
|
* Add Azure to readme Bryan Lim2017-08-021-3/+1
| | | previously https://github.com/rails/activestorage/pull/86
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-19 16:05:40 +0000