Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Merge pull request #30280 from koic/change_namespace_of_active_storage_rake_task | Ryuta Kamizono | 2017-08-16 | 1 | -1/+1 | |
|\ | | | | | Change namespace of Active Storage rake task | |||||
| * | Change namespace of Active Storage rake task | Koichi ITO | 2017-08-16 | 1 | -1/+1 | |
| | | ||||||
* | | Fix RuboCop offenses | Koichi ITO | 2017-08-16 | 1 | -2/+2 | |
|/ | | | | And enable `context_dependent` of Style/BracesAroundHashParameters cop. | |||||
* | restores some double newlines deleted in ae87217 | Xavier Noria | 2017-08-15 | 3 | -0/+6 | |
| | | | | | | These were intentional, see https://github.com/rails/rails/pull/30061#issuecomment-320068368 | |||||
* | minor tweaks in Active Storage after a walkthrough | Xavier Noria | 2017-08-15 | 15 | -48/+59 | |
| | ||||||
* | Move test to its proper place | George Claghorn | 2017-08-14 | 1 | -0/+0 | |
| | | | | ActiveStorage::Filename is a model, so its test case belongs in test/models. | |||||
* | Run Active Storage service tests in CI | George Claghorn | 2017-08-14 | 1 | -0/+0 | |
| | ||||||
* | Should escape regexp wildcard character `.` | Koichi ITO | 2017-08-14 | 3 | -4/+4 | |
| | ||||||
* | Merge pull request #30211 from koic/frozen_activestorage | Matthew Draper | 2017-08-13 | 74 | -4/+148 | |
|\ | | | | | Use frozen string literal in Active Storage | |||||
| * | Use frozen string literal in Active Storage | Koichi ITO | 2017-08-12 | 74 | -4/+148 | |
| | | ||||||
* | | Use `references` to respect primary key type in active storage tables | Ryuta Kamizono | 2017-08-13 | 1 | -5/+3 | |
|/ | | | | | | If created active storage tables by mysql2 or postgresql adapters, a primary key is defined as a bigint. It should be used `references` to the reference columns to respect primary key type. | |||||
* | Merge pull request #30198 from betesh/activestorage-rack-test-uploaded-file | Rafael França | 2017-08-11 | 2 | -2/+8 | |
|\ | | | | | Activestorage rack test uploaded file | |||||
| * | Make activestorage treat Rack::Test::UploadedFile just like ↵ | Isaac Betesh | 2017-08-11 | 2 | -2/+8 | |
| | | | | | | | | ActionDispatch::Http::UploadedFile | |||||
* | | Merge pull request #30147 from yhirano55/fix_trailing_blank_lines | Rafael França | 2017-08-11 | 2 | -2/+0 | |
|\ \ | | | | | | | [Active Storage] `rubocop -a --only Layout/TrailingBlankLines` | |||||
| * | | [Active Storage] `rubocop -a --only Layout/TrailingBlankLines` | Yoshiyuki Hirano | 2017-08-09 | 3 | -3/+1 | |
| | | | ||||||
* | | | Merge pull request #30113 from dixpac/remove_unecessary_require_in_test_helper | Rafael França | 2017-08-11 | 1 | -2/+0 | |
|\ \ \ | | | | | | | | | ActiveStorage: Remove unnecessary require in test_helper | |||||
| * | | | Remove unecessary require in test_helper | dixpac | 2017-08-09 | 1 | -2/+0 | |
| |/ / | ||||||
* | | | Remove unnedded Active Storage installation steps | Rafael Mendonça França | 2017-08-11 | 1 | -8/+0 | |
| | | | | | | | | | | | | | | | Active Storage was now merged to master and it is automatically installed in a new application. | |||||
* | | | Merge pull request #30201 from ↵ | Rafael França | 2017-08-11 | 1 | -12/+8 | |
|\ \ \ | | | | | | | | | | | | | | | | | kamipo/eval_active_storage_attached_name_only_once Evaluate `@active_storage_attached_#{name}` only once | |||||
| * | | | Evaluate `@active_storage_attached_#{name}` only once | Ryuta Kamizono | 2017-08-12 | 1 | -12/+8 | |
| | | | | | | | | | | | | | | | | | | | | Currently `"@active_storage_attached_#{name}"` in `define_method` is evaluated every call. It is better to evaluate it only once. | |||||
* | | | | Merge pull request #30202 from kamipo/add_null_false_to_active_storage_tables | Rafael França | 2017-08-11 | 1 | -10/+10 | |
|\ \ \ \ | | | | | | | | | | | Add `null: false` to Active Storage tables | |||||
| * | | | | Add `null: false` to Active Storage tables | Ryuta Kamizono | 2017-08-12 | 1 | -10/+10 | |
| |/ / / | | | | | | | | | | | | | These columns aren't intended nullable. | |||||
* / / / | Enable browser caching for blobs and variants (#30196) | Anton Khamets | 2017-08-11 | 3 | -0/+17 | |
|/ / / | ||||||
* | | | Microsoft Azure --> Microsoft Azure Storage [ci skip] | Ryuta Kamizono | 2017-08-12 | 1 | -1/+1 | |
| | | | ||||||
* | | | Fix formatting of Active Storage docs [ci skip] | Koichi ITO | 2017-08-11 | 7 | -33/+33 | |
| | | | | | | | | | | | | Follow up of #30188. | |||||
* | | | Fix formatting of Active Storage docs [ci skip] | yuuji.yaginuma | 2017-08-11 | 9 | -36/+36 | |
| |/ |/| | | | | | | | * Use `+` instead of backquote. * Remove escape from class to be link | |||||
* | | Run Active Storage tests in CI (#30144) | George Claghorn | 2017-08-10 | 4 | -20/+18 | |
| | | ||||||
* | | Isolate ActiveStorage namespaces (#30095) | Dino Maric | 2017-08-10 | 2 | -1/+3 | |
| | | | | | | | | | | | | | | * Isolate ActiveStorage namespaces * Rename migrations task [Rafael Mendonça França + Dino Maric] | |||||
* | | Fix a typo | qsona | 2017-08-10 | 1 | -1/+1 | |
|/ | ||||||
* | Merge pull request #30112 from dixpac/filter_minitest_backtrace | Rafael França | 2017-08-08 | 1 | -0/+4 | |
|\ | | | | | ActiveStorage:Filter out Minitest backtrace. | |||||
| * | Filter out Minitest backtrace. | dixpac | 2017-08-07 | 1 | -0/+4 | |
| | | | | | | | | | | Filter out Minitest backtrace while allowing backtrace from other libraries to be shown. | |||||
* | | Merge pull request #30118 from georgeclaghorn/active-storage-load-hooks | Rafael França | 2017-08-08 | 1 | -16/+15 | |
|\ \ | | | | | | | Set ActiveStorage::Blob.service when ActiveStorage::Blob is loaded | |||||
| * | | Set ActiveStorage::Blob.service when ActiveStorage::Blob is loaded | George Claghorn | 2017-08-08 | 1 | -16/+15 | |
| | | | | | | | | | | | | | | | Fixes that ActiveStorage::Blob.service is unset when ActiveStorage::Blob is reloaded. | |||||
* | | | Merge pull request #30135 from ffmike/azure-storage-fix-content-type | Rafael Mendonça França | 2017-08-08 | 2 | -3/+11 | |
|\ \ \ | |/ / |/| | | | | | Support content_type in AzureStorageService#url | |||||
| * | | Support content_type in AzureStorageService#url | Mike Gunderloy | 2017-08-08 | 2 | -2/+12 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Add in the content_type option, which is defined as part of the generic ActiveStorage::Service class. Without this option, attempts to generate a URL for an attached file fail with "ArgumentError (unknown keyword: content_type)" | |||||
* | | | ActiveStorage:Add migrations per rails engine conventions (#30111) | Dino Maric | 2017-08-08 | 3 | -12/+4 | |
|/ / | | | | | | | | | | | * Add migrations per rails engine conventions * Fix failing tests | |||||
* / | Extend image_tag to accept ActiveStorage Attachments and Variants (#30084) | Anton Khamets | 2017-08-07 | 2 | -1/+41 | |
|/ | | | | | | | | | | | | | | | | | | * Extend image_tag to accept ActiveStorage's Attachments and Variants * Flip resolve_image_source around * Add tests for the new use-cases of image_tag * Remove the higher-level test * Update image_tag documentation * Add error states into the test suite * Re-raise polymorhic_url's NoMethodError as ArgumentError * delegate_missing_to will raise DelegationError instead of NoMethodError | |||||
* | Active Storage to 5.2.0.alpha inside `activestorage/package.json` | bogdanvlviv | 2017-08-06 | 1 | -1/+1 | |
| | | | | Follow #30083 | |||||
* | Pass over Active Storage readme [ci skip] (#30086) | Vipul A M | 2017-08-06 | 1 | -2/+2 | |
| | ||||||
* | Merge branch 'master' into ast-module | David Heinemeier Hansson | 2017-08-05 | 12 | -24/+30 | |
|\ | ||||||
| * | Merge pull request #30068 from kamipo/user_start_with_than_regexp | David Heinemeier Hansson | 2017-08-05 | 1 | -4/+4 | |
| |\ | | | | | | | Use `content_type.start_with?("...")` than `content_type =~ /^.../` | |||||
| | * | Use `content_type.start_with?("...")` than `content_type =~ /^.../` | Ryuta Kamizono | 2017-08-05 | 1 | -4/+4 | |
| | | | | | | | | | | | | | | | `start_with?` is a little faster than regexp for prefix matching by a fixed string. | |||||
| * | | Merge pull request #30081 from y-yagi/fix_ruby_warnings | David Heinemeier Hansson | 2017-08-05 | 6 | -11/+17 | |
| |\ \ | | | | | | | | | Fix ruby warnings | |||||
| | * | | Fix ruby warnings | yuuji.yaginuma | 2017-08-05 | 6 | -11/+17 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes following warnings: ``` test/models/variant_test.rb:11: warning: ambiguous first argument; put parentheses or a space even after `/' operator lib/active_storage/attached/macros.rb:63: warning: instance variable @active_storage_attached_highlights not initialized lib/active_storage/attached/macros.rb:25: warning: instance variable @active_storage_attached_avatar not initialized ``` | |||||
| * | | | Merge pull request #30080 from georgeclaghorn/active-storage-secret-key-base | David Heinemeier Hansson | 2017-08-05 | 1 | -1/+1 | |
| |\ \ \ | | | | | | | | | | | Active Storage: check for `app.secrets.secret_key_base`, not `app.config.secret_key_base` | |||||
| | * | | | Check for `app.secrets.secret_key_base`, not `app.config.secret_key_base` | George Claghorn | 2017-08-05 | 1 | -1/+1 | |
| | |/ / | | | | | | | | | | | | | By default, apps only have the former set. | |||||
| * | | | Merge pull request #30083 from ↵ | David Heinemeier Hansson | 2017-08-05 | 1 | -2/+2 | |
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | koic/change_gem_version_of_active_storage_to_5_2_0 Change gem version of Active Storage to 5.2.0.alpha | |||||
| | * | | | Change gem version of Active Storage to 5.2.0.alpha | Koichi ITO | 2017-08-05 | 1 | -2/+2 | |
| | |/ / | ||||||
| * / / | Remove unecesarry exception variable | dixpac | 2017-08-05 | 1 | -1/+1 | |
| |/ / | ||||||
| * / | Fix repository URL [ci skip] | yuuji.yaginuma | 2017-08-05 | 2 | -4/+4 | |
| |/ | | | | | | | changed `rails/activestorage` to `rails/rails`. |