| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | Fix tests for AWS buckets that include a . (#30059) | Claudio B | 2017-08-04 | 2 | -3/+7 | |
| | | | | | | | | | | If an AWS bucket name includes a `.` (e.g. `bucket.name`), then the canonical URL for an object will start with "https://s3.amazonaws.com/bucket.name/" and not with "https://bucket.name.s3.amazonaws.com/". The URL tests have now been separated into two separate asserts, to ensure that both the "s3.amazonaws.com" and the "bucket.name" components are included, but not specifically in that order. | |||||
| * | Do not change the entire codebase style only because of active_storage | Rafael Mendonça França | 2017-08-03 | 1 | -4/+2 | |
| | | | | | | | We are already removing the braces around hash parameters in the last argument in other places so we should not change the entire codebase because of two places. | |||||
| * | Fix all rubocop violations | Rafael Mendonça França | 2017-08-03 | 1 | -2/+4 | |
| | | ||||||
| * | Merge pull request #30061 from claudiob/ast-rubocop | Rafael França | 2017-08-03 | 5 | -5/+5 | |
| |\ | | | | | Make Rubocop happy about ActiveStorage | |||||
| | * | Make Rubocop happier about ActiveStorage | claudiob | 2017-08-03 | 5 | -5/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | Running `rubocop activestorage` before this commit resulted in 20 offenses. This commit only fixes: - Trailing whitespace detected - Space inside } missing - Put one space between the method name and the first argument. The other offenses are left since they are intentional according to @georgeclaghorn (https://github.com/rails/rails/pull/30061#issuecomment-319999190) | |||||
| * | | We need to require the top file before individual one | Rafael Mendonça França | 2017-08-03 | 1 | -0/+1 | |
| | | | ||||||
| * | | Do not eager load ActiveRecord::Base | Rafael Mendonça França | 2017-08-03 | 4 | -12/+0 | |
| | | | | | | | | | Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them. | |||||
| * | | There is no reason to single line methods here | Rafael Mendonça França | 2017-08-03 | 1 | -4/+12 | |
| |/ | | | | | I know those methods are unlikely to change but having one line method is hard to read and also hard to modify. | |||||
| * | Can't initialize a message verifier without a key base | David Heinemeier Hansson | 2017-08-03 | 1 | -1/+3 | |
| | | ||||||
| * | Tweak requires | Mike Gunderloy | 2017-08-02 | 1 | -1/+1 | |
| | | | | Omit azure-core (it's required by azure-storage), remove require:false to match other points. | |||||
| * | Use release azure-core gem | Mike Gunderloy | 2017-08-02 | 1 | -1/+1 | |
| | | ||||||
| * | Update README.md | Mike Gunderloy | 2017-08-02 | 1 | -1/+1 | |
| | | ||||||
| * | Add Azure gems to README | Mike Gunderloy | 2017-08-02 | 1 | -1/+2 | |
| | | ||||||
| * | Fix `Style/StringLiterals` violations for Active Storage | Ryuta Kamizono | 2017-08-03 | 15 | -25/+25 | |
| | | | | | | | | | | | | | ``` % be rubocop -a --only Style/StringLiterals activestorage Inspecting 74 files ........................................CCCCCCCCCC.C........CC.......C.C.. (snip) 74 files inspected, 31 offenses detected, 31 offenses corrected ``` | |||||
| * | Add Azure to the available services list | Rolandas Barysas | 2017-08-02 | 1 | -0/+1 | |
| | | ||||||
| * | Add Azure to readme | Bryan Lim | 2017-08-02 | 1 | -3/+1 | |
| | | | | previously https://github.com/rails/activestorage/pull/86 | |||||
| * | Skip if credentials aren't provided | David Heinemeier Hansson | 2017-08-01 | 2 | -2/+2 | |
| | | ||||||
| * | Fix dummy app for inclusion in Rails | David Heinemeier Hansson | 2017-08-01 | 1 | -2/+1 | |
| | | ||||||
| * | Remove circular dependency | David Heinemeier Hansson | 2017-08-01 | 1 | -2/+0 | |
| | | ||||||
| * | Follow same format as action_cable | David Heinemeier Hansson | 2017-08-01 | 1 | -1/+3 | |
| | | ||||||
| * | Cut down on installation advice | David Heinemeier Hansson | 2017-08-01 | 1 | -8/+4 | |
| | | ||||||
| * | Drop README terms no longer relevant | David Heinemeier Hansson | 2017-08-01 | 1 | -12/+0 | |
| | | ||||||
| * | Rely on top-level files | David Heinemeier Hansson | 2017-08-01 | 2 | -150/+0 | |
| | | ||||||
| * | Merge pull request #30030 from claudiob/only-disk | Guillermo Iguaran | 2017-08-01 | 1 | -1/+3 | |
| |\ | | | | | Let ActiveStorage tests pass only for Disk | |||||
| | * | Let ActiveStorage tests pass only for Disk | claudiob | 2017-08-01 | 1 | -1/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you have a "service/configurations.yml" file, but every single line is commented out, then an error occurs when running tests: ``` git:active-storage-import~/code/rails/activestorage$ rake ~/code/rails/activestorage/test/test_helper.rb:17:in `<top (required)>': undefined method `deep_symbolize_keys' for false:FalseClass (NoMethodError) from ~/code/rails/activestorage/test/controllers/direct_uploads_controller_test.rb:1:in `require' ``` The reason is that `YAML.load(..an empty file content..)` simply returns `false`, and not `{}`. This PR fixes this behavior so tests can also run when no remote service is available. | |||||
| * | | Don't depend on HTTParty | claudiob | 2017-08-01 | 3 | -15/+18 | |
| |/ | | | | | | | "httparty" is only added in #30020 to write two tests to make PUT requests against S3 and GCS. The same requests can be made with net/http, removing a dependency from the Gemfile. | |||||
| * | Setup travis to be able to run CI tests against S3 | David Heinemeier Hansson | 2017-07-31 | 4 | -33/+31 | |
| | | ||||||
| * | Move the direct_upload: true convenience option from the activestorage ↵ | David Heinemeier Hansson | 2017-07-31 | 1 | -18/+0 | |
| | | | | | helper into actionview | |||||
| * | Move to new storage.yml location | David Heinemeier Hansson | 2017-07-31 | 1 | -0/+0 | |
| | | ||||||
| * | Directory and config installation now done by app_generator | David Heinemeier Hansson | 2017-07-31 | 1 | -7/+0 | |
| | | ||||||
| * | Fix gitignore to be relative | David Heinemeier Hansson | 2017-07-31 | 1 | -1/+1 | |
| | | ||||||
| * | Follow form from actioncable | David Heinemeier Hansson | 2017-07-31 | 1 | -1/+4 | |
| | | ||||||
| * | Use config/storage.yml as part of the skeleton and loading | David Heinemeier Hansson | 2017-07-31 | 4 | -37/+3 | |
| | | ||||||
| * | Resolve gemspec typo | David Heinemeier Hansson | 2017-07-31 | 1 | -1/+1 | |
| | | ||||||
| * | No longer used | David Heinemeier Hansson | 2017-07-31 | 1 | -23/+0 | |
| | | ||||||
| * | Bring activestorage dependencies into the general Gemfile | David Heinemeier Hansson | 2017-07-31 | 1 | -233/+0 | |
| | | ||||||
| * | Initialize changelog | David Heinemeier Hansson | 2017-07-31 | 1 | -0/+3 | |
| | | ||||||
| * | Use standard Rails layout for gemspec | David Heinemeier Hansson | 2017-07-31 | 1 | -12/+24 | |
| | | ||||||
| * | Add 'activestorage/' from commit '3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58' | Rafael Mendonça França | 2017-07-31 | 121 | -0/+7370 | |
| git-subtree-dir: activestorage git-subtree-mainline: 0d58e7e478e79c2d6b2a39a4444d2a17a903b2a6 git-subtree-split: 3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58 | ||||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |
path: root/activestorage