Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | Translate service-specific missing object exceptions into a generic one | Cameron Bothner | 2018-08-21 | 7 | -18/+102 | |
| | | | | | | | | | | | | | | | | | | `ActiveStorage::Blob#download` and `ActiveStorage::Blob#open` raise `ActiveStorage::FileNotFoundError` when the corresponding file is missing from the storage service. Services translate service-specific missing object exceptions (e.g. `Google::Cloud::NotFoundError` for the GCS service and `Errno::ENOENT` for the disk service) into `ActiveStorage::FileNotFoundError`. | |||||
* | | activestorage: yarn build | bogdanvlviv | 2018-08-19 | 1 | -4/+4 | |
| | | | | | | | | Context https://github.com/rails/rails/pull/33413#issuecomment-414137587 | |||||
* | | Retry ActiveStorage::AnalyzeJobs on download integrity check failures | George Claghorn | 2018-08-19 | 1 | -0/+2 | |
| | | ||||||
* | | Remove superfluous test | George Claghorn | 2018-08-19 | 1 | -10/+0 | |
| | | | | | | | | This test no longer covers the behavior of ActiveStorage::PurgeJob. Attached blobs are ignored by ActiveStorage::Blob#purge as of 934fccd, which includes an equivalent model test. | |||||
* | | Enable multiple submit buttons for Active Storage forms | Chris Seelus | 2018-08-18 | 2 | -2/+22 | |
|/ | ||||||
* | Extract ActiveStorage::SetCurrent | George Claghorn | 2018-08-16 | 3 | -5/+23 | |
| | | | | Provide a handy concern for custom Active Storage controllers that can't inherit from ActiveStorage::BaseController. | |||||
* | Document all Active Storage error classes [ci skip] | George Claghorn | 2018-08-10 | 1 | -0/+8 | |
| | ||||||
* | Add a generic base class for Active Storage exceptions | George Claghorn | 2018-08-10 | 2 | -4/+14 | |
| | | | | | | Closes #33292. [Andrei Makarov & George Claghorn] | |||||
* | Extract transformers | George Claghorn | 2018-08-10 | 6 | -70/+146 | |
| | ||||||
* | DRY up web image checks in ActiveStorage::Variant | George Claghorn | 2018-08-09 | 1 | -18/+24 | |
| | ||||||
* | Camelize instead of classifying | George Claghorn | 2018-08-06 | 1 | -1/+1 | |
| | | | | | | | Avoid mangling service names that end in S: "GCS".classify # => "GC" "GCS".camelize # => "GCS" | |||||
* | Improve ActiveStorage service adapter error handling | Joel Taylor | 2018-08-06 | 2 | -1/+9 | |
| | ||||||
* | Fix uploading Tempfiles to Azure Storage | George Claghorn | 2018-08-03 | 2 | -1/+18 | |
| | | | | Closes #32530. | |||||
* | Remove another unused require | George Claghorn | 2018-08-02 | 1 | -2/+0 | |
| | ||||||
* | Remove unused require | George Claghorn | 2018-08-01 | 1 | -2/+0 | |
| | ||||||
* | Retry ActiveStorage::PurgeJobs on DB deadlock | George Claghorn | 2018-07-31 | 1 | -0/+1 | |
| | ||||||
* | Guard against missing blobs caused by concurrent purges | George Claghorn | 2018-07-30 | 1 | -3/+3 | |
| | ||||||
* | Ignore concurrently-deleted files when deleting by prefix from GCS | George Claghorn | 2018-07-30 | 1 | -1/+7 | |
| | ||||||
* | Update ActiveStorage::Previewer docs | George Claghorn | 2018-07-29 | 1 | -2/+2 | |
| | | | | PDFPreviewer became MuPDFPreviewer in 0b717c2. Previewers are simple enough that we can just provide a single example. | |||||
* | Clarify condition | George Claghorn | 2018-07-27 | 1 | -1/+1 | |
| | | | | && binds tighter than || in JavaScript, but we ought not expect readers to remember language trivia. | |||||
* | Fix directly uploading zero-byte files | George Claghorn | 2018-07-27 | 2 | -2/+2 | |
| | | | | Closes #33450. | |||||
* | Log streaming downloads | George Claghorn | 2018-07-26 | 1 | -0/+2 | |
| | ||||||
* | Ignore ActiveRecord::InvalidForeignKey in ActiveStorage::Blob#purge | Jasper Martin | 2018-07-26 | 5 | -3/+95 | |
| | | | Do nothing instead of raising an error when it’s called on an attached blob. | |||||
* | Merge pull request #33229 from ↵ | Matthew Draper | 2018-07-25 | 1 | -1/+1 | |
|\ | | | | | | | | | albertoalmagro/albertoalmagro/prefer-rails-command-over-bin-rails Prefer rails command over bin/rails | |||||
| * | Recommend use of rails over bin/rails | Alberto Almagro | 2018-07-06 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | As discussed in #33203 rails command already looks for, and runs, bin/rails if it is present. We were mixing recommendations within guides and USAGE guidelines, in some files we recommended using rails, in others bin/rails and in some cases we even had both options mixed together. | |||||
* | | Remove unused attribute | George Claghorn | 2018-07-21 | 2 | -5/+5 | |
| | | ||||||
* | | Discard ActiveStorage::PurgeJobs on ActiveRecord::InvalidForeignKey | George Claghorn | 2018-07-20 | 2 | -1/+11 | |
| | | ||||||
* | | Test that ActiveStorage::Blob#purge fails when attachments exist | George Claghorn | 2018-07-20 | 1 | -0/+8 | |
| | | ||||||
* | | Add a foreign-key constraint to the attachments table for blobs | George Claghorn | 2018-07-19 | 3 | -2/+3 | |
| | | ||||||
* | | Delete attachment before purging blob | George Claghorn | 2018-07-19 | 1 | -2/+2 | |
| | | ||||||
* | | Destroy blob record before deleting stored data | George Claghorn | 2018-07-19 | 1 | -1/+1 | |
| | | ||||||
* | | Link between ActiveStorage::Blob#purge, #purge_later, and #delete [ci skip] | George Claghorn | 2018-07-18 | 1 | -5/+5 | |
| | | ||||||
* | | Clarify the ActiveStorage::Attachment#purge and #purge_later docs | George Claghorn | 2018-07-18 | 1 | -2/+2 | |
| | | | | | | | | Link to the corresponding ActiveStorage::Blob methods, whose docs more accurately describe their effects. [ci skip] | |||||
* | | Remove unnecessary tap | George Claghorn | 2018-07-17 | 1 | -10/+8 | |
| | | ||||||
* | | Fix replacing many attachments via assign and attach | George Claghorn | 2018-07-17 | 2 | -0/+40 | |
| | | ||||||
* | | Correct test name | George Claghorn | 2018-07-16 | 1 | -1/+1 | |
| | | ||||||
* | | Fix that successive ActiveStorage::Attached::Many#attach calls would ↵ | George Claghorn | 2018-07-16 | 2 | -27/+22 | |
| | | | | | | | | overwrite previous attachments | |||||
* | | Test removing attachments via #attach | George Claghorn | 2018-07-16 | 2 | -12/+59 | |
| | | ||||||
* | | Restore inadvertently-removed fallback | George Claghorn | 2018-07-15 | 2 | -1/+8 | |
| | | ||||||
* | | Support HTTP Range downloads from disk | George Claghorn | 2018-07-15 | 3 | -20/+30 | |
| | | | | | | | | Closes #32193. | |||||
* | | Clear attachment changes on reload | George Claghorn | 2018-07-13 | 3 | -0/+20 | |
| | | ||||||
* | | Implement ActiveStorage::Attached::{One,Many}#attach in terms of changes | George Claghorn | 2018-07-13 | 7 | -67/+183 | |
| | | ||||||
* | | Fix that detaching could purge | George Claghorn | 2018-07-13 | 4 | -2/+34 | |
| | | ||||||
* | | Fix analyzing new blobs from uploaded files on attach | George Claghorn | 2018-07-13 | 3 | -18/+120 | |
| | | ||||||
* | | Discard ActiveStorage::PurgeJobs for missing blobs | George Claghorn | 2018-07-11 | 2 | -0/+29 | |
| | | ||||||
* | | Remove overly-broad retry in ActiveStorage::PurgeJob | George Claghorn | 2018-07-11 | 1 | -3/+0 | |
| | | | | | | | | We've never intentionally tripped this retry in production. Add retries for specific errors as needed. | |||||
* | | Raise an ArgumentError instead of a RuntimeError | George Claghorn | 2018-07-08 | 3 | -3/+3 | |
| | | ||||||
* | | Store newly-uploaded files on save rather than assignment | George Claghorn | 2018-07-07 | 22 | -679/+1049 | |
| | | ||||||
* | | Fix that models can clobber each others' attachment reflections | George Claghorn | 2018-07-07 | 3 | -16/+25 | |
|/ | | | | | | | | | | | | | | Consider the following model definitions: class User < ApplicationRecord has_one_attached :avatar end class Group < ApplicationRecord has_one_attached :avatar end If you attempt to reflect on the User model's avatar attachment via User.reflect_on_attachment, you could receive a reflection for the Group model's avatar attachment. Fix this by ensuring that each model class uses its own Hash object to track attachment reflections. | |||||
* | Remove vestigial require on ActiveStorage GCSService | Bibek Shrestha | 2018-07-04 | 1 | -1/+0 | |
| | | | | | | | | | | | | The file `filename.rb` as mentioned in `require "active_storage/filename"` belongs to the `app` folder while GCSService belongs to the lib folder. Looking at the git blame, it was added in commit https://github.com/rails/rails/commit/ccac681122db9747fec9512076772bca345e24b9#diff-bda6a610ef1575b2c8458c96b7f12578 where ActiveStorage::Filename was actually used. But it is no longer required on master and therefore can be removed. This allows anyone to use GCSService directly without enabling ActiveStorage engine. |