aboutsummaryrefslogtreecommitdiffstats
path: root/activestorage
Commit message (Collapse)AuthorAgeFilesLines
...
* | Add executable file `activestorage/bin/test`bogdanvlviv2017-08-201-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | ``` rails$ cd activestorage/ rails/activestorage$ bin/test ........(compressed).... rails/activestorage$ bin/test test/controllers/disk_controller_test.rb .(compressed).. rails/activestorage$ bin/test test/controllers/disk_controller_test.rb:42 . ```
* | Remove Active Storage code climate config fileJon Moss2017-08-181-7/+0
| | | | | | | | There's already a .codeclimate.yml file at the root of the project.
* | Merge pull request #30292 from maclover7/jm-ast-purgeGeorge Claghorn2017-08-171-0/+7
|\ \ | | | | | | Add missing test for Blob#purge
| * | Add missing test for Blob#purgeJon Moss2017-08-171-0/+7
| |/
* / Use nil Logger for testsJon Moss2017-08-171-1/+1
|/ | | | | | | | | | | | | | | | Makes tests much more quietly, as opposed to the enormous amount of logging that appears right now. This setting is used in AJ, as well as other frameworks. Output from test run: ``` ......................................................... Finished in 3.003355s, 18.9788 runs/s, 45.2827 assertions/s. 57 runs, 136 assertions, 0 failures, 0 errors, 0 skips ```
* Merge pull request #30280 from koic/change_namespace_of_active_storage_rake_taskRyuta Kamizono2017-08-161-1/+1
|\ | | | | Change namespace of Active Storage rake task
| * Change namespace of Active Storage rake taskKoichi ITO2017-08-161-1/+1
| |
* | Fix RuboCop offensesKoichi ITO2017-08-161-2/+2
|/ | | | And enable `context_dependent` of Style/BracesAroundHashParameters cop.
* restores some double newlines deleted in ae87217Xavier Noria2017-08-153-0/+6
| | | | | | These were intentional, see https://github.com/rails/rails/pull/30061#issuecomment-320068368
* minor tweaks in Active Storage after a walkthroughXavier Noria2017-08-1515-48/+59
|
* Move test to its proper placeGeorge Claghorn2017-08-141-0/+0
| | | | ActiveStorage::Filename is a model, so its test case belongs in test/models.
* Run Active Storage service tests in CIGeorge Claghorn2017-08-141-0/+0
|
* Should escape regexp wildcard character `.`Koichi ITO2017-08-143-4/+4
|
* Merge pull request #30211 from koic/frozen_activestorageMatthew Draper2017-08-1374-4/+148
|\ | | | | Use frozen string literal in Active Storage
| * Use frozen string literal in Active StorageKoichi ITO2017-08-1274-4/+148
| |
* | Use `references` to respect primary key type in active storage tablesRyuta Kamizono2017-08-131-5/+3
|/ | | | | | If created active storage tables by mysql2 or postgresql adapters, a primary key is defined as a bigint. It should be used `references` to the reference columns to respect primary key type.
* Merge pull request #30198 from betesh/activestorage-rack-test-uploaded-fileRafael França2017-08-112-2/+8
|\ | | | | Activestorage rack test uploaded file
| * Make activestorage treat Rack::Test::UploadedFile just like ↵Isaac Betesh2017-08-112-2/+8
| | | | | | | | ActionDispatch::Http::UploadedFile
* | Merge pull request #30147 from yhirano55/fix_trailing_blank_linesRafael França2017-08-112-2/+0
|\ \ | | | | | | [Active Storage] `rubocop -a --only Layout/TrailingBlankLines`
| * | [Active Storage] `rubocop -a --only Layout/TrailingBlankLines`Yoshiyuki Hirano2017-08-093-3/+1
| | |
* | | Merge pull request #30113 from dixpac/remove_unecessary_require_in_test_helperRafael França2017-08-111-2/+0
|\ \ \ | | | | | | | | ActiveStorage: Remove unnecessary require in test_helper
| * | | Remove unecessary require in test_helperdixpac2017-08-091-2/+0
| |/ /
* | | Remove unnedded Active Storage installation stepsRafael Mendonça França2017-08-111-8/+0
| | | | | | | | | | | | | | | Active Storage was now merged to master and it is automatically installed in a new application.
* | | Merge pull request #30201 from ↵Rafael França2017-08-111-12/+8
|\ \ \ | | | | | | | | | | | | | | | | kamipo/eval_active_storage_attached_name_only_once Evaluate `@active_storage_attached_#{name}` only once
| * | | Evaluate `@active_storage_attached_#{name}` only onceRyuta Kamizono2017-08-121-12/+8
| | | | | | | | | | | | | | | | | | | | Currently `"@active_storage_attached_#{name}"` in `define_method` is evaluated every call. It is better to evaluate it only once.
* | | | Merge pull request #30202 from kamipo/add_null_false_to_active_storage_tablesRafael França2017-08-111-10/+10
|\ \ \ \ | | | | | | | | | | Add `null: false` to Active Storage tables
| * | | | Add `null: false` to Active Storage tablesRyuta Kamizono2017-08-121-10/+10
| |/ / / | | | | | | | | | | | | These columns aren't intended nullable.
* / / / Enable browser caching for blobs and variants (#30196)Anton Khamets2017-08-113-0/+17
|/ / /
* | | Microsoft Azure --> Microsoft Azure Storage [ci skip]Ryuta Kamizono2017-08-121-1/+1
| | |
* | | Fix formatting of Active Storage docs [ci skip]Koichi ITO2017-08-117-33/+33
| | | | | | | | | | | | Follow up of #30188.
* | | Fix formatting of Active Storage docs [ci skip]yuuji.yaginuma2017-08-119-36/+36
| |/ |/| | | | | | | * Use `+` instead of backquote. * Remove escape from class to be link
* | Run Active Storage tests in CI (#30144)George Claghorn2017-08-104-20/+18
| |
* | Isolate ActiveStorage namespaces (#30095)Dino Maric2017-08-102-1/+3
| | | | | | | | | | | | | | * Isolate ActiveStorage namespaces * Rename migrations task [Rafael Mendonça França + Dino Maric]
* | Fix a typoqsona2017-08-101-1/+1
|/
* Merge pull request #30112 from dixpac/filter_minitest_backtraceRafael França2017-08-081-0/+4
|\ | | | | ActiveStorage:Filter out Minitest backtrace.
| * Filter out Minitest backtrace.dixpac2017-08-071-0/+4
| | | | | | | | | | Filter out Minitest backtrace while allowing backtrace from other libraries to be shown.
* | Merge pull request #30118 from georgeclaghorn/active-storage-load-hooksRafael França2017-08-081-16/+15
|\ \ | | | | | | Set ActiveStorage::Blob.service when ActiveStorage::Blob is loaded
| * | Set ActiveStorage::Blob.service when ActiveStorage::Blob is loadedGeorge Claghorn2017-08-081-16/+15
| | | | | | | | | | | | | | | Fixes that ActiveStorage::Blob.service is unset when ActiveStorage::Blob is reloaded.
* | | Merge pull request #30135 from ffmike/azure-storage-fix-content-typeRafael Mendonça França2017-08-082-3/+11
|\ \ \ | |/ / |/| | | | | Support content_type in AzureStorageService#url
| * | Support content_type in AzureStorageService#urlMike Gunderloy2017-08-082-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | Add in the content_type option, which is defined as part of the generic ActiveStorage::Service class. Without this option, attempts to generate a URL for an attached file fail with "ArgumentError (unknown keyword: content_type)"
* | | ActiveStorage:Add migrations per rails engine conventions (#30111)Dino Maric2017-08-083-12/+4
|/ / | | | | | | | | | | * Add migrations per rails engine conventions * Fix failing tests
* / Extend image_tag to accept ActiveStorage Attachments and Variants (#30084)Anton Khamets2017-08-072-1/+41
|/ | | | | | | | | | | | | | | | | | * Extend image_tag to accept ActiveStorage's Attachments and Variants * Flip resolve_image_source around * Add tests for the new use-cases of image_tag * Remove the higher-level test * Update image_tag documentation * Add error states into the test suite * Re-raise polymorhic_url's NoMethodError as ArgumentError * delegate_missing_to will raise DelegationError instead of NoMethodError
* Active Storage to 5.2.0.alpha inside `activestorage/package.json`bogdanvlviv2017-08-061-1/+1
| | | | Follow #30083
* Pass over Active Storage readme [ci skip] (#30086)Vipul A M2017-08-061-2/+2
|
* Merge branch 'master' into ast-moduleDavid Heinemeier Hansson2017-08-0512-24/+30
|\
| * Merge pull request #30068 from kamipo/user_start_with_than_regexpDavid Heinemeier Hansson2017-08-051-4/+4
| |\ | | | | | | Use `content_type.start_with?("...")` than `content_type =~ /^.../`
| | * Use `content_type.start_with?("...")` than `content_type =~ /^.../`Ryuta Kamizono2017-08-051-4/+4
| | | | | | | | | | | | | | | `start_with?` is a little faster than regexp for prefix matching by a fixed string.
| * | Merge pull request #30081 from y-yagi/fix_ruby_warningsDavid Heinemeier Hansson2017-08-056-11/+17
| |\ \ | | | | | | | | Fix ruby warnings
| | * | Fix ruby warningsyuuji.yaginuma2017-08-056-11/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes following warnings: ``` test/models/variant_test.rb:11: warning: ambiguous first argument; put parentheses or a space even after `/' operator lib/active_storage/attached/macros.rb:63: warning: instance variable @active_storage_attached_highlights not initialized lib/active_storage/attached/macros.rb:25: warning: instance variable @active_storage_attached_avatar not initialized ```
| * | | Merge pull request #30080 from georgeclaghorn/active-storage-secret-key-baseDavid Heinemeier Hansson2017-08-051-1/+1
| |\ \ \ | | | | | | | | | | Active Storage: check for `app.secrets.secret_key_base`, not `app.config.secret_key_base`
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-04 10:35:43 +0000